[Libvir] [PATCH] Fix the check of cpumap in virsh vcpupin

2007-06-18 Thread Masayuki Sunou
Hi Because virsh vcpupin does not check a form of cpumap, when non-numerical letters are set, it does not become an error. This patch fixes it so that it become an error when non-numerical letters are set. Signed-off-by: Masayuki Sunou [EMAIL PROTECTED] Thanks, Masayuki Sunou.

Re: [Libvir] [PATCH] hypervisor version

2007-06-18 Thread Daniel Veillard
On Fri, Jun 15, 2007 at 06:26:53PM -0400, Mark Johnson wrote: Saving the dom0 patch for last :-) On 6/15/07, Daniel Veillard [EMAIL PROTECTED] wrote: On Thu, Jun 14, 2007 at 11:27:21PM +0100, Daniel P. Berrange wrote: On Thu, Jun 14, 2007 at 05:06:16PM -0400, Mark Johnson wrote: This

Re: [Libvir] PATCH 0/3: Refactor QEMU daemon

2007-06-18 Thread Daniel Veillard
On Sun, Jun 17, 2007 at 10:48:17PM +0100, Daniel P. Berrange wrote: The 3 patches which follow are work-in-progress to re-factor the QEMU daemon / driver to eventually adhere to the main libvirt internal driver API. Once this work is complete, there will only need to be a single daemon running

Re: [Libvir] PATCH 1/3: Split out simple event loop

2007-06-18 Thread Daniel Veillard
On Sun, Jun 17, 2007 at 10:52:55PM +0100, Daniel P. Berrange wrote: The following patch adds a qemud/event.c qemud/event.h file providing a general purpose event loop built around poll. Users register file handles and associated callbacks, and / or timers. The qemud.c file is changed to make

Re: [Libvir] PATCH: Fix marshalling of ID on wire with remote

2007-06-18 Thread Richard W.M. Jones
Daniel P. Berrange wrote: THe code which marshalls virDomainptr objects onto the wire in the remote driver forgets to include the 'id' value. We get away with this for Xen and QEMU because they do most things based off name or UUID. The test driver however wants the ID number. The attached patch

Re: [Libvir] [PATCH] hypervisor version

2007-06-18 Thread Daniel Veillard
On Mon, Jun 18, 2007 at 06:36:22PM +0900, Atsushi SAKAI wrote: Hi, Daniel  I would prefer keep extra in code. (extra region stores additional info) for example (in extra) xen-unstable : -unstable fedora7 :.4-1-1.2898.2.3 Not possible as the API allows only for an unsigned long

Re: [Libvir] PATCH 7/9: Rename uuid functions

2007-06-18 Thread Daniel Veillard
On Mon, Jun 18, 2007 at 03:24:54AM +0100, Daniel P. Berrange wrote: The UUID functions in qemud/uuid.c have qemud_ in the name. They will be moved into the main src/ directory and so deserve a more generic name. This patch makes them use virUUID as a prefix. No functional change. completely

Re: [Libvir] Register libvirtd ports with IANA ?

2007-06-18 Thread Richard W.M. Jones
Daniel Veillard wrote: On Mon, Jun 18, 2007 at 12:09:33PM +0100, Richard W.M. Jones wrote: Daniel P. Berrange wrote: For the libvirtd we currently use two ports 16509 - TCP unencrypted stream 16514 - TLS encrypted stream My first thought is that we should really use consequetive port

Re: [Libvir] PATCH 1/3: Split out simple event loop

2007-06-18 Thread Richard W.M. Jones
Daniel P. Berrange wrote: The following patch adds a qemud/event.c qemud/event.h file providing a general purpose event loop built around poll. Users register file handles and associated callbacks, and / or timers. The qemud.c file is changed to make use of these APIs for dealing with server,

Re: [Libvir] Register libvirtd ports with IANA ?

2007-06-18 Thread Daniel P. Berrange
On Mon, Jun 18, 2007 at 01:31:15PM +0100, Richard W.M. Jones wrote: Daniel Veillard wrote: On Mon, Jun 18, 2007 at 12:09:33PM +0100, Richard W.M. Jones wrote: Daniel P. Berrange wrote: For the libvirtd we currently use two ports 16509 - TCP unencrypted stream 16514 - TLS encrypted

Re: [Libvir] PATCH 4/9: Remove startup/reload handling into driver.c

2007-06-18 Thread Richard W.M. Jones
Daniel P. Berrange wrote: This patch moves a little more code dealing with VMs / networks out of the qemud.c file into the driver.c file. Specifically code to load configs at startup, code to re-load config files on SIGHUP, and some code to cleanup unused inactive VM / network config file

Re: [Libvir] PATCH 4/9: Remove startup/reload handling into driver.c

2007-06-18 Thread Daniel P. Berrange
On Mon, Jun 18, 2007 at 01:50:31PM +0100, Richard W.M. Jones wrote: Daniel P. Berrange wrote: This patch moves a little more code dealing with VMs / networks out of the qemud.c file into the driver.c file. Specifically code to load configs at startup, code to re-load config files on SIGHUP,

Re: [Libvir] PATCH 5/9: Adapt to virError API

2007-06-18 Thread Daniel P. Berrange
On Mon, Jun 18, 2007 at 01:53:18PM +0100, Richard W.M. Jones wrote: Daniel P. Berrange wrote: And with the actual patch... On Mon, Jun 18, 2007 at 03:18:40AM +0100, Daniel P. Berrange wrote: This patch switches the driver.c, conf.c and dispatch.c files over to use the virError object and

Re: [Libvir] [PATCH] Fix the check of cpumap in virsh vcpupin

2007-06-18 Thread Daniel Veillard
On Mon, Jun 18, 2007 at 12:02:01PM +0100, Richard W.M. Jones wrote: rant It's 2007 - we should not be writing any more software in C. /rant You're right, I really need to write a javascript interpreter and embbed it in libxml2 so we can rewrite all the upper layers. Daniel -- Red Hat

Re: [Libvir] PATCH 6/9: Split qemud_server struct in two

2007-06-18 Thread Richard W.M. Jones
Daniel P. Berrange wrote: This is a very big patch, but actually there is no real functional change in it at all. It is splitting the qemud_server struct into 2 pieces. The qemud_server struct now only deals with client/server socket stuff. The new qemud_driver struct deals with QEMU vms and

Re: [Libvir] PATCH 6/9: Split qemud_server struct in two

2007-06-18 Thread Daniel P. Berrange
On Mon, Jun 18, 2007 at 02:08:34PM +0100, Richard W.M. Jones wrote: Daniel P. Berrange wrote: This is a very big patch, but actually there is no real functional change in it at all. It is splitting the qemud_server struct into 2 pieces. The qemud_server struct now only deals with client/server

Re: [Libvir] PATCH 0/3: Refactor QEMU daemon

2007-06-18 Thread Richard W.M. Jones
Daniel Veillard wrote: On Mon, Jun 18, 2007 at 03:27:03AM +0100, Daniel P. Berrange wrote: The bufferNNN functions in the qemud/buf.c file are identical those already present in the src/xml.c file, except the latter are named virBufferNNN. This patch renames bufferNNN to virBufferNNN so that

Re: [Libvir] PATCH 9/9: Split out virBuffer from xml.c

2007-06-18 Thread Richard W.M. Jones
Daniel Veillard wrote: On Mon, Jun 18, 2007 at 03:31:46AM +0100, Daniel P. Berrange wrote: And with the patch attached this time... On Mon, Jun 18, 2007 at 03:30:11AM +0100, Daniel P. Berrange wrote: The virBuffer functions are currently held in src/xml.c file. This patch splits them out into

Re: [Libvir] PATCH 0/3: Refactor QEMU daemon

2007-06-18 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Mon, Jun 18, 2007 at 05:32:45AM -0400, Daniel Veillard wrote: On Sun, Jun 17, 2007 at 10:48:17PM +0100, Daniel P. Berrange wrote: The 3 patches which follow are work-in-progress to re-factor the QEMU daemon / driver to eventually adhere to the main libvirt internal

Re: [Libvir] PATCH 0/3: Refactor QEMU daemon

2007-06-18 Thread Daniel P. Berrange
On Mon, Jun 18, 2007 at 02:25:36PM +0100, Richard W.M. Jones wrote: Daniel P. Berrange wrote: On Mon, Jun 18, 2007 at 05:32:45AM -0400, Daniel Veillard wrote: On Sun, Jun 17, 2007 at 10:48:17PM +0100, Daniel P. Berrange wrote: The 3 patches which follow are work-in-progress to re-factor the

Re: [Libvir] [PATCH] Fix the check of cpumap in virsh vcpupin

2007-06-18 Thread Richard W.M. Jones
Richard W.M. Jones wrote: Index: src/virsh.c === RCS file: /data/cvs/libvirt/src/virsh.c,v retrieving revision 1.85 diff -u -r1.85 virsh.c --- src/virsh.c 18 Jun 2007 08:33:08 - 1.85 +++ src/virsh.c 18 Jun 2007 11:00:59

Re: [Libvir] PATCH 1/3: Split out simple event loop

2007-06-18 Thread Daniel P. Berrange
Attached is a new version of the patch which allocs/frees memory for storing the callback data in blocks. It also adds copious comments and fixes a very subtle bug in adding handles during dispatch. The printfs are changed into qemudDebug()s and the nvmfds field is killed here. On Mon, Jun 18,