Re: [Libvir] [PATCH] #4: Change interface between xen_unified & its underlying drivers

On Tue, Jul 03, 2007 at 04:19:13PM +0100, Richard W.M. Jones wrote: > > This patch starts by removing the id, name and version fields from > virDriver. > > It also removes getMaxVcpus and the domainLookup* fields, which will > make more sense when you see patches #6 and #7 in this series. Yes, i

Re: [Libvir] [PATCH] #3: Fix xm_internal / remote interaction

On Tue, Jul 03, 2007 at 04:14:30PM +0100, Richard W.M. Jones wrote: > I'm not quite sure what the problem is (although the problem is in > xm_internal), but when you use xm_internal over remote, it sometimes > doesn't initialize its internal cache correctly, so it thinks that > there are no inactiv

Re: [Libvir] [PATCH] #2: Fix remote so that EPIPE errors are caught and reported

On Tue, Jul 03, 2007 at 04:12:56PM +0100, Richard W.M. Jones wrote: > Here we just fix the remote driver so that if the server goes down, the > process doesn't die on SIGPIPE. This isn't thread safe. Changing signals with sigaction affects the entire process - so if you've got multiple threads run

Re: [Libvir] [PATCH] #1: Add error handling and do quick wins (qemu, test)

On Tue, Jul 03, 2007 at 04:12:20PM +0100, Richard W.M. Jones wrote: > This patch: > > (1) Adds the VIR_ERR_NO_DOMAIN and VIR_ERR_NO_NETWORK errors (the latter > will be used later to make the same change to virNetworkLookup* functions). > > (2) Changes the documentation of virDomainLookup* functi

Re: [Libvir] [PATCH] Readd buffer errors & some cleanups

On Tue, Jul 03, 2007 at 11:47:20AM +0100, Richard W.M. Jones wrote: > This readds some error checking of the returns from virBuffer* > functions, removes need for is_blank (a _GNU_SOURCE extension), and a > couple of other very minor cleanups. Looks fine to me Dan. -- |=- Red Hat, Engineering,

Re: [Libvir] PATCH: Fix remote driver to handle network API for local non-QEMU

On Fri, Jun 29, 2007 at 10:21:42AM -0400, Daniel Veillard wrote: > On Fri, Jun 29, 2007 at 03:08:47PM +0100, Daniel P. Berrange wrote: > > On Wed, Jun 27, 2007 at 07:04:00PM +0100, Daniel P. Berrange wrote: > > > > +#define GET_NETWORK_PRIVATE(conn,retcode) > >

[Libvir] [PATCH] #7: Change the virDomainLookup* calls

This changes the three virDomainLookup* calls to make direct calls to the underlying drivers, and to return VIR_ERR_NO_DOMAIN error if the domain is not found. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peas

[Libvir] [PATCH] #6: Change xenUnifiedGetMaxVcpus to make direct calls to the underlying driver

Because the type field is now missing from xenUnifiedDriver, the old method of implementing xenUnifiedGetMaxVcpus didn't work. There's only one underlying driver which can implement this anyway, so just make the call directly. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rj

[Libvir] [PATCH] #5: Tidy up whitespace in xs_internal.c

Fix the whitespace in xs_internal.c xenStoreLookupByName function. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales und

[Libvir] [PATCH] #4: Change interface between xen_unified & its underlying drivers

If you recall the current driver model, which looks like this: libvirt.c | (virDriver) | V + xen_unified.c | (virDriver) | V + xen_internal.c |

[Libvir] [PATCH] #3: Fix xm_internal / remote interaction

I'm not quite sure what the problem is (although the problem is in xm_internal), but when you use xm_internal over remote, it sometimes doesn't initialize its internal cache correctly, so it thinks that there are no inactive domains. The fix is a one-liner which I hit upon by accident -- I don't

[Libvir] [PATCH] #2: Fix remote so that EPIPE errors are caught and reported

Here we just fix the remote driver so that if the server goes down, the process doesn't die on SIGPIPE. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom.

[Libvir] [PATCH] #1: Add error handling and do quick wins (qemu, test)

This patch: (1) Adds the VIR_ERR_NO_DOMAIN and VIR_ERR_NO_NETWORK errors (the latter will be used later to make the same change to virNetworkLookup* functions). (2) Changes the documentation of virDomainLookup* functions to match the new behaviour. (3) Changes qemu & test drivers to have the ne

[Libvir] [PATCH] virDomainLookup* functions raise VIR_ERR_NO_DOMAIN if the domain doesn't exist

The patches that I'm going to follow up with change virDomainLookup* functions so that they raise VIR_ERR_NO_DOMAIN where a domain doesn't exist (but there is no other error), else raise some other error where there's an actual error occuring. This will allow wrappers in other languages to dis

[Libvir] [PATCH] Readd buffer errors & some cleanups

This readds some error checking of the returns from virBuffer* functions, removes need for is_blank (a _GNU_SOURCE extension), and a couple of other very minor cleanups. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place,