Re: [Libvir] Extending libvirt to probe NUMA topology

2007-09-07 Thread beth kon
Daniel Veillard wrote: On Wed, Jun 13, 2007 at 10:40:40AM -0500, Ryan Harper wrote: Hello all, I wanted to start a discussion on how we might get libvirt to be able to probe the NUMA topology of Xen and Linux (for QEMU/KVM). In Xen, I've recently posted patches for exporting topology into

Re: [Libvir] build problem

2007-09-07 Thread Daniel P. Berrange
On Fri, Sep 07, 2007 at 11:08:23AM -0400, Mark Johnson wrote: I'm having problems building the libvirt cvs bits (clean) on FC 7. I'm sure I'm doing something stupid?? I don't see xdr_qemud_packet_client anywhere in the source? Any ideas? That was removed when we switched all the QEMU

Re: [Libvir] Memory leak in XenHypervisorMakeCapabilitiesXML?

2007-09-07 Thread Daniel P. Berrange
On Fri, Sep 07, 2007 at 12:18:05PM -0400, beth kon wrote: Hi. Seems to me there is a memory leak with the strdup function in xenHypervisorMakeCapabilitiesXML. Looking up the chain of calls leading to xenHypervisorMakeCapabilitiesXML, I don't see the required free for the hidden malloc in

[Libvir] Memory leak in XenHypervisorMakeCapabilitiesXML?

2007-09-07 Thread beth kon
Hi. Seems to me there is a memory leak with the strdup function in xenHypervisorMakeCapabilitiesXML. Looking up the chain of calls leading to xenHypervisorMakeCapabilitiesXML, I don't see the required free for the hidden malloc in the strdup. The same problem may exist with other strdups in

Re: [Libvir] build problem

2007-09-07 Thread Mark Johnson
On 9/7/07, Daniel P. Berrange [EMAIL PROTECTED] wrote: On Fri, Sep 07, 2007 at 11:08:23AM -0400, Mark Johnson wrote: I'm having problems building the libvirt cvs bits (clean) on FC 7. I'm sure I'm doing something stupid?? I don't see xdr_qemud_packet_client anywhere in the source? Any

[Libvir] Documentation errors and shortcomings

2007-09-07 Thread Tóth István
Hello! I am currently working on java bindings for libvirt, and in the process I have found a few bugs with the documentation, and also what I believe to be a design problem in the API. 1. The parameterized C macros do not have their arguments listed either on libvirt.org, or in the docs folder

[Libvir] Documentation errors and shortcomings

2007-09-07 Thread Toth Istvan
Hello! I am currently working on java bindings for libvirt, and in the process I have found a few bugs with the documentation, and also what I believe to be a design problem in the API. 1. The parameterized C macros do not have their arguments listed either on libvirt.org, or in the docs

[Libvir] [PATCH] Support Sun's Compiler

2007-09-07 Thread Mark Johnson
The following patch allows libvirt to be compiled with Sun's CC compiler. tested on today's CVS bits on a FC7 dom0 (LD_PRELOAD=src/.libs/libvirt.so src/.libs/virsh) Thanks, MRJ sun-cc Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com

Re: [Libvir] [PATCH] Support Sun's Compiler

2007-09-07 Thread Daniel P. Berrange
On Fri, Sep 07, 2007 at 11:33:48AM -0400, Mark Johnson wrote: The following patch allows libvirt to be compiled with Sun's CC compiler. Small request - for any future patches could you make sure gmail sends them as text/plain rather tha application/octet-stream, or have them inline instead of

Re: [Libvir] Documentation errors and shortcomings

2007-09-07 Thread Daniel P. Berrange
On Fri, Sep 07, 2007 at 06:52:21PM +0200, T?th Istv?n wrote: Hello! I am currently working on java bindings for libvirt, and in the process I have found a few bugs with the documentation, and also what I believe to be a design problem in the API. 1. The parameterized C macros do not have

Re: [Libvir] [PATCH] Support Sun's Compiler

2007-09-07 Thread Mark Johnson
On 9/7/07, Daniel P. Berrange [EMAIL PROTECTED] wrote: On Fri, Sep 07, 2007 at 11:33:48AM -0400, Mark Johnson wrote: The following patch allows libvirt to be compiled with Sun's CC compiler. Small request - for any future patches could you make sure gmail sends them as text/plain rather

Re: [Libvir] [PATCH] Support Sun's Compiler

2007-09-07 Thread Daniel P. Berrange
On Fri, Sep 07, 2007 at 05:05:15PM -0400, Mark Johnson wrote: On 9/7/07, Daniel P. Berrange [EMAIL PROTECTED] wrote: So, the bulk of this patch is just getting rid of the anonymous members in the union. Looks huge, but its an obvious safe fix - I explored doing this myself before to make us