Re: [Libvir] PATCH: Fix KVM / QEMU pxe boot config

2007-09-12 Thread Daniel Veillard
On Wed, Sep 12, 2007 at 04:17:26AM +0100, Daniel P. Berrange wrote: The XML config for PXE boot is being parsed/formatted incorrectly by the KVM tools. It is using 'net' instead of 'network' for the boot tag. I had even made this mistake in the test suite :-) Patch is simple - also fixed a

Re: [Libvir] PATCH: Fix KVM / QEMU pxe boot config

2007-09-12 Thread Richard W.M. Jones
Daniel P. Berrange wrote: The XML config for PXE boot is being parsed/formatted incorrectly by the KVM tools. It is using 'net' instead of 'network' for the boot tag. I had even made this mistake in the test suite :-) Patch is simple - also fixed a flaw in the test suite code Looks good to me.

[Libvir] Removing virDomainRestart typedef

2007-09-12 Thread Richard W.M. Jones
virDomainReboot takes a flag argument which is documented as: * @flags: extra flags for the reboot operation, not used yet In fact, the test driver (alone) allows a virDomainRestart typedef to be passed as a flag, although it's not clear to me that anything actually does pass it. Certainly

Re: [Libvir] [PATCH] Fix enum virDrvOpenRemoteFlags

2007-09-12 Thread Richard W.M. Jones
Daniel Veillard wrote: On Thu, Sep 06, 2007 at 03:53:57PM +0100, Richard W.M. Jones wrote: (Thanks Eduardo for pointing this one out ...) Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street,

Re: [Libvir] [PATCH] Remove warning when dumping XML from an inactive domain with Xen 3.1

2007-09-12 Thread Richard W.M. Jones
Richard W.M. Jones wrote: # virsh dumpxml solaris32fv libvir: Xen Daemon error : failed Xen syscall xenDaemonDomainDumpXML domain ID 0 and xendConfigVersion 3 0 [ and dump proceeds as normal ] The patch just removes the false error message and makes a note that this still needs a real fix

Re: [Libvir] unsigned long

2007-09-12 Thread John Levon
On Wed, Sep 12, 2007 at 02:20:21AM -0400, Daniel Veillard wrote: I just saw an email about unsigned long and max memory fly by along with a comment like 32-bit will never have more than 'X' Gb ... This raises an obvious question: is libvirt explictly not 32/64 clean? On Solaris we

Re: [Libvir] [PATCH] properly check buffer size in virDomainXMLDevID

2007-09-12 Thread Richard W.M. Jones
Hugh Brock wrote: Richard W.M. Jones wrote: Hugh Brock wrote: As promised, a patch to protect the 80-character device id buffer from overflow by the unbounded device= XML attribute. Before, a large device attribute gave a stack overflow error; now it merely results in an obscure (but

[Libvir] Java bindings

2007-09-12 Thread Tóth István
Hello! A development version of the java bindings I've been working on are available at : http://tiger.3ginformatika.hu/java-libvirt.tgz I'd appreciate your feedback on it. Building: Have java/gcc set up correctly through alternatives ( I use jpackage sun java 1.5.0 on Fedora 7 x86_64)

[Libvir] problems using libvirt to mange defined domains.

2007-09-12 Thread Evan Bigall
I'm having a problem using libvirt to manage defined domains (ie: domains for which it has XML, but are not running.) I have tried several debugging scenarios, but the simplest one is this. In a libvirt C program I define the following XML: char domxml[]=domain type='xen' id='99'