[Libvir] sexpr_get: add __printf__ attribute

2007-10-17 Thread Jim Meyering
I noticed sexpr_get takes a printf-style format, yet it is declared with no printf attribute. Here's the fix: 2007-10-17 Jim Meyering [EMAIL PROTECTED] * src/xend_internal.c (sexpr_get): Declare with gcc's printf attribute. Index: src/xend_internal.c

[Libvir] BuildRequires check

2007-10-17 Thread Jim Meyering
Hi, I tried to configure libvirt from cvs on a just-built rawhide system and it failed like this, since I hadn't installed the check package, which defines PKG_CHECK_EXISTS: checking for init script flavor... redhat checking for iptables... /sbin/iptables ./configure: line 12187: syntax

[Libvir] make check requires qemu

2007-10-17 Thread Jim Meyering
So perhaps libvirt should BuildRequire qemu, too? When I ran make check on a system without qemu, I got lots of failures: ... QEMU XML-2-ARGV Misc ACPI ... FAILED libvir: QEMU error : Cannot find QEMU binary /usr/bin/qemu: No such file or directory QEMU

Re: [Libvir] sexpr_get: add __printf__ attribute

2007-10-17 Thread Richard W.M. Jones
Jim Meyering wrote: I noticed sexpr_get takes a printf-style format, yet it is declared with no printf attribute. Here's the fix: 2007-10-17 Jim Meyering [EMAIL PROTECTED] * src/xend_internal.c (sexpr_get): Declare with gcc's printf attribute. Index: src/xend_internal.c

Re: [Libvir] sexpr_get: add __printf__ attribute

2007-10-17 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: I changed it to use the ATTRIBUTE_FORMAT macro (expands to nothing on non-GCC), and committed it. Ha! Thanks. That'll teach me to use an old work tree. -- Libvir-list mailing list Libvir-list@redhat.com

Re: [Libvir] BuildRequires check

2007-10-17 Thread Richard W.M. Jones
Jim Meyering wrote: Hi, I tried to configure libvirt from cvs on a just-built rawhide system and it failed like this, since I hadn't installed the check package, which defines PKG_CHECK_EXISTS: checking for init script flavor... redhat checking for iptables... /sbin/iptables ./configure:

Re: [Libvir] make check requires qemu

2007-10-17 Thread Richard W.M. Jones
Jim Meyering wrote: So perhaps libvirt should BuildRequire qemu, too? When I ran make check on a system without qemu, I got lots of failures: ... QEMU XML-2-ARGV Misc ACPI ... FAILED libvir: QEMU error : Cannot find QEMU binary /usr/bin/qemu: No such file

[Libvir] memory error in another test

2007-10-17 Thread Jim Meyering
Running tests under valgrind exposed this: (line numbers are slightly off, due to local changes) ==27876== ERROR SUMMARY: 32 errors from 2 contexts (suppressed: 5 from 2) ==27876== ==27876== 16 errors in context 1 of 2: ==27876== Conditional jump or move depends on uninitialised value(s)

Re: [Libvir] Concepts in storage management

2007-10-17 Thread Daniel P. Berrange
On Tue, Oct 16, 2007 at 04:19:29PM +0100, Daniel P. Berrange wrote: Storage attributes == - Local vs network(ext3 vs NFS, SCSI vs iSCSI) - Private vs shared (IDE vs FibreChannel) - Pool vs volume (LVM VG vs LV, Directory vs File, Disk vs Partition)

Re: [Libvir] Concepts in storage management

2007-10-17 Thread Mark McLoughlin
Hi Dan, FWIW, this looks pretty much spot on to me ... I'm not sure there's a lot to discuss :-) On Tue, 2007-10-16 at 16:19 +0100, Daniel P. Berrange wrote: Application users = - virt-manager / virt-install - Enumerate available pools - Allocate volume

Re: [Libvir] CPU pinning of domains at creation time

2007-10-17 Thread Daniel Veillard
On Thu, Oct 11, 2007 at 10:45:44AM -0500, Ryan Harper wrote: * Daniel Veillard [EMAIL PROTECTED] [2007-10-11 08:01]: - for the mapping at the XML level I suggest to use a simple extension to the vcpun/vcpu and extend it to vcpu cpuset='2,3'n/vcpu with a limited syntax

Re: [Libvir] Concepts in storage management

2007-10-17 Thread Daniel P. Berrange
On Wed, Oct 17, 2007 at 02:55:21PM +0100, Mark McLoughlin wrote: Hi Dan, FWIW, this looks pretty much spot on to me ... I'm not sure there's a lot to discuss :-) On Tue, 2007-10-16 at 16:19 +0100, Daniel P. Berrange wrote: Application users = - virt-manager

Re: [Libvir] Concepts in storage management

2007-10-17 Thread Daniel P. Berrange
On Wed, Oct 17, 2007 at 04:02:01PM +0100, Daniel P. Berrange wrote: On Wed, Oct 17, 2007 at 02:55:21PM +0100, Mark McLoughlin wrote: Recursive! n x Volume - Pool - n x Volume Nesting to many levels... Hmm, I'd try and avoid the confusion associated with this nesting

[Libvir] Problem to compile virt-manager in debian etch

2007-10-17 Thread Marco Sinhoreli
Hello all, I have a problem to compile the virt-manager in a Debian etch (64 bit version). I got the virt-manager source from mercurial repository. Bellow the output autogen.sh command: ./autogen.sh libtoolize: `config.guess' exists: use `--force' to overwrite libtoolize: `config.sub' exists: