Re: [Libvir] [PATCH] Fix failure of HVM domain definition on Xen 3.0.3or earlier(BZ328841)

2007-10-29 Thread Masayuki Sunou
Hi Would you give me a comment on this? Thanks, Masayuki Sunou In message [EMAIL PROTECTED] [Libvir] [PATCH] Fix failure of HVM domain definition on Xen 3.0.3or earlier(BZ328841) Masayuki Sunou [EMAIL PROTECTED] wrote: Hi VirDomainDefineXML() fails, when HVM domain using CD-ROM is

Re: [Libvir] PATCH: 1/7 Split up the public header files

2007-10-29 Thread Richard W.M. Jones
Daniel P. Berrange wrote: This patch splits up the libvirt.h file into multiple pieces. The big header file was getting rather long hard to follow, with API calls for domains and networks all mixed together, and macros typedefs methods all mixed up. Adding another 25 APIs for storage won't

Re: [Libvir] PATCH: 7/7 storage driver and local backend implementation

2007-10-29 Thread Richard W.M. Jones
As a first observation, I'm getting warnings like: storage_backend_iscsi.c: In function 'virStoragePoolBackendISCSICreate': storage_backend_iscsi.c:4: warning: unused parameter 'pool' storage_backend_iscsi.c: In function 'virStoragePoolBackendISCSIStart': storage_backend_iscsi.c:9: warning:

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Daniel P. Berrange
On Mon, Oct 29, 2007 at 01:52:04PM +, Daniel P. Berrange wrote: On Mon, Oct 29, 2007 at 12:03:34PM +, Richard W.M. Jones wrote: I was envisaging a much more straightforward config file: /etc/libvirt.conf --- disk_storage_pools: [ /var/lib/xen/images ]

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Richard W.M. Jones
Daniel P. Berrange wrote: As we did with virsh attach-disk/attach-interface, vs attach-device I think it would be helpful to provide a 'virsh vol-create' variant which took a handful of explicit args as an alternative to the XML, eg virsh pool-create --type fs xenimages /var/lib/xen/images

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Mon, Oct 29, 2007 at 01:52:04PM +, Daniel P. Berrange wrote: On Mon, Oct 29, 2007 at 12:03:34PM +, Richard W.M. Jones wrote: I was envisaging a much more straightforward config file: /etc/libvirt.conf --- disk_storage_pools: [

Re: [Libvir] PATCH: 0/7 Implementation of storage APIs

2007-10-29 Thread Daniel P. Berrange
On Mon, Oct 29, 2007 at 02:49:16PM +, Richard W.M. Jones wrote: Daniel P. Berrange wrote: As we did with virsh attach-disk/attach-interface, vs attach-device I think it would be helpful to provide a 'virsh vol-create' variant which took a handful of explicit args as an alternative to the