Re: [Libvir] [RFC] Linux-VServer support

2007-11-06 Thread Daniel Hokka Zakrisson
Daniel Veillard wrote: On Thu, Nov 01, 2007 at 03:09:00AM +0100, Daniel Hokka Zakrisson wrote: Daniel Veillard wrote: On Wed, Oct 31, 2007 at 02:39:05PM +0100, Daniel Hokka Zakrisson wrote: Daniel Veillard wrote: I looked at the code, that seems clean but I have a concern about the overall

Re: [Libvir] [PATCH] Fix failure of virsh attach-disk (BZ346281)

2007-11-06 Thread Daniel Veillard
On Tue, Nov 06, 2007 at 09:10:54AM +0900, Masayuki Sunou wrote: Hi Virsh attach-disk fails when the disk is attached to domain. And error message displays that device_configure() failed. # virsh attach-disk PV_RH51RC_12 /dev/hda8 xvdb --driver phy libvir: Xen Daemon error : POST

Re: [Libvir] [RFC] Linux-VServer support

2007-11-06 Thread Daniel P. Berrange
On Tue, Nov 06, 2007 at 11:23:22AM +0100, Daniel Hokka Zakrisson wrote: Daniel Veillard wrote: Ah, yes, I missed that. How about: os type machine='i586'vserver/type hostnametestvm/hostname release2.6.12/release distribution method='debootstrap'etch/distribution /os

[Libvir] [PATCH]: Fix build warning in xs_internal.c

2007-11-06 Thread Chris Lalancette
All, Attached is a trivial patch to fix a build warning in xs_internal.c; basically the xenUnifiedDriver structure doesn't have a domainDumpXML method, so we had one too many NULLs. Signed-off-by: Chris Lalancette [EMAIL PROTECTED] Index: src/xs_internal.c

Re: [Libvir] [PATCH]: Fix build warning in xs_internal.c

2007-11-06 Thread Daniel Veillard
On Tue, Nov 06, 2007 at 10:19:27AM -0500, Chris Lalancette wrote: All, Attached is a trivial patch to fix a build warning in xs_internal.c; basically the xenUnifiedDriver structure doesn't have a domainDumpXML method, so we had one too many NULLs. Whoops , good catch, my fault !

[Libvir] PATCH: Avoid format string abuse (also avoids gcc warnings).

2007-11-06 Thread Jim Meyering
This patch was prompted by warnings like this: util.c:56: warning: format not a string literal and no format arguments and they're legitimate. Imagine a format string contains %%... goes through the vnsprintf call, which reduces it to % If the result string is then passed to

Re: [Libvir] PATCH: Avoid format string abuse (also avoids gcc warnings).

2007-11-06 Thread Daniel P. Berrange
On Tue, Nov 06, 2007 at 08:31:06PM +0100, Jim Meyering wrote: This patch was prompted by warnings like this: util.c:56: warning: format not a string literal and no format arguments Hmm, what compiler version are you using ? I don't see those warnings when I build. Or did you add extra

[Libvir] PATCH: Avoid format string abuse (also avoids gcc warnings).

2007-11-06 Thread Jim Meyering
[resending with the patch in-line, not as an attachment -- mailman removed my attached patch the first time! Bad mailman. Bad. ] This patch was prompted by warnings like this: util.c:56: warning: format not a string literal and no format arguments and they're legitimate. Imagine a format

Re: [Libvir] PATCH: Avoid format string abuse (also avoids gcc warnings).

2007-11-06 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Nov 06, 2007 at 08:31:06PM +0100, Jim Meyering wrote: This patch was prompted by warnings like this: util.c:56: warning: format not a string literal and no format arguments Hmm, what compiler version are you using ? I don't see those

[Libvir] Question about specifications of virsh start

2007-11-06 Thread Masayuki Sunou
Hi I have a question about specifications of virsh start. It is necessary to remove type=ioemu from the configuration file of Xen, when HVM domain installed Para Virtualized Driver use unmodified driver on Xen 3.0.3. But,libvirt always adds type=ioemu to vif of HVM domain in xm_internal.c.