FYI, I have just applied the attached patch to fix a 32-bit overflow in
the stats code. We were doing a left shift of more than 32 bits on '1L'
which is only 32-bit wide on 32-bit platforms. I simply cast to a long long
instead.
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies,
On Fri, Nov 09, 2007 at 10:30:15PM +0100, Jim Meyering wrote:
Jim Meyering [EMAIL PROTECTED] wrote:
There are over 30 uses of strtol in libvirt, and they all can silently
accept invalid input. The invalid string might range from an outlandish
domain ID like 4294967298 to strings of digits
On Sat, Nov 17, 2007 at 01:17:34PM +, Daniel P. Berrange wrote:
On Fri, Nov 09, 2007 at 10:30:15PM +0100, Jim Meyering wrote:
+TESTS_ENVIRONMENT =\
+ abs_top_builddir='$(abs_top_builddir)' \
+ abs_top_srcdir='$(abs_top_srcdir)' \
+
Daniel Veillard [EMAIL PROTECTED] wrote:
On Sat, Nov 17, 2007 at 01:17:34PM +, Daniel P. Berrange wrote:
On Fri, Nov 09, 2007 at 10:30:15PM +0100, Jim Meyering wrote:
+TESTS_ENVIRONMENT = \
+ abs_top_builddir='$(abs_top_builddir)' \
+