[Libvir] [PATCH] (vshCloseLogFile): Diagnose close/write failure.

2007-11-28 Thread Jim Meyering
I noticed a minor problem in vshCloseLogFile. Although callers do check for log-file write failure, this function doesn't check for close failure (which can happen, and indicates a write failure). I considered changing the function to return an int and propagating that success/failure up to

Re: [Libvir] libvirt: serving to web interface (swarm idea!)

2007-11-28 Thread Daniel Veillard
On Tue, Nov 27, 2007 at 07:55:25PM -0200, Grabber wrote: Yeah, I'm focused to develop a decente web interface to manage Xen using libvirt. I have some ideas for the interface, can anyone help me saying: this is cool, this doesn't work?! The main idea for migrate

Re: [Libvir] [PATCH] BZ#251641: Allow to change the cpu pinning for inactive domain

2007-11-28 Thread Richard W.M. Jones
Saori Fukuta wrote: I checked the patch and confirmed that is working properly. Many thanks to all for your help ! OK, that's in CVS now. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street,

[Libvir] [PATCH] Detect heap allocation failure; factor out some duplication.

2007-11-28 Thread Jim Meyering
I spotted a few unchecked heap allocations (strdup, malloc, calloc) in qemud.c and have fixed it so such failure evokes a proper diagnostic rather than e.g., a segfault. I've also arranged to free some of the memory upon failure, but not all (see comments for why). In spite of those additions,

Re: [Libvir] libvirt: serving to web interface (swarm idea!)

2007-11-28 Thread Grabber
hum... And only to monitor running virtual machines? Regards, Luiz Vitor. On Nov 28, 2007 7:16 AM, Daniel Veillard [EMAIL PROTECTED] wrote: On Tue, Nov 27, 2007 at 07:55:25PM -0200, Grabber wrote: Yeah, I'm focused to develop a decente web interface to manage Xen using

Re: [Libvir] [PATCH] Detect heap allocation failure; factor out some duplication.

2007-11-28 Thread Richard W.M. Jones
Worthwhile cleanups, ACK. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903

Re: [Libvir] [PATCH] Detect heap allocation failure; factor out some duplication.

2007-11-28 Thread Daniel P. Berrange
On Wed, Nov 28, 2007 at 02:18:22PM +0100, Jim Meyering wrote: I spotted a few unchecked heap allocations (strdup, malloc, calloc) in qemud.c and have fixed it so such failure evokes a proper diagnostic rather than e.g., a segfault. Yep, good stuff. I've also arranged to free some of the

Re: [Libvir] [PATCH] Detect heap allocation failure; factor out some duplication.

2007-11-28 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Wed, Nov 28, 2007 at 02:18:22PM +0100, Jim Meyering wrote: I spotted a few unchecked heap allocations (strdup, malloc, calloc) in qemud.c and have fixed it so such failure evokes a proper diagnostic rather than e.g., a segfault. Yep, good stuff. I've also

Re: [Libvir] Building libvirt-0.3.3 on CentOS4

2007-11-28 Thread Grabber
Probably you need libc6-dev package! Regards, Luiz Vitor Martinez Cardoso aka Grabber. On Nov 27, 2007 10:25 PM, Carl Jones [EMAIL PROTECTED] wrote: Hi, I'm trying to build libvirt-0.3.3 on a CentOS4 machine. But I'm hitting this error while running 'make': ./configure

Re: [Libvir] Building libvirt-0.3.3 on CentOS4

2007-11-28 Thread Carl Jones
Richard W.M. Jones wrote: Daniel P. Berrange wrote: On Wed, Nov 28, 2007 at 01:25:41PM +1300, Carl Jones wrote: Hi, I'm trying to build libvirt-0.3.3 on a CentOS4 machine. But I'm hitting this error while running 'make': ./configure --with-init-script=redhat --without-qemu --without-remote