Richard W.M. Jones [EMAIL PROTECTED] wrote:
Richard W.M. Jones wrote:
Jim Meyering wrote:
-libvirtd_LDADD = ../src/libvirt.la
+libvirtd_LDADD = ../src/libvirt.la ../lib/libgnu.la
Shouldn't we be using LIBOBJS (automake feature) here? I kind of
thought this was how gnulib worked, and it
On Wed, Dec 05, 2007 at 12:33:24AM +0100, Jim Meyering wrote:
Recently, I heard of two tricky portability problems in libvirt that
are easy to solve with gnulib. Of course, gnulib provides a lot more,
and is not exactly lightweight if you count lines of code imported, but
once the framework
On Tue, 2007-12-04 at 12:08 +, Richard W.M. Jones wrote:
What do people think about adding port forwarding to network
configurations?
No question that it'd be a very useful feature ...
But, apart from everything Dan pointed out, there is the problem that
this isn't really
Richard W.M. Jones wrote:
Jim Meyering wrote:
-libvirtd_LDADD = ../src/libvirt.la
+libvirtd_LDADD = ../src/libvirt.la ../lib/libgnu.la
Shouldn't we be using LIBOBJS (automake feature) here? I kind of
thought this was how gnulib worked, and it was what I used for the
previous getaddrinfo
Daniel P. Berrange wrote:
On Tue, Dec 04, 2007 at 12:57:39PM +, Richard W.M. Jones wrote:
Daniel P. Berrange wrote:
virConnectPtr virConnectOpenAuth (const char *name,
virConnectAuthPtr auth,
On Tue, Dec 04, 2007 at 12:57:39PM +, Richard W.M. Jones wrote:
Daniel P. Berrange wrote:
virConnectPtr virConnectOpenAuth (const char *name,
virConnectAuthPtr auth,
int flags);
On Thu, Nov 29, 2007 at 05:17:07PM +, Daniel P. Berrange wrote:
With the TLS socket, all data is encrypted on the wire. The TCP socket though
is still clear text. Fortunately some SASL authentication mechanism can
also supply encryption capabilities. This is called SSF in SASL
On Mon, Dec 03, 2007 at 04:24:51AM -0500, Daniel Veillard wrote:
On Fri, Nov 30, 2007 at 10:32:40PM +, Daniel P. Berrange wrote:
On Thu, Nov 29, 2007 at 05:16:34PM +, Daniel P. Berrange wrote:
This patch hooks up the basic authentication RPC calls, and the specific
SASL
Here's the complete patch (but still none of the new files), rebased
and relative to the trunk. As before, this passes make distcheck.
And as Daniel Veillard noted, you'd need git.
However the next patch will cvs-add all of the bootstrap-imported
files, so you won't need git unless you want to
On Tue, Dec 04, 2007 at 10:10:28PM +0100, Jim Meyering wrote:
Daniel P. Berrange [EMAIL PROTECTED] wrote:
This adds a binding for the virConnectOpenAuth() api in the python
API. This allows a python function to be used as the callback.
diff -r 8a79678f789f python/libvir.c
---
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Jim, I also needed the attached patch, and then I had to do this:
cd docs/examples ./index.py
...
-LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la
+LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la
Fixes compilation when ./configure --without-sasl.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company
On Wed, Dec 05, 2007 at 05:41:52PM +0100, Jim Meyering wrote:
Daniel P. Berrange [EMAIL PROTECTED] wrote:
I put tests/gnulib before tests there to make it clear that the
gnulib tests run before any bit of libvirt's own unit tests.
Either way works.
We already have many SUBDIRS listed in
On Wed, Dec 05, 2007 at 05:39:32PM +, Richard W.M. Jones wrote:
Fixes compilation when ./configure --without-sasl.
Thanks, I applied this and one other fix needed once the whole patch
series was present.
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392
Jim Meyering wrote:
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Jim, I also needed the attached patch, and then I had to do this:
cd docs/examples ./index.py
...
-LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la
+LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS)
On Thu, Nov 29, 2007 at 05:15:44PM +, Daniel P. Berrange wrote:
This the 3rd iteration of the remote authentication / SASL patches
previously provided here:
v1: http://www.redhat.com/archives/libvir-list/2007-October/msg00131.html
v2:
On Mon, Dec 03, 2007 at 11:53:04PM +0100, Jim Meyering wrote:
Daniel P. Berrange [EMAIL PROTECTED] wrote:
This patch implements internal driver API for authentication callbacks
in the remote driver. It is basically a bunch of code to bridge from
the libvirt public API for auth/credentials
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Jim Meyering wrote:
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Jim, I also needed the attached patch, and then I had to do this:
cd docs/examples ./index.py
...
-LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la
+LDADDS
Daniel P. Berrange [EMAIL PROTECTED] wrote:
Just discovered an accidental ommission in this patch - removed the listen_tls
and listen_tcp config param handling completely. So I've commited the attached
trivial patch to re-add them.
Thanks.
I'll adjust my upcoming config-test addition so that
Jim, to use the gnulib string.h replacement with GCC 4.1.2 compiled
under MinGW, I needed to patch lib/string.h as follows:
--- gnulib/lib/string.h~2007-12-05 18:29:29.0 +
+++ gnulib/lib/string.h 2007-12-05 19:36:22.0 +
@@ -280,7 +280,7 @@
See also
Daniel P. Berrange [EMAIL PROTECTED] wrote:
On Wed, Dec 05, 2007 at 03:08:11PM +0100, Jim Meyering wrote:
Here's the complete patch (but still none of the new files), rebased
and relative to the trunk. As before, this passes make distcheck.
And as Daniel Veillard noted, you'd need git.
On Wed, Dec 05, 2007 at 05:36:48PM +0100, Jim Meyering wrote:
Daniel P. Berrange [EMAIL PROTECTED] wrote:
On Wed, Dec 05, 2007 at 03:08:11PM +0100, Jim Meyering wrote:
Here's the complete patch (but still none of the new files), rebased
and relative to the trunk. As before, this passes
Just discovered an accidental ommission in this patch - removed the listen_tls
and listen_tcp config param handling completely. So I've commited the attached
trivial patch to re-add them.
On Thu, Nov 29, 2007 at 07:35:47PM +0100, Jim Meyering wrote:
@@ -1521,166 +1654,103 @@
Jim, and this one. This is actually something which I accidentally
committed to CVS, but if you agree I think it should be removed.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor,
On Wed, Dec 05, 2007 at 03:08:11PM +0100, Jim Meyering wrote:
Here's the complete patch (but still none of the new files), rebased
and relative to the trunk. As before, this passes make distcheck.
And as Daniel Veillard noted, you'd need git.
However the next patch will cvs-add all of the
Jim Meyering wrote:
(1) Need to add ``--avoid=alloca-opt-tests'' to bootstrap.
I wonder why I didn't hit that.
Did you add any modules to the list in bootstrap?
Not yet :-)
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Jim, I also needed the attached patch, and then I had to do this:
cd docs/examples ./index.py
...
-LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la
+LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la
I noticed that gnulib-tool had deposited a file named
link-warning.h into the top-level directory.
How odd, I thought. This doesn't affect other projects
because most of them define what autoconf calls the AUX directory,
with a line like this in configure.in or configure.ac:
Jim, I also needed the attached patch, and then I had to do this:
cd docs/examples ./index.py
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.
I've checked in all of the changes to let libvirt use
the first two modules from gnulib.
That exposed the fact that gnulib's gl_INIT macro depends
on autoconf-2.59c or newer for its definition of the m4_foreach_w
macro. Here's a kludgey work-around patch, just committed, to
fix build failure for
On Wed, Dec 05, 2007 at 09:51:15PM +0100, Jim Meyering wrote:
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Jim, to use the gnulib string.h replacement with GCC 4.1.2 compiled
under MinGW, I needed to patch lib/string.h as follows:
--- gnulib/lib/string.h~2007-12-05
Richard W.M. Jones [EMAIL PROTECTED] wrote:
Jim, to use the gnulib string.h replacement with GCC 4.1.2 compiled
under MinGW, I needed to patch lib/string.h as follows:
--- gnulib/lib/string.h~2007-12-05 18:29:29.0 +
+++ gnulib/lib/string.h 2007-12-05 19:36:22.0
Daniel P. Berrange [EMAIL PROTECTED] wrote:
On Wed, Dec 05, 2007 at 03:08:11PM +0100, Jim Meyering wrote:
Here's the complete patch (but still none of the new files), rebased
and relative to the trunk. As before, this passes make distcheck.
And as Daniel Veillard noted, you'd need git.
Here is the first of two patches. For now, neither includes
all of the new files. That one's coming up shortly.
First the incremental one, to show you what's changed since last time:
(so you would apply this on top of the patch from last night)
I'll post the combined, (i.e., full,
Daniel P. Berrange [EMAIL PROTECTED] wrote:
...
include physmem.h. For getaddrinfo, merely include getaddrinfo.h
from the two files that use the function.
Hi Dan,
I've not looked closely, but since we're unconditiaonlly including
it, I assume the getaddrinfo.h file is setup to not override
Richard W.M. Jones [EMAIL PROTECTED] wrote:
More modules we could use (all for MinGW / Windows):
...
- gettext
MinGW lacks libintl.h and any gettext function. I thought that
gettextize was supposed to supply all the code needed to implement
these? Anyhow, it doesn't seem to.
Hi
Daniel P. Berrange wrote:
I think the source code should go into gnulib/*.[ch] in case we
ever want to have a lib/ dir for code shared by the daemon library.
There's no need to pollute the top level dir with gl-tests, when we
can have tests/gnulib/, or gnulib/tests/. We've already got an
On Tue, Dec 04, 2007 at 07:02:09PM +, Richard W.M. Jones wrote:
(1) #include libvirt/*.h --- #include libvirt/*.h
I was just wondering why, but looking at the patch yes, okay
(2) src/internal.h has become a dumping ground for all sorts of
includes. Removed the ones which are not
38 matches
Mail list logo
