Re: [Libvir] [PATCH] 1/2 Add qparams.[ch] mini-library for parsing and assembling query strings

2007-12-15 Thread Daniel P. Berrange
On Fri, Dec 14, 2007 at 04:19:52PM +, Richard Jones wrote: > Daniel P. Berrange wrote: > >Looks good to me, although you seem to have left out the part of the patch > >with the unit tests in ;-P > > Did I? ooops ... Unit testing coming up later then. BTW, I've no issue with the refactoring

Re: [Libvir] [PATCH] Enhance virBuffer code

2007-12-15 Thread Daniel Veillard
On Fri, Dec 14, 2007 at 11:53:35PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > Personally, I don't care at all, but I suspect that people using z/OS > and OS/390 care, among others. Some might even be Red Hat customers. > What's wrong with making the code portabl