Re: [Libvir] [RFC] Add Container support to libvirt

2008-01-15 Thread Dave Leskovec
Greetings, Following up on the XML format for the Linux Container support I proposed... I've made the following recommended changes: * Changed mount tags * Changed nameserver tag to be consistent with gateway * Moved cpushare and memory tags outside container tag This is the updated format:

Re: [Libvir] PATCH: Fix remote driver SSH tunnelling

2008-01-15 Thread Richard W.M. Jones
Daniel P. Berrange wrote: An off-by-one error in the remote driver checking for malloc() failure in the SSH argv meant all SSH connections were always rejected. It was always checking the trailing NULL in the argv[] Strange, I wonder when that happened ... I was using an ssh tunnel only the

Re: [Libvir] RFC: Add a short doc with libvirt coding style guidelines

2008-01-15 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: Daniel P. Berrange wrote: There's a few coding style guidelines we've kind of informally agreed upon wrt to libvirt patches, and perhaps more that we ought to make decisions on. For the benefit of people sending patches I reckon its worth writing

Re: [Libvir] RFC: Add a short doc with libvirt coding style guidelines

2008-01-15 Thread Daniel P. Berrange
On Tue, Jan 15, 2008 at 03:49:32PM +0100, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: Daniel P. Berrange wrote: There's a few coding style guidelines we've kind of informally agreed upon wrt to libvirt patches, and perhaps more that we ought to make decisions on.

Re: [Libvir] PATCH: make debug builds quiet by default

2008-01-15 Thread Daniel P. Berrange
On Mon, Jan 14, 2008 at 12:21:44PM +, Richard W.M. Jones wrote: Daniel Veillard wrote: On Wed, Jan 09, 2008 at 05:13:47AM +, Daniel P. Berrange wrote: During development I like to have the --enable-debug flag enabled all the time because its very handy at times. I don't want it spewing

Re: [Libvir] [PATCH] Keyboard layout support for QEMU/KVM

2008-01-15 Thread Daniel P. Berrange
On Tue, Jan 15, 2008 at 09:33:07AM +, Richard W.M. Jones wrote: Daniel Hokka Zakrisson wrote: This patch adds support for qemu's -k option, which is required to run virt-manager with a non-US keymap. Without it, keys are remapped a number of times, ending up with a completely unusable

Re: [Libvir] PATCH: Fix remote driver SSH tunnelling

2008-01-15 Thread Daniel P. Berrange
On Tue, Jan 15, 2008 at 09:31:28AM +, Richard W.M. Jones wrote: Daniel P. Berrange wrote: An off-by-one error in the remote driver checking for malloc() failure in the SSH argv meant all SSH connections were always rejected. It was always checking the trailing NULL in the argv[]

Re: [Libvir] [PATCH] Linux-VServer support

2008-01-15 Thread Daniel P. Berrange
On Tue, Jan 15, 2008 at 03:43:37PM +, Daniel P. Berrange wrote: On Wed, Jan 09, 2008 at 10:51:20PM +0100, Daniel Hokka Zakrisson wrote: This patch implements support for Linux-VServer guests. It is currently missing vcpu and console support, and the necessary virsh code to support it,

Re: [Libvir] [RFC] Add Container support to libvirt

2008-01-15 Thread Daniel P. Berrange
On Tue, Jan 15, 2008 at 12:26:43AM -0800, Dave Leskovec wrote: Greetings, Following up on the XML format for the Linux Container support I proposed... I've made the following recommended changes: * Changed mount tags * Changed nameserver tag to be consistent with gateway * Moved cpushare

Re: [Libvir] [PATCH] Linux-VServer support

2008-01-15 Thread Daniel P. Berrange
On Wed, Jan 09, 2008 at 10:51:20PM +0100, Daniel Hokka Zakrisson wrote: This patch implements support for Linux-VServer guests. It is currently missing vcpu and console support, and the necessary virsh code to support it, but is otherwise pretty feature complete. This is an XML dump from one

Re: [Libvir] [PATCH] Linux-VServer support

2008-01-15 Thread Daniel Hokka Zakrisson
Daniel P. Berrange wrote: On Wed, Jan 09, 2008 at 10:51:20PM +0100, Daniel Hokka Zakrisson wrote: This patch implements support for Linux-VServer guests. It is currently missing vcpu and console support, and the necessary virsh code to support it, but is otherwise pretty feature complete.

Re: [Libvir] [PATCH] Linux-VServer support

2008-01-15 Thread Daniel Hokka Zakrisson
Daniel P. Berrange wrote: On Tue, Jan 15, 2008 at 03:43:37PM +, Daniel P. Berrange wrote: On Wed, Jan 09, 2008 at 10:51:20PM +0100, Daniel Hokka Zakrisson wrote: This patch implements support for Linux-VServer guests. It is currently missing vcpu and console support, and the necessary

Re: [Libvir] [RFC] Add Container support to libvirt

2008-01-15 Thread Balbir Singh
* Daniel P. Berrange [EMAIL PROTECTED] [2008-01-15 15:52:13]: On Tue, Jan 15, 2008 at 12:26:43AM -0800, Dave Leskovec wrote: Greetings, Following up on the XML format for the Linux Container support I proposed... I've made the following recommended changes: * Changed mount tags *

Re: [Libvir] [RFC] Add Container support to libvirt

2008-01-15 Thread Dave Leskovec
Thanks again for the feedback. I've made the following additional recommended changes: * Changed filesystem tag for consistency * Changed network spec to match most recent OpenVZ format. The latest OpenVZ format I could find was here:

Re: [Libvir] [RFC] Add Container support to libvirt

2008-01-15 Thread Dave Leskovec
Balbir, I'd appreciate any links... How will this configuration be persisted across reboots? Specifically, once a configuration is set up for a container, who is responsible for storing this configuration? Will a libvirt driver need to store it somewhere in it's configuration file(s) or

Re: [Libvir] PATCH: make debug builds quiet by default

2008-01-15 Thread Daniel P. Berrange
On Tue, Jan 15, 2008 at 03:02:55PM +, Daniel P. Berrange wrote: On Mon, Jan 14, 2008 at 12:21:44PM +, Richard W.M. Jones wrote: Daniel Veillard wrote: On Wed, Jan 09, 2008 at 05:13:47AM +, Daniel P. Berrange wrote: During development I like to have the --enable-debug flag

Re: [Libvir] [RFC] Add Container support to libvirt

2008-01-15 Thread Daniel Hokka Zakrisson
Dave Leskovec wrote: Thanks again for the feedback. I've made the following additional recommended changes: * Changed filesystem tag for consistency * Changed network spec to match most recent OpenVZ format. The latest OpenVZ format I could find was here:

Re: [Libvir] [RFC] Add Container support to libvirt

2008-01-15 Thread Dave Leskovec
Daniel Hokka Zakrisson wrote: Dave Leskovec wrote: Thanks again for the feedback. I've made the following additional recommended changes: * Changed filesystem tag for consistency * Changed network spec to match most recent OpenVZ format. The latest OpenVZ format I could find was here:

[Libvir] OpenVZ XML

2008-01-15 Thread Mikhail A. Pokidko
On Jan 16, 2008 1:52 AM, Dave Leskovec wrote: 2) The Linux Container driver will be a little different than the Xen and OpenVZ drivers in that it doesn't have already existing configuration files or facilities. Yes, thats me who took Linux Container XML for OpenVZ XML. I better ask Shuveb.