[Libvir] [PATCH] Fix USB device name mis-conversion from S-Expr to XML

2008-01-23 Thread Hiroyuki Kaguchi
"tablet" and "mouse" are set as a value of the /local/domain//image/hvm/usbdevice, but libvirt expects "usbdevice" and "usbmouse" as a value. This causes the following. If a USB device is attached by virt-manager, the USB device is not seen from virt-manager. This patch fixes expected value of lib

Re: [Libvir] Empty tag?

2008-01-23 Thread Kaitlin Rupert
Kaitlin Rupert wrote: Daniel P. Berrange wrote: On Wed, Jan 16, 2008 at 10:56:39PM -0800, Kaitlin Rupert wrote: Hello, I created a guest from XML without a tag. When I run dumpxml on the guest, I notice that an empty tag is appended. Is this the expected behavior? This seems to differ f

Re: [Libvir] PATCH: Remove use of PKG_CHECK_EXISTS

2008-01-23 Thread Daniel P. Berrange
On Tue, Jan 22, 2008 at 05:39:54PM +, Daniel P. Berrange wrote: > On Tue, Jan 22, 2008 at 04:00:49PM +, Daniel P. Berrange wrote: > > This patch removes the use of PKG_CHECK_EXISTS which is only available in > > new versions of pkg-config. Instead we use the 3rd and 4th args of the > > PKG

Re: [Libvir] Libvirt on Mac OS X 10.5

2008-01-23 Thread Daniel P. Berrange
On Wed, Jan 23, 2008 at 02:38:52PM +, Richard W.M. Jones wrote: > Daniel Veillard wrote: > >> dnl Do we have rpcgen? > >> AC_PATH_PROG(RPCGEN, rpcgen, no) > >>@@ -621,8 +625,8 @@ > >> [enableval=no]) > >> > >> if test "${enableval}" = yes; then > >>- gl_COMPILER_FLAGS(-fprofile-

Re: [Libvir] Libvirt on Mac OS X 10.5

2008-01-23 Thread Daniel P. Berrange
On Wed, Jan 23, 2008 at 09:33:04AM -0500, Daniel Veillard wrote: > On Wed, Jan 23, 2008 at 01:21:29PM +, Richard W.M. Jones wrote: > > I got a little bit further with this, my current patch is attached. > > > > At the moment, it gets as far as building libvirt & virsh, but fails to > > build

Re: [Libvir] API "int virDomainRestore(Conn, from)"

2008-01-23 Thread Daniel Veillard
On Wed, Jan 23, 2008 at 03:18:32PM +0100, Daniel Schwager wrote: > Hi, > > I would like to restore a domain. > > I think, after restoring the domain, the vnc-port > maybe has changed (because e.g. another domain use the old VNC-port > at the meantime). I guess this could happen yes. > If I d

Re: [Libvir] Libvirt on Mac OS X 10.5

2008-01-23 Thread Richard W.M. Jones
Daniel Veillard wrote: dnl Do we have rpcgen? AC_PATH_PROG(RPCGEN, rpcgen, no) @@ -621,8 +625,8 @@ [enableval=no]) if test "${enableval}" = yes; then - gl_COMPILER_FLAGS(-fprofile-arcs) - gl_COMPILER_FLAGS(-ftest-coverage) + dnl gl_COMPILER_FLAGS(-fprofile-arcs) + dnl gl_

Re: [Libvir] Any sample code to use virConnectOpenAuth() in C binding ?

2008-01-23 Thread Daniel P. Berrange
On Wed, Jan 23, 2008 at 06:07:23PM +0530, Arun Sharma wrote: > Hello All, > > Can anyone provide me sample code for connecting hypervisor using > credentials. > > As of now i have implemented using(virConnectOpen(NULL)) , but this function > does not takes any credential information. > > I saw t

Re: [Libvir] Libvirt on Mac OS X 10.5

2008-01-23 Thread Daniel Veillard
On Wed, Jan 23, 2008 at 01:23:56PM +, Richard W.M. Jones wrote: > Just in case it wasn't clear, this patch is not to be applied. yes but some parts should IMHO, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://l

Re: [Libvir] Libvirt on Mac OS X 10.5

2008-01-23 Thread Daniel Veillard
On Wed, Jan 23, 2008 at 01:21:29PM +, Richard W.M. Jones wrote: > I got a little bit further with this, my current patch is attached. > > At the moment, it gets as far as building libvirt & virsh, but fails to > build the Python bindings. However virsh doesn't run, apparently > because of a

[Libvir] API "int virDomainRestore(Conn, from)"

2008-01-23 Thread Daniel Schwager
Hi, I would like to restore a domain. I think, after restoring the domain, the vnc-port maybe has changed (because e.g. another domain use the old VNC-port at the meantime). If I do not know the domainname I restored, I have no possibility to get this vnc-port or connect to the restored domain.

Re: [Libvir] Windows sizeof(long) != Linux sizeof(long)

2008-01-23 Thread John Levon
On Wed, Jan 23, 2008 at 08:39:46AM +, Richard W.M. Jones wrote: > >file for dealing with VM memory. Fortunately they are all using memory in > >size of KB, so we are not totally doomed until people start wanting to > >manage VMs with > 2 TB of RAM. Also fortunately, the wire-encoding for > >

[Libvir] PortableXDR - an XDR library for Windows and Mac OS X

2008-01-23 Thread Richard W.M. Jones
This is a formal project to support a known XDR platform on Windows and Mac OS X. It includes / supersedes the XDR port that Windows users were told to use before to get libvirt to compile. http://et.redhat.com/~rjones/portablexdr/ Rich. -- Emerging Technologies, Red Hat - http://et.redhat.c

Re: [Libvir] Libvirt on Mac OS X 10.5

2008-01-23 Thread Richard W.M. Jones
Just in case it wasn't clear, this patch is not to be applied. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under C

[Libvir] Libvirt on Mac OS X 10.5

2008-01-23 Thread Richard W.M. Jones
I got a little bit further with this, my current patch is attached. At the moment, it gets as far as building libvirt & virsh, but fails to build the Python bindings. However virsh doesn't run, apparently because of a simple dynamic linking problem because of where the libraries are (not yet)

[Libvir] Any sample code to use virConnectOpenAuth() in C binding ?

2008-01-23 Thread Arun Sharma
Hello All, Can anyone provide me sample code for connecting hypervisor using credentials. As of now i have implemented using(virConnectOpen(NULL)) , but this function does not takes any credential information. I saw that there is function (virConnectOpenAuth()) which can be used , but i don;t kn

Re: [Libvir] PATCH: Remove use of PKG_CHECK_EXISTS

2008-01-23 Thread Daniel Veillard
On Tue, Jan 22, 2008 at 09:37:46PM +, Daniel P. Berrange wrote: > I put those extra 'x' back into the tests - and added some more which > were already msssing. I broke some of the lines to be under 80, but > it wasn't pratical to fix all of them. Okay, thanks, after a bit of tweaking libvirt

Re: [Libvir] Remove useless "if (foo)" before "free (foo)".

2008-01-23 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> wrote: >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >>> I gave it a once-over and it looks correct to me. >> >> Thanks for the quick review. > > In relaxing the regexp, I found two more: ... > -if(mapstr) > -

Re: [Libvir] Windows sizeof(long) != Linux sizeof(long)

2008-01-23 Thread Pau Garcia i Quiles
Quoting "Richard W.M. Jones" <[EMAIL PROTECTED]>: Daniel P. Berrange wrote: Just discovered that on x86_64, Windows and Linux differ in what they think sizeof(long) to be. http://lists.xensource.com/archives/html/xen-devel/2008-01/msg00736.html http://www.winehq.org/pipermail/wine-devel/200

Re: [Libvir] Remove useless "if (foo)" before "free (foo)".

2008-01-23 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> I gave it a once-over and it looks correct to me. > > Thanks for the quick review. In relaxing the regexp, I found two more: diff --git a/src/xm_internal.c b/src/xm_internal.c index a1317c4..90dc1a4 10064

Re: [Libvir] Windows sizeof(long) != Linux sizeof(long)

2008-01-23 Thread Daniel Veillard
On Wed, Jan 23, 2008 at 12:33:47AM +, Daniel P. Berrange wrote: > Just discovered that on x86_64, Windows and Linux differ in what they > think sizeof(long) to be. > > http://lists.xensource.com/archives/html/xen-devel/2008-01/msg00736.html > http://www.winehq.org/pipermail/wine-devel/200

Re: [Libvir] Windows sizeof(long) != Linux sizeof(long)

2008-01-23 Thread Richard W.M. Jones
Daniel P. Berrange wrote: Just discovered that on x86_64, Windows and Linux differ in what they think sizeof(long) to be. http://lists.xensource.com/archives/html/xen-devel/2008-01/msg00736.html http://www.winehq.org/pipermail/wine-devel/2005-July/038602.html Oh yes. I haven't even tried

Re: [Libvir] Probs migrating domain with libvirt 0.4.0

2008-01-23 Thread Richard W.M. Jones
Daniel Schwager wrote: On Tue, Jan 22, 2008 at 06:27:56PM +, Richard W.M. Jones wrote: Daniel Schwager wrote: virsh # migrate 3 xen://xen03.domain.com libvir: Remote error : remoteDispatchClientRequest: internal error: library function returned error but did not set virterror If it isn't s