[Libvir] VIR_DOMAIN_NOSTATE

2008-01-25 Thread Russ Blaine
On Solaris-based xen 3.1.2 I am seeing virDomainGetInfo() often returning VIR_DOMAIN_NOSTATE in dominfo.state for domUs that are powered on and running. What exactly does VIR_DOMAIN_NOSTATE mean? Why does it exist? I suspect it is a catch-all in the API for hosts that don't entirely have their

Re: [Libvir] VIR_DOMAIN_NOSTATE

2008-01-25 Thread Richard W.M. Jones
Russ Blaine wrote: On Solaris-based xen 3.1.2 I am seeing virDomainGetInfo() often returning VIR_DOMAIN_NOSTATE in dominfo.state for domUs that are powered on and running. What exactly does VIR_DOMAIN_NOSTATE mean? Why does it exist? I suspect it is a catch-all in the API for hosts that don't

Re: [Libvir] VIR_DOMAIN_NOSTATE

2008-01-25 Thread Daniel Veillard
[please subscribe to the mailing-list, I can't guarantee proper delivery of mail bounced by the list tool if you are not subscibed, thanks !] On Thu, Jan 24, 2008 at 12:32:32PM -0800, Russ Blaine wrote: On Solaris-based xen 3.1.2 I am seeing virDomainGetInfo() often returning

Re: [Libvir] [PATCH] Clarify virsh setvcpus and setmem commands

2008-01-25 Thread Richard W.M. Jones
Daniel P. Berrange wrote: On Thu, Jan 17, 2008 at 05:35:57PM +, Richard W.M. Jones wrote: This adds a small section to the documentation for these virsh commands to clarify that you can't use them on running, fullvirt domains under Xen. ACK This has been committed now, but it turns out

Re: [Libvir] VIR_DOMAIN_NOSTATE

2008-01-25 Thread Russ Blaine
Richard W.M. Jones wrote: Russ Blaine wrote: On Solaris-based xen 3.1.2 I am seeing virDomainGetInfo() often returning VIR_DOMAIN_NOSTATE in dominfo.state for domUs that are powered on and running. What exactly does VIR_DOMAIN_NOSTATE mean? Why does it exist? I suspect it is a catch-all in

Re: [Libvir] VIR_DOMAIN_NOSTATE

2008-01-25 Thread Daniel P. Berrange
On Fri, Jan 25, 2008 at 06:39:00PM -0800, Russ Blaine wrote: Richard W.M. Jones wrote: Russ Blaine wrote: On Solaris-based xen 3.1.2 I am seeing virDomainGetInfo() often returning VIR_DOMAIN_NOSTATE in dominfo.state for domUs that are powered on and running. What exactly does

Re: [Libvir] A sample program to create a Linux Container

2008-01-25 Thread Dave Leskovec
Daniel Hokka Zakrisson wrote: Dave Leskovec wrote: Thanks! I added CLONE_NEWIPC and CLONE_NEWUTS. Adding CLONE_NEWUSER caused clone() to fail. I'm looking into that. Make sure you have CONFIG_USER_NS=y That was a little weird. I verified that I had that flag set. I did tweak

[Libvir] 0/8 add syntax checks

2008-01-25 Thread Jim Meyering
A few days ago I wrote a patch eliminating all of the useless if tests of the form if (foo) free (foo);. In general, when making such a global change, I prefer to add a check so that it is easy to ensure mechanically that the new violations don't sneak back in. So I wrote a script to detect the

Re: [Libvir] A sample program to create a Linux Container

2008-01-25 Thread Daniel P. Berrange
On Fri, Jan 25, 2008 at 11:30:35AM -0800, Dave Leskovec wrote: Daniel Hokka Zakrisson wrote: Dave Leskovec wrote: Attached is a simple program that uses the clone() function to create a container. This is not intended as a patch - just an example of what creating a Linux Container looks

[Libvir] 3/8 Enable the duplicate-the test; fix violations

2008-01-25 Thread Jim Meyering
Enable the duplicate-the test; fix violations * Makefile.cfg (local-checks-to-skip) [sc_the_the]: Enable. * docs/virsh.pod: Remove a duplicate the. * libvirt.spec.in: Likewise. * virsh.1: Likewise. Signed-off-by: Jim Meyering [EMAIL PROTECTED] --- Makefile.cfg|1 - docs/virsh.pod |

Re: [Libvir] [PATCH] Clarify virsh setvcpus and setmem commands

2008-01-25 Thread Daniel Veillard
On Fri, Jan 25, 2008 at 12:24:02PM +, Richard W.M. Jones wrote: Daniel P. Berrange wrote: On Thu, Jan 17, 2008 at 05:35:57PM +, Richard W.M. Jones wrote: This adds a small section to the documentation for these virsh commands to clarify that you can't use them on running, fullvirt

[Libvir] 2/8 Add framework for code style- and syntax-checking rules.

2008-01-25 Thread Jim Meyering
Add framework for code style- and syntax-checking rules. Almost all tests are initially disabled via the list in Makefile.cfg. * Makefile.am (EXTRA_DIST): Add .x-sc_avoid_if_before_free. Omit names of files that automake includes automatically. * .x-sc_avoid_if_before_free: New file. *

[Libvir] 4/8 Enable the config.h-requiring test; fix violations

2008-01-25 Thread Jim Meyering
Enable the config.h-requiring test; fix violations Use config.h, not config.h, per autoconf documentation. * Makefile.cfg (local-checks-to-skip) [sc_require_config_h]: Enable. * .x-sc_require_config_h: New file, to list exempted files. * Makefile.am (EXTRA_DIST): Add .x-sc_require_config_h.

[Libvir] 6/8 Enable the po-check test; fix violations.

2008-01-25 Thread Jim Meyering
This ensures that files with translatable strings are listed in po/POTFILES.in. Currently it checks only the error function. Obviously we'll have to add a few more here, but I'll do that separately. Enable the po-check test; fix violations. * Makefile.cfg (local-checks-to-skip)

[Libvir] 7/8 Remove unnecessary #include assert.hs

2008-01-25 Thread Jim Meyering
Enable the assert.h-checking test; fix violations. * Makefile.cfg (local-checks-to-skip) [sc_prohibit_assert_without_use]: Enable. * qemud/mdns.c: Don't include assert.h; no uses of assert here. * qemud/qemud.c: Likewise. * qemud/remote.c: Likewise. Signed-off-by: Jim Meyering [EMAIL PROTECTED]

Re: [Libvir] A sample program to create a Linux Container

2008-01-25 Thread Daniel Hokka Zakrisson
Dave Leskovec wrote: Daniel Hokka Zakrisson wrote: Dave Leskovec wrote: Attached is a simple program that uses the clone() function to create a container. This is not intended as a patch - just an example of what creating a Linux Container looks like. Something along these lines will be

Re: [Libvir] 2/8 Add framework for code style- and syntax-checking rules.

2008-01-25 Thread Jim Meyering
Jim Meyering [EMAIL PROTECTED] wrote: Add framework for code style- and syntax-checking rules. Almost all tests are initially disabled via the list in Makefile.cfg. * Makefile.am (EXTRA_DIST): Add .x-sc_avoid_if_before_free. Omit names of files that automake includes automatically. *