Re: [Libvir] [PATCH] Enable another syntax-check rule.

2008-02-14 Thread Daniel Veillard
On Thu, Feb 07, 2008 at 07:09:44PM +0100, Jim Meyering wrote: This one makes sure we don't use the #ifdef HAVE_CONFIG_H meme: Enable another syntax-check rule. * Makefile.cfg (local-checks-to-skip): Remove sc_no_have_config_h. * qemud/mdns.c: Remove #ifdef HAVE_CONFIG_H.

Re: [Libvir] PATCH: 2/16: Internal driver API

2008-02-14 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:30:45AM +, Daniel P. Berrange wrote: This defines the internal driver API for the storage APIs. The pattern follows that used for the existing APIs. NB, both the storage pool and storage volume objects are now top level objects. Previous iterations of this code

Re: [Libvir] PATCH: 3/16: API docs update

2008-02-14 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:31:33AM +, Daniel P. Berrange wrote: This refreshes the API docs to detail the new public APIs which were added by the last patch. Automatically generated, +1, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard |

Re: [Libvir] PATCH: 0/16: Storage management APIs

2008-02-14 Thread Jim Meyering
Daniel Veillard [EMAIL PROTECTED] wrote: ... In general I like the approach 'let's put what we consider fine first and discuss other parts later' . I guess it's the third round of review and I really find easier to comment based on existing stuff than big patches that gets iterated over

Re: [Libvir] [PATCH] autobuild.sh: Run make syntax-check

2008-02-14 Thread Daniel P. Berrange
On Thu, Feb 14, 2008 at 05:42:28AM -0500, Daniel Veillard wrote: On Thu, Feb 07, 2008 at 07:15:22PM +0100, Jim Meyering wrote: Tiny change. So the autobuilder runs these checks, too. I guess it make sense, but I don't think I receive the autobuilder failures :-) If anyone wants to

Re: [Libvir] PATCH: 1/16: public API

2008-02-14 Thread Daniel P. Berrange
On Thu, Feb 14, 2008 at 06:06:08AM -0500, Daniel Veillard wrote: On Tue, Feb 12, 2008 at 04:30:07AM +, Daniel P. Berrange wrote: + + +typedef enum { + VIR_STORAGE_POOL_BUILD_NEW = 0, /* Regular build from scratch */ + VIR_STORAGE_POOL_BUILD_REPAIR = 1, /* Repair / reinitialize

Re: [Libvir] PATCH: 2/16: Internal driver API

2008-02-14 Thread Daniel P. Berrange
On Thu, Feb 14, 2008 at 12:15:26PM +0100, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: I tried to apply all of these patches, and ended up with a bunch of failed hunks. For example, the one above fails due to the fact that there is no jobs member in checked-in sources,

Re: [Libvir] PATCH: 2/16: Internal driver API

2008-02-14 Thread Daniel P. Berrange
On Thu, Feb 14, 2008 at 06:24:09AM -0500, Daniel Veillard wrote: On Tue, Feb 12, 2008 at 04:30:45AM +, Daniel P. Berrange wrote: This defines the internal driver API for the storage APIs. The pattern follows that used for the existing APIs. NB, both the storage pool and storage volume

Re: [Libvir] PATCH: 0/16: Storage management APIs

2008-02-14 Thread Daniel P. Berrange
On Thu, Feb 14, 2008 at 05:51:13AM -0500, Daniel Veillard wrote: On Tue, Feb 12, 2008 at 04:28:29AM +, Daniel P. Berrange wrote: The patch series that follows provides storage management APIs for dealing with local directories, local filesystems, remote filesystems, logical volumes

Re: [Libvir] PATCH: 0/16: Storage management APIs

2008-02-14 Thread Daniel P. Berrange
On Thu, Feb 14, 2008 at 01:27:18PM +0100, Jim Meyering wrote: Daniel Veillard [EMAIL PROTECTED] wrote: ... In general I like the approach 'let's put what we consider fine first and discuss other parts later' . I guess it's the third round of review and I really find easier to comment

[Libvir] Announcing oVirt

2008-02-14 Thread Hugh O. Brock
Announcing oVirt It is my pleasure to announce oVirt, the next step in open virtual machine management. oVirt is: * A small OS image that runs libvirt and hosts virtual machines * A Web-based virtual machine management console oVirt goals: * Empower virtual