Re: [Libvir] Deprecated PolicyKit function

2008-02-18 Thread Daniel P. Berrange
On Fri, Feb 15, 2008 at 12:49:03PM +, Daniel P. Berrange wrote: > On Fri, Feb 15, 2008 at 11:03:47AM +, Mark McLoughlin wrote: > > Hi, > > Just a heads-up ... trying to build with -Werror on Fedora rawhide, I > > see: > > Yep, I've got a patch for this pending - just need to get my raw

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > +int virStoragePoolObjSaveDef(virConnectPtr conn, > + virStorageDriverStatePtr driver, > + virStoragePoolObjPtr pool, > + virStoragePoolDefPtr def) { > +char

Re: [Libvir] PATCH: 7/16: virsh core commands

2008-02-18 Thread Daniel P. Berrange
On Mon, Feb 18, 2008 at 06:12:47AM -0500, Daniel Veillard wrote: > > +static int > > +cmdPoolDelete(vshControl * ctl, vshCmd * cmd) > > +{ > > +virStoragePoolPtr pool; > > +int ret = TRUE; > > +char *name; > > + > > +if (!vshConnectionUsability(ctl, ctl->conn, TRUE)) > > +re

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Daniel P. Berrange
On Mon, Feb 18, 2008 at 09:51:28AM -0500, Daniel Veillard wrote: > On Tue, Feb 12, 2008 at 04:36:04AM +, Daniel P. Berrange wrote: > > This patch provides the general purpose code for the storage driver. > > The storage_driver.{c,h} file implements the libvirt internal storage > > driver API. T

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Daniel P. Berrange
On Mon, Feb 18, 2008 at 03:20:37PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > +static int virStorageSize(virConnectPtr conn, > > + const char *unit, > > + const char *val, > > + unsigned

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Daniel P. Berrange
On Mon, Feb 18, 2008 at 02:41:09PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > ... > > diff -r 77cf7f42edd4 src/storage_conf.c > > --- /dev/null Thu Jan 01 00:00:00 1970 + > > +++ b/src/storage_conf.cThu Feb 07 12:59:40 2008 -0500 > ... > > +static i

Re: [Libvir] PATCH: 10/16: general purpose helper APIs

2008-02-18 Thread Daniel Veillard
On Mon, Feb 18, 2008 at 03:45:52PM +, Daniel P. Berrange wrote: > On Mon, Feb 18, 2008 at 10:36:06AM -0500, Daniel Veillard wrote: > > On Tue, Feb 12, 2008 at 04:37:08AM +, Daniel P. Berrange wrote: > > > > > > The SELinux code is optional, and can be replaced with calls to any other > > >

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Daniel P. Berrange
On Mon, Feb 18, 2008 at 10:25:04AM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > ... > > diff -r 77cf7f42edd4 src/storage_conf.c > > --- /dev/null Thu Jan 01 00:00:00 1970 + > > +++ b/src/storage_conf.cThu Feb 07 12:59:40 2008 -0500 > ... > > +if (

Re: [Libvir] PATCH: 10/16: general purpose helper APIs

2008-02-18 Thread Daniel P. Berrange
On Mon, Feb 18, 2008 at 10:36:06AM -0500, Daniel Veillard wrote: > On Tue, Feb 12, 2008 at 04:37:08AM +, Daniel P. Berrange wrote: > > > > The SELinux code is optional, and can be replaced with calls to any other > > library which can provide MAC file labels, or just disabled completely.. > [.

Re: [Libvir] PATCH: 10/16: general purpose helper APIs

2008-02-18 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:37:08AM +, Daniel P. Berrange wrote: > This patch provides a couple of helper APIs used by the forthcoming > driver backends. > >- virStorageBackendUpdateVolInfo - take a filename and virStorageVolPtr > and update the capacity/allocation information based on

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:36:04AM +, Daniel P. Berrange wrote: > This patch provides the general purpose code for the storage driver. > The storage_driver.{c,h} file implements the libvirt internal storage > driver API. The storage_conf.{c,h} file takes care of parsing and > formatting the XML

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > +static int virStorageSize(virConnectPtr conn, > + const char *unit, > + const char *val, > + unsigned long long *ret) { > +unsigned long long mult; > +char *end; > +

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > diff -r 77cf7f42edd4 src/storage_conf.c > --- /dev/null Thu Jan 01 00:00:00 1970 + > +++ b/src/storage_conf.c Thu Feb 07 12:59:40 2008 -0500 ... > +static int virStoragePoolDefParsePerms(virConnectPtr conn, > xmlXPathContextPtr ctxt, v

Re: [Libvir] PATCH: 8/16: virsh convenience commands

2008-02-18 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:35:19AM +, Daniel P. Berrange wrote: > This patch adds 3 extra commands to virsh to allow storage pools > and volumes to be defined & created without using XML. These have > the names 'pool-define-as', 'pool-create-as', 'vol-create-as'. > virsh will take the args to t

Re: [Libvir] PATCH: 7/16: virsh core commands

2008-02-18 Thread Daniel Veillard
On Tue, Feb 12, 2008 at 04:34:34AM +, Daniel P. Berrange wrote: > This patch adds new virsh commands for all the libvirt storage APIs > allowing their use from the shell. The style follows that of the > existing domain & network commands, so I won't bother listing them > in great detail. > > T

Re: [Libvir] PATCH: 9/16: main internal storage driver

2008-02-18 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > diff -r 77cf7f42edd4 src/storage_conf.c > --- /dev/null Thu Jan 01 00:00:00 1970 + > +++ b/src/storage_conf.c Thu Feb 07 12:59:40 2008 -0500 ... > +if (options->flags & VIR_STORAGE_BACKEND_POOL_SOURCE_DEVICE) { > +xmlNodePtr