[Libvir] [PATCH] add error message for the case of the vcpupin command fails.

2008-03-04 Thread S.Sakamoto
Hi, I try follow, # virsh vcpupin guest_dom AAA 0,1 [no error messages] # echo $? 1 There is no processing to output an error-message, when vshCommandOptInt become an error. I make the patch to solve this problem. Thanks, Shigeki Sakamoto. Index: src/virsh.c

Re: [Libvir] Any API available for renaming the guest OS

2008-03-04 Thread Richard W.M. Jones
On Tue, Mar 04, 2008 at 11:43:10AM +0530, Ajishrao.r wrote: xm has rename option, without reboot. Right, but not in the manpage. Is theirs any specific reason why we don't have rename API? Not particularly, just waiting for a patch. The QEMU driver looks like it could be easily modified to

Re: [Libvir] [PATCH] add error message for the case of the vcpupin command fails.

2008-03-04 Thread Richard W.M. Jones
On Tue, Mar 04, 2008 at 06:30:46PM +0900, S.Sakamoto wrote: Hi, I try follow, # virsh vcpupin guest_dom AAA 0,1 [no error messages] # echo $? 1 There is no processing to output an error-message, when vshCommandOptInt become an error. I make the patch to solve this

Re: [Libvir] [PATCH] add error message for the case of the vcpupin command fails.

2008-03-04 Thread Richard W.M. Jones
OK, I'm going to qualify that a bit. Is it always safe to access arg-data? I think probably it is, but I'm not sure so I modified the patch slightly just to print an error message like this: $ src/virsh -c test:///default vcpupin test AAA 0,1 error: vcpupin: Invalid or missing vCPU number.

Re: [Libvir] Any API available for renaming the guest OS

2008-03-04 Thread Ajishrao.r
In solaris in Man page of xm it show rename option rename oldname newname Renames the domain oldname to newname. On Tue, Mar 4, 2008 at 4:17 PM, Richard W.M. Jones [EMAIL PROTECTED] wrote: On Tue, Mar 04, 2008 at 11:43:10AM +0530, Ajishrao.r wrote: xm has rename option, without

Re: [Libvir] Re: Support for other platforms

2008-03-04 Thread John Levon
On Tue, Mar 04, 2008 at 01:12:04AM -0500, Daniel Veillard wrote: We're already doing this internally for Xen. In theory, it shouldn't be too much harder to do the same with libvirt. Ryan? The biggest problem would be dealing with incoming patches that conflict with our internal

Re: [Libvir] virsh list

2008-03-04 Thread John Levon
On Tue, Mar 04, 2008 at 01:19:48AM -0500, Daniel Veillard wrote: Well, you've hit upon a good question here. Is virsh interactive, or scriptable? Within Sun we generally attempt to clearly delineate these things, precisely for reasons like the above. well to me clearly it was designed

Re: [Libvir] Re: Support for other platforms

2008-03-04 Thread Daniel Veillard
On Tue, Mar 04, 2008 at 12:33:10PM +, John Levon wrote: On Tue, Mar 04, 2008 at 01:12:04AM -0500, Daniel Veillard wrote: We're already doing this internally for Xen. In theory, it shouldn't be too much harder to do the same with libvirt. Ryan? The biggest problem would be

Re: [Libvir] a couple of questions -Newbie

2008-03-04 Thread Richard W.M. Jones
On Mon, Mar 03, 2008 at 10:48:01PM +, Richard W.M. Jones wrote: On Mon, Mar 03, 2008 at 03:38:46PM -0700, Spencer Parker wrote: I actually just saw this and started playing around with it. Should actually do what I need to do for that part. The next thing I need to monitor is disk

Re: [Libvir] many more translatable strings need to be marked

2008-03-04 Thread Daniel P. Berrange
On Fri, Feb 29, 2008 at 10:02:35AM -0500, Daniel Veillard wrote: On Fri, Feb 29, 2008 at 03:48:18PM +0100, Jim Meyering wrote: I've found many more strings that should be marked for translation. The first part of this change is to add to the list of diagnostic-printing function names in

Re: [Libvir] a couple of questions -Newbie

2008-03-04 Thread Richard W.M. Jones
On Tue, Mar 04, 2008 at 09:01:22AM -0700, Spencer Parker wrote: Now when I run virt-top with the script option it just hangs...how long till it dies? Or is there a way to daemonize it? Which version of virt-top is this? Script mode is designed to run forever. If used in conjunction with

Re: [Libvir] [PATCH]: Make iSCSI login actually work

2008-03-04 Thread Chris Lalancette
Chris Lalancette wrote: Hello, I mentioned this before, but this patch must have been dropped when Dan committed storage stuff to CVS. In order for iSCSI login to work properly, you must properly --sendtargets before trying to login, otherwise your logins will fail. This patch just

Re: [Libvir] [PATCH]: Make iSCSI login actually work

2008-03-04 Thread Richard W.M. Jones
On Tue, Mar 04, 2008 at 02:16:25PM -0500, Chris Lalancette wrote: Chris Lalancette wrote: Hello, I mentioned this before, but this patch must have been dropped when Dan committed storage stuff to CVS. In order for iSCSI login to work properly, you must properly --sendtargets

Re: [Libvir] [PATCH] add error message for the case of the vcpupin command fails.

2008-03-04 Thread Richard W.M. Jones
On Tue, Mar 04, 2008 at 11:03:25AM +, Richard W.M. Jones wrote: OK, I'm going to qualify that a bit. Is it always safe to access arg-data? I think probably it is, but I'm not sure so I modified the patch slightly just to print an error message like this: $ src/virsh -c test:///default

[Libvir] [PATCH] Add xen and hvm guest types to test drive caps

2008-03-04 Thread Cole Robinson
The attached patch adds xen and hvm guest types to the test driver's capabilities. It was currently set to offer only a 'linux' type which doesn't seem to follow the conventions of the other drivers, so I removed that. Please yell if I'm wrong :) Thanks, Cole diff --git a/src/test.c b/src/test.c

Re: [Libvir] [PATCH] Add xen and hvm guest types to test drive caps

2008-03-04 Thread Daniel P. Berrange
On Tue, Mar 04, 2008 at 04:17:34PM -0500, Cole Robinson wrote: The attached patch adds xen and hvm guest types to the test driver's capabilities. It was currently set to offer only a 'linux' type which doesn't seem to follow the conventions of the other drivers, so I removed that. Please yell

[Libvir] RPM build issue

2008-03-04 Thread Vadim Zaliva
Hi! I am trying to build libvirt-0.4.1 on Centos 5.1/i386 from SRPM. I am getting following error: RPM build errors: File not found: /var/tmp/libvirt-0.4.1-root/usr/libexec/ libvirt_parthelper Any suggestions? Sincerely, Vadim -- Libvir-list mailing list Libvir-list@redhat.com

[Libvir] Re: RPM build issue

2008-03-04 Thread Vadim Zaliva
It was due to missing build dependency in SRPM: e2fsprogs-devel. Vadim I am trying to build libvirt-0.4.1 on Centos 5.1/i386 from SRPM. I am getting following error: RPM build errors: File not found: /var/tmp/libvirt-0.4.1-root/usr/libexec/ libvirt_parthelper -- Libvir-list

Re: [Libvir] Re: RPM build issue

2008-03-04 Thread Daniel P. Berrange
On Tue, Mar 04, 2008 at 05:59:53PM -0800, Vadim Zaliva wrote: It was due to missing build dependency in SRPM: e2fsprogs-devel. Hmm, are you sure about that ? AFAIK, we don't have any (direct) dependancy on e2fsprogs-devel. Our primary dependancy for this particular binary is the parted-devel

Re: [Libvir] Re: RPM build issue

2008-03-04 Thread Vadim Zaliva
On Mar 4, 2008, at 19:03, Daniel P. Berrange wrote: Hmm, are you sure about that ? AFAIK, we don't have any (direct) dependancy on e2fsprogs-devel. Our primary dependancy for this particular binary is the parted-devel RPM. If merely having parted-devel is not sufficient, can you post the

Re: [Libvir] [PATCH] add error message for the case of the vcpupincommand fails.

2008-03-04 Thread S.Sakamoto
On Tue, Mar 04, 2008 at 11:03:25AM +, Richard W.M. Jones wrote: OK, I'm going to qualify that a bit. Is it always safe to access arg-data? I think probably it is, but I'm not sure so I modified the patch slightly just to print an error message like this: $ src/virsh -c