Re: [Libvir] [PATCH] Fix MAC address parsing for 1-digit case

2008-03-19 Thread Hiroyuki Kaguchi
Hi, Jim and Rich Thank you for your suggestions. I apply the following changes to the patch. 1) Initialize errno to 0 before the loop. 2) Use isxdigit instead of isdigit and isalpha, and add a comment. 3) Test errno != 0. 4) Add a terminating NUL check. 5) the MAC address function go in file

Re: [Libvir] [PATCH] Fix MAC address parsing for 1-digit case

2008-03-19 Thread Richard W.M. Jones
On Wed, Mar 19, 2008 at 04:07:34PM +0900, Hiroyuki Kaguchi wrote: Hi, Jim and Rich Thank you for your suggestions. I apply the following changes to the patch. 1) Initialize errno to 0 before the loop. 2) Use isxdigit instead of isdigit and isalpha, and add a comment. 3) Test errno != 0.

Re: [Libvir] [PATCH] Fix MAC address parsing for 1-digit case

2008-03-19 Thread Jim Meyering
Hiroyuki Kaguchi [EMAIL PROTECTED] wrote: Thank you for your suggestions. I apply the following changes to the patch. 1) Initialize errno to 0 before the loop. 2) Use isxdigit instead of isdigit and isalpha, and add a comment. 3) Test errno != 0. 4) Add a terminating NUL check. 5) the MAC

[Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Jim Meyering
I had a few in-progress changes from a week or two ago, and am clearing the decks. I added a new build-checking rule (coming separately) and it exposed an unnecessary include: * qemud/remote.c: Don't include getopt.h. Not used. diff --git a/qemud/remote.c b/qemud/remote.c index

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Richard W.M. Jones
On Wed, Mar 19, 2008 at 02:08:44PM +0100, Jim Meyering wrote: I had a few in-progress changes from a week or two ago, and am clearing the decks. I added a new build-checking rule (coming separately) and it exposed an unnecessary include: +1 So we have a way to find header files which are

Re: [Libvir] Accessing qemu from windows

2008-03-19 Thread Richard W.M. Jones
On Wed, Mar 19, 2008 at 03:14:44PM +0200, Gabriel Kaufmann wrote: Hi, Sorry for my late reply, I was having technical problems with the machine that has the KVM installed in. I run libvirtd with the --verbose flag, but I still receive the same message with no extra details libvirtd

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: On Wed, Mar 19, 2008 at 02:08:44PM +0100, Jim Meyering wrote: I had a few in-progress changes from a week or two ago, and am clearing the decks. I added a new build-checking rule (coming separately) and it exposed an unnecessary include: +1 So

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Daniel P. Berrange
On Wed, Mar 19, 2008 at 01:11:18PM +, Richard W.M. Jones wrote: On Wed, Mar 19, 2008 at 02:08:44PM +0100, Jim Meyering wrote: I had a few in-progress changes from a week or two ago, and am clearing the decks. I added a new build-checking rule (coming separately) and it exposed an

[Libvir] [PATCH] Sync Makefile rules from coreutils.

2008-03-19 Thread Jim Meyering
This change is a net no-op for make all builds. For make syntax-check, it adds the getopt.h check, and... It includes name-space clean-up and VPATH make distcheck support in GNUmakefile, and factoring and renaming changes in Makefile.maint. Sync Makefile rules from coreutils. *

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Richard W.M. Jones
On Wed, Mar 19, 2008 at 01:25:33PM +, Daniel P. Berrange wrote: On Wed, Mar 19, 2008 at 01:11:18PM +, Richard W.M. Jones wrote: On Wed, Mar 19, 2008 at 02:08:44PM +0100, Jim Meyering wrote: I had a few in-progress changes from a week or two ago, and am clearing the decks. I

[Libvir] [PATCH] Fix bugs in tests/Makefile.am.

2008-03-19 Thread Jim Meyering
I added a new test (coming in next message), but it failed due to problems fixed here: Fix bugs in tests/Makefile.am. * tests/Makefile.am (abs_top_builddir): Correct invalid settings of abs_top_builddir and abs_top_srcdir. Also prepend src/ to PATH, so we test the

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Richard W.M. Jones
On Wed, Mar 19, 2008 at 02:21:26PM +0100, Jim Meyering wrote: The hard part is coming up with a regular expression to indicate whether a particular header is used. The following are simple-minded, but so far they seem to do the job... However, for a header with many functions and macros, the

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Daniel P. Berrange
On Wed, Mar 19, 2008 at 01:50:27PM +, Richard W.M. Jones wrote: On Wed, Mar 19, 2008 at 01:25:33PM +, Daniel P. Berrange wrote: On Wed, Mar 19, 2008 at 01:11:18PM +, Richard W.M. Jones wrote: On Wed, Mar 19, 2008 at 02:08:44PM +0100, Jim Meyering wrote: I had a few

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Mar 19, 2008 at 01:50:27PM +, Richard W.M. Jones wrote: On Wed, Mar 19, 2008 at 01:25:33PM +, Daniel P. Berrange wrote: On Wed, Mar 19, 2008 at 01:11:18PM +, Richard W.M. Jones wrote: On Wed, Mar 19, 2008 at 02:08:44PM +0100,

[Libvir] [PATCH] Add new testing framework and the first test to use it.

2008-03-19 Thread Jim Meyering
A week or so ago, I read a bug report on this list with a simple reproducer + fix that was just begging for a test suite addition. This change adds framework to make that easy, and adds the first test. I uncovered problems in tests/Makefile.am along the way and just posted a patch for that. This

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-19 Thread Daniel Veillard
On Tue, Mar 18, 2008 at 02:28:36PM -0400, Cole Robinson wrote: Cole Robinson wrote: The attached patch implements the following operations for the qemu driver: virDomainGetMaxMemory virDomainSetMaxMemory virDomainSetMemory A few questions/comments: 1) I changed maxmem and

Re: [Libvir] [PATCH] * qemud/remote.c: Don't include getopt.h. Not used.

2008-03-19 Thread Richard W.M. Jones
Automated builds on a variety of platforms would help here ... Tricky for us to set up however. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn

[Libvir] Announcement : Enomalism 2.0 Alpha Released

2008-03-19 Thread Reuven Cohen
This is an general announcement of the release of Enomalism 2.0 (Alpha) Now Available for Download. -- Enomaly, Inc. is pleased to announce the Alpha release of the Enomalism Elastic Computing Platform. The Enomalism v2.0 Alpha has been completely redeveloped from the ground up and further builds