Re: [Libvir] [PATCH] lxc: start domain

On Thu, Mar 27, 2008 at 02:50:20PM -0700, Dave Leskovec wrote: > Daniel Veillard wrote: > >> +int execStringLen = strlen(vmDef->init) + 1 + 5; > >> +strcpy(execString, "exec "); > >> +strcat(execString, vmDef->init); > > > > Hum, it seems there is an off by one allocation error, you d

Re: [Libvir] PHP bindings for libvirt API?

On Thu, Mar 27, 2008 at 02:23:28PM +0100, BrunoM wrote: > Does anyone have information about a mean to plug libvirt into PHP? Maybe > we could just issue shell commands to "virsh", but it would be preferable > to have direct access to the API. It's been asked before and I guess it is the next ma

Re: [Libvir] [PATCH 2/9] xenXMError: mark for translation string args to this function

+1 -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailing list Libvir-li

Re: [Libvir] [PATCH 3/9] ReportError: mark for translation string args to this function

Simple enough, +1 -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailin

Re: [Libvir] [PATCH 5/9] Convert diagnostics like "VAR > MAX_VAR" to translatable messages.

+1. I think this nicely solves the problem of those messages which I thought were untranslatable before. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats,

Re: [Libvir] [PATCH 6/9] error: mark most string arguments for translation

+1 -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailing list Libvir-l

Re: [Libvir] [PATCH 7/9] openvzLog: mark its string arguments for translation

+1 -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -- Libvir-list mailing list Libvir-list@redh

Re: [Libvir] [PATCH 8/9] testError: mark most string arguments for translation

On Wed, Mar 26, 2008 at 08:57:56PM +0100, Jim Meyering wrote: > -# Uncomment this after adjusting remaining diagnostics to be translatable. > +# Uncomment the following and run "make syntax-check" to see diagnostics > +# that are not yet marked for translation, but that need to be rewritten > +# so

Re: [Libvir] [PATCH 9/9] lxcError: mark a string and add to the list of nearly-checked functions

+1, simple. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailin

Re: [Libvir] [PATCH 4/9] qemudReportError: mark for translation string args to this function

On Wed, Mar 26, 2008 at 08:55:53PM +0100, Jim Meyering wrote: > qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY, > - "vncTLSx509certdir"); > + "%s", _("failed to allocate > vncTLSx509certdir")); versus: > qemudRep

Re: [Libvir] [PATCH 1/9] Mark many more strings for translation.

+1 -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailing list Libvir-l

Re: [Libvir] [PATCH 8/9] testError: mark most string arguments for translation

"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > On Wed, Mar 26, 2008 at 08:57:56PM +0100, Jim Meyering wrote: >> -# Uncomment this after adjusting remaining diagnostics to be translatable. >> +# Uncomment the following and run "make syntax-check" to see diagnostics >> +# that are not yet marked f

Re: [Libvir] [PATCH 4/9] qemudReportError: mark for translation string args to this function

"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > On Wed, Mar 26, 2008 at 08:55:53PM +0100, Jim Meyering wrote: >> qemudReportError(NULL, NULL, NULL, VIR_ERR_NO_MEMORY, >> - "vncTLSx509certdir"); >> + "%s", _("failed to allocate

Re: [Libvir] [PATCH 4/9] qemudReportError: mark for translation string args to this function

On Fri, Mar 28, 2008 at 12:15:04PM +0100, Jim Meyering wrote: > But there's nothing we can do about the latter, and there *is* something > we can do about the former: precede with "%s". Of course, gettext tools > like msgmerge are careful to ensure that %-directives in translations > match those i

Re: [Libvir] [PATCH 4/9] qemudReportError: mark for translation string args to this function

"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > On Fri, Mar 28, 2008 at 12:15:04PM +0100, Jim Meyering wrote: >> But there's nothing we can do about the latter, and there *is* something >> we can do about the former: precede with "%s". Of course, gettext tools >> like msgmerge are careful to ens

[Libvir] Lxc driver patch

Patch against CVS version, it tries to avoid 2 issues: - problem with global data settings when loading of the driver got interrupted. Check more NULLs and reset to NULL, i was getting crashes when running the regression tests and the /etc/libvirtd/lxc was not accessible.

[Libvir] Lxc conf patch

Okay, that's something i promised last week, but it has some significant changes: - cleanup the XPath methods to access the XML informations, reusing the existing methods from xml.h - make string fields from __lxc_vm_def dynamic (except the UUID) - fix what looked like a funny leak

[Libvir] use C99 initializer for lastErr

...this makes things just a bit more readable. -- Guido --- src/virterror.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/virterror.c b/src/virterror.c index 1e39be4..1463129 100644 --- a/src/virterror.c +++ b/src/virterror.c @@ -19,7 +19,9 @@ #include "internal

[Libvir] [PATCH/RFC] remote driver uses already freed dom

Hi, when trying to undefine a running qemu domain the domain name gets corrupted: $ ./virsh undefine system1 Name: /�em1 libvir: QEMU error /�em1: internal error cannot delete active domain error: Failed to undefine domain system1 the reaseon is that in qemud/remote.c the domain is freed after f

[Libvir] [PATCH] deep copy dom structure

--- src/virterror.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/virterror.c b/src/virterror.c index 1463129..49f3b89 100644 --- a/src/virterror.c +++ b/src/virterror.c @@ -115,6 +115,11 @@ virResetError(virErrorPtr err) free(err->str1); free

Re: [Libvir] [PATCH/RFC] remote driver uses already freed dom

...and here's the patch attached again. It seems mailman stripped the attachment and the original mail into two parts because of the git headers. -- Guido --- src/virterror.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/src/virterror.c b/src/virterror.c i

Re: [Libvir] ruby binding patch

Hi Vadim, thanks a lot for the patch. First off, can you send patches in the future as text patches, either attached or inline[1] ? I was able to apply your hg bundle though. On Thu, 2008-03-27 at 23:59 -0700, Vadim Zaliva wrote: > I have attempted to add following methods to Domain class: > > 1

Re: [Libvir] Patch for routed virtual networks

On Tue, Mar 25, 2008 at 12:56:31PM +0100, Mads Chr. Olesen wrote: > > man, 24 03 2008 kl. 19:00 +, skrev Daniel P. Berrange: > > > > On Mon, Mar 24, 2008 at 10:52:41AM +0100, Mads Chr. Olesen wrote: > > > Anything further I can do to help get this patch commited? > > > > > > I have been runn

Re: [Libvir] ruby binding patch

On Mar 28, 2008, at 10:48, David Lutterkort wrote: * there were no tests for the two new methods. In general, try to add/expand the tests in tests/tc_connect.rb when you add to the bindings, though that is highly dependent on what the test driver supports. In this case t