Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-25 Thread Daniel Veillard
On Thu, Apr 24, 2008 at 10:14:49PM +0100, Daniel P. Berrange wrote: On Thu, Apr 24, 2008 at 10:42:34PM +0200, Jim Meyering wrote: All of the virBufferAddLit and virBufferVSprintf calls above can fail with ENOMEM. I see that there are *many* more virBufferAddLit and virBufferVSprintf calls

Re: [libvir] [PATCH] Change group ownership of /var/run/libvirt/

2008-04-25 Thread Guido Günther
On Thu, Apr 24, 2008 at 07:20:45PM +0400, Anton Protopopov wrote: 1) If libvirtd is running as root, main() will try to change the group ownership of /var/run/libvirt to one specified by unix_sock_gid. 2) Default permissions on /var/run/libvirt are now 0750 How does this match with the default

Re: [Libvir] [PATCH] avoid problems with sign-extended char operand to is* functions

2008-04-25 Thread Daniel Veillard
On Thu, Apr 24, 2008 at 10:01:10PM +0200, Jim Meyering wrote: I spotted this in existing code while doing a review: These uses all cause trouble if the byte in question has a value larger than 127 and the char type is signed. avoid problems with sign-extended char operand to is*

[Libvir] libvirt.org is not correctly viewed on IE

2008-04-25 Thread Atsushi SAKAI
Hi, Dan My collegue says the libvirt.org web pages are not correctly viewed from InternetExplorer.(CSS problem ?) Where should I report it? Of course, it views fine on Firefox! (I always use Firefox) Thanks Atsushi SAKAI -- Libvir-list mailing list Libvir-list@redhat.com

Re: [Libvir] PATCH 4/4: Xen test suite support

2008-04-25 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: This patch updates the Xen test suite to cover the new serial and paralle device syntax extensions Looks good. sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml| 44 ++ sexpr2xmldata/sexpr2xml-fv-serial-file.xml | 48 ++

Re: [Libvir] libvirt.org is not correctly viewed on IE

2008-04-25 Thread Daniel Veillard
On Fri, Apr 25, 2008 at 09:04:07PM +0900, Atsushi SAKAI wrote: Hi, Dan My collegue says the libvirt.org web pages are not correctly viewed from InternetExplorer.(CSS problem ?) Where should I report it? here I guess, what's the problem ? Daniel -- Red Hat Virtualization group

Re: [Libvir] libvirt.org is not correctly viewed on IE

2008-04-25 Thread Atsushi SAKAI
Hi, Daniel Nothing Heavy. Just left side window does not appear on IE. But, It should be fixed as nice to have, since IE is also a major Web browser. (libvirt is also working on Windows.) Or should I check for my spare time? Thanks Atsushi SAKAI Daniel Veillard [EMAIL PROTECTED] wrote: On

Re: [Libvir] libvirt.org is not correctly viewed on IE

2008-04-25 Thread Daniel Veillard
On Fri, Apr 25, 2008 at 09:38:02PM +0900, Atsushi SAKAI wrote: Hi, Daniel Nothing Heavy. Just left side window does not appear on IE. But, It should be fixed as nice to have, since IE is also a major Web browser. (libvirt is also working on Windows.) Well I certainly can't test it, I

Re: [Libvir] libvirt.org is not correctly viewed on IE

2008-04-25 Thread Daniel Veillard
On Fri, Apr 25, 2008 at 09:51:50PM +0900, Atsushi SAKAI wrote: Hi, Daniel I checked further. IE7 shows fine.(on my colleague machine.) IE6 lacks left side.(my and other colleague machine.) Well if not too hard we should try to fix the CSS to help rendering on IE 6 too, thanks, Daniel

Re: [Libvir] libvirt.org is not correctly viewed on IE

2008-04-25 Thread Daniel Veillard
On Fri, Apr 25, 2008 at 02:13:59PM +0100, Daniel P. Berrange wrote: On Fri, Apr 25, 2008 at 09:09:17AM -0400, Daniel Veillard wrote: Well I certainly can't test it, I have no IE around really, could be a layering problem, are your colleagues able to click on the search box on the top

Re: [libvir] [PATCH] Change group ownership of /var/run/libvirt/

2008-04-25 Thread Daniel Veillard
On Fri, Apr 25, 2008 at 12:57:23PM +0400, Anton Protopopov wrote: 2008/4/25, Guido Günther [EMAIL PROTECTED]: On Thu, Apr 24, 2008 at 07:20:45PM +0400, Anton Protopopov wrote: 1) If libvirtd is running as root, main() will try to change the group ownership of /var/run/libvirt to one

[Libvir] [PATCH] avoid format-related warnings

2008-04-25 Thread Jim Meyering
This avoids two warnings: avoid format-related warnings * qemud/qemud.c (main): Fix a bogus format string reported as umarked. * src/virsh.c (cmdVcpupin): Non-literal with no args. Signed-off-by: Jim Meyering [EMAIL PROTECTED] --- qemud/qemud.c |4 ++-- src/virsh.c

[Libvir] [PATCH] avoid make distcheck failure

2008-04-25 Thread Jim Meyering
make distcheck was failing. This fixes it: avoid make distcheck failure * docs/Makefile.am (EXTRA_DIST): Replace wildcards html/*.html and html/*.png the corresponding lists of file names. Signed-off-by: Jim Meyering [EMAIL PROTECTED] --- docs/Makefile.am | 11

Re: [Libvir] libvirt.org is not correctly viewed on IE

2008-04-25 Thread Daniel P. Berrange
On Fri, Apr 25, 2008 at 09:51:50PM +0900, Atsushi SAKAI wrote: Hi, Daniel I checked further. IE7 shows fine.(on my colleague machine.) IE6 lacks left side.(my and other colleague machine.) I have fixed the layout and it now displays correctly in IE6 7 Regards, Dan. -- |: Red Hat,

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-25 Thread Daniel P. Berrange
On Fri, Apr 25, 2008 at 03:11:44AM -0400, Daniel Veillard wrote: On Thu, Apr 24, 2008 at 10:14:49PM +0100, Daniel P. Berrange wrote: On Thu, Apr 24, 2008 at 10:42:34PM +0200, Jim Meyering wrote: All of the virBufferAddLit and virBufferVSprintf calls above can fail with ENOMEM. I see that

Re: [Libvir] PATCH 2/4: Xen driver support for serial/paralle

2008-04-25 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Fri, Apr 25, 2008 at 03:11:44AM -0400, Daniel Veillard wrote: On Thu, Apr 24, 2008 at 10:14:49PM +0100, Daniel P. Berrange wrote: On Thu, Apr 24, 2008 at 10:42:34PM +0200, Jim Meyering wrote: All of the virBufferAddLit and virBufferVSprintf