Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-20 Thread Stefan de Konink
Daniel P. Berrange schreef: and a volume can be either a file or a physical device, so fixing it to be 'phy:' is not correct. How can we know if the volume is a file or a device? virStorageVolGetInfo() will tell you via the 'info' field of the struct it fills As attached. I updated the 'typ'

[libvirt] PATCH: Fix removal of iptables FORWARD rules

2008-05-20 Thread Daniel P. Berrange
The previous patch to add routed networking broke the removal of one of the FORWARD rules at shutdown. It was adding /sbin/iptables --table filter --insert FORWARD --destination 192.168.122.0/255.255.255.0 --out-interface virbr0 --match state --state ESTABLISHED,RELATED --jump ACCE

Re: [libvirt] Domain XML format using defined storage volume + RFC

2008-05-20 Thread Daniel P. Berrange
On Mon, May 19, 2008 at 11:53:07PM +0200, Stefan de Konink wrote: > Daniel P. Berrange schreef: > >On Fri, May 16, 2008 at 01:00:16AM +0200, Stefan de Konink wrote: > > > >>+} > >>+} > >>+} > >> } else if ((target == NULL) && >

Re: [libvirt] [PATCH] Free object after *Destroy in python bindings

2008-05-20 Thread Cole Robinson
Daniel P. Berrange wrote: > On Mon, May 19, 2008 at 05:17:07PM -0400, Cole Robinson wrote: >> Daniel P. Berrange wrote: >>> On Mon, May 19, 2008 at 04:21:55PM -0400, Cole Robinson wrote: Cole Robinson wrote: > The patch below fixes an issue in the python bindings with the > vir*Destroy

Re: [libvirt] PATCH: Add NUMA info to QEMU driver

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 06:42:17PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > + else > > +AC_CHECK_HEADER([numa.h],[], > > + [AC_MSG_ERROR([You must install the numactl development package in > > order to compile libvirt])]) > > +AC_CHECK_LIB(nu

Re: [libvirt] PATCH: Add NUMA info to QEMU driver

2008-05-20 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... > These 2 configure changes are candidates for global cleanup - the same > duplicate diagnostics & underquoting are present through-out Yep. Deferring it is fine, of course. That's why I said this: [I hesitate to mention this, since there is

Re: [libvirt] PATCH: Write pidfile earlier in startup

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 12:02:03PM -0400, Daniel Veillard wrote: > On Fri, May 16, 2008 at 05:39:46PM +0100, Daniel P. Berrange wrote: > > On Fri, May 16, 2008 at 05:05:08PM +0100, Daniel P. Berrange wrote: > > There were actually some more changes needed. It needs to write the PID file > > even if

Re: [libvirt] PATCH: Write pidfile earlier in startup

2008-05-20 Thread Daniel Veillard
On Fri, May 16, 2008 at 05:39:46PM +0100, Daniel P. Berrange wrote: > On Fri, May 16, 2008 at 05:05:08PM +0100, Daniel P. Berrange wrote: > > When used with the --daemon arg, libvirtd will write out a pid file to > > /var/run/libvirtd.pid and exit if this file already exists. Unfortuantely > > it d

Re: [libvirt] PATCH: Add NUMA info to QEMU driver

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 02:15:59PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > This patch includes NUMA topology info in the QEMU driver capabilities > > XML output. It also implements the free memory driver APIs. This is done > > with the LGPL'd numactl librar

Re: [libvirt] PATCH: Don't rely on host binaries in QEMU tests

2008-05-20 Thread Daniel Veillard
On Fri, May 16, 2008 at 04:19:16PM +0100, Daniel P. Berrange wrote: > The QEMU test suites rely on the QEMU/KVM/Xenner binaries being present > in /usr/bin. This has obvious problems and is unneccessary. The solution > is to not use the qemudCapsInit() function which initializes capabilities > base

Re: [libvirt] listen_tls not enabling libvirtd to listen for tls

2008-05-20 Thread Daniel Veillard
On Mon, May 19, 2008 at 04:39:26PM +0300, Kenneth Nagin wrote: > [...] > Per your request I created this attached updated remote.html.in file: > (See attached file: remote.html.in.nagin) Looks fine, applied, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/

Re: [libvirt] [PATCH] Fix destroy command memory leaks

2008-05-20 Thread Cole Robinson
Cole Robinson wrote: > Some pieces of libvirt currently assume that the vir*Destroy > functions will free the passed object upon success. In > practice none of the current drivers seem to do this, > resulting in memory leaks. > > The attached patch fixes the leaks I could find, as well as > change

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 02:18:37PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > On Tue, May 20, 2008 at 01:49:08PM +0200, Jim Meyering wrote: > >> > >> Looks fine. Though you'll want to undo the global > >> re-indentation-with-TABs in qemud/remote_protocol.h: >

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2008 at 03:38:01PM +0100, Daniel P. Berrange wrote: > So I vote for applying all Cole's patches which do indeed fix a number > of memory leaks. Fixing the daemon to correctly serialize errors with > a dom/net object can be done later unless someone has burning desire > to tackle it

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 10:11:57AM -0400, Cole Robinson wrote: > Richard W.M. Jones wrote: > > On Tue, May 20, 2008 at 09:57:02AM -0400, Cole Robinson wrote: > >> I'll try this again from the original unpatched state and try to > >> figure out exactly what was happening. > > > > Do you trigger an

Re: [libvirt] autostarting xend domains

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 04:20:44PM +0200, Wolfgang Rosenauer wrote: > Daniel P. Berrange wrote: > > I just found the following patch which is applied to Xen 3.1 on openSUSE > which sounds like the culprit. > If you can confirm that I'm happy to report a bug over at openSUSE. Yes, this changeset

Re: [libvirt] autostarting xend domains

2008-05-20 Thread Wolfgang Rosenauer
Daniel P. Berrange wrote: On Tue, May 20, 2008 at 10:00:50AM -0400, Cole Robinson wrote: Wolfgang Rosenauer wrote: I found that support for setting autostart parameters for xend managed guests has been added to libvirt (https://www.redhat.com/archives/libvir-list/2008-May/msg00060.html) So I

Re: [libvirt] autostarting xend domains

2008-05-20 Thread Wolfgang Rosenauer
Daniel P. Berrange wrote: On Tue, May 20, 2008 at 10:00:50AM -0400, Cole Robinson wrote: I found that support for setting autostart parameters for xend managed guests has been added to libvirt (https://www.redhat.com/archives/libvir-list/2008-May/msg00060.html) So I tried that but failed wit

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-20 Thread Cole Robinson
Richard W.M. Jones wrote: > On Tue, May 20, 2008 at 09:57:02AM -0400, Cole Robinson wrote: >> I'll try this again from the original unpatched state and try to >> figure out exactly what was happening. > > Do you trigger an error at any point in the testing? You could try > doing that (eg. try mig

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2008 at 09:57:02AM -0400, Cole Robinson wrote: > I'll try this again from the original unpatched state and try to > figure out exactly what was happening. Do you trigger an error at any point in the testing? You could try doing that (eg. try migrating a QEMU domain). Rich. -- R

Re: [libvirt] autostarting xend domains

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 10:00:50AM -0400, Cole Robinson wrote: > Wolfgang Rosenauer wrote: > > Hi, > > > > I found that support for setting autostart parameters for xend managed > > guests has been added to libvirt > > (https://www.redhat.com/archives/libvir-list/2008-May/msg00060.html) > > > >

Re: [libvirt] autostarting xend domains

2008-05-20 Thread Cole Robinson
Wolfgang Rosenauer wrote: > Hi, > > I found that support for setting autostart parameters for xend managed > guests has been added to libvirt > (https://www.redhat.com/archives/libvir-list/2008-May/msg00060.html) > > So I tried that but failed with virsh's autostart command (and also > virt-man

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-20 Thread Cole Robinson
Richard W.M. Jones wrote: > On Tue, May 20, 2008 at 02:39:52PM +0100, Daniel P. Berrange wrote: >> I'm not entirely convinced yet - the code certainly suggests to me that >> we need to free these. Only a couple of lines further up we obtain a >> referenced >> object >> >> /* Get the domain and

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2008 at 02:39:52PM +0100, Daniel P. Berrange wrote: > I'm not entirely convinced yet - the code certainly suggests to me that > we need to free these. Only a couple of lines further up we obtain a > referenced > object > > /* Get the domain and network, if set. */ > dom =

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 09:32:28AM -0400, Cole Robinson wrote: > Daniel P. Berrange wrote: > > On Tue, May 20, 2008 at 10:44:52AM +0100, Richard W.M. Jones wrote: > >> On Mon, May 19, 2008 at 04:58:38PM -0400, Cole Robinson wrote: > >>> diff --git a/src/remote_internal.c b/src/remote_internal.c > >

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-20 Thread Cole Robinson
Daniel P. Berrange wrote: > On Tue, May 20, 2008 at 10:44:52AM +0100, Richard W.M. Jones wrote: >> On Mon, May 19, 2008 at 04:58:38PM -0400, Cole Robinson wrote: >>> diff --git a/src/remote_internal.c b/src/remote_internal.c >>> index 51e8eb7..80f6ce6 100644 >>> --- a/src/remote_internal.c >>> +++

Re: [libvirt] libvirt & VServer?

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 08:28:27AM -0400, Daniel Veillard wrote: > On Tue, May 20, 2008 at 10:22:50AM +0100, Richard W.M. Jones wrote: > > On Tue, May 20, 2008 at 05:23:27AM -0400, Daniel Veillard wrote: > > > On Tue, May 20, 2008 at 09:46:11AM +0100, Richard W.M. Jones wrote: > > > > > > > > Does

Re: [libvirt] [PATCH] Free object after *Destroy in python bindings

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 01:20:17PM +0100, Richard W.M. Jones wrote: > On Tue, May 20, 2008 at 12:58:15PM +0100, Daniel P. Berrange wrote: > > On Tue, May 20, 2008 at 10:51:43AM +0100, Richard W.M. Jones wrote: > > > On Mon, May 19, 2008 at 09:25:55PM +0100, Daniel P. Berrange wrote: > > > > The doc

Re: [libvirt] libvirt & VServer?

2008-05-20 Thread Daniel Veillard
On Tue, May 20, 2008 at 10:22:50AM +0100, Richard W.M. Jones wrote: > On Tue, May 20, 2008 at 05:23:27AM -0400, Daniel Veillard wrote: > > On Tue, May 20, 2008 at 09:46:11AM +0100, Richard W.M. Jones wrote: > > > > > > Does anyone know what the current status of Linux VServer support is? > > > Las

Re: [libvirt] [PATCH] Free object after *Destroy in python bindings

2008-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2008 at 12:58:15PM +0100, Daniel P. Berrange wrote: > On Tue, May 20, 2008 at 10:51:43AM +0100, Richard W.M. Jones wrote: > > On Mon, May 19, 2008 at 09:25:55PM +0100, Daniel P. Berrange wrote: > > > The docs are wrong. Destory merely hard-kills the object being managed. > > > It do

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-20 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Tue, May 20, 2008 at 01:49:08PM +0200, Jim Meyering wrote: >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> > For some reason the virNodeGetFreeMemroy and virNodeGetCellsFreeMemory >> > NUMA APIs were never added to the remote driver. THis

Re: [libvirt] PATCH: Add NUMA info to QEMU driver

2008-05-20 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > This patch includes NUMA topology info in the QEMU driver capabilities > XML output. It also implements the free memory driver APIs. This is done > with the LGPL'd numactl library. The configure script probes for it and > only enables this function

Re: [libvirt] [PATCH] Fix destroy command memory leaks

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 10:48:27AM +0100, Richard W.M. Jones wrote: > On Mon, May 19, 2008 at 05:30:33PM -0400, Cole Robinson wrote: > > Some pieces of libvirt currently assume that the vir*Destroy > > functions will free the passed object upon success. In > > practice none of the current drivers s

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 10:44:52AM +0100, Richard W.M. Jones wrote: > On Mon, May 19, 2008 at 04:58:38PM -0400, Cole Robinson wrote: > > diff --git a/src/remote_internal.c b/src/remote_internal.c > > index 51e8eb7..80f6ce6 100644 > > --- a/src/remote_internal.c > > +++ b/src/remote_internal.c > > @

Re: [libvirt] [PATCH] Free object after *Destroy in python bindings

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 10:51:43AM +0100, Richard W.M. Jones wrote: > On Mon, May 19, 2008 at 09:25:55PM +0100, Daniel P. Berrange wrote: > > The docs are wrong. Destory merely hard-kills the object being managed. > > It does not free memory associated with the object. > > No, the documentation sa

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-20 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 01:49:08PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > For some reason the virNodeGetFreeMemroy and virNodeGetCellsFreeMemory > > NUMA APIs were never added to the remote driver. THis patch fixes that. > > It also updates the 2 perl scrip

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-20 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > For some reason the virNodeGetFreeMemroy and virNodeGetCellsFreeMemory > NUMA APIs were never added to the remote driver. THis patch fixes that. > It also updates the 2 perl scripts which post-process the RPC files to > not insert TABs, since we'd p

Re: [libvirt] VMware ESX

2008-05-20 Thread Stefan de Konink
On Tue, 20 May 2008, Pau Garcia i Quiles wrote: > > I read about VIX again, but is this already working for ESX? On their site > > and fora they mention Workstatation/Server only. > > According to http://communities.vmware.com/thread/115071 the VIX API > will be supported in ESX in the future. Th

Re: [libvirt] VMware ESX

2008-05-20 Thread Pau Garcia i Quiles
Quoting Stefan de Konink <[EMAIL PROTECTED]>: On Tue, 20 May 2008, Daniel Veillard wrote: On Mon, May 19, 2008 at 02:28:10PM -0600, drew einhorn wrote: > Hi, Hi, > I have some code that can probably be hacked into a libvirt driver for > VMware ESX. interesting, how did you go? I did som

Re: [libvirt] VMware ESX

2008-05-20 Thread Stefan de Konink
On Tue, 20 May 2008, Daniel Veillard wrote: > On Mon, May 19, 2008 at 02:28:10PM -0600, drew einhorn wrote: > > Hi, > > Hi, > > > I have some code that can probably be hacked into a libvirt driver for > > VMware ESX. > > interesting, how did you go? I did some experimentation using SOAP and >

Re: [libvirt] [RFC] Comfortable lookup functions interface/block stats

2008-05-20 Thread Daniel Veillard
On Mon, May 19, 2008 at 12:48:59PM +0100, Richard W.M. Jones wrote: > On Mon, May 12, 2008 at 01:35:33AM +0200, Stefan de Konink wrote: > > Wouldn't it be much nicer for Joe Programmer if the API facilitated the > > functions: > > > > char ** virDomainInterfacePaths(virDomainPtr dom); > > char **

Re: [libvirt] [PATCH] Free object after *Destroy in python bindings

2008-05-20 Thread Richard W.M. Jones
On Mon, May 19, 2008 at 09:25:55PM +0100, Daniel P. Berrange wrote: > The docs are wrong. Destory merely hard-kills the object being managed. > It does not free memory associated with the object. No, the documentation says it frees the objects (and has done forever), so it should free them. I hav

Re: [libvirt] [PATCH] Fix destroy command memory leaks

2008-05-20 Thread Richard W.M. Jones
On Mon, May 19, 2008 at 05:30:33PM -0400, Cole Robinson wrote: > Some pieces of libvirt currently assume that the vir*Destroy > functions will free the passed object upon success. In > practice none of the current drivers seem to do this, > resulting in memory leaks. > > The attached patch fixes t

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-20 Thread Richard W.M. Jones
On Mon, May 19, 2008 at 04:58:38PM -0400, Cole Robinson wrote: > diff --git a/src/remote_internal.c b/src/remote_internal.c > index 51e8eb7..80f6ce6 100644 > --- a/src/remote_internal.c > +++ b/src/remote_internal.c > @@ -4606,6 +4606,10 @@ server_error (virConnectPtr conn, remote_error *err) >

Re: [libvirt] Re: [Libvir] KVM migration

2008-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2008 at 05:25:35AM -0400, Daniel Veillard wrote: > On Mon, May 19, 2008 at 11:50:25AM +0100, Richard W.M. Jones wrote: > > On Fri, May 16, 2008 at 12:12:00AM +0200, Soren Hansen wrote: > > > On Mon, Apr 07, 2008 at 04:40:41PM +0100, Richard W.M. Jones wrote: > > > > It turns out tha

Re: [libvirt] Re: [Libvir] KVM migration

2008-05-20 Thread Daniel Veillard
On Mon, May 19, 2008 at 11:50:25AM +0100, Richard W.M. Jones wrote: > On Fri, May 16, 2008 at 12:12:00AM +0200, Soren Hansen wrote: > > On Mon, Apr 07, 2008 at 04:40:41PM +0100, Richard W.M. Jones wrote: > > > It turns out that the general migration strategy I defined[1] in > > > reference to Xen,

Re: [libvirt] libvirt & VServer?

2008-05-20 Thread Richard W.M. Jones
On Tue, May 20, 2008 at 05:23:27AM -0400, Daniel Veillard wrote: > On Tue, May 20, 2008 at 09:46:11AM +0100, Richard W.M. Jones wrote: > > > > Does anyone know what the current status of Linux VServer support is? > > Last message I can find is a patch for it, which didn't make it into > > libvirt:

Re: [libvirt] libvirt & VServer?

2008-05-20 Thread Daniel Veillard
On Tue, May 20, 2008 at 09:46:11AM +0100, Richard W.M. Jones wrote: > > Does anyone know what the current status of Linux VServer support is? > Last message I can find is a patch for it, which didn't make it into > libvirt: > > http://www.redhat.com/archives/libvir-list/2007-October/msg00273.html

[libvirt] libvirt & VServer?

2008-05-20 Thread Richard W.M. Jones
Does anyone know what the current status of Linux VServer support is? Last message I can find is a patch for it, which didn't make it into libvirt: http://www.redhat.com/archives/libvir-list/2007-October/msg00273.html Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com

Re: [libvirt] VMware ESX

2008-05-20 Thread Daniel Veillard
On Mon, May 19, 2008 at 02:28:10PM -0600, drew einhorn wrote: > Hi, Hi, > I have some code that can probably be hacked into a libvirt driver for > VMware ESX. interesting, how did you go? I did some experimentation using SOAP and gsoap2 a few weeks ago that i need to restart. Did you use VIX