[libvirt] Problem in attaching a interface to a domain

2008-05-21 Thread sarveswara rao mygapula
Hello, I am facing problems in creating a network bridge using libvirt. My requirement is, i need to create a bridge on the host machine. The bridge shd get ip address from dhcp server(instead of static). I am not getting what exactly the xml format that virsh is looking for? I am using the follo

[libvirt] Dom0 Interface stats with virDomainInterfaceStats

2008-05-21 Thread Stefan de Konink
Would it be possible to enable fetch of the interface stats of the dom0 via the API? Stefan -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] PATCH: Misc fixes to qparams

2008-05-21 Thread Daniel P. Berrange
I found a couple more small bugs in the qparams code - In the qparam_query_parse() method, after appending each (name,value) pair of params, it failed to free the temporary buffers for the (name,value) pair. - Did not allow for ';' as a valid query parameter separator - In a couple of OO

[libvirt] PATCH: Remove duplicate messages in configure.ac

2008-05-21 Thread Daniel P. Berrange
Another configure.ac cleanup, this time removing a bunch of duplicated messages printed out by various checks. Applies ontop of the previous patch. Dan. diff -r cc378ee57aab configure.in --- a/configure.in Tue May 20 14:23:31 2008 -0400 +++ b/configure.in Tue May 20 14:32:17 2008 -0400

[libvirt] PATCH: Ensure configure.ac is fully quoted

2008-05-21 Thread Daniel P. Berrange
As suggested by Jim, this patch goes through the configure script and makes sure all args to macros are fully quoted. NB, this applies on top of the NUMA/cpu pinning patches I sent the other day, not CVS. Dan. diff -r d2bddf5ed80e configure.in --- a/configure.in Tue May 20 14:10:37 2008 -040

[libvirt] PATCH: Fix some more memory leaks

2008-05-21 Thread Daniel P. Berrange
While testing Cole's series of patches I identified a couple more places where we leak memory. In libvirt.c, the default authentication callback uses uninitialized data, and indeed strdup()'s it and this is then never released. This simply disables that bit of code. In qparams.c when free'ing th

Re: [libvirt] [PATCH] Free object after *Destroy in python bindings

2008-05-21 Thread Daniel P. Berrange
On Tue, May 20, 2008 at 02:43:42PM -0400, Cole Robinson wrote: > > Here is the correct patch then: remove any special case cleanup for the > destroy functions. I've applied this to CVS Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -

Re: [libvirt] [PATCH] Fix destroy command memory leaks

2008-05-21 Thread Daniel P. Berrange
On Mon, May 19, 2008 at 05:30:33PM -0400, Cole Robinson wrote: > Some pieces of libvirt currently assume that the vir*Destroy > functions will free the passed object upon success. In > practice none of the current drivers seem to do this, > resulting in memory leaks. > > The attached patch fixes t

Re: [libvirt] [PATCH] Domain/Net object cleanups after remote error

2008-05-21 Thread Daniel P. Berrange
On Mon, May 19, 2008 at 04:58:38PM -0400, Cole Robinson wrote: > Cole Robinson wrote: > > Domain and Net objects were not being cleaned up properly > > when reporting errors from the remote driver. Attached patch > > fixes this. > > > > Stupid typo. Correct patch attached. I've applied this to C

Re: [libvirt] Re: [Libvir] ISCSI howto, example, etc?

2008-05-21 Thread Chris Lalancette
Daniel P. Berrange wrote: > Can you provide a documentation patch describing the sysfs layout for the > kernels the patch is intended to support, along with captured output from > the isciadm tool running on each, for the various commands libvirt needs > to run. > > The only way we are going t

Re: [libvirt] Problems in using Storage APIs in libvirt

2008-05-21 Thread Amudhan Gunasekaran
Hi Chris Lalancette, Thanks for your quick reply. I just removed the already installed libvirt from my machine and did a *make install* in my CVS version of the code (which is in my machine at: /root/libvirt). The *make install* completed without any problems. But when I tried to compile the co

Re: [libvirt] Problems in using Storage APIs in libvirt

2008-05-21 Thread Chris Lalancette
Amudhan Gunasekaran wrote: > Hi, > > I am getting the following the error when I try to use ANY storage related > APIs. > > undefined reference to '' for example, > > undefined reference to virConnectListStoragePools. > > I checked in the libvirt.h and it has the method definition. I checked t

[libvirt] Problems in using Storage APIs in libvirt

2008-05-21 Thread Amudhan Gunasekaran
Hi, I am getting the following the error when I try to use ANY storage related APIs. undefined reference to '' for example, undefined reference to virConnectListStoragePools. I checked in the libvirt.h and it has the method definition. I checked the libvirt.c and it has the implementations. I

Re: [libvirt] [PATCH] A few simple "copy-paste" errors

2008-05-21 Thread Daniel Veillard
On Mon, May 19, 2008 at 07:29:24PM +0400, Anton Protopopov wrote: > Hi, > > I found few simple errors in docs/formatdomain.html while scrolling it; > the appended patch fixes them. Oh, right, thanks ! Just one thing to note, the .html in docs are generated from the .html.in so it's better to ge

Re: [libvirt] PATCH: Support initial boot time CPU affinity mask

2008-05-21 Thread Daniel Veillard
On Fri, May 16, 2008 at 10:50:20PM +0100, Daniel P. Berrange wrote: > The XML format allows for an initial CPU mask to be specified for a guests > vCPUs. eg with this XML: > > 1 what about output. In the xen case we went though the exercise to dump a cpuset string back only if it wasn't 'all

Re: [libvirt] PATCH: Support vCPU pinning in QEMU driver

2008-05-21 Thread Daniel P. Berrange
On Wed, May 21, 2008 at 10:59:28AM -0400, Daniel Veillard wrote: > On Fri, May 16, 2008 at 10:47:40PM +0100, Daniel P. Berrange wrote: > > KVM added ability to get the thread ID for vCPUs via the monitor > > > > (qemu) info cpus > > * CPU #0: pc=0x0000 thread_id=11463 > > CPU #1: pc=

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-21 Thread Jim Meyering
"Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > On Tue, May 20, 2008 at 03:51:53PM +0100, Daniel P. Berrange wrote: >> +if GLIBC_RPCGEN >> +mv $@ [EMAIL PROTECTED] >> +sed -e 's/\t//g' [EMAIL PROTECTED] > $@ >> +endif > > I guess it doesn't matter in a generated file, but is the a

Re: [libvirt] PATCH: Fix removal of iptables FORWARD rules

2008-05-21 Thread Richard W.M. Jones
On Tue, May 20, 2008 at 09:44:01PM +0100, Daniel P. Berrange wrote: > The previous patch to add routed networking broke the removal of one of the > FORWARD rules at shutdown. It was adding > > /sbin/iptables --table filter --insert FORWARD > --destination 192.168.122.0/255.255.255.0 > -

Re: [libvirt] PATCH: Add NUMA apis to remote driver

2008-05-21 Thread Richard W.M. Jones
On Tue, May 20, 2008 at 03:51:53PM +0100, Daniel P. Berrange wrote: > +if GLIBC_RPCGEN > + mv $@ [EMAIL PROTECTED] > + sed -e 's/\t//g' [EMAIL PROTECTED] > $@ > +endif I guess it doesn't matter in a generated file, but is the above correct? Probably better to use the 'expand' comm

Re: [libvirt] PATCH: Support vCPU pinning in QEMU driver

2008-05-21 Thread Daniel Veillard
On Fri, May 16, 2008 at 10:47:40PM +0100, Daniel P. Berrange wrote: > KVM added ability to get the thread ID for vCPUs via the monitor > > (qemu) info cpus > * CPU #0: pc=0x0000 thread_id=11463 > CPU #1: pc=0xfff0 thread_id=11464 > CPU #2: pc=0xfff0 thread_i

Re: [libvirt] Re: [Libvir] ISCSI howto, example, etc?

2008-05-21 Thread Daniel P. Berrange
On Wed, May 21, 2008 at 04:50:12PM +0200, Chris Lalancette wrote: > Stefan de Konink wrote: > > I think if you can get iscsi_sysfs.c; get_block_dev_from_lun you have the > > code already to do this all. So basically get openiscsi into a lib with > > helper functions. > > OK. I took a look at this

Re: [libvirt] Re: [Libvir] ISCSI howto, example, etc?

2008-05-21 Thread Chris Lalancette
Stefan de Konink wrote: > I think if you can get iscsi_sysfs.c; get_block_dev_from_lun you have the > code already to do this all. So basically get openiscsi into a lib with > helper functions. OK. I took a look at this further, and I figured out what is going on here. The original impetus for m

Re: [libvirt] virsh create Guest Crashing

2008-05-21 Thread Kenneth Nagin
>Stefan de Konink <[EMAIL PROTECTED]> wrote on 19/05/2008 18:18:25: > Chris Lalancette schreef: > > Kenneth Nagin wrote: > >> Setting up new root fs > >> setuproot: moving /dev failed: No such file or directory > >> no fstab.sys, mounting internal defaults > >> setuproot: error mounting /proc: No