Re: [libvirt] [PATCH] Eliminate noise from python type wrappers

2008-06-24 Thread Ryan Scott
Atsushi SAKAI wrote: Hi, Just a simple question. Why you do not turn off the DEBUG flag for libvirt build? Doing builds can be an interesting stress test, so we often have debug bits installed on our build servers. -Ryan Thanks Atsushi SAKAI Ryan Scott <[EMAIL PROTECTED]> wrote: Hi,

Re: [libvirt] [PATCH] Eliminate noise from python type wrappers

2008-06-24 Thread Atsushi SAKAI
Hi, Just a simple question. Why you do not turn off the DEBUG flag for libvirt build? Thanks Atsushi SAKAI Ryan Scott <[EMAIL PROTECTED]> wrote: > > Hi, > >We recently had a virt-install build failure when someone tried > building on a system with debug libvirt packages installed. It

[libvirt] [PATCH] Eliminate noise from python type wrappers

2008-06-24 Thread Ryan Scott
Hi, We recently had a virt-install build failure when someone tried building on a system with debug libvirt packages installed. It was caused by extra noise from commands that load libvirt. For example: $ python ./setup.py --version libvirt_virConnectPtrWrap: node = 8938fb8 0.300.3 I'

Re: [libvirt] PATCH: Generic internal API for domain XML parser/formatter

2008-06-24 Thread Daniel P. Berrange
On Tue, Jun 24, 2008 at 04:34:11PM +0100, Daniel P. Berrange wrote: > We currently have five drivers which handle the domain XML containing > duplicated parsers and formatters for the XML with varying degrees of > buginess, and often very similar structs. This patch introduces a new > general purpo

[libvirt] PATCH: 0/2: port QEMU driver to new XML apis

2008-06-24 Thread Daniel P. Berrange
The next two patches port the QEMU driver over to the new APIs. This is a fairly straightforward exercise since the new APIs are derived from the currenty QEMU driver impl. Aside from a mass deletion of code the rest is mostly just renaming function calls / objects. The test suite passes and I can

Re: [libvirt] PATCH: 2/2: port Test driver to new domain APIs

2008-06-24 Thread Daniel P. Berrange
This patch ports the Test driver over to the domain XML apis. Basically the 'struct _testDom' is removed, and replaced by usage of the generic virDomainObjPtr and virDomainDefPtr objects. The XML parser and formatters are ripped out and replaced by calls to the generic APIs in domain_conf.h. Fina

Re: [libvirt] PATCH: 1/2: port Test driver to network APIs

2008-06-24 Thread Daniel P. Berrange
This patch ports the Test driver to use the network XML apis. Basically the 'struct _testNet' is removed, and replaced by usage of the generic virNetworkObjPtr and virNetworkDefPtr objects. The XML parser and formatters are ripped out and replaced by calls to the generic APIs in network_conf.h. Fi

[libvirt] PATCH: 0/2: port Test driver to new XML apis

2008-06-24 Thread Daniel P. Berrange
The next two patches port the test driver over to use the new XML APIs for dealing with domain and network XML. More details with each one... Daniel. -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://

[libvirt] [PATCH 4 of 4] [LXC] Add setup/cleanup of container network interfaces

2008-06-24 Thread Dan Smith
Changes: - Remove extraneous "i" variables from various functions - Only bring up lo if we have other interfaces (and thus NETNS) - Fail setup of interfaces if NETNS support is not present - Only add CLONE_NEWNET to start flags if domain has interfaces defined - Make lxc_vm_t parameters const

[libvirt] [PATCH 3 of 4] [LXC] Add XML parsing of container network interfaces

2008-06-24 Thread Dan Smith
Changes: - Throw an error after parsing if nets were specified and NETNS support is not present diff -r 203dce381784 -r bb48967cf19e src/lxc_conf.c --- a/src/lxc_conf.cMon Jun 23 11:53:42 2008 -0700 +++ b/src/lxc_conf.cMon Jun 23 11:53:45 2008 -0700 @@ -69,6 +69,190 @@ __virRaiseE

[libvirt] [PATCH 2 of 4] [LXC] Add functions to manage veth device pairs

2008-06-24 Thread Dan Smith
This gives us the ability to create a veth pair so that we can move one into the network namespace of an LXC container. Changes from last time: - Fixed use of sprintf() - Fixed up 'ip link...' argument synthesis - Fixed license headers - Fixed while() {...} to do {...} while() - Fixed copying

[libvirt] [PATCH 1 of 4] [LXC] Detect support for NETNS in lxc driver initialization

2008-06-24 Thread Dan Smith
Allow check for containers support to be done without CLONE_NEWNET, and then determine support on the fly by checking for iproute2 support and a successful clone(CLONE_NEWNET). This lets us set a flag for later, as well as not completely disable LXC support on a system without NETNS support. diff

[libvirt] [PATCH 0 of 4] [LXC] RFC: Network interface support

2008-06-24 Thread Dan Smith
I think I have addressed all of the comments. Changes detailed per patch. I converted to using a dynamic detection routine for determining NETNS support, which I think is much better. That is pulled out into a separate patch for easier distinction. Thanks! -- Libvir-list mailing list Libvir-li

[libvirt] PATCH: Generic internal API for network XML parser/formatter

2008-06-24 Thread Daniel P. Berrange
We currently have two drivers which handle the networking XML containing duplicated parsers and formatters for the XML, and very similar structs. This patch introduces a new general purpose internal API for parsing and formatting network XML, and representing it as a series of structs. This code i

Re: [libvirt] PATCH: Helper for enumerations

2008-06-24 Thread Daniel P. Berrange
On Sun, Jun 15, 2008 at 11:55:10PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > There are quite a few places in our code where we have to convert from > > a string to an int enumeration, and vica-verca. This is tedious code to > > write, and I'm about to introduc