[Libvirt] [PATCH] 1+2=3 errors in docs

2008-07-08 Thread Anton Protopopov
Hi. This patch fixes three examples given in docs/drvqemu.html.in and docs/ formatnetwork.html.in A. libvirt_docs_examples.patch Description: Binary data -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] PATCH: 2/14: Generic network XML parser/formatter

2008-07-08 Thread Daniel P. Berrange
We currently have two drivers which handle the networking XML containing duplicated parsers and formatters for the XML, and very similar structs. This patch introduces a new general purpose internal API for parsing and formatting network XML, and representing it as a series of structs. This code

Re: [libvirt] PATCH: 4/14: Convert test driver to generic network API

2008-07-08 Thread Daniel P. Berrange
This patch ports the Test driver to use the network XML apis. Basically the 'struct _testNet' is removed, and replaced by usage of the generic virNetworkObjPtr and virNetworkDefPtr objects. The XML parser and formatters are ripped out and replaced by calls to the generic APIs in network_conf.h.

Re: [libvirt] PATCH: 5/14: Convert test driver to generic domain API

2008-07-08 Thread Daniel P. Berrange
This patch ports the Test driver over to the domain XML apis. Basically the 'struct _testDom' is removed, and replaced by usage of the generic virDomainObjPtr and virDomainDefPtr objects. The XML parser and formatters are ripped out and replaced by calls to the generic APIs in domain_conf.h.

Re: [libvirt] PATCH: 8/14: Remove dead Xen code

2008-07-08 Thread Daniel P. Berrange
This patch is a cleanup to prepare the way for the next set of Xen related patches. It basically removes a bunch of no-op or unused code. proxy_internal.c | 10 -- xen_unified.c|3 xend_internal.c | 242 +++ xend_internal.h | 91

Re: [libvirt] PATCH: 12/14: Convert XM driver XML formatter to generic API

2008-07-08 Thread Daniel P. Berrange
This replaces the code which converts from virConfPtr objects into XML, with code which converts from virConfPtr objects straight into virDomainDefPtr objects. A few more XML changes are needed in the test suite to take account of better XML generation this produces src/xend_internal.c

Re: [libvirt] PATCH: 14/14: Report XML errors against virConnectPtr

2008-07-08 Thread Daniel P. Berrange
The generic XML parsing routines can generate various errors. We were not passing a virConnectPtr object into any of them, so the errors were not propagated back to the calling app correctly. This fixes that problem domain_conf.c | 60 -

Re: [libvirt] PATCH: 1/14: Relative XPath expressions

2008-07-08 Thread Daniel Veillard
On Tue, Jul 08, 2008 at 05:32:45PM +0100, Daniel P. Berrange wrote: This change adjusts the XML parsing routines so that they will preserve the context node when evaluating XPath expressions. This allows us to use relative XPath expressions reliably in the parsers. Needed one tiny fix to a

Re: [libvirt] PATCH: 10/14: Convert XenD XML parser to generic API

2008-07-08 Thread Stefan de Konink
Daniel P. Berrange schreef: This replaces the code which converts from the XML into SEXPR with code which converts from the virDomainDefPtr object to a SEXPR. We then simply use virDomainDefParseString() to generate the initial virDomainDefPtr. This makes the SEXPR generating code much easier to

Re: [libvirt] PATCH: 10/14: Convert XenD XML parser to generic API

2008-07-08 Thread Daniel P. Berrange
On Tue, Jul 08, 2008 at 06:48:45PM +0200, Stefan de Konink wrote: Daniel P. Berrange schreef: This replaces the code which converts from the XML into SEXPR with code which converts from the virDomainDefPtr object to a SEXPR. We then simply use virDomainDefParseString() to generate the initial

Re: [libvirt] PATCH: 10/14: Convert XenD XML parser to generic API

2008-07-08 Thread Stefan de Konink
Daniel P. Berrange schreef: On Tue, Jul 08, 2008 at 06:48:45PM +0200, Stefan de Konink wrote: Daniel P. Berrange schreef: This replaces the code which converts from the XML into SEXPR with code which converts from the virDomainDefPtr object to a SEXPR. We then simply use

[libvirt] libvirt and linux vserver

2008-07-08 Thread ADNET Ghislain
Hi, i am new here , i looked on the web but cannot find anything about linux vserver support in libvirt. I found that one of the main dev of linux vserver submitted patches for the support but nothing seems to have been integrated from his work into libvirt. Do you have reviewed them ? Is

Re: [libvirt] [PATCH] SetAutostart and GetAutostart in openvz driver

2008-07-08 Thread Daniel P. Berrange
On Tue, Jul 08, 2008 at 05:51:05PM +0400, Evgeniy Sokolov wrote: +int +openvzReadConfigParam(int vpsid ,const char * param, char *value, int maxlen) +{ +char conf_file[PATH_MAX] ; +char line[PATH_MAX] ; +int ret, found = 0; +char * conf_dir; +int fd ; +char * sf, *

Re: [libvirt] [PATCH] fix diagnostic when execute openvz commands

2008-07-08 Thread Daniel P. Berrange
On Tue, Jul 08, 2008 at 07:46:52PM +0400, Evgeniy Sokolov wrote: Index: openvz_driver.c === RCS file: /data/cvs/libvirt/src/openvz_driver.c,v retrieving revision 1.23 diff -u -p -r1.23 openvz_driver.c --- openvz_driver.c 7 Jul

Re: [libvirt] libvirt and linux vserver

2008-07-08 Thread Daniel P. Berrange
On Tue, Jul 08, 2008 at 07:09:38PM +0200, ADNET Ghislain wrote: Hi, i am new here , i looked on the web but cannot find anything about linux vserver support in libvirt. I found that one of the main dev of linux vserver submitted patches for the support but nothing seems to have been

Re: [libvirt] [PATCH] give a more useful diagnostic for tap-add failure w/ENOTSUP

2008-07-08 Thread Daniel P. Berrange
On Tue, Jul 08, 2008 at 02:07:32PM +0200, Jim Meyering wrote: I invoked virt-isntall with --network=bridge:eth1 rather than --network=bridge:br1 and got the latter (current) diagnostic below. This change makes it so in this relatively common case people get a slightly more understandable

Re: [libvirt] [PATCH] Missing htonl (etc) on MinGW

2008-07-08 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: With the attached patch you can get all the way through a compile of libvirt using the MinGW cross-compiler. ... Index: configure.in === ... -AC_CHECK_FUNCS([cfmakeraw regexec uname

Re: [Libvirt] [PATCH] 1+2=3 errors in docs

2008-07-08 Thread Daniel P. Berrange
On Tue, Jul 08, 2008 at 04:31:28PM +0400, Anton Protopopov wrote: This patch fixes three examples given in docs/drvqemu.html.in and docs/ formatnetwork.html.in Thanks for the fix -I've committed them and they'll be live on the website within the hour Daniel -- |: Red Hat, Engineering, London

Re: [libvirt] incorrect VIR_DOMAIN_NONE usage

2008-07-08 Thread Daniel P. Berrange
On Tue, Jul 01, 2008 at 10:04:58PM +0200, T?th Istv?n wrote: As I was trying to understand exact semantics of the libvirt flags api, I found an error in the xs_internal.c file. When it wants to indicate that it cannot report the state of the domain, it user VIR_DOMAIN_NONE as a return value,

Re: [libvirt] [PATCH] Missing htonl (etc) on MinGW

2008-07-08 Thread Richard W.M. Jones
On Tue, Jul 08, 2008 at 07:43:07PM +0200, Jim Meyering wrote: +#ifndef _PORTABLEXDR_BYTESWAP_H +#define _PORTABLEXDR_BYTESWAP_H 1 A different name file name might be nice, so this file is not confused (by people) with the system-provided byteswap.h. Maybe byteswap-pxdr.h or something