Re: [libvirt] Question SSH support and libirt on Windows

2008-08-08 Thread Daniel P. Berrange
On Fri, Aug 08, 2008 at 02:28:44PM +0900, Atsushi SAKAI wrote: Hi, Rich I have a question about SSH support of libvirt on Windows. Is there any reason for not supporting SSH. The initial problem is that to use SSH we fork/exec not gonna work on Windows which has no concept of

Re: [libvirt] Question SSH support and libirt on Windows

2008-08-08 Thread Daniel Veillard
On Fri, Aug 08, 2008 at 10:09:22AM +0100, Daniel P. Berrange wrote: On Fri, Aug 08, 2008 at 02:28:44PM +0900, Atsushi SAKAI wrote: Hi, Rich I have a question about SSH support of libvirt on Windows. Is there any reason for not supporting SSH. The initial problem is that to use SSH

[libvirt] /var/run/libvirt

2008-08-08 Thread Stefan de Konink
It is a trivial error, but i wonder if: Failed to change group ownership of /var/run/libvirt Failed to bind socket to '/var/run/libvirt/libvirt-sock': No such file or directory This could be corrected to: /var/run/libvirt doesn't exist or an mkdir is done on the directory... Stefan --

Re: [libvirt] /var/run/libvirt

2008-08-08 Thread Daniel Veillard
On Fri, Aug 08, 2008 at 11:49:46AM +0200, Stefan de Konink wrote: It is a trivial error, but i wonder if: Failed to change group ownership of /var/run/libvirt Failed to bind socket to '/var/run/libvirt/libvirt-sock': No such file or directory This could be corrected to:

Re: [libvirt] /var/run/libvirt

2008-08-08 Thread Stefan de Konink
On Fri, 8 Aug 2008, Daniel Veillard wrote: On Fri, Aug 08, 2008 at 11:49:46AM +0200, Stefan de Konink wrote: It is a trivial error, but i wonder if: Failed to change group ownership of /var/run/libvirt Failed to bind socket to '/var/run/libvirt/libvirt-sock': No such file or directory

[libvirt] [PATCH]: ruby-libvirt migration fixes

2008-08-08 Thread Chris Lalancette
Attached is a relatively simple patch to the ruby-libvirt bindings with some bugfixes for the migrate call. The first problem was that there was no way to pass a nil through to the underlying virDomainMigrate() call. This is important because generally the dname and uri parameters end up being

Re: [libvirt] /var/run/libvirt

2008-08-08 Thread Daniel P. Berrange
On Fri, Aug 08, 2008 at 12:08:05PM +0200, Stefan de Konink wrote: On Fri, 8 Aug 2008, Daniel Veillard wrote: install -d -m 0755 $RPM_BUILD_ROOT%{_localstatedir}/run/libvirt/ in libvirt spec file and mkdir -p $(DESTDIR)$(localstatedir)/run/libvirt in qemud/Makefile.am as part of

Re: [libvirt] /var/run/libvirt

2008-08-08 Thread Stefan de Konink
On Fri, 8 Aug 2008, Daniel P. Berrange wrote: On Fri, Aug 08, 2008 at 12:08:05PM +0200, Stefan de Konink wrote: On Fri, 8 Aug 2008, Daniel Veillard wrote: install -d -m 0755 $RPM_BUILD_ROOT%{_localstatedir}/run/libvirt/ in libvirt spec file and mkdir -p

[libvirt] Re: [PATCH]: hostdev passthrough support take #3

2008-08-08 Thread Daniel P. Berrange
On Thu, Aug 07, 2008 at 06:25:56PM +0200, Guido G?nther wrote: Hi, attached is version three of the hostdev passthrough patch. It adds: * code to format the XML for output * RelaxNG schema update * testcases ACK, this looks ready to commit now - great work getting this done. Daniel -- |:

[libvirt] Re: [PATCH]: file backed usb massstorage #3

2008-08-08 Thread Daniel P. Berrange
On Thu, Aug 07, 2008 at 07:16:30PM +0200, Guido G?nther wrote: Hi, attached is version three of the file backed usb massstorage patch. * handle type != DISK case * on OOM use VIR_ERR_NO_MEMORY instead of VIR_ERR_OPERAION_FAILED * RelaxNG schema update * testcase The patches are ment to

[libvirt] PATCH: Fix const-ness for virRun/virExec

2008-08-08 Thread Daniel P. Berrange
The exec() family of UNIX functions have broken const-ness in the argv[] parameter. For inexplicable reasons, I followed this brokeness when originally doing the virRun/virExec functions. So every caller is either using wrong const-ness, or having to cast when calling them. This patch fixes the

Re: [libvirt] /var/run/libvirt

2008-08-08 Thread John Levon
On Fri, Aug 08, 2008 at 06:05:12AM -0400, Daniel Veillard wrote: install -d -m 0755 $RPM_BUILD_ROOT%{_localstatedir}/run/libvirt/ in libvirt spec file and mkdir -p $(DESTDIR)$(localstatedir)/run/libvirt /var/run is tmpfs on at least Solaris. regards john -- Libvir-list mailing list

Re: [libvirt] PATCH: Fix const-ness for virRun/virExec

2008-08-08 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: The exec() family of UNIX functions have broken const-ness in the argv[] parameter. For inexplicable reasons, I followed this brokeness when originally doing the virRun/virExec functions. So every caller is either using wrong const-ness, or having to

Re: [libvirt] [PATCH]: file backed usb massstorage  #3

2008-08-08 Thread Jim Meyering
Guido Günther [EMAIL PROTECTED] wrote: attached is version three of the file backed usb massstorage patch. * handle type != DISK case * on OOM use VIR_ERR_NO_MEMORY instead of VIR_ERR_OPERAION_FAILED * RelaxNG schema update * testcase ... ACK, once you fix the following: From

Re: [libvirt] [PATCH]: hostdev passthrough support take #3

2008-08-08 Thread Jim Meyering
Guido Günther [EMAIL PROTECTED] wrote: attached is version three of the hostdev passthrough patch. It adds: * code to format the XML for output * RelaxNG schema update * testcases ACK, modulo the details below. From cfcfc85accdcc7be7a5fbfd2c8dde435646d5ab2 Mon Sep 17 00:00:00 2001 From:

Re: [libvirt] [PATCH]: file back ed usb massstorage #3

2008-08-08 Thread Daniel P. Berrange
On Fri, Aug 08, 2008 at 02:07:49PM +0200, Jim Meyering wrote: Guido Günther [EMAIL PROTECTED] wrote: From a714b14a13f97b824c288fc40165ef9fe5fbaae0 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] Date: Thu, 7 Aug 2008 14:39:35 +0200 Subject: [PATCH] usbmass: testcase for

Re: [et-mgmt-tools] Re: [libvirt] RE: [Qemu-devel] [ANNOUNCE] virt-mem tools version 0.2.8 released

2008-08-08 Thread Javier Guerra
On Thu, Aug 7, 2008 at 8:06 AM, Richard W.M. Jones [EMAIL PROTECTED] wrote: I think the message here is, install libvirt be happy :-) nice as this tool sounds, i would need far more than this to make me switch from a simple, easily scriptable command-line to a generic, 'lowest common', solution

Re: [libvirt] [PATCH]: file backed usb massstorage  #3

2008-08-08 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Fri, Aug 08, 2008 at 02:07:49PM +0200, Jim Meyering wrote: Guido Günther [EMAIL PROTECTED] wrote: From a714b14a13f97b824c288fc40165ef9fe5fbaae0 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] ... Please add a newline and split

[libvirt] Release of libvirt-java-0.2.1

2008-08-08 Thread Daniel Veillard
Following the refactoring patch by Tóth István, it was a good idea to make a release awoiding all the know leaks and providing the storage API. Sor libvirt-java-0.2.1 is available at the usual place: ftp://libvirt.org/libvirt/java/ thanks Tóth ! Daniel -- Red Hat Virtualization group

Re: [libvirt] [PATCH]: file backed usb massstorage #3

2008-08-08 Thread Chris Lalancette
Jim Meyering wrote: On Fri, Aug 08, 2008 at 02:07:49PM +0200, Jim Meyering wrote: Guido Günther [EMAIL PROTECTED] wrote: From a714b14a13f97b824c288fc40165ef9fe5fbaae0 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] ... Please add a newline and split the long line:

Re: [libvirt] [PATCH]: ruby-libvirt migration fixes

2008-08-08 Thread Jim Meyering
Chris Lalancette [EMAIL PROTECTED] wrote: Attached is a relatively simple patch to the ruby-libvirt bindings with some bugfixes for the migrate call. The first problem was that there was no way to pass a nil through to the underlying virDomainMigrate() call. This is important because

Re: [libvirt] [PATCH]: file backed usb massstorage #3

2008-08-08 Thread Jim Meyering
Chris Lalancette [EMAIL PROTECTED] wrote: Jim Meyering wrote: On Fri, Aug 08, 2008 at 02:07:49PM +0200, Jim Meyering wrote: Guido Günther [EMAIL PROTECTED] wrote: From a714b14a13f97b824c288fc40165ef9fe5fbaae0 Mon Sep 17 00:00:00 2001 From: Guido Guenther [EMAIL PROTECTED] ... Please add a

[libvirt] [PATCH]: file backed usb massstorage #4

2008-08-08 Thread Guido Günther
On Fri, Aug 08, 2008 at 02:07:49PM +0200, Jim Meyering wrote: Guido Günther [EMAIL PROTECTED] wrote: [..snip..] +static int qemudDomainAttachUsbMassstorageDevice(virDomainPtr dom, virDomainDeviceDefPtr dev) +{ +struct qemud_driver *driver = (struct qemud_driver

[libvirt] [PATCH]: hostdev passthrough support take #4

2008-08-08 Thread Guido Günther
On Fri, Aug 08, 2008 at 02:30:15PM +0200, Jim Meyering wrote: Guido Günther [EMAIL PROTECTED] wrote: [..snip..] +static int qemudDomainAttachCdromDevice(virDomainPtr dom, +virDomainDeviceDefPtr dev) +{ +struct qemud_driver *driver = (struct

[libvirt] Re: [PATCH]: hostdev passthrough support take #4

2008-08-08 Thread Jim Meyering
Guido Günther [EMAIL PROTECTED] wrote: The same applies here: qemudDomainAttachDevice checked that already, but again - better safe than sorry. Updated patches attached. ACK. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] Re: [PATCH]: file backed usb massstorage #4

2008-08-08 Thread Jim Meyering
Guido Günther [EMAIL PROTECTED] wrote: New patches attached. Patches apply on top of the hostdev patches. ACK. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH]: ruby-libvirt migration fixes

2008-08-08 Thread Chris Lalancette
Jim Meyering wrote: diff -r c6a3e36cdf54 ext/libvirt/_libvirt.c --- a/ext/libvirt/_libvirt.c Thu Jul 17 15:24:26 2008 -0700 +++ b/ext/libvirt/_libvirt.c Fri Aug 08 06:04:56 2008 -0400 @@ -637,16 +637,51 @@ VALUE libvirt_conn_num_of_defined_storag } #endif +static char

Re: [libvirt] [PATCH]: hostdev passthrough support take #4

2008-08-08 Thread Daniel Veillard
On Fri, Aug 08, 2008 at 04:05:10PM +0200, Guido Günther wrote: Likewise. The same applies here: qemudDomainAttachDevice checked that already, but again - better safe than sorry. Updated patches attached. Okidoc, all look good ! Applied and commited to CVS, thanks a lot for the work, I

[libvirt] [PATCH] append a newline to expected-output files lacking NL-at-EOF

2008-08-08 Thread Jim Meyering
Jim Meyering [EMAIL PROTECTED] wrote: Maybe you're talking about something else? I proposed to add a trailing newline in the expected output as well as in the code to generate the actual output. This is the sort of change I was thinking of: diff --git a/tests/qemuxml2argvtest.c

Re: [libvirt] [PATCH]: ruby-libvirt migration fixes

2008-08-08 Thread Jim Meyering
Chris Lalancette [EMAIL PROTECTED] wrote: Jim Meyering wrote: diff -r c6a3e36cdf54 ext/libvirt/_libvirt.c --- a/ext/libvirt/_libvirt.cThu Jul 17 15:24:26 2008 -0700 +++ b/ext/libvirt/_libvirt.cFri Aug 08 06:04:56 2008 -0400 @@ -637,16 +637,51 @@ VALUE

Re: [libvirt] [PATCH]: file backed usb massstorage #4

2008-08-08 Thread Daniel Veillard
On Fri, Aug 08, 2008 at 04:04:17PM +0200, Guido Günther wrote: New patches attached. Patches apply on top of the hostdev patches. All commited, I just removed an extra space at end of line :-) thanks a lot ! Again a small patch to the doc describing it would fix the last weak spot,

Re: [libvirt] [PATCH]: hostdev passthrough support take #4

2008-08-08 Thread Guido Günther
Hi, On Fri, Aug 08, 2008 at 10:34:00AM -0400, Daniel Veillard wrote: [..snip..] I think the only thing missing is extending the descrition in the documentation would you mind adding a description in formatdomain.html(.in) Probably an USB devices section added below the elementsDisks part,

[libvirt] [PATCH] make sure we call the freshly build libvirtd

2008-08-08 Thread Guido Guenther
...not the one in $PATH. I was wondering why this test kept failing... -- Guido --- tests/daemon-conf |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/daemon-conf b/tests/daemon-conf index db1f0d3..4a42d1e 100755 --- a/tests/daemon-conf +++ b/tests/daemon-conf

Re: [libvirt] [PATCH] make sure we call the freshly build libvirtd

2008-08-08 Thread Jim Meyering
Guido Guenther [EMAIL PROTECTED] wrote: ...not the one in $PATH. I was wondering why this test kept failing... You shouldn't need that change, since make check already sets PATH so that $abs_top_builddir/qemud is early in PATH. And it does it in such a way that it should work even if the

Re: [libvirt] [PATCH] make sure we call the freshly build libvirtd

2008-08-08 Thread Guido Günther
On Fri, Aug 08, 2008 at 06:30:56PM +0200, Jim Meyering wrote: Guido Guenther [EMAIL PROTECTED] wrote: ...not the one in $PATH. I was wondering why this test kept failing... You shouldn't need that change, since make check already sets PATH so that $abs_top_builddir/qemud is early in PATH.

Re: [libvirt] [PATCH] make sure we call the freshly build libvirtd

2008-08-08 Thread Jim Meyering
Guido Günther [EMAIL PROTECTED] wrote: On Fri, Aug 08, 2008 at 06:30:56PM +0200, Jim Meyering wrote: Guido Guenther [EMAIL PROTECTED] wrote: ...not the one in $PATH. I was wondering why this test kept failing... You shouldn't need that change, since make check already sets PATH so that

[libvirt] [PATCH] introducing source name (for logical storage pools)

2008-08-08 Thread David Lively
Hi Folks - This small patch is a proposed prerequisite for the storage pool discovery patch I submitted last week. Daniel B proposed having storage pool discovery return a bunch of XML storage source elements, rather than full pool elements (which contain target-dependent details like the

Re: [libvirt] static ip address

2008-08-08 Thread Olivier Deckmyn
On Sun, Aug 3, 2008 at 7:04 PM, Mads Chr. Olesen [EMAIL PROTECTED] wrote: lør, 02 08 2008 kl. 23:13 +0200, skrev Olivier Deckmyn: I would like to be able to choose on a way or another the ip of each of my VM. As far as I can understand, the only way to get an IP (from a vm point of view)