Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-11 Thread Atsushi SAKAI
Hi, Jim and Dan How about this? src/domain_conf.c|1 + src/domain_conf.h|6 +++--- src/network_conf.c |1 + src/qemu_driver.c| 32 src/util.c |4 ++-- src/virsh.c |3 +++ tests/testutilsxen.c |2 ++ 7 fil

[libvirt] [PATCH] Fix python error reporting for some storage operations

2008-08-11 Thread Cole Robinson
In the python bindings, all vir* classes expect to be passed a virConnect object when instantiated. Before the storage stuff, these classes were only instantiated in virConnect methods, so the generator is hardcoded to pass 'self' as the connection instance to these classes. Problem is there are s

[libvirt] [PATCH] Implement vol delete for disk pools

2008-08-11 Thread Cole Robinson
The patch below implements virStorageVolDelete for volumes on a disk pool. The only interesting thing here is that parted wants a partition number to delete, so we need to peel off the end of the volume's target path which will be of the form '/dev/sda1' or similar (I assume. If not, it's still be

Re: [libvirt] PATCH: 2/7: Re-arrange methods acros LXC source files

2008-08-11 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > The lxc_driver.c file contains quite a large amount of code, > serving two reasonably well separated purposes. First there > is the direct implemntation of each of the libvirt driver > APIs. Second there is the code to spawn a container and a > cont

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-11 Thread Cole Robinson
Jim Meyering wrote: > Cole Robinson <[EMAIL PROTECTED]> wrote: >> parted doesn't seem to want the label 'dos', instead >> wanting 'msdos'. Patch is basically s/dos/msdos/ > > Hi Cole, > > This definitely needs to be fixed. > > FYI, "dos" appears to be the preferred name for that partition table

Re: [libvirt] [PATCH] Ensure parted doesn't prompt if labeling disk

2008-08-11 Thread Cole Robinson
Daniel P. Berrange wrote: > On Sun, Aug 10, 2008 at 10:40:30PM -0400, Cole Robinson wrote: >> Trying to 'build' a disk pool uses 'parted mklabel' which can >> prompt for confirmation. Patch adds the '--script' option to >> remove the chance of this happening. > > Can you double-check this works on

Re: [libvirt] [PATCH] append a newline to expected-output files lacking NL-at-EOF

2008-08-11 Thread Jim Meyering
Jim Meyering <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> wrote: >> Maybe you're talking about something else? >> I proposed to add a trailing newline in the expected output >> as well as in the code to generate the "actual" output. >> >> This is the sort of change I was thinking o

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-11 Thread Jim Meyering
Atsushi SAKAI <[EMAIL PROTECTED]> wrote: > Hi, Dan > > Thank you for commenting it. > Without WITH_QEMU, following errors are appeared. > === > In file included from test.c:44: > domain_conf.h:447: error: syntax error before '&' token > domain_conf.h:447: warning: no semicolon at end of struct or

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-11 Thread Atsushi SAKAI
Hi, Dan Thank you for commenting it. Without WITH_QEMU, following errors are appeared. === In file included from test.c:44: domain_conf.h:447: error: syntax error before '&' token domain_conf.h:447: warning: no semicolon at end of struct or union domain_conf.h:448: error: syntax error before '&'

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-11 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 07:57:46PM +0900, Atsushi SAKAI wrote: > Hi, Jim and Dan > > Thank you for commenting. > > I compiled with attached patch successfully. This is bit not good: > diff -u -r1.6 domain_conf.h > --- src/domain_conf.h 8 Aug 2008 15:03:00 - 1.6 > +++ src/domain_conf

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-11 Thread Atsushi SAKAI
Hi, Jim and Dan Thank you for commenting. I compiled with attached patch successfully. src/domain_conf.c|1 + src/domain_conf.h|2 ++ src/network_conf.c |1 + src/util.c |4 ++-- src/virsh.c |3 +++ tests/testutilsxen.c |2 ++ 6 files changed

Re: [libvirt] PATCH: 1/7: Removing state from lxc_vm_t

2008-08-11 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > This patch does some simple re-factoring of the way the TTYs and > control socket are handled to reduce the amount of state stored > in the lxc_vm_t structure, in preparation for the switchover to > the generic domain handling APIs. One more thing:

Re: [libvirt] PATCH: 1/7: Removing state from lxc_vm_t

2008-08-11 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > This patch does some simple re-factoring of the way the TTYs and > control socket are handled to reduce the amount of state stored > in the lxc_vm_t structure, in preparation for the switchover to > the generic domain handling APIs. ... > diff -r 63

Re: [libvirt] [PATCH] Change disk type 'dos' to 'msdos'

2008-08-11 Thread Jim Meyering
Cole Robinson <[EMAIL PROTECTED]> wrote: > parted doesn't seem to want the label 'dos', instead > wanting 'msdos'. Patch is basically s/dos/msdos/ Hi Cole, This definitely needs to be fixed. FYI, "dos" appears to be the preferred name for that partition table type (google for "partition table" a

[libvirt] Re: [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-11 Thread James Morris
On Sun, 10 Aug 2008, Casey Schaufler wrote: > > 1.1 Rationale > > > > With increased use of virtualization, one security benefit of > > physically separated systems -- strong isolation -- is reduced, > > This issue can always be readily resolved by going back to physically > separated h

Re: [libvirt] [PATCH] Ensure parted doesn't prompt if labeling disk

2008-08-11 Thread Daniel P. Berrange
On Sun, Aug 10, 2008 at 10:40:30PM -0400, Cole Robinson wrote: > Trying to 'build' a disk pool uses 'parted mklabel' which can > prompt for confirmation. Patch adds the '--script' option to > remove the chance of this happening. Can you double-check this works on RHEL-5 - IIRC, the --script arg is

Re: [libvirt] [PATCH] Ensure parted doesn't prompt if labeling disk

2008-08-11 Thread Jim Meyering
Cole Robinson <[EMAIL PROTECTED]> wrote: > Trying to 'build' a disk pool uses 'parted mklabel' which can > prompt for confirmation. Patch adds the '--script' option to > remove the chance of this happening. > > diff --git a/src/storage_backend_disk.c b/src/storage_backend_disk.c > index d6548eb..39

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-11 Thread Daniel P. Berrange
On Mon, Aug 11, 2008 at 10:41:43AM +0200, Jim Meyering wrote: > Atsushi SAKAI <[EMAIL PROTECTED]> wrote: > > I am looking around the code about WEXITSTATUS. > > It seems that following kind of code needs on gnulib. > > http://kerneltrap.org/mailarchive/git/2008/2/27/1003054 > > What do you think? >

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-11 Thread Jim Meyering
Atsushi SAKAI <[EMAIL PROTECTED]> wrote: > I am looking around the code about WEXITSTATUS. > It seems that following kind of code needs on gnulib. > http://kerneltrap.org/mailarchive/git/2008/2/27/1003054 > What do you think? Hi Atsushi, Yes, git provides MinGW support, and I see it's compat/ming

Re: [libvirt] [PATCH] make sure we call the freshly build libvirtd

2008-08-11 Thread Daniel P. Berrange
On Fri, Aug 08, 2008 at 06:30:56PM +0200, Jim Meyering wrote: > Guido Guenther <[EMAIL PROTECTED]> wrote: > > ...not the one in $PATH. I was wondering why this test kept failing... > > You shouldn't need that change, since "make check" already sets PATH > so that $abs_top_builddir/qemud is early i

Re: [libvirt] /var/run/libvirt

2008-08-11 Thread Daniel P. Berrange
On Sat, Aug 09, 2008 at 09:56:45AM +0100, Richard W.M. Jones wrote: > On Fri, Aug 08, 2008 at 12:08:05PM +0200, Stefan de Konink wrote: > > My /var/run is empty upon boot. (ramfs) One may wonder why libvirt needs a > > dedicated directory at all for two sockets... > > This seems to be a valid poin

[libvirt] Re: [ANNOUNCE][RFC] sVirt: Integrating SELinux and Linux-based virtualization

2008-08-11 Thread Casey Schaufler
James Morris wrote: This is to announce the formation of the sVirt project, which aims to integrate SELinux and Linux-based virtualization (KVM et al). The idea has been discussed a few times over the last year or so, and in recent weeks, a few Fedora folk (such as Dan Walsh, Daniel Berrange a

Re: [et-mgmt-tools] Re: [libvirt] RE: [Qemu-devel] [ANNOUNCE] virt-mem tools version 0.2.8 released

2008-08-11 Thread Jamie Lokier
Javier Guerra wrote: > On Thu, Aug 7, 2008 at 8:06 AM, Richard W.M. Jones <[EMAIL PROTECTED]> wrote: > > I think the message here is, install libvirt & be happy :-) > > nice as this tool sounds, i would need far more than this to make me > switch from a simple, easily scriptable command-line to a

Re: [libvirt] [PATCH] fix MinGW compilation(200808)

2008-08-11 Thread Atsushi SAKAI
Hi, Jim I am looking around the code about WEXITSTATUS. It seems that following kind of code needs on gnulib. http://kerneltrap.org/mailarchive/git/2008/2/27/1003054 What do you think? Thanks Atsushi SAKAI Atsushi SAKAI <[EMAIL PROTECTED]> wrote: > Hi, Dan > > mkstemp is solved by Jim. > >