Re: [libvirt] [PATCH] kvm: maxVCPU runtime detection

2008-08-29 Thread Guido Günther
Hi, On Fri, Aug 22, 2008 at 02:27:58PM +0100, Daniel P. Berrange wrote: > On Fri, Aug 22, 2008 at 03:16:42PM +0200, Guido G?nther wrote: > > Hi, > > with recent linux kernels we can detect the maximum number of virtual > > cpus at runtime via an ioctl. Possible patch attached. It does this on > > e

Re: [libvirt] [PATCH] introducing (for logical storage pools)

2008-08-29 Thread David Lively
Hi Jim - I've attached a (very) small incremental patch (i.e., to be applied after the one you've already merged) that addresses a couple things I noticed missing: (a) documents the new element in formatstorage.html.in (b) adds --source-name to the (optional) args for virsh pool-define-as

Re: [libvirt] A laundry list of "TODO" items for libvirt

2008-08-29 Thread David Lively
On Thu, 2008-08-28 at 22:08 +0100, Daniel P. Berrange wrote: > On Thu, Aug 28, 2008 at 05:02:29PM -0400, David Lively wrote: > > Does "host power support" belong on the TODO? > > (i.e. ??virConnect{Poweroff,Suspend,Hibernate,Reboot}) > > > > ???If libvirt is going to be the only external inte

[libvirt] [PATCH] [LXC] Add version implementation

2008-08-29 Thread Dan Smith
This patch adds an implementation of the version function to the LXC driver. The providers use the hypervisor version in a field of one of the instances, so we need to have something meaningful here. AFAICT, the only real option we have (considering the limitations of the libvirt version informati

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-08-29 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > Here's an updated patch ... > diff -r e270be59a80f src/openvz_conf.c ... > +if (VIR_ALLOC(dom) < 0 || > +VIR_ALLOC(dom->def) < 0) > +goto no_memory; > + > +if (STRNEQ(status, "stopped")) > +dom->st

Re: [libvirt] Live migration sanity checks

2008-08-29 Thread Richard W.M. Jones
On Fri, Aug 29, 2008 at 10:44:50AM +0200, Chris Lalancette wrote: > Things that I've missed? Maybe a good place for this list is on the wiki? On the actual feature/todo page. I'd like to see where KVM is going to go with this, since it seems they are going to implement migration checking. Rich.

[libvirt] Re: XML representation of security labels

2008-08-29 Thread Casey Schaufler
James Morris wrote: On Fri, 29 Aug 2008, Daniel Veillard wrote: 2. The XML format for security labels needs to be extended to indicate which security model is in use, and potentially carry model-specific metadata. For SELinux, we may want to know what type of policy is active, and later,

Re: [libvirt] [PATCH] Fix ejecting cdroms with latest qemu syntax

2008-08-29 Thread Jim Meyering
Cole Robinson <[EMAIL PROTECTED]> wrote: ... > Okay, latest cut. This addresses the above piece pointed out > by Jim and all of Dan's comments. Looks fine. Thanks, Cole. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] virConnectListAllDomains (version 2)

2008-08-29 Thread Richard W.M. Jones
Here's a second version of the patch which allows 'infos' to be NULL, but doesn't yet include a Xen driver. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my OCaml programming blog: http://camltastic.blogspot.com/ Fedora now supports 64 OCaml packages

Re: [libvirt] [PATCH] virConnectListAllDomains

2008-08-29 Thread Richard W.M. Jones
On Fri, Aug 29, 2008 at 03:39:44PM +0200, Daniel Veillard wrote: > > +/* For virConnectListAllDomains. */ > > +#define VIR_DOMAIN_LIST_NOSTATE (1 << VIR_DOMAIN_NOSTATE) > > +#define VIR_DOMAIN_LIST_RUNNING (1 << VIR_DOMAIN_RUNNING) > > +#define VIR_DOMAIN_LIST_BLOCKED (1 << VIR_DOMAIN_BLOCKED) > >

Re: [libvirt] [PATCH] Fix ejecting cdroms with latest qemu syntax

2008-08-29 Thread Daniel P. Berrange
On Fri, Aug 29, 2008 at 10:27:04AM -0400, Cole Robinson wrote: > Jim Meyering wrote: > > Cole Robinson <[EMAIL PROTECTED]> wrote: > > ... > >> Okay, second cut attached. I followed your recommendations: > > ... > > > > With all of Dan's comments addressed, this should be fine. > > > >> diff --git

Re: [libvirt] [PATCH] Fix ejecting cdroms with latest qemu syntax

2008-08-29 Thread Cole Robinson
Jim Meyering wrote: > Cole Robinson <[EMAIL PROTECTED]> wrote: > ... >> Okay, second cut attached. I followed your recommendations: > ... > > With all of Dan's comments addressed, this should be fine. > >> diff --git a/src/domain_conf.c b/src/domain_conf.c > ... >> +int virDiskNameToBusDeviceInde

Re: [libvirt] [PATCH] fix a error message and coding-style cleanup

2008-08-29 Thread Daniel Veillard
On Fri, Aug 29, 2008 at 01:51:34PM +0100, Richard W.M. Jones wrote: > Here's just the fix to virDomainMemoryPeek. > > +1 from me. sure +1, please push, and thanks to Nguyen :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ [EMAIL PROTECTED] | Rpmfind RP

Re: [libvirt] LXC: making the private root filesystem more secure

2008-08-29 Thread Dan Smith
DB> mkdir /dev/cgroups/libvirt/lxc/{NAME} I have a small (and not-yet-working) patch that uses libcgroup[1] to setup a cgroup per container. This provides the ability to enforce the quantity on the group through memory.limit_in_bytes. I've also got some stubs that I plan to use to provide a

Re: [libvirt] [PATCH] virConnectListAllDomains

2008-08-29 Thread Daniel Veillard
On Fri, Aug 29, 2008 at 01:38:57PM +0100, Richard W.M. Jones wrote: > As observed in this thread: > > https://www.redhat.com/archives/libvir-list/2008-July/msg00215.html > > several tools need to grab the complete list of domains frequently > (eg. virt-manager and virt-top) and the way they do

Re: [libvirt] [PATCH] virConnectListAllDomains

2008-08-29 Thread Daniel P. Berrange
On Fri, Aug 29, 2008 at 02:30:55PM +0100, Richard W.M. Jones wrote: > On Fri, Aug 29, 2008 at 02:26:47PM +0100, Daniel P. Berrange wrote: > > The compatability code requires that you get all virDomainInfo objects > > to filter by state, but a native implementation in the various drivers > > will no

Re: [libvirt] [PATCH] virConnectListAllDomains

2008-08-29 Thread Richard W.M. Jones
On Fri, Aug 29, 2008 at 02:26:47PM +0100, Daniel P. Berrange wrote: > The compatability code requires that you get all virDomainInfo objects > to filter by state, but a native implementation in the various drivers > will not neccessarily require this to be done. I agree we should > have the 'infos

Re: [libvirt] [PATCH] virConnectListAllDomains

2008-08-29 Thread Daniel P. Berrange
On Fri, Aug 29, 2008 at 01:38:57PM +0100, Richard W.M. Jones wrote: > As observed in this thread: > > https://www.redhat.com/archives/libvir-list/2008-July/msg00215.html > > several tools need to grab the complete list of domains frequently > (eg. virt-manager and virt-top) and the way they do

Re: [libvirt] Re: XML representation of security labels

2008-08-29 Thread Daniel J Walsh
Richard W.M. Jones wrote: > On Fri, Aug 29, 2008 at 06:00:36AM +0100, Daniel P. Berrange wrote: >> Indeed - I'm not aware of any apps using it yet. It is currently only >> of marginal benefit, since you can't actually set the label, only see >> the existing (potentially wrong) label. > > It always

[libvirt] [PATCH] util.c: add a file-descriptor-based wrapper for fread_file_lim

2008-08-29 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > On Thu, Aug 28, 2008 at 04:18:08PM +0200, Jim Meyering wrote: >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> > On Wed, Aug 20, 2008 at 06:40:37PM +0200, Jim Meyering wrote: >> >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: >> > + >> > + >

Re: [libvirt] [PATCH] fix a error message and coding-style cleanup

2008-08-29 Thread Richard W.M. Jones
Here's just the fix to virDomainMemoryPeek. +1 from me. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redha

Re: [libvirt] Re: XML representation of security labels

2008-08-29 Thread Daniel P. Berrange
On Fri, Aug 29, 2008 at 01:41:09PM +0100, Richard W.M. Jones wrote: > On Fri, Aug 29, 2008 at 06:00:36AM +0100, Daniel P. Berrange wrote: > > Indeed - I'm not aware of any apps using it yet. It is currently only > > of marginal benefit, since you can't actually set the label, only see > > the exist

Re: [libvirt] Re: XML representation of security labels

2008-08-29 Thread Richard W.M. Jones
On Fri, Aug 29, 2008 at 05:13:23PM +1000, James Morris wrote: > In the simplest case, we'll just be wanting to ensure that domains are > running with distinct labels for separation purposes, so that concept may > be possible to convey during migration. > > As for specific labels (e.g. "privilege

Re: [libvirt] Re: XML representation of security labels

2008-08-29 Thread Richard W.M. Jones
On Fri, Aug 29, 2008 at 06:00:36AM +0100, Daniel P. Berrange wrote: > Indeed - I'm not aware of any apps using it yet. It is currently only > of marginal benefit, since you can't actually set the label, only see > the existing (potentially wrong) label. It always seemed to me a bit worrying that l

[libvirt] [PATCH] virConnectListAllDomains

2008-08-29 Thread Richard W.M. Jones
As observed in this thread: https://www.redhat.com/archives/libvir-list/2008-July/msg00215.html several tools need to grab the complete list of domains frequently (eg. virt-manager and virt-top) and the way they do it currently is very inefficient, both in terms of the number of round-trips in

Re: [libvirt] PATCH: Switch openvz driver to domain APIs

2008-08-29 Thread Evgeniy Sokolov
On Thu, Aug 28, 2008 at 12:06:08PM +0400, Evgeniy Sokolov wrote: The biggest flaw I see currently is that the openvz driver doesn't load the existing device config for networks or filesystems of existing VMs, so you can't see that info in the XML dump Yes. Good note. I will implement it. -

[libvirt] Live migration sanity checks

2008-08-29 Thread Chris Lalancette
All, One thing that oVirt would like to have (and that might be useful for other users) is a call that would do some basic sanity checking for live migration. This call would go over to the remote libvirtd, do some checks, and return whether we think migration is likely to succeed. Note that

Re: [libvirt] A laundry list of "TODO" items for libvirt

2008-08-29 Thread Daniel P. Berrange
On Fri, Aug 29, 2008 at 10:41:20AM +0900, Atsushi SAKAI wrote: > Hi, Dan > > Which layer supports OVF(Open Virtual Appliance Format) handling? OVF would be something for tools built using libvirt. Likely candidates for some level of OVF support would be virt-image/-convert and virt-manager Danie

[libvirt] Re: XML representation of security labels

2008-08-29 Thread Daniel P. Berrange
On Fri, Aug 29, 2008 at 08:46:35AM +0200, Daniel Veillard wrote: > On Fri, Aug 29, 2008 at 06:00:36AM +0100, Daniel P. Berrange wrote: > > On Fri, Aug 29, 2008 at 01:32:27PM +1000, James Morris wrote: > > > I'd suggest we implement a new label element to avoid breaking > > > compatibility and to a

Re: [libvirt] PATCH: 5/5: Make all code use virExec

2008-08-29 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... >> +/* Like virFileReadLimFP, but use a file descriptor rather than a FILE*. */ >> +int __virFileReadLimFD(int fd_arg, int maxlen, char **buf) >> +{ >> +int fd = dup (fd_arg); >> +if (0 <= fd) { > > Can we stick to 'fd >= 0' or 'fd < 0' o

[libvirt] Re: XML representation of security labels

2008-08-29 Thread James Morris
On Fri, 29 Aug 2008, Daniel Veillard wrote: > > > 2. The XML format for security labels needs to be extended to indicate > > > which security model is in use, and potentially carry model-specific > > > metadata. For SELinux, we may want to know what type of policy is > > > active, > > > and l

Re: [libvirt] PATCH: 5/5: Make all code use virExec

2008-08-29 Thread Daniel P. Berrange
On Thu, Aug 28, 2008 at 04:18:08PM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > On Wed, Aug 20, 2008 at 06:40:37PM +0200, Jim Meyering wrote: > >> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > > + > > + > > +while (got < (sizeof(help)-1)) { > > +i