Re: [libvirt] LXC: making the private root filesystem more secure

2008-09-04 Thread Daniel Veillard
On Fri, Aug 29, 2008 at 06:59:21AM -0700, Dan Smith wrote: DB mkdir /dev/cgroups/libvirt/lxc/{NAME} I have a small (and not-yet-working) patch that uses libcgroup[1] to setup a cgroup per container. This provides the ability to enforce the memory quantity on the group through

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: I've got a MinGW build environment setup on Fedora 10 now, so just checked out what the latest state of libvirt CVS is. ... This new version of the patch fixes two small bugs in the

Re: [libvirt] Libvirtd needs to be always running/

2008-09-04 Thread Stefan de Konink
On Wed, 3 Sep 2008, Yushu Yao wrote: It seems that libvirtd has to run with root, is this true? To make itself useful it should be root yes. But why does libvirtd need to run for QEMU? If it's for start/stop/pause vm, is Qemu's command line tool not enough? I presume it works by keeping

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Richard W.M. Jones
Yes, this patch looks fine, and adding the MinGW build to the automatic build script is great. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my OCaml programming blog: http://camltastic.blogspot.com/ Fedora now supports 67 OCaml packages (the OPEN

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Richard W.M. Jones
On Thu, Sep 04, 2008 at 08:24:14AM +0200, Jim Meyering wrote: Instead of adding the #if/else blocks above, how about adding these in some header file? #ifndef HAVE_GETGID static inline gid_t getgid (void) { return 0; } #endif #ifndef HAVE_GETUID static inline uid_t getuid (void) {

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread atif bajwa
Just wondering, Will it help to solve issues with libvirt windows port or list of items mentioned at http://wiki.libvirt.org/page/TodoWindowsSupport. Regards, Atif On Thu, Sep 4, 2008 at 11:30 AM, Richard W.M. Jones [EMAIL PROTECTED]wrote: Yes, this patch looks fine, and adding the MinGW build

Re: [libvirt] [PATCH] Fix vnc port determining for xend

2008-09-04 Thread Daniel P. Berrange
On Thu, Sep 04, 2008 at 07:51:51AM +0200, Daniel Veillard wrote: On Thu, Aug 28, 2008 at 04:48:06PM -0400, Cole Robinson wrote: Current libvirt checks xenstore for a xen guests fixed vnc port on xend 3.0.3. At least on f8 though, hvm guests don't store the vnc port in xenstore, it is

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Jim Meyering
Richard W.M. Jones [EMAIL PROTECTED] wrote: On Thu, Sep 04, 2008 at 08:24:14AM +0200, Jim Meyering wrote: Instead of adding the #if/else blocks above, how about adding these in some header file? #ifndef HAVE_GETGID static inline gid_t getgid (void) { return 0; } #endif #ifndef HAVE_GETUID

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Richard W.M. Jones
On Thu, Sep 04, 2008 at 11:42:54AM +0200, atif bajwa wrote: Just wondering, Will it help to solve issues with libvirt windows port or list of items mentioned at http://wiki.libvirt.org/page/TodoWindowsSupport. So if you follow the mailing list, you will see that Dan Berrange has just spent a

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Richard W.M. Jones
On Thu, Sep 04, 2008 at 11:56:44AM +0200, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: On Thu, Sep 04, 2008 at 08:24:14AM +0200, Jim Meyering wrote: Instead of adding the #if/else blocks above, how about adding these in some header file? #ifndef HAVE_GETGID static

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Daniel P. Berrange
On Thu, Sep 04, 2008 at 11:09:49AM +0100, Richard W.M. Jones wrote: On Thu, Sep 04, 2008 at 11:56:44AM +0200, Jim Meyering wrote: Richard W.M. Jones [EMAIL PROTECTED] wrote: On Thu, Sep 04, 2008 at 08:24:14AM +0200, Jim Meyering wrote: Instead of adding the #if/else blocks above, how

Re: [libvirt] PATCH: Add a augeas lens for libvirtd.conf

2008-09-04 Thread Daniel P. Berrange
On Wed, Sep 03, 2008 at 10:40:45PM +0200, Daniel Veillard wrote: On Wed, Aug 27, 2008 at 12:04:17PM +0100, Richard W.M. Jones wrote: On Tue, Aug 26, 2008 at 09:05:37PM +0100, Daniel P. Berrange wrote: Augeas is a awesome config file manipulation tool. libvirtd has a config file. libvirtd

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Daniel P. Berrange
On Thu, Sep 04, 2008 at 08:24:14AM +0200, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: I've got a MinGW build environment setup on Fedora 10 now, so just checked out what the latest state of libvirt CVS

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: ... Attached is a version with that change - though I had to make it 'int' for the return type since uid_t/gid_t don't exist on mingw either. Not that it matters, since we store the result in an int anyway ... Thanks for reposting. By the light of

Re: [libvirt] [PATCH] Fix vnc port determining for xend

2008-09-04 Thread Cole Robinson
Daniel P. Berrange wrote: On Thu, Sep 04, 2008 at 07:51:51AM +0200, Daniel Veillard wrote: On Thu, Aug 28, 2008 at 04:48:06PM -0400, Cole Robinson wrote: Current libvirt checks xenstore for a xen guests fixed vnc port on xend 3.0.3. At least on f8 though, hvm guests don't store the

Re: [libvirt] [PATCH]Fix minor issues in logical storage backend

2008-09-04 Thread Daniel Veillard
On Thu, Aug 28, 2008 at 06:15:27PM -0600, Jim Fehlig wrote: Hi All! I came across some problems trying to create a new LVM-based storage pool using this config pool type=logical nametest_vg/name source device path=/dev/sdb1/ /source target path/dev/test_vg/path

Re: [libvirt] [PATCH] fix a error message and coding-style cleanup

2008-09-04 Thread Daniel Veillard
On Fri, Aug 29, 2008 at 04:23:20PM +0200, Daniel Veillard wrote: On Fri, Aug 29, 2008 at 01:51:34PM +0100, Richard W.M. Jones wrote: Here's just the fix to virDomainMemoryPeek. +1 from me. sure +1, please push, and thanks to Nguyen :-) Okay I commited this ! Daniel -- Daniel

Re: [libvirt] [PATCH]Fix minor issues in logical storage backend

2008-09-04 Thread Daniel P. Berrange
On Thu, Sep 04, 2008 at 03:13:45PM +0200, Daniel Veillard wrote: On Thu, Aug 28, 2008 at 06:15:27PM -0600, Jim Fehlig wrote: Hi All! I came across some problems trying to create a new LVM-based storage pool using this config pool type=logical nametest_vg/name source

Re: [libvirt] PATCH: Only pass in emulator if user requested it

2008-09-04 Thread Daniel Veillard
On Mon, Sep 01, 2008 at 03:55:57PM +0100, Daniel P. Berrange wrote: Previouly with Xen we would only specify an emulator path to XenD if there was one provided in the XML. With the new domain XML routines we will always lookup the default emulator path internally using our capabilities data.

Re: [libvirt] [PATCH] Fix capacity reporting for qcow2 images

2008-09-04 Thread Daniel Veillard
On Tue, Sep 02, 2008 at 05:17:56PM -0400, Cole Robinson wrote: Libvirt was reporting some ridiculously large 'capacity' values for some qcow2 images I was creating with relatively small sizes (200 MB). Seems there was a signedness problem when parsing the file header. The attached fix shows

Re: [libvirt] [PATCH] Add more xen vnc tests, patch failures

2008-09-04 Thread Daniel Veillard
On Tue, Sep 02, 2008 at 05:18:00PM -0400, Cole Robinson wrote: Investigating an old bug made me trip over a few problems with vnc parameter handling in the xen driver. The attached patch adds test cases for these bugs and fixes the failures, particularly fixing incomplete handling of a fixed

Re: [libvirt] [PATCH] use poweroff not halt for virsh shutdown

2008-09-04 Thread Daniel Veillard
On Thu, Aug 28, 2008 at 03:05:32PM +0100, John Levon wrote: halt means just that, and we want to poweroff. Linux doesn't care, but Solaris differentiates between the two. Okay, makes sense, applied and commited, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit

Re: [libvirt] [PATCH] Fix vnc port determining for xend

2008-09-04 Thread Cole Robinson
Cole Robinson wrote: Current libvirt checks xenstore for a xen guests fixed vnc port on xend 3.0.3. At least on f8 though, hvm guests don't store the vnc port in xenstore, it is stored in the sexpr. Patch fixes the logic to look in the sexpr if the xenstore lookup appears to fail. This

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Daniel Veillard
On Wed, Sep 03, 2008 at 05:47:30PM +0100, Daniel P. Berrange wrote: On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: I've got a MinGW build environment setup on Fedora 10 now, so just checked out what the latest state of libvirt CVS is. With the attached patch, I can

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Daniel P. Berrange
On Thu, Sep 04, 2008 at 03:58:19PM +0200, Daniel Veillard wrote: On Wed, Sep 03, 2008 at 05:47:30PM +0100, Daniel P. Berrange wrote: On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: I've got a MinGW build environment setup on Fedora 10 now, so just checked out what the

Re: [libvirt] PATCH: Latest MinGW patches

2008-09-04 Thread Daniel Veillard
On Thu, Sep 04, 2008 at 03:50:17PM +0100, Daniel P. Berrange wrote: On Thu, Sep 04, 2008 at 03:58:19PM +0200, Daniel Veillard wrote: On Wed, Sep 03, 2008 at 05:47:30PM +0100, Daniel P. Berrange wrote: On Wed, Sep 03, 2008 at 01:35:27PM +0100, Daniel P. Berrange wrote: I've got a MinGW

Re: [libvirt] remote_protocol.{c,h} ?

2008-09-04 Thread Jun Koi
On Wed, Sep 3, 2008 at 8:41 PM, Richard W.M. Jones [EMAIL PROTECTED] wrote: On Wed, Sep 03, 2008 at 01:00:52PM +0900, Jun Koi wrote: Is it really true that qemud/remote_protocol.{c,h} are created by rpcgen? If so, why dont we have them created at compile time? I still see them in the source