Re: [libvirt] [PATCH] Log virRun command output, return with error

2008-09-24 Thread Chris Lalancette
Cole Robinson wrote: The attached patch adds some extra logging to the virRun command. The full argv is now logged with DEBUG, as well as the commands stdout and stderr (if anything is found). Also, if the command returns an error, we raise the stderr content with the reported error msg.

[libvirt] Release of libvirt-0.4.6

2008-09-24 Thread Daniel Veillard
As promised after we discovered a couple of serious bugs in 0.4.5, a new release was in order, so I pushed 0.4.6 yesterday evening, it's available as usual at ftp://libvirt.org/libvirt/ There is no major change in this release, just the bug fixes a few improvements and some cleanup: *

Re: [libvirt] [PATCH] Sanitize qemu monitor reads

2008-09-24 Thread Richard W.M. Jones
On Tue, Sep 23, 2008 at 04:56:08PM -0400, Cole Robinson wrote: @@ -1670,7 +1670,7 @@ qemudMonitorCommand (const struct qemud_driver *driver ATTRIBUTE_UNUSED, const char *cmd, char **reply) { int size = 0; -char *buf = NULL; +char

Re: [libvirt] [PATCH] fix spec file when building without qemu

2008-09-24 Thread Richard W.M. Jones
On Wed, Sep 24, 2008 at 11:13:39AM +0200, Daniel Veillard wrote: While trying to build libvirt 0.4.6 for Fedora, I got an error when building on ppc64 which is the only architecture where qemu support is disabled. Files which were conditional to qemu were installed nonetheless in the build

Re: [libvirt] [PATCH] Log virRun command output, return with error

2008-09-24 Thread Richard W.M. Jones
On Tue, Sep 23, 2008 at 04:56:45PM -0400, Cole Robinson wrote: if ((ret = virExec(conn, argv, NULL, NULL, - childpid, -1, NULL, NULL, VIR_EXEC_NONE)) 0) + childpid, -1, outfd, errfd, VIR_EXEC_NONE)) 0) return ret; while ((ret

Re: [libvirt] [PATCH] Log virRun command output, return with error

2008-09-24 Thread Daniel P. Berrange
On Wed, Sep 24, 2008 at 12:24:18PM +0100, Richard W.M. Jones wrote: On Tue, Sep 23, 2008 at 04:56:45PM -0400, Cole Robinson wrote: if ((ret = virExec(conn, argv, NULL, NULL, - childpid, -1, NULL, NULL, VIR_EXEC_NONE)) 0) + childpid, -1,

[libvirt] [PATCH] avoid problem for parallel buld in python subdir

2008-09-24 Thread Daniel Veillard
Seems very hard to hit but one could get a problem with generation of the python bindings, https://bugzilla.redhat.com/show_bug.cgi?id=463733 the enclosed patch is by Dan Berrange Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ [EMAIL PROTECTED] |

Re: [libvirt] [PATCH] Sanitize qemu monitor reads

2008-09-24 Thread Cole Robinson
Richard W.M. Jones wrote: It looks to me like tmpbuf is leaked on the two error paths. garbage.collection++ Rich. ah foo, sorry about that. Fixed version attached. Thanks, Cole diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 9d8f75a..b7c8e70 100644 --- a/src/qemu_driver.c +++

[libvirt] libvirt-qpid

2008-09-24 Thread Ian Main
Howdy folks! So I've been working on a qpid interface to libvirt. Here's the description I've come up with: libvirt-qpid provides an interface with libvirt using QMF (qpid modeling framework) which utilizes the AMQP protocol. The Advanced Message Queuing Protocol (AMQP) is an open standard