On Thu, Oct 09, 2008 at 09:35:51PM +0100, Daniel P. Berrange wrote:
> On Thu, Oct 09, 2008 at 05:42:07PM +0200, Daniel Veillard wrote:
> > There is major electric change at the hosting place for libvirt.org
> > and the server will need to be shutdown for the night (french time,
> > i.e. beginnin
On Thu, Oct 09, 2008 at 04:31:49PM +0200, Jim Meyering wrote:
> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> > +#define ADD_ENV_COPY(envname) \
> > +do {\
> > +char *val = gete
On Wed, Oct 08, 2008 at 06:23:05PM -0700, Chris Wright wrote:
> Calling virDiskNameToIndex with a disk name > {sd,hd,xvd,vd}z, such as
> vdaa, generates a bogus index. Account for iterations through the loop.
>
> Old behaviour:
> vda -> 0
> vdz -> 25
> vdaa -> 0
> vdaz -> 25
>
> New behaviour:
>
On Thu, Oct 09, 2008 at 05:16:37PM +0200, Daniel Veillard wrote:
> As promised in the libvirt-qpid thread, virDomainCreateLinux() call
> name makes no sense (anymore), and it should be renamed, i guess since
> virDomainCreate() already exist and by similarity with
> virDomainDefineXML() the best
On Thu, Oct 09, 2008 at 05:42:07PM +0200, Daniel Veillard wrote:
> There is major electric change at the hosting place for libvirt.org
> and the server will need to be shutdown for the night (french time,
> i.e. beginning of the afternoon US EST time). Hopefully the services
> will be restarted
On Thu, Oct 09, 2008 at 02:29:18PM -0400, David Lively wrote:
> On Thu, 2008-10-09 at 18:01 +0100, Daniel P. Berrange wrote:
>
> > dump example, the time to lookup the object is likely dwarfed by the
> > time to generate the XML doc, or to talk to the QEMU monitor.
> > IMHO, optimizing this is ove
On Thu, Oct 09, 2008 at 08:33:14PM +0200, Stefan de Konink wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Daniel P. Berrange schreef:
> >> +typedef enum {
> >> + VIR_DOMAIN_EVENT_ADDED,
> >> + VIR_DOMAIN_EVENT_REMOVED,
> >> + VIR_DOMAIN_EVENT_STARTED,
> >> + VIR
On Thu, Oct 09, 2008 at 06:50:15PM +0100, Daniel P. Berrange wrote:
> On Thu, Oct 09, 2008 at 11:22:38AM -0400, Ben Guthro wrote:
> > diff --git a/src/internal.h b/src/internal.h
> > index a3d48fa..67a3e5b 100644
> > --- a/src/internal.h
> > +++ b/src/internal.h
> > @@ -191,6 +191,18 @@ extern int
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Daniel P. Berrange schreef:
>> +typedef enum {
>> + VIR_DOMAIN_EVENT_ADDED,
>> + VIR_DOMAIN_EVENT_REMOVED,
>> + VIR_DOMAIN_EVENT_STARTED,
>> + VIR_DOMAIN_EVENT_SUSPENDED,
>> + VIR_DOMAIN_EVENT_RESUMED,
>> + VIR_DOMAIN_EV
On Thu, 2008-10-09 at 18:01 +0100, Daniel P. Berrange wrote:
> On Thu, Oct 09, 2008 at 12:25:18PM -0400, David Lively wrote:
> > Hi Daniel -
> > I'm implementing virNodeDeviceDef, as suggested, but I just noticed
> > something that really bothers me. In a nutshell, it's that the current
> > impl
On Thu, Oct 09, 2008 at 11:24:47AM -0400, Ben Guthro wrote:
> This test app prints domain events as they are emitted.
> I was not sure where it belonged in the tree - so this is
> not in the context of the rest of the libvirt tree
Since it relies on host OS state, its not relaly something we can
r
On Thu, Oct 09, 2008 at 11:23:16AM -0400, Ben Guthro wrote:
> Monitor xenstore for domain changes
> NOTE: this patch is currently untested
Nice that this is so simple for getting destroy/start events. Its a
shame xen doesn't store the paused/crash/etc state here too though.
I guess we'll have to t
On Thu, Oct 09, 2008 at 11:22:38AM -0400, Ben Guthro wrote:
> This patch is somewhat large, and touches many files.
For large patches like this, its useful to split it up
in order of:
- The public header API & libvirt.c/driver.c glue layer
- The daemon code
- One patch per internal driver
I h
* Anthony Liguori ([EMAIL PROTECTED]) wrote:
> I've been persuaded. Relying on the host's integrity for guest data
> integrity is not a good idea by default. I don't think we should use
> cache=off to address this though. I've sent a patch and started a
> thread on qemu-devel. Let's conti
Chris Wright wrote:
* Anthony Liguori ([EMAIL PROTECTED]) wrote:
Mark McLoughlin wrote:
This is the bit I really don't buy - we're equating qemu caching to IDE
write-back caching and saying the risk of corruption is the same in both
cases.
Yes.
I'm with Mark here.
I'
On Thu, Oct 09, 2008 at 12:25:18PM -0400, David Lively wrote:
> Hi Daniel -
> I'm implementing virNodeDeviceDef, as suggested, but I just noticed
> something that really bothers me. In a nutshell, it's that the current
> implementation of this scheme unnecessarily increases the (time)
> complexi
Hi Daniel -
I'm implementing virNodeDeviceDef, as suggested, but I just noticed
something that really bothers me. In a nutshell, it's that the current
implementation of this scheme unnecessarily increases the (time)
complexity of O(1) operations to O(n).
For example, take virDomainGetXMLDesc()
* Anthony Liguori ([EMAIL PROTECTED]) wrote:
> Mark McLoughlin wrote:
>> This is the bit I really don't buy - we're equating qemu caching to IDE
>> write-back caching and saying the risk of corruption is the same in both
>> cases.
>
> Yes.
I'm with Mark here.
>> But doesn't qemu cache data for fa
Daniel Veillard wrote:
> On Wed, Oct 08, 2008 at 08:35:38PM +0100, Daniel P. Berrange wrote:
>>> One side question: is src/xmlrpc.{c,h} even used? And
>>> if not, can it be removed?
>> It is not used at this time. It was for the hypothetical
>> alternative Xen driver which talks XML-RPC which we ne
There is major electric change at the hosting place for libvirt.org
and the server will need to be shutdown for the night (french time,
i.e. beginning of the afternoon US EST time). Hopefully the services
will be restarted tomorrow morning,
sorry for the disruption and the late announcement,
This test app prints domain events as they are emitted.
I was not sure where it belonged in the tree - so this is not in the context of
the rest of the libvirt tree
Signed-off-by: Ben Guthro <[EMAIL PROTECTED]>
Makefile |2
event-test.c | 134 +++
Monitor xenstore for domain changes
NOTE: this patch is currently untested
Signed-off-by: Ben Guthro <[EMAIL PROTECTED]>
proxy/Makefile.am |1
src/xen_unified.c |8 ++
src/xen_unified.h |3
src/xs_internal.c | 176 ++
src/xs_intern
The following patch series implements the Events API discussed here previously
in this thread:
http://www.redhat.com/archives/libvir-list/2008-September/msg00321.html
This is a rather large patch, and touches quite a few files, but in the end,
accomplishes the goal of event delivery of notificat
As promised in the libvirt-qpid thread, virDomainCreateLinux() call
name makes no sense (anymore), and it should be renamed, i guess since
virDomainCreate() already exist and by similarity with
virDomainDefineXML() the best name is virDomainCreateXML().
The associated patch rename virDomainCre
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> On Thu, Oct 02, 2008 at 07:37:38PM +0200, Jim Meyering wrote:
>> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
>> ...
>> > Now previously since we just use 'execv' the QEMU process would just
>> > inherit all libvirtd's environment variables. When
Anthony Liguori wrote:
Mark McLoughlin wrote:
And let's take a step back too. If people are really concerned about
this point, let's introduce a sync=on option that opens the image with
O_SYNC. This will effectively make the cache write-through without
the baggage associated with O_DIRECT.
Steve Ofsthun wrote:
Anthony Liguori wrote:
Daniel P. Berrange wrote:
On Wed, Oct 08, 2008 at 11:06:27AM -0500, Anthony Liguori wrote:
Sorry, it was mistakenly private - fixed now.
Xen does use O_DIRECT for paravirt driver case - blktap is using the
combo
of AIO+O_DIRECT.
You
Daniel Veillard wrote:
On Wed, Oct 08, 2008 at 10:51:16AM -0500, Anthony Liguori wrote:
Daniel P. Berrange wrote:
- It is unsafe on host OS crash - all unflushed guest I/O will be
lost, and there's no ordering guarentees, so metadata updates could
be flushe to disk, while the jou
Mark McLoughlin wrote:
i.e. with write-back caching enabled, the IDE protocol makes no
guarantees about when data is committed to disk.
So, from a protocol correctness POV, qemu is behaving correctly with
cache=on and write-back caching enabled on the disk.
Yes, the host page cache is basi
Daniel Veillard wrote:
> On Wed, Oct 08, 2008 at 10:51:16AM -0500, Anthony Liguori wrote:
>> Daniel P. Berrange wrote:
>>> - It is unsafe on host OS crash - all unflushed guest I/O will be
>>>lost, and there's no ordering guarentees, so metadata updates could
>>>be flushe to disk, while th
On Wed, Oct 08, 2008 at 10:51:16AM -0500, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
>> - It is unsafe on host OS crash - all unflushed guest I/O will be
>>lost, and there's no ordering guarentees, so metadata updates could
>>be flushe to disk, while the journal updates were not. S
On Wed, Oct 08, 2008 at 08:08:35PM +0100, Daniel P. Berrange wrote:
> On Thu, Oct 02, 2008 at 07:37:38PM +0200, Jim Meyering wrote:
> > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> > ...
> > > Now previously since we just use 'execv' the QEMU process would just
> > > inherit all libvirtd's env
Hi,
Not greatly familiar with this subject, but trying to follow your
logic ...
On Wed, 2008-10-08 at 10:51 -0500, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> > - It is unsafe on host OS crash - all unflushed guest I/O will be
> >lost, and there's no ordering guarentees, so metadata
On Wed, Oct 08, 2008 at 08:35:38PM +0100, Daniel P. Berrange wrote:
> > One side question: is src/xmlrpc.{c,h} even used? And
> > if not, can it be removed?
>
> It is not used at this time. It was for the hypothetical
> alternative Xen driver which talks XML-RPC which we never
> got around to writ
On Thu, Oct 09, 2008 at 03:32:30AM +0200, Stefan de Konink wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Daniel P. Berrange schreef:
> > On Wed, Oct 08, 2008 at 09:29:29PM +0200, Stefan de Konink wrote:
> >> -BEGIN PGP SIGNED MESSAGE-
> >> Hash: SHA512
> >>
> >> Daniel P.
35 matches
Mail list logo
