Re: [libvirt] PATCH: Fix virRealloc for zero-sized alloc

2008-10-14 Thread Daniel Veillard
On Fri, Oct 10, 2008 at 07:18:44PM +0100, Daniel P. Berrange wrote: > The change to use arrays instead of linked-lists exposed a tiny bug in > the virReallocN function. The realloc() contract says that if size is > zero, then its semantics are the same as free(). virReallocN wasn't > matching this,

Re: [libvirt] [PATCH] openvz: swap with

2008-10-14 Thread Daniel P. Berrange
On Wed, Oct 08, 2008 at 01:02:44PM +0400, Anton Protopopov wrote: > > > > I do not undesrtand how it will simplify parsing: the iterator > >> in parsing is an interface name, not bridge name. I attached a patch, so > >> you will see how I do think about it :) (this patch includes all > >> discussed

[libvirt] PATCH 0/4: Openvz bridge support & related patches

2008-10-14 Thread Daniel P. Berrange
This patch series is derived from Anton Protopopov /Evgeniy Sokolov bridge device patches. It first does some generic refactoring of MAC address handler in all drivers, then adds code to extract openvz version number, then does network config, and finally does filesystem config. Daniel -- |: Red

Re: [libvirt] PATCH 3/4: SUpport bridge config for openvz

2008-10-14 Thread Daniel P. Berrange
This implements support for bridge configs in openvz following the rules set out in http://wiki.openvz.org/Virtual_Ethernet_device#Making_a_bridged_veth-device_persistent This simply requires that the admin has created /etc/vz/vznetctl.conf containing #!/bin/bash EXTERNAL_SCRIPT="/usr/sbin/

Re: [libvirt] [PATCH] openvz: swap with

2008-10-14 Thread Anton Protopopov
2008/10/14 Anton Protopopov <[EMAIL PROTECTED]> > 2008/10/14 Daniel P. Berrange <[EMAIL PROTECTED]> > >> On Wed, Oct 08, 2008 at 01:02:44PM +0400, Anton Protopopov wrote: >> > > >> > > I do not undesrtand how it will simplify parsing: the iterator >> > >> in parsing is an interface name, not bridg

Re: [libvirt] PATCH 2/4: implement getVersion method for openvz

2008-10-14 Thread Daniel P. Berrange
This patch implements the getVersion driver method for openvz to report the version number of vzctl. This is needed in the next patch to determine if we have builtin support for bridges Daniel diff -r 524f426a413d src/openvz_conf.c --- a/src/openvz_conf.c Tue Oct 14 14:41:47 2008 +0100 +++ b/src

Re: [libvirt] PATCH 1/4: More generic MAC address handling

2008-10-14 Thread Daniel P. Berrange
This patch improves the MAC address handling. Currently our XML parser auto-generates a MAC addres using the KVM vendor prefix. This isn't much use for other drivers. This patch addresses this: - Stores each driver's vendor prefix in the capability object - Changes domain parser to use the per-

Re: [libvirt] [PATCH] openvz: swap with

2008-10-14 Thread Anton Protopopov
2008/10/14 Daniel P. Berrange <[EMAIL PROTECTED]> > On Wed, Oct 08, 2008 at 01:02:44PM +0400, Anton Protopopov wrote: > > > > > > I do not undesrtand how it will simplify parsing: the iterator > > >> in parsing is an interface name, not bridge name. I attached a patch, > so > > >> you will see how

Re: [libvirt] PATCH 4/4: support FS template config

2008-10-14 Thread Daniel P. Berrange
The root filesystem for an openvz guest is defined from a template name. We support this when creating a new guest, but never include this info when dumping the XML. Thsi patch addresses this problem by reading the OSTEMPLATE config parameter diff -r e0c166ce24bd src/openvz_conf.c --- a/src/openvz

[libvirt] Re: [PATCH 3/3] qemu: fix block stats for virtio and scsi

2008-10-14 Thread Cole Robinson
Guido Günther wrote: > On Fri, Oct 10, 2008 at 06:05:37PM +0100, Daniel P. Berrange wrote: >> Sorry to mess up your patch, but I just committed the code to turn >> all linked lists into arrays. So you'll need to tweak this to do >> >> for (i = 0 ; i < vm->def->ndisks ; i++) >> if (STREQ(v

[libvirt] [PATCH] Couple of patches to fix remote connections from Windows

2008-10-14 Thread Richard W.M. Jones
There's a mistake in the way drivers are registered which means that if libvirt is configured with the remote driver but without libvirtd, then the remote driver is compiled in but not registered, which means it doesn't work. The first patch fixes this. The second patch just causes LIBVIRT_DEBUG