Re: [libvirt] Question about supporting other hypervisor

2008-10-21 Thread Atsushi SAKAI
Hi, Daniel I am looking around the wbemexec code on openpegasus. and count its code size.(seems small than I expected) Then I raised the question. Of course, Dan Smith's suggestion is very helpful advice. Thanks Atsushi SAKAI Daniel Veillard <[EMAIL PROTECTED]> wrote: > On Mon, Oct 20, 2008 a

Re: [libvirt] PATCH 1/4: More generic MAC address handling

2008-10-21 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... >> Also, unless there's a guarantee that the random number state is >> initialized elsewhere, it should be initialized here, like it was in >> the now-removed xenXMAutoAssignMac function. >> >>srand((unsigned)time(NULL)); >> >> Or maybe ju

Re: [libvirt] [PATCH] minor usb masstorage hotadd cleanup

2008-10-21 Thread Daniel Veillard
On Fri, Oct 17, 2008 at 12:44:13PM +0200, Guido Günther wrote: > Hi, > this just brings qemudDomainAttachUsbMassstorageDevice in line with the > rest of the code: > > * don't allow to add the same target device name more than once > * escape paths for qemu's monitor command Good idea ! Applied

[libvirt] FYI; warning while compiling lxc_driver.c

2008-10-21 Thread Chris Lalancette
Just wanted to give a heads up that the LXC driver spits a warning when compiling on i686; the exact warning is: gcc -DHAVE_CONFIG_H -I. -I.. -I../gnulib/lib -I../gnulib/lib -I../include -I../include -I../qemud -I/usr/include/libxml2 -DBINDIR=\"/usr/libexec\" -DSBINDIR=\"/usr/sbin\" -DSYSCONF_DIR

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-21 Thread Daniel Veillard
On Fri, Oct 17, 2008 at 04:24:52PM +0200, Guido Günther wrote: > On Fri, Oct 17, 2008 at 02:37:17PM +0200, Daniel Veillard wrote: > [..snip..] > > Looks fine, i just removed a couple of extra spaces at end of line > > before commiting :-) > Thanks a lot for applying this so quickly! Attached is

Re: [libvirt] image locking?

2008-10-21 Thread Perry Myers
Itamar Heim wrote: Hi, I am interested to find out how libvirt envisions image locking. i.e., how do we make sure multiple nodes are not trying to access the same storage volume, probably causing image corruption. I know this can be solved by means of a cluster, but it seems excessive

Re: [libvirt] Re: [PATCH 04/12] Domain Events - rpc changes

2008-10-21 Thread Ben Guthro
This is very similar to what I had in the original patch, where on the server side, we just increment/decrement a callback_registered counter, then keep the list of callbacks/opaque data on the client. The server would then send one rpc to each connected client, whose job it would be to multiple

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-21 Thread Daniel P. Berrange
On Fri, Oct 17, 2008 at 04:24:52PM +0200, Guido G?nther wrote: > On Fri, Oct 17, 2008 at 02:37:17PM +0200, Daniel Veillard wrote: > [..snip..] > > Looks fine, i just removed a couple of extra spaces at end of line > > before commiting :-) > Thanks a lot for applying this so quickly! Attached is

Re: [libvirt] Re: [PATCH 04/12] Domain Events - rpc changes

2008-10-21 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 08:57:51AM -0400, Ben Guthro wrote: > This is very similar to what I had in the original patch, > where on the server side, we just increment/decrement a callback_registered > counter, > then keep the list of callbacks/opaque data on the client. > > The server would then s

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-21 Thread Daniel J Walsh
James Morris wrote: > This is a request for comments on the initial prototype release of sVirt, > a project to add security labeling support to Linux-based virtualization. > > Project page: > http://www.selinuxproject.org/page/SVirt > > Previous libvirt discussions: > > High-level requirem

[libvirt] [PATCH 0/5]: Logical backend fixes and cleanups

2008-10-21 Thread Chris Lalancette
All, This series of 5 patches fixes a couple of issues with the logical backend implementation, and also extends the xml returned by find-storage-pool-sources-as logical to also return the 's that a logical backend is made of. Patches 1 - 4 do the cleanup, while patch 5 implements the additio

[libvirt] [PATCH 1/5]: Shore up virGetLastError handling

2008-10-21 Thread Chris Lalancette
While doing testing on this patch series, I mistakenly added a bogus piece of storage XML to libvirtd, which was saved in /etc/libvirt/storage. On subsequent stop/start of libvirtd, because of another bug (fixed in a later patch), an error wasn't being set properly in an error path, so libvirtd wa

[libvirt] [PATCH 2/5]: Properly set errors on unknown format types

2008-10-21 Thread Chris Lalancette
Because of my patch last week that converted the various virStorage*FromString and virStorage*ToString implementations to the generic VIR_ENUM_IMPL, there were a couple of places that didn't properly set errors when they failed. This patch fixes these places up. It also adds an additional check i

[libvirt] [PATCH 3/5]: Set format type to LVM2 on NULL format

2008-10-21 Thread Chris Lalancette
Again because of my generic VIR_ENUM_IMPL patch last week, I unwittingly caused a regression in the storage_backend_logical driver. Previously, if you submitted logical pool XML that had no string, it would just default to VIR_STORAGE_POOL_LOGICAL_LVM2. This would succeed just fine and go on wit

[libvirt] [PATCH 4/5]: Make dumpXML more idempotent with defineXML

2008-10-21 Thread Chris Lalancette
Currently, you can define a logical storage pool with something like the following: MyVG ... However, dumping out the XML for this same storage pool (with, say, virsh pool-dumpxml), gives: MyVG

[libvirt] [PATCH 5/5]: Export when doing logical pool discovery

2008-10-21 Thread Chris Lalancette
When doing logical pool discovery, it currently returns XML like: myvg However, for oVirt, we need to know the device name that corresponds to this logical volume group as well. Therefore, extend the virStorageBackendLogicalFindPoolSources function to return this information as well. This requi

Re: [libvirt] [PATCH 1/5]: Shore up virGetLastError handling

2008-10-21 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:56:48PM +0200, Chris Lalancette wrote: > While doing testing on this patch series, I mistakenly added a bogus piece of > storage XML to libvirtd, which was saved in /etc/libvirt/storage. On > subsequent > stop/start of libvirtd, because of another bug (fixed in a later

Re: [libvirt] [PATCH 2/5]: Properly set errors on unknown format types

2008-10-21 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:57:00PM +0200, Chris Lalancette wrote: > Because of my patch last week that converted the various virStorage*FromString > and virStorage*ToString implementations to the generic VIR_ENUM_IMPL, there > were > a couple of places that didn't properly set errors when they fai

Re: [libvirt] [PATCH 4/5]: Make dumpXML more idempotent with defineXML

2008-10-21 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:57:13PM +0200, Chris Lalancette wrote: > Currently, you can define a logical storage pool with something like the > following: > > > > MyVG > > ... > > However, dumping out the XML for this same storage pool (with, say, virsh > pool

Re: [libvirt] [PATCH 5/5]: Export when doing logical pool discovery

2008-10-21 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:57:24PM +0200, Chris Lalancette wrote: > When doing logical pool discovery, it currently returns XML like: > > myvg > > However, for oVirt, we need to know the device name that corresponds to this > logical volume group as well. Therefore, extend the > virStorageBacken

Re: [libvirt] [PATCH 3/5]: Set format type to LVM2 on NULL format

2008-10-21 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 03:57:07PM +0200, Chris Lalancette wrote: > Again because of my generic VIR_ENUM_IMPL patch last week, I unwittingly > caused > a regression in the storage_backend_logical driver. Previously, if you > submitted logical pool XML that had no string, > it > would just defau

Re: [libvirt] [PATCH 0 of 2] Cgroup and LXC fixes

2008-10-21 Thread Dan Smith
DS> This set moves the cgroup creation before that of the container DS> process, thus ensuring that it is put in the cgroup as well. As a DS> result, I noticed that we need to allow device access to DS> /dev/pts/*, and thus added a cgroup mechanism to allow a whole DS> major device type. The LXC

Re: [libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-21 Thread Daniel Veillard
On Fri, Oct 17, 2008 at 11:53:53AM -0400, Ben Guthro wrote: > This patch does the following: >-implements the Event register/deregister code >-Adds some callback lists, and queue functions used by drivers >-Move EventImpl definitions into the public Basically looks fine with however

Re: [libvirt] [PATCH 1 of 2] Add virCgroupAllowMajor()

2008-10-21 Thread Daniel P. Berrange
On Thu, Oct 16, 2008 at 02:07:56PM -0700, Dan Smith wrote: > This interface provides a way to allow an entire major device type ACK. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org

Re: [libvirt] [PATCH 2 of 2] [LXC] Create and enter the cgroup before starting container process

2008-10-21 Thread Daniel P. Berrange
On Thu, Oct 16, 2008 at 02:07:57PM -0700, Dan Smith wrote: > Without this, our container child doesn't actually end up in the cgroup, > and thus runs unrestricted. Note that this does not address the container's > ability to mount cgroup and move itself into the parent namespace. > > While making

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-21 Thread Guido Günther
On Tue, Oct 21, 2008 at 02:42:40PM +0100, Daniel P. Berrange wrote: [..snip..] > Is there not some 'info pci' or 'info disk' command we cna use to find > out the PCI slot number at the time we want to detach the device. This > would make it work for all disks, and avoid the need to track the > st

Re: [libvirt] [PATCH/RFC] qemu/kvm: allow to hot remove scsi/virtio disks

2008-10-21 Thread Guido Günther
Hi Daniel, On Tue, Oct 21, 2008 at 03:25:25PM +0200, Daniel Veillard wrote: > Those are just stylistic issues, I can apply the patch with those > changed if you wish if you don't have time for a new patch, I'll come up with a corrected version, no problem. -- Guido -- Libvir-list mailing list

Re: [libvirt] [PATCH 1 of 2] Add virCgroupAllowMajor()

2008-10-21 Thread Daniel Veillard
On Thu, Oct 16, 2008 at 02:07:56PM -0700, Dan Smith wrote: > This interface provides a way to allow an entire major device type Looks uncontroversial, +1 Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ [EMAIL PROTECTED] | Rpmfind RPM search engine http://r

Re: [libvirt] [PATCH 2 of 2] [LXC] Create and enter the cgroup before starting container process

2008-10-21 Thread Daniel Veillard
On Thu, Oct 16, 2008 at 02:07:57PM -0700, Dan Smith wrote: > Without this, our container child doesn't actually end up in the cgroup, > and thus runs unrestricted. Note that this does not address the container's > ability to mount cgroup and move itself into the parent namespace. Okay this move

Re: [libvirt] [PATCH 0 of 2] Cgroup and LXC fixes

2008-10-21 Thread Daniel Veillard
On Tue, Oct 21, 2008 at 07:58:29AM -0700, Dan Smith wrote: > DS> This set moves the cgroup creation before that of the container > DS> process, thus ensuring that it is put in the cgroup as well. As a > DS> result, I noticed that we need to allow device access to > DS> /dev/pts/*, and thus added a

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-21 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 09:57:15AM -0400, Daniel J Walsh wrote: > James Morris wrote: [snip] > > The domain security label configuration format is as follows: > > > > # virsh dumpxml sys1 > > > > > > > > system_u:system_r:virtd_t:s0 > > targeted > > > > > > > > It's pos

Re: [libvirt] [PATCH] minor usb masstorage hotadd cleanup

2008-10-21 Thread Guido Günther
On Tue, Oct 21, 2008 at 03:09:48PM +0200, Daniel Veillard wrote: > On Fri, Oct 17, 2008 at 12:44:13PM +0200, Guido Günther wrote: > > Hi, > > this just brings qemudDomainAttachUsbMassstorageDevice in line with the > > rest of the code: > > > > * don't allow to add the same target device name more

Re: [libvirt] [PATCH 1/5]: Shore up virGetLastError handling

2008-10-21 Thread Chris Lalancette
Daniel P. Berrange wrote: > On Tue, Oct 21, 2008 at 03:56:48PM +0200, Chris Lalancette wrote: >> While doing testing on this patch series, I mistakenly added a bogus piece of >> storage XML to libvirtd, which was saved in /etc/libvirt/storage. On >> subsequent >> stop/start of libvirtd, because o

Re: [libvirt] [PATCH 2/5]: Properly set errors on unknown format types

2008-10-21 Thread Chris Lalancette
Daniel P. Berrange wrote: > On Tue, Oct 21, 2008 at 03:57:00PM +0200, Chris Lalancette wrote: >> Because of my patch last week that converted the various >> virStorage*FromString >> and virStorage*ToString implementations to the generic VIR_ENUM_IMPL, there >> were >> a couple of places that didn

Re: [libvirt] [PATCH 4/5]: Make dumpXML more idempotent with defineXML

2008-10-21 Thread Chris Lalancette
Daniel P. Berrange wrote: > On Tue, Oct 21, 2008 at 03:57:13PM +0200, Chris Lalancette wrote: >> Currently, you can define a logical storage pool with something like the >> following: >> >> >> >> MyVG >> >> ... >> >> However, dumping out the XML for this same stor

Re: [libvirt] [PATCH 3/5]: Set format type to LVM2 on NULL format

2008-10-21 Thread Chris Lalancette
Daniel P. Berrange wrote: > On Tue, Oct 21, 2008 at 03:57:07PM +0200, Chris Lalancette wrote: >> Again because of my generic VIR_ENUM_IMPL patch last week, I unwittingly >> caused >> a regression in the storage_backend_logical driver. Previously, if you >> submitted logical pool XML that had no

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-21 Thread Daniel P. Berrange
On Tue, Oct 21, 2008 at 01:06:17PM +1100, James Morris wrote: > With this release, it is possible to define a security label for a > kvm/qemu domain in its XML configuration ('virsh edit'), launch the domain > and have it transition to the specified security label ('virsh start'), > then query t

[libvirt] Re: [PATCH 1/6] host ("node") device enumeration - public API additions

2008-10-21 Thread David Lively
This patch contains the public API additions. diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 3624367..c888943 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -993,6 +993,76 @@ char * virStorageVolGetPath(v

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-21 Thread Daniel J Walsh
Daniel P. Berrange wrote: > On Tue, Oct 21, 2008 at 09:57:15AM -0400, Daniel J Walsh wrote: >> James Morris wrote: > > [snip] > >>> The domain security label configuration format is as follows: >>> >>> # virsh dumpxml sys1 >>> >>> >>> >>> system_u:system_r:virtd_t:s0 >>> targ

[libvirt] Re: [PATCH 2/6] host ("node") device enumeration - internal API additions

2008-10-21 Thread David Lively
This patch contains the internal API additions. diff --git a/src/hash.c b/src/hash.c index 0a5bdcd..424c4a7 100644 --- a/src/hash.c +++ b/src/hash.c @@ -687,6 +687,9 @@ virGetConnect(void) { ret->storageVols = virHashCreate(20); if (ret->storageVols == NULL) goto failed; +re

Re: [libvirt] [PATCH 0 of 2] Cgroup and LXC fixes

2008-10-21 Thread Dan Smith
DV> sorry for the delay, please push ! Done. Thanks! -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: [EMAIL PROTECTED] -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 0/6] host ("node") device enumeration, take two

2008-10-21 Thread David Lively
Ok, here's my substantially-reworked node device enumeration patch, this time done with a proper understanding of the public-obj/Obj/Def model :-) as last discussed here: https://www.redhat.com/archives/libvir-list/2008-September/msg00398.html I've broken it into the following pieces: 1-public-a

[libvirt] Re: [PATCH 0/6] host ("node") device enumeration - local node drivers

2008-10-21 Thread David Lively
This patch contains the actual HAL- and DeviceKit-based local "node" drivers. diff --git a/configure.in b/configure.in index 66d271a..3441742 100644 --- a/configure.in +++ b/configure.in @@ -1048,6 +1048,93 @@ test "$enable_shared" = no && lt_cv_objdir=. LV_LIBTOOL_OBJDIR=${lt_cv_objdir-.} AC_SU

RE: [libvirt] image locking?

2008-10-21 Thread Itamar Heim
Hi Perry, The problem is with unreachable hosts which are locking the image forever. When fencing can't be used, there is no way for the management to "release" the image, since it can't verify the host stopped using the image. A leased lock mechanism, while not providing 100% prevention, does a

Re: [libvirt] image locking?

2008-10-21 Thread Perry Myers
Itamar Heim wrote: Hi Perry, The problem is with unreachable hosts which are locking the image forever. When fencing can't be used, there is no way for the management to "release" the image, since it can't verify the host stopped using the image. A leased lock mechanism, while not providing 100

RE: [libvirt] image locking?

2008-10-21 Thread Itamar Heim
While this might work for SBC (although most enterprises have the datacenter on remote sites as well, so not always that easy). I don't think the solution is viable for CBC though (I am not sure CBC would use iSCSI, probably NFS is a more relevant option, but the leased locking is required there

[libvirt] Re: [PATCH 03/12] Domain Events - daemon changes

2008-10-21 Thread Ben Guthro
[PATCH 03/12] Domain Events - daemon changes This code changes the daemaon to: use the pulic def of virEventRegisterImpl Add functionality to dispatch events to connected remote drivers event.c | 21 + event.h |5 +- mdns.c | 15 -- qemud.c | 72

[libvirt] Re: [PATCH 04/12] Domain Events - rpc changes

2008-10-21 Thread Ben Guthro
[PATCH 04/12] Domain Events - rpc changes Changes to the RPC protocol remote_dispatch_localvars.h |3 +++ remote_dispatch_proc_switch.h | 18 ++ remote_dispatch_prototypes.h |3 +++ remote_protocol.c | 29 + remote_protocol.h

[libvirt] Re: [PATCH 05/12] Domain Events - Driver API

2008-10-21 Thread Ben Guthro
[PATCH 05/12] Domain Events - Driver API Additions to the driver API driver.h | 13 + 1 file changed, 13 insertions(+) diff --git a/src/driver.h b/src/driver.h index 0540f80..d1b541f 100644 --- a/src/driver.h +++ b/src/driver.h @@ -280,6 +280,17 @@ typedef unsigned long long (*

[libvirt] Re: [PATCH 06/12] Domain Events - qemu driver

2008-10-21 Thread Ben Guthro
[PATCH 06/12] Domain Events - qemu driver Register for, and dispatch domain event callbacks qemu_conf.h |3 + qemu_driver.c | 101 +- 2 files changed, 97 insertions(+), 7 deletions(-) diff --git a/src/qemu_conf.h b/src/qemu_conf.h ind

[libvirt] Re: [PATCH 07/12] Domain Events - remote driver

2008-10-21 Thread Ben Guthro
[PATCH 07/12] Domain Events - remote driver Deliver local callbacks in response to remote events remote_internal.c | 276 +- 1 file changed, 271 insertions(+), 5 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index 35b7

[libvirt] Re: [PATCH 08/12] Domain Events - lxc driver

2008-10-21 Thread Ben Guthro
[PATCH 08/12] Domain Events - lxc driver Minor changes to LXC driver structure to prevent compile errors lxc_driver.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lxc_driver.c b/src/lxc_driver.c index c598d1d..d1e4418 100644 --- a/src/lxc_driver.c +++ b/src/lxc_

[libvirt] Re: [PATCH 09/12] Domain Events - openvz driver

2008-10-21 Thread Ben Guthro
[PATCH 09/12] Domain Events - openvz driver Minor changes to openvz driver structure to prevent compile errors openvz_driver.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvz_driver.c b/src/openvz_driver.c index b82d0df..2d0ddaa 100644 --- a/src/openvz_driver.c +++ b/src/openvz

[libvirt] Re: [PATCH 10/12] Domain Events - test driver

2008-10-21 Thread Ben Guthro
[PATCH 10/12] Domain Events - test driver Minor changes to test driver structure to prevent compile errors test.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test.c b/src/test.c index aab74e4..34d35db 100644 --- a/src/test.c +++ b/src/test.c @@ -1552,6 +1552,8 @@ static virDriver

[libvirt] Re: [PATCH 11/12] Domain Events - test harness

2008-10-21 Thread Ben Guthro
[PATCH 11/12] Domain Events - test harness Test app, and infrastructure changes for an example dir Makefile.am |2 configure.in |3 examples/domain-events/events-c/Makefile.am |5 examples/domain-events/events-c/event-t

[libvirt] Re: [PATCH 12/12] Domain Events - python

2008-10-21 Thread Ben Guthro
[PATCH 12/12] Domain Events - python Add functions to be ignored, to prevent rpm build failures generator.py |3 +++ 1 file changed, 3 insertions(+) diff --git a/python/generator.py b/python/generator.py index c706b19..ca83eaf 100755 --- a/python/generator.py +++ b/python/generator.py @@ -33

[libvirt] Re: [PATCH 4/6] host ("node") device enumeration - remote node driver

2008-10-21 Thread David Lively
This patch contains the remote impl of the node driver. diff --git a/qemud/remote.c b/qemud/remote.c index 72e064e..48564e6 100644 --- a/qemud/remote.c +++ b/qemud/remote.c @@ -66,6 +66,7 @@ static void make_nonnull_domain (remote_nonnull_domain *dom_dst, virDomainPtr do static void make_nonnull_

[libvirt] [PATCH 00/12] Domain Events - Round 3

2008-10-21 Thread Ben Guthro
The following patch series implements the Events API discussed here previously in this thread: http://www.redhat.com/archives/libvir-list/2008-September/msg00321.html http://www.redhat.com/archives/libvir-list/2008-October/msg00245.html and https://www.redhat.com/archives/libvir-list/2008-October

[libvirt] [PATCH 00/12] Domain Events - Round 3

2008-10-21 Thread Ben Guthro
The following patch series implements the Events API discussed here previously in this thread: http://www.redhat.com/archives/libvir-list/2008-September/msg00321.html http://www.redhat.com/archives/libvir-list/2008-October/msg00245.html and https://www.redhat.com/archives/libvir-list/2008-October

[libvirt] Re: [PATCH 02/12] Domain Events - Internal API

2008-10-21 Thread Ben Guthro
[PATCH 02/12] Domain Events - Internal API This patch -Removes EventImpl from being a private function -Introduces the virDomainEventCallbackListPtr, and virDomainEventQueuePtr objects diff --git a/proxy/Makefile.am b/proxy/Makefile.am index 5902cab..75ba6b4 100644 --- a/proxy/Makefile.am ++

[libvirt] Re: [PATCH 02/12] Domain Events - Internal API

2008-10-21 Thread Ben Guthro
[PATCH 02/12] Domain Events - Internal API This patch -Removes EventImpl from being a private function -Introduces the virDomainEventCallbackListPtr, and virDomainEventQueuePtr objects diff --git a/proxy/Makefile.am b/proxy/Makefile.am index 5902cab..75ba6b4 100644 --- a/proxy/Makefile.am +

[libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-21 Thread Ben Guthro
[PATCH 01/12] Domain Events - Public API This patch does the following: -implements the Event register/deregister code -Adds some callback lists, and queue functions used by drivers -Move EventImpl definitions into the public diff --git a/include/libvirt/libvirt.h b/include/libvirt/libvir

[libvirt] Re: [PATCH 01/12] Domain Events - Public API

2008-10-21 Thread Ben Guthro
[PATCH 01/12] Domain Events - Public API This patch does the following: -implements the Event register/deregister code -Adds some callback lists, and queue functions used by drivers -Move EventImpl definitions into the public diff --git a/include/libvirt/libvirt.h b/include/libvirt/libvi

[libvirt] Re: [PATCH 6/6] host ("node") device enumeration - python bindings

2008-10-21 Thread David Lively
This patch implements the python bindings, rather lamely. I'll submit a new version with a proper NodeDevice object soon ... diff --git a/python/generator.py b/python/generator.py index c706b19..a8fd969 100755 --- a/python/generator.py +++ b/python/generator.py @@ -258,6 +258,11 @@ py_types = {

[libvirt] Re: [PATCH 5/6] host ("node") device enumeration - virsh support

2008-10-21 Thread David Lively
This patch implements virsh support. It's pretty sparse right now, and I'm not wild about the command names I chose. I welcome suggestions (i.e., command names / args) for completing (or changing) this. diff --git a/src/virsh.c b/src/virsh.c index 89aa4fa..67963f0 100644 --- a/src/virsh.c +++

Re: [libvirt] [PATCH 00/12] Domain Events - Round 3

2008-10-21 Thread Ben Guthro
Apologies about the duplicate 00, 01, and 02 emails. My email seems to be acting up, and I didn't see those patches come through...so I resent those 3 Then they arrived in pairs. Please ignore the duplicates. Ben Guthro wrote on 10/21/2008 03:10 PM: > The following patch series implements the

[libvirt] errors building rpm

2008-10-21 Thread Ben Guthro
I keep getting the following error when trying to build via a 'sudo make rpm' on the tip of the tree + /usr/lib/rpm/find-lang.sh /var/tmp/libvirt-0.4.6-1.fc9-root libvirt No translations found for libvirt in /var/tmp/libvirt-0.4.6-1.fc9-root error: Bad exit status from /var/tmp/rpm-tmp.82848 (%ins