[libvirt] [0/17] patches: mingw, gnulib, warnings, misc

2008-10-28 Thread Jim Meyering
Last week, I set out simply to adjust libvirt to accommodate a recent gnulib API change, whereby you now include the standard netdb.h rather than the gnulib-made-up getaddrinfo.h header file. That meant pulling in many gnulib updates (a lot's been happening on the mingw portability front

[libvirt] [PATCH 13/17] * qemud/remote_protocol.x: Include remote_protocol.h and rpc/xdr.h.

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] --- qemud/remote_protocol.x |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/qemud/remote_protocol.x b/qemud/remote_protocol.x index b7e41aa..d15c549 100644 --- a/qemud/remote_protocol.x +++ b/qemud/remote_protocol.x @@ -3,7 +3,7

[libvirt] [PATCH 16/17] avoid many mingw-specific warnings

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] * tests/virshtest.c (mymain): Use only one definition of this function. [WIN32]: Call exit(77) to skip the test. * tests/nodeinfotest.c: Likewise. --- tests/nodeinfotest.c |8 +++- tests/virshtest.c| 11 --- 2 files changed, 7

[libvirt] [PATCH 08/17] socketcompat.h: simplify, to match latest gnulib

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] Now, sys/socket.h is always available, and errno works. --- src/socketcompat.h | 29 + 1 files changed, 5 insertions(+), 24 deletions(-) diff --git a/src/socketcompat.h b/src/socketcompat.h index 51235f6..a06fe36 100644 ---

[libvirt] [PATCH 01/17] exempt gnulib from ctype-macros prohibition

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] --- .x-sc_avoid_ctype_macros |1 + 1 files changed, 1 insertions(+), 0 deletions(-) create mode 100644 .x-sc_avoid_ctype_macros diff --git a/.x-sc_avoid_ctype_macros b/.x-sc_avoid_ctype_macros new file mode 100644 index 000..06e95c1 --- /dev/null

[libvirt] [PATCH 14/17] * remote_protocol.c, remote_protocol.h: regenerate

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] --- qemud/remote_protocol.c |3 +++ qemud/remote_protocol.h |2 ++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/qemud/remote_protocol.c b/qemud/remote_protocol.c index 06b33d8..652d5b5 100644 --- a/qemud/remote_protocol.c +++

[libvirt] [PATCH 05/17] adapt to API change in gnulib

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] * qemud/qemud.c: Include netdb.h, not getaddrinfo.h * src/remote_internal.c: Likewise. --- qemud/qemud.c |2 +- src/remote_internal.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemud/qemud.c b/qemud/qemud.c index

[libvirt] [PATCH 02/17] exempt gnulib from write-avoidance syntax check

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] --- .x-sc_avoid_write |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.x-sc_avoid_write b/.x-sc_avoid_write index fe38d83..46ffdec 100644 --- a/.x-sc_avoid_write +++ b/.x-sc_avoid_write @@ -1,3 +1,4 @@ ^src/util\.c$

[libvirt] [PATCH 10/17] remove duplicate inclusion of remote_protocol.h (before config.h!)

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] --- qemud/remote_protocol.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemud/remote_protocol.c b/qemud/remote_protocol.c index 5ef80e5..06b33d8 100644 --- a/qemud/remote_protocol.c +++ b/qemud/remote_protocol.c @@ -3,7 +3,6 @@

[libvirt] [PATCH 11/17] * src/remote_internal.c (remoteFindDaemonPath) [!WIN32]: Don't compile.

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] --- src/remote_internal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index 5f528a8..08d42a9 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -189,6 +189,7 @@

[libvirt] [PATCH 17/17] avoid compiler warning when all storage backends are disabled

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] * src/storage_backend.c (backends): Add a NULL terminator. (virStorageBackendForType): Use NULL terminator rather than warning-provoking (possibly 0) array size. --- src/storage_backend.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff

[libvirt] [PATCH 09/17] use errno, not socket_errno()

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] * remote_internal.c: s/socket_errno()/errno/, now that gnulib's socket module ensures errno is useful in those cases. --- src/remote_internal.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/remote_internal.c

[libvirt] [PATCH 12/17] include netinet etc #ifndef HAVE_WINSOCK2_H

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] --- src/remote_internal.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index 08d42a9..703ebf8 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -36,6 +36,13 @@

[libvirt] [PATCH 04/17] * src/network_conf.c: Include string.h for declaration of memcmp.

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] --- src/network_conf.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/network_conf.c b/src/network_conf.c index 4c32fa1..99a84dc 100644 --- a/src/network_conf.c +++ b/src/network_conf.c @@ -30,6 +30,7 @@ #include sys/stat.h

[libvirt] [PATCH 07/17] updates from gnulib

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] --- Here's some of it. For the entire patch, see http://meyering.net/code/tmp/0007-updates-from-gnulib.patch .cvsignore | 39 +- .gitignore | 39 +-

[libvirt] [PATCH 15/17] cvsignore mingw build artifacts: *.exe

2008-10-28 Thread Jim Meyering
From: Jim Meyering [EMAIL PROTECTED] --- docs/examples/.cvsignore |1 + docs/examples/.gitignore |1 + examples/domain-events/events-c/.cvsignore |1 + examples/domain-events/events-c/.gitignore |1 + gnulib/tests/.cvsignore

Re: [libvirt] [PATCH 01/17] exempt gnulib from ctype-macros prohibition

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:17PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] --- .x-sc_avoid_ctype_macros |1 + 1 files changed, 1 insertions(+), 0 deletions(-) create mode 100644 .x-sc_avoid_ctype_macros diff --git a/.x-sc_avoid_ctype_macros

Re: [libvirt] [PATCH 03/17] use ARRAY_CARDINALITY more

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:19PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] * tests/nodeinfotest.c: Include util.h. * src/xen_internal.c: Likewise. * src/qemu_conf.c (qemudCapsInit): Use ARRAY_CARDINALITY. * src/storage_backend.c (virStorageBackendForType): Likewise.

Re: [libvirt] [PATCH 04/17] * src/network_conf.c: Include string.h for declaration of memcmp.

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:20PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] --- src/network_conf.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/network_conf.c b/src/network_conf.c index 4c32fa1..99a84dc 100644 ---

Re: [libvirt] [PATCH 05/17] adapt to API change in gnulib

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:21PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] * qemud/qemud.c: Include netdb.h, not getaddrinfo.h * src/remote_internal.c: Likewise. --- qemud/qemud.c |2 +- src/remote_internal.c |2 +- 2 files changed, 2

Re: [libvirt] [PATCH 06/17] use more gnulib modules

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:22PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] * bootstrap: use more gnulib modules: close, connect, perror, recv, send, socket setsockopt, gethostname. ACK Daniel -- |: Red Hat, Engineering, London -o-

Re: [libvirt] [PATCH 08/17] socketcompat.h: simplify, to match latest gnulib

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:25PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] Now, sys/socket.h is always available, and errno works. With the removal of errno stuff and santization of headers I don't see all that much point in keeping socketcompat.h around at all - can't

Re: [libvirt] [PATCH 09/17] use errno, not socket_errno()

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:26PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] * remote_internal.c: s/socket_errno()/errno/, now that gnulib's socket module ensures errno is useful in those cases. @@ -4627,7 +4627,7 @@ really_write_buf (virConnectPtr conn, struct

Re: [libvirt] [PATCH 10/17] remove duplicate inclusion of remote_protocol.h (before config.h!)

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:27PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] --- qemud/remote_protocol.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemud/remote_protocol.c b/qemud/remote_protocol.c index 5ef80e5..06b33d8 100644 ---

Re: [libvirt] [PATCH 11/17] * src/remote_internal.c (remoteFindDaemonPath) [!WIN32]: Don't compile.

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:28PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] --- src/remote_internal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index 5f528a8..08d42a9 100644 ---

Re: [libvirt] [PATCH 12/17] include netinet etc #ifndef HAVE_WINSOCK2_H

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:29PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] --- src/remote_internal.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index 08d42a9..703ebf8 100644 ---

Re: [libvirt] [PATCH 13/17] * qemud/remote_protocol.x: Include remote_protocol.h and rpc/xdr.h.

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:30PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] --- qemud/remote_protocol.x |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/qemud/remote_protocol.x b/qemud/remote_protocol.x index b7e41aa..d15c549 100644 ---

Re: [libvirt] [PATCH 14/17] * remote_protocol.c, remote_protocol.h: regenerate

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:31PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] --- qemud/remote_protocol.c |3 +++ qemud/remote_protocol.h |2 ++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/qemud/remote_protocol.c b/qemud/remote_protocol.c

Re: [libvirt] [PATCH 15/17] cvsignore mingw build artifacts: *.exe

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:32PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] --- docs/examples/.cvsignore |1 + docs/examples/.gitignore |1 + examples/domain-events/events-c/.cvsignore |1 +

Re: [libvirt] [PATCH 16/17] avoid many mingw-specific warnings

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:33PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] * tests/virshtest.c (mymain): Use only one definition of this function. [WIN32]: Call exit(77) to skip the test. * tests/nodeinfotest.c: Likewise. --- tests/nodeinfotest.c |8 +++-

Re: [libvirt] [PATCH 17/17] avoid compiler warning when all storage backends are disabled

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 12:21:34PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] * src/storage_backend.c (backends): Add a NULL terminator. (virStorageBackendForType): Use NULL terminator rather than warning-provoking (possibly 0) array size. ACK Daniel -- |: Red Hat,

Re: [libvirt] [PATCH 10/17] remove duplicate inclusion of remote_protocol.h (before config.h!)

2008-10-28 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Oct 28, 2008 at 12:21:27PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] --- qemud/remote_protocol.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemud/remote_protocol.c

Re: [libvirt] [PATCH 09/17] use errno, not socket_errno()

2008-10-28 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Oct 28, 2008 at 12:21:26PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] * remote_internal.c: s/socket_errno()/errno/, now that gnulib's socket module ensures errno is useful in those cases. @@ -4627,7 +4627,7 @@

Re: [libvirt] [PATCH 09/17] use errno, not socket_errno()

2008-10-28 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Oct 28, 2008 at 12:21:26PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] * remote_internal.c: s/socket_errno()/errno/, now that gnulib's socket module ensures errno is useful in those cases. @@ -4627,7 +4627,7 @@

Re: [libvirt] [PATCH 08/17] socketcompat.h: simplify, to match latest gnulib

2008-10-28 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Oct 28, 2008 at 12:21:25PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] Now, sys/socket.h is always available, and errno works. With the removal of errno stuff and santization of headers I don't see all that much point

Re: [libvirt] [PATCH 08/17] socketcompat.h: simplify, to match latest gnulib

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 01:33:35PM +0100, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Oct 28, 2008 at 12:21:25PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] Now, sys/socket.h is always available, and errno works. With the removal of

Re: [libvirt] [PATCH 10/17] remove duplicate inclusion of remote_protocol.h (before config.h!)

2008-10-28 Thread Jim Meyering
Jim Meyering [EMAIL PROTECTED] wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: On Tue, Oct 28, 2008 at 12:21:27PM +0100, Jim Meyering wrote: From: Jim Meyering [EMAIL PROTECTED] --- qemud/remote_protocol.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] Re: [PATCH 1/6] host (node) device enumeration - public API additions

2008-10-28 Thread Daniel Veillard
On Tue, Oct 21, 2008 at 01:49:19PM -0400, David Lively wrote: This patch contains the public API additions. the libvirt.h part looks just fine at this point for me. I'm just wondering a bit about some of the naming node driver are devkit and Hal really node drivers, then sound more like

Re: [libvirt] Re: [PATCH 2/6] host (node) device enumeration - internal API additions

2008-10-28 Thread Daniel Veillard
On Tue, Oct 21, 2008 at 01:54:13PM -0400, David Lively wrote: This patch contains the internal API additions. Looks fine to me, just a couple of questions: +// TODO: Implement PCI bus devs +// TODO: Implement USB bus devs Any reason it's not in ? I would expect HAL to

Re: [libvirt] Re: [PATCH 2/6] host (node) device enumeration - internal API additions

2008-10-28 Thread Daniel Veillard
On Tue, Oct 28, 2008 at 11:32:03AM -0400, David Lively wrote: On Tue, 2008-10-28 at 14:13 +0100, Daniel Veillard wrote: On Tue, Oct 21, 2008 at 01:54:13PM -0400, David Lively wrote: This patch contains the internal API additions. Looks fine to me, just a couple of questions: +

Re: [libvirt] [PATCH]: Update ruby-libvirt migrate binding to use rb_scan_args

2008-10-28 Thread David Lutterkort
On Thu, 2008-10-23 at 12:04 +0200, Chris Lalancette wrote: It's really not a good idea to hand parse variable number of args to a ruby binding, like I implemented for the migrate method. Convert this to use rb_scan_args, which is the proper way to do it, and matches all of the other variable

Re: [libvirt] [PATCH]: Implement ruby-libvirt storage pool discovery binding

2008-10-28 Thread David Lutterkort
On Thu, 2008-10-23 at 12:04 +0200, Chris Lalancette wrote: Attached is a pretty simple patch to implement the virConnectFindStoragePoolSources() binding for ruby-libvirt.This capability went into libvirt-0.4.5, so any version of libvirt that has storage API support should have support for

Re: [libvirt] [PATCH 01/17] exempt gnulib from ctype-macros prohibition

2008-10-28 Thread Jim Meyering
Thanks for the quick feedback. I've just committed all of those changes. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC] domain-events-python

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 09:09:53AM -0400, Ben Guthro wrote: Attached is a preliminary patch implementing the python bindings for domain events, and the EventImpl code. This implements a python test app equivalent to the code in the C event-test app. Contrary to what Daniel B originally

[libvirt] [PATCH] remove src/socketcompat.h; no longer needed

2008-10-28 Thread Jim Meyering
Daniel P. Berrange [EMAIL PROTECTED] wrote: ... So how about if I remove socketcompat.h once these changes are committed? Works for me Here you go: From 57cc6abb180564463bb4824c54017544564ac77c Mon Sep 17 00:00:00 2001 From: Jim Meyering [EMAIL PROTECTED] Date: Tue, 28 Oct 2008 19:17:20

[libvirt] Re: [PATCH] remove src/socketcompat.h; no longer needed

2008-10-28 Thread Daniel P. Berrange
On Tue, Oct 28, 2008 at 07:24:43PM +0100, Jim Meyering wrote: Daniel P. Berrange [EMAIL PROTECTED] wrote: ... So how about if I remove socketcompat.h once these changes are committed? Works for me Here you go: From 57cc6abb180564463bb4824c54017544564ac77c Mon Sep 17 00:00:00 2001

[libvirt] libvirt adds , boot-on to qemu-kvm command line - prevents guest boot!

2008-10-28 Thread Bruce Rogers
I'm experimenting with libvirt and qemu-kvm using a raw hard disk image that has a bootable DOS partition in it. I noticed that libvirt was adding the ,boot=on option to the disk section of the qemu-kvm command line. This prevents the guest from booting somehow. If that option is removed,

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-28 Thread James Morris
On Thu, 23 Oct 2008, Paul Moore wrote: However, may I suggest that instead of representing the DOI as a string we use a 32bit integer? I know that may sound a bit odd, but in the networking world most DOI values are represented as integers and when security labels are involved they tend

[libvirt] Re: [RFC] sVirt v0.10 - initial prototype

2008-10-28 Thread Paul Moore
On Tuesday 28 October 2008 5:42:17 pm James Morris wrote: On Thu, 23 Oct 2008, Paul Moore wrote: However, may I suggest that instead of representing the DOI as a string we use a 32bit integer? I know that may sound a bit odd, but in the networking world most DOI values are represented as