Hi,
I have a question.
Why does libvirt check size of memory in xenStoreDomainSetMemory of
xs_internal.c?
In the xen not exclude lifecycle,
when I do the following command for the domain that is shutoff,
error message is output and return value is 0 and the definition
file(=/etc/xen/XXX) is
Hi, Shigeki
At first, libvirt.c should not check VMM-arch specific value.
In this meaning, xs_internal.c do the right thing.
The problem is error handling on libvirt.c(Xen Store error is not handled
properly).
Do you investigate it?
Thanks
Atsushi SAKAI
S.Sakamoto [EMAIL PROTECTED] wrote:
Hi, James
I have a question just for interest.
The security context stores like
/etc/selinux/targeted/contexts/files/file_contexts.
But you are storeing the domain security label on libvirt specific XML.
Of course, this is good for libvirt POV.
Is it permitted for SELinux policy POV?
By the
After Daniel's feedback that adding src/virterror.h is confusing, I've
re-done the patch to instead add virterror_internal.h, making it clear
that these function prototypes are related to virterror.c, but internal
use only. That patch is basically moving them out of src/internal.h
In addition it
When we added the LXC driver, it originally needed to respond
to signals. We removed that need a while ago, but left the
infrastructure around. This patch removes the driver calls
relating to signal progation, since they're unneccessary and
we shouldn't follow this approach again in the future,
This is a re-diff of the patch I sent yesterday to just move the
domain events code into its own separate file.
b/src/domain_event.c | 229 ++
b/src/domain_event.h | 83 ++
qemud/event.c |8 -
qemud/event.h
The configure script lets users turn on/of individual drivers. Their
choices get fed into a LIBVIRT_FEATURES macro, which has one or more
-DWITH_XEN -DWITH_OPENVZ, etc, etc. The compiler args become rather
long when we have all the drivers enabled. So this patch tweaks the
configure file to
A while ago we introduced a libvirt_test.so which is identical to
libvirt.so, but without the linker whitelist of symbols. This did
impose a little overhead in the build process - it meant we compiled
all source files twice.
A future patch will want to compile drivers into individual libraries
to
The libvirt.so file currently whitelists all the symbols in our public
API. libvirtd and virsh, however, also want to use a bunch of our so
called 'private' symbols which aren't in the public API. For saferead
and safewrite() we dealt with this by compiling the code twice with
some nasty macro
This patches changes the way some of the drivers are built. Specifically
the stateful drivers (QEMU, LXC, Network and Storage) are no longer
compiled into libvirt.so Instead they are linked directly to the libvirt
binary. They could only ever be executed as part of the daemon, and we had
code
This patch adds full support for dlopen()'ing of individual drivers.
- configure.in gains a new command line flag --with-driver-modules.
It defaults to off, producing a monolithic build. If enabled, it
checks dlopen() in -ldl and dlfcn.h
- src/Makefile.am if the WITH_DRIVER_MODULES
As a convenience I've placed the entire patch series online for direct
download avoiding email client mangling :-)
http://berrange.fedorapeople.org/libvirt-dlopen/
On Thu, Oct 30, 2008 at 01:33:31PM +, Daniel P. Berrange wrote:
The following series of patches clean up our internal
On Thu, Oct 30, 2008 at 01:35:24PM +, Daniel P. Berrange wrote:
This patch updates the storage drivers to make full use of
virStorageSourceList
and thus removes the now uneeded virStringList code. No change since last
time,
just re-diffed for new CVS.
No problem, +1
Daniel
--
On Thu, Oct 30, 2008 at 01:36:10PM +, Daniel P. Berrange wrote:
After Daniel's feedback that adding src/virterror.h is confusing, I've
re-done the patch to instead add virterror_internal.h, making it clear
that these function prototypes are related to virterror.c, but internal
use only.
On Thu, Oct 30, 2008 at 03:19:11PM +0100, Daniel Veillard wrote:
On Thu, Oct 30, 2008 at 01:36:10PM +, Daniel P. Berrange wrote:
After Daniel's feedback that adding src/virterror.h is confusing, I've
re-done the patch to instead add virterror_internal.h, making it clear
that these
On Thu, Oct 30, 2008 at 01:38:08PM +, Daniel P. Berrange wrote:
This is a re-diff of the patch I sent yesterday to just move the
domain events code into its own separate file.
Yup, fine +1,
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
[EMAIL
On Thu, Oct 30, 2008 at 01:38:56PM +, Daniel P. Berrange wrote:
The configure script lets users turn on/of individual drivers. Their
choices get fed into a LIBVIRT_FEATURES macro, which has one or more
-DWITH_XEN -DWITH_OPENVZ, etc, etc. The compiler args become rather
long when we have
On Thu, Oct 30, 2008 at 03:44:20PM +0100, Daniel Veillard wrote:
On Thu, Oct 30, 2008 at 01:38:56PM +, Daniel P. Berrange wrote:
The configure script lets users turn on/of individual drivers. Their
choices get fed into a LIBVIRT_FEATURES macro, which has one or more
-DWITH_XEN
On Thu, Oct 30, 2008 at 01:39:33PM +, Daniel P. Berrange wrote:
A while ago we introduced a libvirt_test.so which is identical to
libvirt.so, but without the linker whitelist of symbols. This did
impose a little overhead in the build process - it meant we compiled
all source files twice.
On Thu, Oct 30, 2008 at 02:21:35PM +, Daniel P. Berrange wrote:
On Thu, Oct 30, 2008 at 03:19:11PM +0100, Daniel Veillard wrote:
On Thu, Oct 30, 2008 at 01:36:10PM +, Daniel P. Berrange wrote:
After Daniel's feedback that adding src/virterror.h is confusing, I've
re-done the patch
In adding a test of the vcpu cpuset parsing code (another patch coming
separately), I noticed a bogus diagnostic:
virsh --connect test:///default dumpxml 1 xml
sed s/vcpu/vcpu cpuset='aaa'/ xml xml-invalid
./virsh --connect test:///default define xml-invalid 21 |head -1
libvir: Domain
From c0beb0ed6dd3d392b11161c565d7dfd52ed2aceb Mon Sep 17 00:00:00 2001
From: Jim Meyering [EMAIL PROTECTED]
Date: Mon, 2 Jun 2008 11:54:34 +0200
Subject: [PATCH 1/2] * tests/cpuset: New script. Test for today's fix.
* tests/Makefile.am (test_scripts): Add cpuset.
---
tests/Makefile.am |1 +
On Thu, Oct 30, 2008 at 01:41:14PM +, Daniel P. Berrange wrote:
The libvirt.so file currently whitelists all the symbols in our public
API. libvirtd and virsh, however, also want to use a bunch of our so
called 'private' symbols which aren't in the public API. For saferead
and safewrite()
Cole Robinson wrote:
The attached patch implements the storage driver routines
for the test driver. Most of the code is identical to
storage_driver.c with all the references to backends
removed.
One caveat of this is that storage pools are hardcoded
to a specific size when they are
The following three patches add improved debug output
for the virExec and virRun commands. The full argv
is now logged, and virRun reads the command stdout
and stderr for use in error reporting.
Thanks,
Cole
--
Libvir-list mailing list
Libvir-list@redhat.com
The attached patch logs the the argv's passed to
the virExec and virRun functions. There's a bit of
trickery here: since virRun is just a wrapper for
virExec, we don't want the argv string to be logged
twice.
I addressed this by renaming virExec to __virExec,
and keeping the original function
The attached patch is my second cut at reading
stdout and stderr of the command virRun kicks
off. There is no hard limit to the amount of
data we read now, and we use a poll loop to
avoid any possible full buffer issues.
If stdout or stderr had any content, we DEBUG
it, and if the command
The attached patch moves the argvToString function
from iptables.c to util.c for use in later patches.
Thanks,
Cole
commit c115b34455789910597061c7b100e056cb3fe787
Author: Cole Robinson [EMAIL PROTECTED]
Date: Fri Oct 24 10:10:11 2008 -0400
Move argvToString to virArgvToString in util
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Atsushi SAKAI wrote:
Hi, James
I have a question just for interest.
The security context stores like
/etc/selinux/targeted/contexts/files/file_contexts.
But you are storeing the domain security label on libvirt specific XML.
Of course,
Cole Robinson [EMAIL PROTECTED] wrote:
The attached patch is my second cut at reading
stdout and stderr of the command virRun kicks
off. There is no hard limit to the amount of
data we read now, and we use a poll loop to
avoid any possible full buffer issues.
If stdout or stderr had any
Attached are the python bindings for domain events as previously submitted:
https://www.redhat.com/archives/libvir-list/2008-October/msg00707.html
https://www.redhat.com/archives/libvir-list/2008-October/msg00668.html
I have resolved most of the issues Daniel V. commented on
I also addressed a
Hi,
I am using virt-viewer to view an Windows VM. However, I cannot get
fullscreen with virt-viewer when using menu View - Fullscreen. When I
did that, nothing happenes. Is that a bug?
The version of virt-viewer is 0.0.3
Thanks,
J
--
Libvir-list mailing list
Libvir-list@redhat.com
32 matches
Mail list logo
