[libvirt] [PATCH] add the check of memory size in xenXMDriver for setmem of Xen domain

2008-10-31 Thread S.Sakamoto
Hi, I make the patch. This patch adds the check of memory size in xenXMDriver, to handle the xenStoreDriver error when the set value by setmem(setmaxmem) is 4096-65535 definitely. Thanks, Shigeki Sakamoto. Index: src/xm_internal.c

Re: [libvirt] [PATCH] add the check of memory size in xenXMDriver forsetmem of Xen domain

2008-10-31 Thread Atsushi SAKAI
Hi, Daniel, This patch itself is OK. But I also think MIN_XEN_GUEST_SIZE should be defined in xen_unified.h not src/internal.h. Since this variable is Xen specific. How do you think? Thanks Atsushi SAKAI S.Sakamoto [EMAIL PROTECTED] wrote: Hi, I make the patch. This patch adds the

Re: [libvirt] PATCH: don't print uninitialized integer in diagnostic

2008-10-31 Thread Daniel Veillard
On Thu, Oct 30, 2008 at 05:26:21PM +0100, Jim Meyering wrote: In adding a test of the vcpu cpuset parsing code (another patch coming separately), I noticed a bogus diagnostic: virsh --connect test:///default dumpxml 1 xml sed s/vcpu/vcpu cpuset='aaa'/ xml xml-invalid ./virsh

Re: [libvirt] [PATCH] * tests/cpuset: New script. Test for today's fix.

2008-10-31 Thread Daniel Veillard
On Thu, Oct 30, 2008 at 05:43:18PM +0100, Jim Meyering wrote: From c0beb0ed6dd3d392b11161c565d7dfd52ed2aceb Mon Sep 17 00:00:00 2001 From: Jim Meyering [EMAIL PROTECTED] Date: Mon, 2 Jun 2008 11:54:34 +0200 Subject: [PATCH 1/2] * tests/cpuset: New script. Test for today's fix. *

Re: [libvirt] [PATCH] add the check of memory size in xenXMDriver forsetmem of Xen domain

2008-10-31 Thread Daniel P. Berrange
On Fri, Oct 31, 2008 at 05:34:24PM +0900, Atsushi SAKAI wrote: Hi, Daniel, This patch itself is OK. But I also think MIN_XEN_GUEST_SIZE should be defined in xen_unified.h not src/internal.h. Since this variable is Xen specific. Yes, I believe one of my patches from yesterday moves this.

Re: [libvirt] Domain Events Python Bindings (Round 2)

2008-10-31 Thread Daniel Veillard
On Thu, Oct 30, 2008 at 05:03:28PM -0400, Ben Guthro wrote: Attached are the python bindings for domain events as previously submitted: https://www.redhat.com/archives/libvir-list/2008-October/msg00707.html https://www.redhat.com/archives/libvir-list/2008-October/msg00668.html I have

Re: [libvirt] [PATCH]: Update ruby-libvirt migrate binding to use rb_scan_args

2008-10-31 Thread Chris Lalancette
Chris Lalancette wrote: It's really not a good idea to hand parse variable number of args to a ruby binding, like I implemented for the migrate method. Convert this to use rb_scan_args, which is the proper way to do it, and matches all of the other variable argument implementations in the

RE: [libvirt] Domain Events Python Bindings (Round 2)

2008-10-31 Thread Ben Guthro
Hmmm... I also realized that I never added the example to the top level Makefile.am EXTRA_DIST. I imagine that would need to be resolved to address adding it to the RPM Would you like me to take a look at this, or will this be something you'll resolve as part of the RPM multlib cleanup? Ben

[libvirt] [PATCH]: Allow arbitrary paths to virStorageVolLookupByPath

2008-10-31 Thread Chris Lalancette
In ovirt, we have to scan iSCSI LUN's for LVM storage when they are first added to the database. To do this, we do roughly the following: iscsi_pool = libvirt.define_and_start_iscsi_pool(/dev/disk/by-id) iscsi_pool.add_luns_to_db logical = conn.discover_storage_pool_sources(logical) for each

Re: [libvirt] [PATCH]: Allow arbitrary paths to virStorageVolLookupByPath

2008-10-31 Thread Chris Lalancette
Daniel P. Berrange wrote: Personally, I think those are bad semantics for virStorageBackendStablePath; assuming it succeeds, you should always be able to know that you have a copy, regardless of whether the copy is the same as the original. Should I change virStorageBackendStablePath to those

Re: [libvirt] [PATCH]: Allow arbitrary paths to virStorageVolLookupByPath

2008-10-31 Thread Daniel P. Berrange
On Fri, Oct 31, 2008 at 12:26:17PM +0100, Chris Lalancette wrote: Daniel P. Berrange wrote: On Fri, Oct 31, 2008 at 12:04:34PM +0100, Chris Lalancette wrote: Index: src/storage_driver.c === RCS file:

Re: [libvirt] PATCH: 8/11: Make better use of linker scripts

2008-10-31 Thread Daniel Veillard
On Thu, Oct 30, 2008 at 04:56:30PM +, Daniel P. Berrange wrote: On Thu, Oct 30, 2008 at 01:41:14PM +, Daniel P. Berrange wrote: The libvirt.so file currently whitelists all the symbols in our public API. libvirtd and virsh, however, also want to use a bunch of our so called

RE: [libvirt] Domain Events Python Bindings (Round 2)

2008-10-31 Thread Ben Guthro
I just took a look over the commit here: http://git.et.redhat.com/?p=libvirt.git;a=commit;h=471b765ae0fc3efd721d6dbd3c82539880933c0b It appears that you may have missed adding the new file python/virConnect.py This file is critical to this patch, as it controls proper callback registration, and

Re: [libvirt] [PATCH] add the check of memory size in xenXMDriver forsetmem of Xen domain

2008-10-31 Thread Daniel Veillard
On Fri, Oct 31, 2008 at 05:34:24PM +0900, Atsushi SAKAI wrote: Hi, Daniel, This patch itself is OK. Yes except for the extra ; after the if making it return -1 all the time, but once fixed sure :-) Patch applied and commited [...] +if (memory 1024 * MIN_XEN_GUEST_SIZE);

Re: [libvirt] PATCH: 10/11: Build stateful drivers into libvirtd instead of libvirt.so

2008-10-31 Thread Daniel Veillard
On Thu, Oct 30, 2008 at 01:42:19PM +, Daniel P. Berrange wrote: This patches changes the way some of the drivers are built. Specifically the stateful drivers (QEMU, LXC, Network and Storage) are no longer compiled into libvirt.so Instead they are linked directly to the libvirt binary. They

Re: [libvirt] Domain Events Python Bindings (Round 2)

2008-10-31 Thread Daniel Veillard
On Fri, Oct 31, 2008 at 07:44:09AM -0400, Ben Guthro wrote: I just took a look over the commit here: http://git.et.redhat.com/?p=libvirt.git;a=commit;h=471b765ae0fc3efd721d6dbd3c82539880933c0b It appears that you may have missed adding the new file python/virConnect.py This file is