[libvirt] [PATCH] Allow rpm to build without uml

2008-11-20 Thread Ben Guthro
Allow to build minimal rpm without uml diff --git a/libvirt.spec.in b/libvirt.spec.in index cfd4a66..91af843 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -10,6 +10,7 @@ %define with_polkit0%{!?_without_polkit:0} %define with_python0%{!?_without_python:1} %define with_libvirtd 0

[libvirt] [PATCH] fix python events

2008-11-20 Thread David Lively
This patch gets python events working again after upstream changes, and make the test implementation properly clean up after itself and implement the new EventImpl API properly. Note that the Python RemoveHandle and RemoveTimeout implementations should return the opaque object registered by the co

[libvirt] [PATCH] fix EventImpl-related error paths in remote driver

2008-11-20 Thread David Lively
This patch makes the remote driver behave properly in the face of: (a) no registered EventImpl, or (b) an EventImpl that returns failure from AddHandle/Timeout In both cases, we now cleanup properly (rather than always passing bogus values to virEventRemoveHandle/Timeout) and fail attempts to

[libvirt] [PATCH] fix libvirtd crash in qemu driver

2008-11-20 Thread David Lively
I noticed that the following sequence of events would crash libvirtd when using the qemu driver: (1) establish a connection that successfully registers for domain events (either of the event-test programs will do, though the python one is currently broken -- another patch on the way

Re: [libvirt] Relax requirement of bridge source device

2008-11-20 Thread Jim Fehlig
Daniel P. Berrange wrote: > On Wed, Nov 19, 2008 at 11:20:08PM -0700, Jim Fehlig wrote: > >> Hi All, >> >> I wanted to get folks thoughts on relaxing the requirement for bridge >> source device in network interface of domain XML, e.g. allowing >> >> >> >> >> >> Currently, virDomai

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-20 Thread Ben Guthro
New xen events patch attached. This removes a couple unnecessary changes from my prior patch, but remains functionally the same as the last version. This will emit the following events for Xen: STARTED STOPPED ADDED REMOVED diff --git a/configure.in b/configure.in index 21931a1..a38592a 100644 -

[libvirt] [PATCH] Fix UML syntax

2008-11-20 Thread Ben Guthro
various changes to fix make syntax-check succeed with new UML driver diff --git a/po/POTFILES.in b/po/POTFILES.in index 3f8fdd2..d9f3abe 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -28,6 +28,8 @@ src/storage_backend_logical.c src/storage_conf.c src/storage_driver.c src/test.c +src/uml_co

Re: [libvirt] PATCH: 9/12: HAL/DevitKit node device impl

2008-11-20 Thread Daniel P. Berrange
On Fri, Nov 14, 2008 at 02:57:09PM -0500, David Lively wrote: > > > > +(void)get_int_prop(ctx, udi, "pci.vendor_id", (int > > > *)&d->pci_dev.vendor); > > > +if (get_str_prop(ctx, udi, "pci.vendor", &d->pci_dev.vendor_name) != > > > 0) > > > +(void)get_str_prop(ctx, udi, "info.ve

Re: [libvirt] --with-xen=foo

2008-11-20 Thread Daniel P. Berrange
On Thu, Nov 20, 2008 at 01:27:40PM -0500, Ben Guthro wrote: > I tried this...didn't seem to help: Sorry, not paying close enough attention. In fact this file was built in an earlier module. Find the line which says libvirt_driver_la_SOURCES = \

Re: [libvirt] --with-xen=foo

2008-11-20 Thread Ben Guthro
I tried this...didn't seem to help: diff --git a/src/Makefile.am b/src/Makefile.am index 3520130..6a38200 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -279,7 +279,7 @@ libvirt_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libvirt_sym.version \ $(COVERAGE_CFLAGS:-f%=-

Re: [libvirt] PATCH: 7/7: Misc fixes

2008-11-20 Thread Daniel P. Berrange
On Thu, Nov 20, 2008 at 06:14:53PM +, Mark McLoughlin wrote: > On Thu, 2008-11-20 at 18:03 +, Daniel P. Berrange wrote: > > > case VIR_NODE_DEV_CAP_STORAGE: > > +virBufferVSprintf(&buf, "%s\n", > ^ > > Mi

Re: [libvirt] PATCH: 8/12:Interal driver API for node devices

2008-11-20 Thread Daniel P. Berrange
On Fri, Nov 14, 2008 at 01:20:22PM +, Mark McLoughlin wrote: > On Thu, 2008-11-13 at 17:31 +, Daniel P. Berrange wrote: > > This is the basic internal driver support code for the node device APIs. > > The actual registration of the drivers was pushed to a later patch to > > allow this to co

Re: [libvirt] PATCH: 7/7: Misc fixes

2008-11-20 Thread Mark McLoughlin
On Thu, 2008-11-20 at 18:03 +, Daniel P. Berrange wrote: > case VIR_NODE_DEV_CAP_STORAGE: > +virBufferVSprintf(&buf, "%s\n", ^ Minore tpyo hero Cheers, Mark. -- Libvir-list mailing list Libvir-list@redhat.c

Re: [libvirt] PATCH: 3/7: Main HAL & DeviceKit impl

2008-11-20 Thread Mark McLoughlin
Hi Dan, All looks good in general - just want to call out the couple of devkit leaks again. No problem leaving them 'til later to fix, of course. Cheers, Mark. On Thu, 2008-11-20 at 17:55 +, Daniel P. Berrange wrote: > + > +static void dev_create(void *_dkdev, void *_dkclient ATTRIBUTE_UNUS

Re: [libvirt] PATCH: 0/7: Final node device patches to be committed

2008-11-20 Thread Daniel P. Berrange
On Thu, Nov 20, 2008 at 05:49:50PM +, Daniel P. Berrange wrote: > FYI, this is a repost of the final node device patches I intend to > commit tomorrow. There's a few changes based on Mark's feedback > which I'll note against each patch... As an example, here is the complete output from a box

Re: [libvirt] PATCH: 7/7: Misc fixes

2008-11-20 Thread Daniel P. Berrange
This patch contains a couple of misc fixes. HAL has separate 'block' and 'storage' and 'volume' capabilities. Actual devices get the 'block' and 'storage' capability, while partitions get the 'block' and 'volume' capability. We have no need to expose partitions in this API, since we already have

Re: [libvirt] PATCH: 6/7: Python binding

2008-11-20 Thread Daniel P. Berrange
This is the python API, again just changed to cope with removal of the ByCaps API calls Daniel diff -r 105e73557ef8 python/generator.py --- a/python/generator.py Thu Nov 20 16:27:06 2008 + +++ b/python/generator.py Thu Nov 20 16:43:08 2008 + @@ -260,6 +260,11 @@ 'const v

Re: [libvirt] PATCH: 5/7: virsh interface

2008-11-20 Thread Daniel P. Berrange
This provides the virsh binding. The main changes is to the list method to not call ByCaps anymore. And I've actually really renamed the commands this time ! Daniel diff -r 9a1d48518cac src/virsh.c --- a/src/virsh.c Thu Nov 20 16:26:13 2008 + +++ b/src/virsh.c Thu Nov 20 16:43:40

Re: [libvirt] PATCH: 4/7: Remove driver API calls

2008-11-20 Thread Daniel P. Berrange
This provides the remote driver implementation for node device APIs This is basically just fixing up to add the optional 'cap' arg to the List methods, and remove the Create/Destroy/ByCap methods Daniel diff -r acc38454f32d qemud/remote.c --- a/qemud/remote.cThu Nov 20 16:16:37 2008 + ++

Re: [libvirt] PATCH: 3/7: Main HAL & DeviceKit impl

2008-11-20 Thread Daniel P. Berrange
The internal impl for HAL and devicekit Changes since last time - Fix broken logic in devicekit NIC interfac checks - Disable DeviceKit by default Daniel diff -r c51d78efb84a configure.in --- a/configure.in Thu Nov 20 17:43:18 2008 + +++ b/configure.in Thu Nov 20 17:47:42 2008

Re: [libvirt] PATCH: 2/7: Internal API framework

2008-11-20 Thread Daniel P. Berrange
This is primarily the internal XML handling for node devices Changes since last time - Remove the duplicate mac address information - Remove unused 'originating_device' Daniel diff -r 28bfbe4fa22f src/Makefile.am --- a/src/Makefile.am Thu Nov 20 17:37:11 2008 + +++ b/src/Makefile.am

Re: [libvirt] PATCH: 1/7: Public API

2008-11-20 Thread Daniel P. Berrange
This patch contains the public API for node devices. Changes since last post are - Remove the ByCap methods - the main list method now takes an optionally NULL, cap arguent. This simplified virsh usage later too which is nice - Change VIR_FROM_DEVMONITOR to VIR_FROM_NODEDEV to match rest of

[libvirt] PATCH: 0/7: Final node device patches to be committed

2008-11-20 Thread Daniel P. Berrange
FYI, this is a repost of the final node device patches I intend to commit tomorrow. There's a few changes based on Mark's feedback which I'll note against each patch... Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt

Re: [libvirt] make install doesn't install to /usr/lib64

2008-11-20 Thread Daniel Berrange
On Thu, Nov 20, 2008 at 07:32:56PM +0200, Kenneth Nagin wrote: > > I am working on a x86_64 machine. I expected 'make install' to install to > libvirt.so to /usr/lib64. But it installs to /usr/lib. Is this a bug or > is it the expected behavior? That is a distro specific policy, whcih varies f

[libvirt] make install doesn't install to /usr/lib64

2008-11-20 Thread Kenneth Nagin
I am working on a x86_64 machine. I expected 'make install' to install to libvirt.so to /usr/lib64. But it installs to /usr/lib. Is this a bug or is it the expected behavior? Kenneth Nagin -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] --with-xen=foo

2008-11-20 Thread Daniel P. Berrange
On Thu, Nov 20, 2008 at 10:46:25AM -0500, Ben Guthro wrote: > I did a git bisect, and as predicted, the culprit seems to be > > aac3e1ab15645f1ff491b140ddb249b01397bebd is first bad commit > commit aac3e1ab15645f1ff491b140ddb249b01397bebd > Author: Daniel P. Berrange <[EMAIL PROTECTED

Re: [libvirt] --with-xen=foo

2008-11-20 Thread Ben Guthro
I did a git bisect, and as predicted, the culprit seems to be aac3e1ab15645f1ff491b140ddb249b01397bebd is first bad commit commit aac3e1ab15645f1ff491b140ddb249b01397bebd Author: Daniel P. Berrange <[EMAIL PROTECTED]> Date: Mon Nov 17 10:43:30 2008 +

Re: [libvirt] libvirt equivalent config for a kvm command line

2008-11-20 Thread Rajkumar S
On Thu, Nov 20, 2008 at 8:01 PM, Daniel P. Berrange <[EMAIL PROTECTED]> wrote: > My 2nd bet would be the serial port - worth removing that from the config > because I know there's been QEMU bugs with serial ports before. Serial could be the issue, I have other vms (normal linux and freebsd) runnin

[libvirt] --with-xen=foo

2008-11-20 Thread Ben Guthro
So, when I merged my changes up yesterday to some of the developments going on, it would seem that one of the changesets I pulled in had a bit of a reduction in configure flexibility. I'm not yet sure what changeset caused it...but I used to be able to specify an external xen tree with the foll

Re: [libvirt] libvirt equivalent config for a kvm command line

2008-11-20 Thread Rajkumar S
On Thu, Nov 20, 2008 at 7:57 PM, Cole Robinson <[EMAIL PROTECTED]> wrote: > If that isn't the issue, I'd say just boot the new kvm command directly, > and remove pieces to see if there is a blatant culprit: ex. revert the > -drive line to use -hda, try with 0/1/2 nics, etc. I will try this, thank

Re: [libvirt] libvirt equivalent config for a kvm command line

2008-11-20 Thread Daniel P. Berrange
On Thu, Nov 20, 2008 at 09:27:58AM -0500, Cole Robinson wrote: > Rajkumar S wrote: > > Hi, > > > > I had been running kvm in a previous version of Ubuntu with the > > following command line: > > > > /usr/bin/kvm > > -hda /mnt/kvm/vm-images-work/nanobsd.img > > -net nic,vlan=26,macaddr=52:54:00:1

Re: [libvirt] libvirt equivalent config for a kvm command line

2008-11-20 Thread Cole Robinson
Rajkumar S wrote: > Hi, > > I had been running kvm in a previous version of Ubuntu with the > following command line: > > /usr/bin/kvm > -hda /mnt/kvm/vm-images-work/nanobsd.img > -net nic,vlan=26,macaddr=52:54:00:12:34:26 -net tap,vlan=26,ifname=tap26 > -net nic,vlan=27,macaddr=52:54:00:12:34:2

[libvirt] libvirt equivalent config for a kvm command line

2008-11-20 Thread Rajkumar S
Hi, I had been running kvm in a previous version of Ubuntu with the following command line: /usr/bin/kvm -hda /mnt/kvm/vm-images-work/nanobsd.img -net nic,vlan=26,macaddr=52:54:00:12:34:26 -net tap,vlan=26,ifname=tap26 -net nic,vlan=27,macaddr=52:54:00:12:34:27 -net tap,vlan=27,ifname=tap27 -net

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-20 Thread Ben Guthro
I see a couple of issues with this patch that I am working out now Apologies for premature submission. (Thats what I get for submitting at the end of the day) New patch to follow shortly Ben Guthro wrote on 11/19/2008 05:47 PM: > I finally was able to get back to this patch. > > Attached is a n

Re: [libvirt] SolidICE integration

2008-11-20 Thread Daniel P. Berrange
On Wed, Nov 19, 2008 at 01:50:09PM -0500, Shahar Frank wrote: > Hi All, here is an initial version of the operations required for SolidICE > and the proposed high level interface. > > I would like to discuss how to map it to libvirt calls and what libvirt > calls are missing. > > Thanks, > > Sha

Re: [libvirt] Relax requirement of bridge source device

2008-11-20 Thread Daniel P. Berrange
On Wed, Nov 19, 2008 at 11:20:08PM -0700, Jim Fehlig wrote: > Hi All, > > I wanted to get folks thoughts on relaxing the requirement for bridge > source device in network interface of domain XML, e.g. allowing > > > > > > Currently, virDomainNetDefParseXML() in src/domain_conf.c w