David Lively <[EMAIL PROTECTED]> wrote:
> On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote:
>> No big deal, but there are several debug printf uses here that look
>> like they try to print NULL pointers upon memory allocation failure.
>> It's ok with glibc's printf of course, but not for other
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> On Fri, Nov 21, 2008 at 11:16:18AM +0100, Jim Meyering wrote:
>> Actually, this was the first step.
>> This tiny script merely invokes all commands blindly,
>> solely to get test coverage, even if they (as most do) fail.
>
> It at least verifies tha
Hi,
I just ran across these oddities when using a bit more libvirt+xen:
1.) virsh setmaxmem:
On a running domain:
# virsh setmaxmem domain 256000
completes but virsh dumpxml as well as the config.sxp still shows the
old amount of memory. Looks as the set_maxmem hypercall simply gets
ignor
On Fri, Nov 21, 2008 at 03:27:49PM -0500, David Lively wrote:
> On Fri, 2008-11-21 at 14:49 +0100, Daniel Veillard wrote:
> > On Wed, Nov 19, 2008 at 11:22:31AM -0500, David Lively wrote:
>
> > note that libxml2 that we rely on has a fully ported mutex basic API
> > in libxml/threads.h
> >
> ..
On Fri, 2008-11-21 at 14:49 +0100, Daniel Veillard wrote:
> On Wed, Nov 19, 2008 at 11:22:31AM -0500, David Lively wrote:
> > On Wed, 2008-11-19 at 10:35 -0500, David Lively wrote:
> > > The patch already synchronizes operations using virConnect objects with
> > > each other. To avoid making illeg
On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote:
> No big deal, but there are several debug printf uses here that look
> like they try to print NULL pointers upon memory allocation failure.
> It's ok with glibc's printf of course, but not for others.
You're right. Attached patch fixes those
I have integrated your changes, and moved this bit referenced below, so it
works with my setup. Could you please test with yours, and make sure I didn't
break anything?
configure.in | 13
examples/domain-events/events-c/event-test.c |2
include/libvirt/virt
On Fri, Nov 21, 2008 at 01:56:16PM -0500, Ben Guthro wrote:
> I think I found the culprit of this:
>
> Daniel P. Berrange wrote on 11/21/2008 11:13 AM:
> > - Allocate capabilities info before initializing inotify driver
> >because loading XM config files /etc/xen requires this
> >
> ...
> >
I think I found the culprit of this:
Daniel P. Berrange wrote on 11/21/2008 11:13 AM:
> - Allocate capabilities info before initializing inotify driver
>because loading XM config files /etc/xen requires this
>
...
> -if (!(priv->caps = xenHypervisorMakeCapabilities(conn))) {
> -D
On Fri, Nov 21, 2008 at 01:06:08PM -0500, Ben Guthro wrote:
> I tested these changes, and seem to be having some issues opening the xen
> driver in a post 3.0.3 codepath:
>
> DEBUG: xen_unified.c: xenUnifiedOpen (Trying hypervisor sub-driver)
> DEBUG: xen_unified.c: xenUnifiedOpen (Activated hype
I tested these changes, and seem to be having some issues opening the xen
driver in a post 3.0.3 codepath:
DEBUG: xen_unified.c: xenUnifiedOpen (Trying hypervisor sub-driver)
DEBUG: xen_unified.c: xenUnifiedOpen (Activated hypervisor sub-driver)
libvir: Xen Daemon error : internal error failed to
Okay, *this* one seems to be a complete fix.
Dave
tests/Makefile.am | 29 ++---
1 file changed, 22 insertions(+), 7 deletions(-)
On Fri, 2008-11-21 at 12:35 -0500, David Lively wrote:
> Hold off on considering this quite yet. I don't think it's a complete
> fix. I'll
Hold off on considering this quite yet. I don't think it's a complete
fix. I'll followup with a complete one soon.
Dave
On Fri, 2008-11-21 at 11:04 -0500, David Lively wrote:
> The last change to tests/Makefile.am broke the build when --without-xen
> is specified. This patch fixes it ...
>
>
David Lively <[EMAIL PROTECTED]> wrote:
...
Hi David,
No big deal, but there are several debug printf uses here that look
like they try to print NULL pointers upon memory allocation failure.
It's ok with glibc's printf of course, but not for others.
> commit efd5098e9a834562cddbf1618e36eb43c272f
On Thu, Nov 20, 2008 at 03:49:07PM -0500, Ben Guthro wrote:
> New xen events patch attached. This removes a couple unnecessary
> changes from my prior patch, but remains functionally the same as
> the last version.
>
> This will emit the following events for Xen:
>
> STARTED
> STOPPED
> ADDED
>
The last change to tests/Makefile.am broke the build when --without-xen
is specified. This patch fixes it ...
Dave
tests/Makefile.am |9 +
1 file changed, 9 insertions(+)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index d2d1254..cc159e0 100644
--- a/tests/Makefile.am
+++
On Fri, Nov 21, 2008 at 02:24:40PM +0100, Jim Meyering wrote:
> Back on October 28, I mistakenly added a binary.
> This adds the requisite .cvsignore entry and
> updates the corresponding .gitignore file as well
> as two stale ones.
sure, +1
Daniel
--
Daniel Veillard | libxml Gnome XML X
Doh! ... attached :-)
On Fri, 2008-11-21 at 10:30 +0100, Jim Meyering wrote:
> David Lively <[EMAIL PROTECTED]> wrote:
> > This patch gets python events working again after upstream changes, and
> > make the test implementation properly clean up after itself and
> > implement the new EventImpl AP
hmm...It looks like this is not the only problem.
If I do a clean build with the following options:
./autogen.sh --enable-compile-warnings=error \
--with-xen \
--without-uml \
On Wed, Nov 19, 2008 at 11:22:31AM -0500, David Lively wrote:
> On Wed, 2008-11-19 at 10:35 -0500, David Lively wrote:
> > The patch already synchronizes operations using virConnect objects with
> > each other. To avoid making illegal EventImpl callbacks from Java for
> > the current libvirt, I ha
Back on October 28, I mistakenly added a binary.
This adds the requisite .cvsignore entry and
updates the corresponding .gitignore file as well
as two stale ones.
>From 30a853d37fc2102a7e4009b93867209e318014a1 Mon Sep 17 00:00:00 2001
From: Jim Meyering <[EMAIL PROTECTED]>
Date: Fri, 21 Nov 2008
Daniel Veillard <[EMAIL PROTECTED]> wrote:
> On Fri, Nov 21, 2008 at 10:27:55AM +0100, Jim Meyering wrote:
>> Jim Meyering <[EMAIL PROTECTED]> wrote:
>> > This is mainly just reorganization and factorization, with an eye
>> > towards making it easier to add more tests in virshtest.c later.
>> >
>>
On Thu, Nov 20, 2008 at 05:49:50PM +, Daniel P. Berrange wrote:
> FYI, this is a repost of the final node device patches I intend to
> commit tomorrow. There's a few changes based on Mark's feedback
> which I'll note against each patch...
This series is now fully committed to CVS. Many thanks
On Fri, Nov 21, 2008 at 10:27:55AM +0100, Jim Meyering wrote:
> Jim Meyering <[EMAIL PROTECTED]> wrote:
> > This is mainly just reorganization and factorization, with an eye
> > towards making it easier to add more tests in virshtest.c later.
> >
> >>From 21352a07b073d52bcd3c442c76d7fb985aeef845 Mo
Oh - sorry for not getting back to you about this.
Yes - it does solve it for me.
+1
-Original Message-
From: Daniel P. Berrange [mailto:[EMAIL PROTECTED]
Sent: Fri 11/21/2008 5:12 AM
To: Ben Guthro
Cc: libvir-list
Subject: Re: [libvirt] --with-xen=foo
On Thu, Nov 20, 2008 at 06:30:38P
On Fri, Nov 21, 2008 at 12:06:30PM +0100, Jim Meyering wrote:
> "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> > On Fri, Nov 21, 2008 at 11:13:03AM +0100, Jim Meyering wrote:
> >> I wanted help SYNOPSIS output that was regular enough to parse.
> >
> >> static const vshCmdInfo info_network_creat
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote:
> On Fri, Nov 21, 2008 at 11:13:03AM +0100, Jim Meyering wrote:
>> I wanted help SYNOPSIS output that was regular enough to parse.
>
>> static const vshCmdInfo info_network_create[] = {
>> -{"syntax", "create a network from an XML "},
>> +{"s
On Thu, Nov 20, 2008 at 05:58:16PM +, Daniel P. Berrange wrote:
> This is the python API, again just changed to cope with removal of the
> ByCaps API calls
looks fine,
[...]
> diff -r 105e73557ef8 python/libvir.c
> --- a/python/libvir.c Thu Nov 20 16:27:06 2008 +
> +++ b/python/libvir.c
On Thu, Nov 20, 2008 at 05:57:37PM +, Daniel P. Berrange wrote:
> This provides the virsh binding. The main changes is to the
> list method to not call ByCaps anymore. And I've actually
> really renamed the commands this time !
okay :-)
+1
Daniel
--
Daniel Veillard | libxml Gnome X
On Thu, Nov 20, 2008 at 05:56:34PM +, Daniel P. Berrange wrote:
> This provides the remote driver implementation for node device APIs
>
> This is basically just fixing up to add the optional 'cap' arg
> to the List methods, and remove the Create/Destroy/ByCap methods
okay, +1
Daniel
--
D
On Thu, Nov 20, 2008 at 05:53:43PM +, Daniel P. Berrange wrote:
> This is primarily the internal XML handling for node devices
> Changes since last time
>
> - Remove the duplicate mac address information
> - Remove unused 'originating_device'
okay, let's push,
Daniel
--
Daniel Veilla
On Fri, Nov 21, 2008 at 11:16:18AM +0100, Jim Meyering wrote:
> Actually, this was the first step.
> This tiny script merely invokes all commands blindly,
> solely to get test coverage, even if they (as most do) fail.
It at least verifies that the commands don't crash or leak
memory in the error p
On Fri, Nov 21, 2008 at 11:13:03AM +0100, Jim Meyering wrote:
> I wanted help SYNOPSIS output that was regular enough to parse.
> static const vshCmdInfo info_network_create[] = {
> -{"syntax", "create a network from an XML "},
> +{"syntax", "net-create "},
I'm kind of wondering why we
On Thu, Nov 20, 2008 at 04:55:44PM -0500, David Lively wrote:
> This patch makes the remote driver behave properly in the face of:
> (a) no registered EventImpl, or
> (b) an EventImpl that returns failure from AddHandle/Timeout
>
> In both cases, we now cleanup properly (rather than always pas
On Thu, Nov 20, 2008 at 04:48:46PM -0500, David Lively wrote:
> I noticed that the following sequence of events would crash libvirtd
> when using the qemu driver:
> (1) establish a connection that successfully registers for domain
> events (either of the event-test programs will do, thoug
Actually, this was the first step.
This tiny script merely invokes all commands blindly,
solely to get test coverage, even if they (as most do) fail.
Additional tests will be smarter about providing sensible arguments.
>From 058681eab07936f4ecbb1ff514528eb921d27074 Mon Sep 17 00:00:00 2001
From: J
I wanted help SYNOPSIS output that was regular enough to parse.
Enforcing/correcting the following is the first step:
>From fa58b801ea80f52a10d48ab75a359ffe06c4be40 Mon Sep 17 00:00:00 2001
From: Jim Meyering <[EMAIL PROTECTED]>
Date: Fri, 21 Nov 2008 10:58:36 +0100
Subject: [PATCH] tests: new tes
On Thu, Nov 20, 2008 at 06:30:38PM +, Daniel P. Berrange wrote:
> On Thu, Nov 20, 2008 at 01:27:40PM -0500, Ben Guthro wrote:
> > I tried this...didn't seem to help:
>
> Sorry, not paying close enough attention. In fact this file was
> built in an earlier module. Find the line which says
>
>
On Thu, Nov 20, 2008 at 05:25:47PM -0500, Ben Guthro wrote:
> Allow to build minimal rpm without uml
Thanks, I've committed this.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
On Thu, Nov 20, 2008 at 05:51:39PM +, Daniel P. Berrange wrote:
> This patch contains the public API for node devices. Changes since last
> post are
>
> - Remove the ByCap methods - the main list method now takes an optionally
>NULL, cap arguent. This simplified virsh usage later too whic
On Thu, Nov 20, 2008 at 03:04:40PM -0500, Ben Guthro wrote:
> various changes to fix make syntax-check succeed with new UML driver
Heh, I was about to submit the exact same patch, so commiting it now :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
[EMAIL
David Lively <[EMAIL PROTECTED]> wrote:
> This patch gets python events working again after upstream changes, and
> make the test implementation properly clean up after itself and
> implement the new EventImpl API properly.
>
> Note that the Python RemoveHandle and RemoveTimeout implementations
> s
Jim Meyering <[EMAIL PROTECTED]> wrote:
> This is mainly just reorganization and factorization, with an eye
> towards making it easier to add more tests in virshtest.c later.
>
>>From 21352a07b073d52bcd3c442c76d7fb985aeef845 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <[EMAIL PROTECTED]>
> Date:
This is mainly just reorganization and factorization, with an eye
towards making it easier to add more tests in virshtest.c later.
>From 21352a07b073d52bcd3c442c76d7fb985aeef845 Mon Sep 17 00:00:00 2001
From: Jim Meyering <[EMAIL PROTECTED]>
Date: Thu, 20 Nov 2008 20:35:57 +0100
Subject: [PATCH] M
44 matches
Mail list logo
