Re: [libvirt] PATCH: allow to set nvcpus = 0

2008-11-24 Thread Daniel P. Berrange
On Wed, Nov 19, 2008 at 07:59:27PM +0300, Evgeniy Sokolov wrote: > > >On Mon, Nov 17, 2008 at 06:44:07PM +0300, Evgeniy Sokolov wrote: > >>OpenVZ uses all CPUs available in system > >>- by default (number of CPUs did not set) > >>- number of CPUs = 0 > >> > >>Currenty, libvirt don't allow to set n

Re: [libvirt] [PATCH] fix python events

2008-11-24 Thread Daniel P. Berrange
On Mon, Nov 24, 2008 at 11:44:15AM -0500, David Lively wrote: > On Mon, 2008-11-24 at 17:30 +0100, Jim Meyering wrote: > > David Lively <[EMAIL PROTECTED]> wrote: > > > On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote: > > >> David Lively <[EMAIL PROTECTED]> wrote: > > >> > On Fri, 2008-11-21

Re: [libvirt] [PATCH] libvirt.c: fix virStateActive return value; document ...

2008-11-24 Thread Daniel P. Berrange
On Mon, Nov 24, 2008 at 06:05:37PM +0100, Jim Meyering wrote: > "Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: > ... > >> + * Run each virtualization driver's "active" method. > >> + * > >> + * Return 0 if successful, -1 upon error. > >> + */ > >> int virStateActive(void) { > >> int i, ret =

Re: [libvirt] [PATCH] fix --without-xen build

2008-11-24 Thread Daniel P. Berrange
On Mon, Nov 24, 2008 at 11:46:56AM -0500, Ben Guthro wrote: > This fixed it in our environment Great, committed this fix now. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: h

Re: [libvirt] [PATCH] fix python events

2008-11-24 Thread David Lively
On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote: > David Lively <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: > > I'm printing the (user-supplied) object names to help in debugging > > misbehaving python EventImpls (since there's no static type checking

Re: [libvirt] [PATCH] libvirt.c: fix virStateActive return value; document ...

2008-11-24 Thread Jim Meyering
"Daniel P. Berrange" <[EMAIL PROTECTED]> wrote: ... >> + * Run each virtualization driver's "active" method. >> + * >> + * Return 0 if successful, -1 upon error. >> + */ >> int virStateActive(void) { >> int i, ret = 0; >> >> for (i = 0 ; i < virStateDriverTabCount ; i++) { >> if

Re: [libvirt] [PATCH] libvirt.c: fix virStateActive return value; document ...

2008-11-24 Thread Daniel Veillard
On Mon, Nov 24, 2008 at 04:31:28PM +, Daniel P. Berrange wrote: > On Mon, Nov 24, 2008 at 03:54:30PM +0100, Jim Meyering wrote: > > The s/1/-1/ fix induces no semantic change, since the sole use > > of virStateActive tests solely for nonzero. > > > > >From 4bc9713207a2ed6b101e2067f7bba82d1df45

[libvirt] PATCH: Fix node device build on mingw32

2008-11-24 Thread Daniel P. Berrange
The node device XML configuration handling routines contain a struct member called 'interface'. This seems to clash with a some typedef or function in the Win32 header files, causing horrific compile failure. This patch simply renames 'interface' to 'ifname'. Index: src/node_device_conf.c

Re: [libvirt] [PATCH] fix --without-xen build

2008-11-24 Thread Ben Guthro
This fixed it in our environment ACK Daniel P. Berrange wrote on 11/24/2008 10:50 AM: > On Fri, Nov 21, 2008 at 12:46:59PM -0500, David Lively wrote: >> Okay, *this* one seems to be a complete fix. > > Not quite. The ENABLE_XEN_TESTS conditional is only set when not > running on a live Xen kerne

Re: [libvirt] [PATCH] fix python events

2008-11-24 Thread David Lively
On Mon, 2008-11-24 at 17:30 +0100, Jim Meyering wrote: > David Lively <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote: > >> David Lively <[EMAIL PROTECTED]> wrote: > >> > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: > >> > I'm printing the (user-suppli

Re: [libvirt] PATCH: Autostart for Xen domains < 3.0.4

2008-11-24 Thread Daniel Veillard
On Mon, Nov 24, 2008 at 04:15:31PM +, Daniel P. Berrange wrote: > The old 'xm' driver does not currently implement the autostart feature > for domains managed via /etc/xen. This patche addresses that limitation > by making it create the symlinks in /etc/xen/auto as expected by the > existing 'x

Re: [libvirt] [PATCH] fix python events

2008-11-24 Thread Daniel P. Berrange
On Fri, Nov 21, 2008 at 02:14:57PM -0500, David Lively wrote: > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: > > No big deal, but there are several debug printf uses here that look > > like they try to print NULL pointers upon memory allocation failure. > > It's ok with glibc's printf of

Re: [libvirt] [PATCH] * src/virterror.c (virReportErrorHelper): Sync doc to code.

2008-11-24 Thread Daniel P. Berrange
On Mon, Nov 24, 2008 at 03:56:38PM +0100, Jim Meyering wrote: > The dom and net parameters are long gone. > Reflect s/msg/fmt/ renaming: > > >From 8b87344dbe31fe478ac4a679005835e03a329ace Mon Sep 17 00:00:00 2001 > From: Jim Meyering <[EMAIL PROTECTED]> > Date: Mon, 24 Nov 2008 15:55:24 +0100 > Su

Re: [libvirt] [PATCH] libvirt.c: fix virStateActive return value; document ...

2008-11-24 Thread Daniel P. Berrange
On Mon, Nov 24, 2008 at 03:54:30PM +0100, Jim Meyering wrote: > The s/1/-1/ fix induces no semantic change, since the sole use > of virStateActive tests solely for nonzero. > > >From 4bc9713207a2ed6b101e2067f7bba82d1df45987 Mon Sep 17 00:00:00 2001 > From: Jim Meyering <[EMAIL PROTECTED]> > Date:

Re: [libvirt] [PATCH] fix python events

2008-11-24 Thread Jim Meyering
David Lively <[EMAIL PROTECTED]> wrote: > On Sat, 2008-11-22 at 08:21 +0100, Jim Meyering wrote: >> David Lively <[EMAIL PROTECTED]> wrote: >> > On Fri, 2008-11-21 at 17:51 +0100, Jim Meyering wrote: >> > I'm printing the (user-supplied) object names to help in debugging >> > misbehaving python Eve

Re: [libvirt] [PATCH] libvirt.c: fix virStateActive return value; document ...

2008-11-24 Thread Daniel Veillard
On Mon, Nov 24, 2008 at 03:54:30PM +0100, Jim Meyering wrote: > The s/1/-1/ fix induces no semantic change, since the sole use > of virStateActive tests solely for nonzero. > > >From 4bc9713207a2ed6b101e2067f7bba82d1df45987 Mon Sep 17 00:00:00 2001 > From: Jim Meyering <[EMAIL PROTECTED]> > Date:

[libvirt] PATCH: Autostart for Xen domains < 3.0.4

2008-11-24 Thread Daniel P. Berrange
The old 'xm' driver does not currently implement the autostart feature for domains managed via /etc/xen. This patche addresses that limitation by making it create the symlinks in /etc/xen/auto as expected by the existing 'xendomains' init script for autostart. Daniel diff -r dddbb717add4 src/xen

Re: [libvirt] [PATCH] fix --without-xen build

2008-11-24 Thread Daniel P. Berrange
On Fri, Nov 21, 2008 at 12:46:59PM -0500, David Lively wrote: > Okay, *this* one seems to be a complete fix. Not quite. The ENABLE_XEN_TESTS conditional is only set when not running on a live Xen kernel, which is a different conditional from disabling Xen driver entirely. It also shouldn't skip ou

Re: [libvirt] [PATCH] fix build for srcdir != builddir

2008-11-24 Thread Guido Günther
On Mon, Nov 24, 2008 at 01:56:29PM +, Daniel P. Berrange wrote: > On Mon, Nov 24, 2008 at 02:52:50PM +0100, Guido G?nther wrote: > > Hi, > > libvirt_sym.version is looked for at the wrong location. O.k. to apply? > > Ah yes, forgot to change this. Go ahead. Applied. -- Guido -- Libvir-list m

[libvirt] [PATCH] * src/virterror.c (virReportErrorHelper): Sync doc to code.

2008-11-24 Thread Jim Meyering
The dom and net parameters are long gone. Reflect s/msg/fmt/ renaming: >From 8b87344dbe31fe478ac4a679005835e03a329ace Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Mon, 24 Nov 2008 15:55:24 +0100 Subject: [PATCH] * src/virterror.c (virReportErrorHelper): Sync doc to code.

[libvirt] [PATCH] libvirt.c: fix virStateActive return value; document ...

2008-11-24 Thread Jim Meyering
The s/1/-1/ fix induces no semantic change, since the sole use of virStateActive tests solely for nonzero. >From 4bc9713207a2ed6b101e2067f7bba82d1df45987 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Mon, 24 Nov 2008 15:52:55 +0100 Subject: [PATCH] libvirt.c: fix virStateAc

Re: [libvirt] [PATCH] fix build for srcdir != builddir

2008-11-24 Thread Daniel P. Berrange
On Mon, Nov 24, 2008 at 02:52:50PM +0100, Guido G?nther wrote: > Hi, > libvirt_sym.version is looked for at the wrong location. O.k. to apply? Ah yes, forgot to change this. Go ahead. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -

[libvirt] [PATCH] fix build for srcdir != builddir

2008-11-24 Thread Guido Günther
Hi, libvirt_sym.version is looked for at the wrong location. O.k. to apply? Cheers, -- Guido >From df2b33ae4a865b0039899297c4fbda066c6be638 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?= <[EMAIL PROTECTED]> Date: Mon, 24 Nov 2008 14:49:47 +0100 Subject: [PATCH] look for libvirt_sy