Re: [libvirt] PATCH: Fix XM driver handling of disks without source file

2008-11-27 Thread Daniel Veillard
On Thu, Nov 27, 2008 at 12:20:26PM +, Daniel P. Berrange wrote: It is possible for disks to be listed without a source file against them, eg a CDROM device with no media loaded. The XenD driver handles this, but the XM driver incorrectly generates XML with a source file=''/ element

[libvirt] PATCH: Fix QEMU/UML use of libnuma

2008-11-27 Thread Daniel P. Berrange
The 2.x series of numactl releases changed the ABI/API for certain libnuma.so functions we use. Fortunately it turns out that they provide back-compatability of both ABI and API with a combo of linker script magic, and header file inline compat functions. So, all we need todo is #define

Re: [libvirt] [PATCH] Prefer xend setmaxmem interface

2008-11-27 Thread Daniel P. Berrange
On Wed, Nov 26, 2008 at 04:06:14PM -0700, Jim Fehlig wrote: Err, maybe a patch that actually compiles would be useful .. ACK, this patch looks good to me. Index: libvirt-0.4.6/src/xen_unified.c === ---

[libvirt] [PATCH] xen: prefer XS in xenUnifiedListDomains

2008-11-27 Thread Guido Günther
On Tue, Nov 25, 2008 at 11:39:57AM +, Daniel P. Berrange wrote: Yeha, this is almost certainly just another example of XenD not properly cleaning up / destroying domains. If you still have a machine which shows this behaviour, then I'd recommend trying this change to our Xen impl In

Re: [libvirt] [PATCH] xen: prefer XS in xenUnifiedListDomains

2008-11-27 Thread Daniel P. Berrange
On Thu, Nov 27, 2008 at 05:04:05PM +0100, Guido G?nther wrote: On Tue, Nov 25, 2008 at 11:39:57AM +, Daniel P. Berrange wrote: Yeha, this is almost certainly just another example of XenD not properly cleaning up / destroying domains. If you still have a machine which shows this

Re: [libvirt] [PATCH] Prefer xend setmaxmem interface

2008-11-27 Thread Daniel Veillard
On Wed, Nov 26, 2008 at 04:06:14PM -0700, Jim Fehlig wrote: Err, maybe a patch that actually compiles would be useful .. Jim Jim Fehlig wrote: As discussed in [1], prefer xend interface for setting max memory. Regards, Jim [1]

Re: [libvirt] [PATCH 2/2]: Call udevsettle in the appropriate places

2008-11-27 Thread Daniel Veillard
On Thu, Nov 27, 2008 at 08:53:49AM +0100, Chris Lalancette wrote: This will set UDEVSETTLE=udevsettle even if it doesn't exist. This will result in us running it on every OS we build on. We should not set this variable if its not found. Right, both points make sense. I think the

Re: [libvirt] [PATCH 2/2]: Call udevsettle in the appropriate places

2008-11-27 Thread Daniel P. Berrange
On Thu, Nov 27, 2008 at 08:53:49AM +0100, Chris Lalancette wrote: Daniel P. Berrange wrote: Index: configure.in === RCS file: /data/cvs/libvirt/configure.in,v retrieving revision 1.187 diff -u -r1.187 configure.in ---

Re: [libvirt] PATCH: Allow automatic driver probe for remote TCP connections

2008-11-27 Thread Daniel P. Berrange
On Wed, Nov 26, 2008 at 10:08:03PM +, Daniel P. Berrange wrote: When connecting to a local libvirt you can let it automatically probe the hypervisor URI if you don't know it ahead of time. This doesn't work with remote URIs because you need to have something to put in the URI scheme before

Re: [libvirt] PATCH: Fix QEMU/UML use of libnuma

2008-11-27 Thread Daniel Veillard
On Thu, Nov 27, 2008 at 01:26:28PM +, Daniel P. Berrange wrote: The 2.x series of numactl releases changed the ABI/API for certain libnuma.so functions we use. Fortunately it turns out that they provide back-compatability of both ABI and API with a combo of linker script magic, and header

Re: [libvirt] PATCH: Allow automatic driver probe for remote TCP connections

2008-11-27 Thread Daniel Veillard
On Thu, Nov 27, 2008 at 04:26:50PM +, Daniel P. Berrange wrote: On Wed, Nov 26, 2008 at 10:08:03PM +, Daniel P. Berrange wrote: When connecting to a local libvirt you can let it automatically probe the hypervisor URI if you don't know it ahead of time. This doesn't work with remote

Re: [libvirt] [PATCH 1/2]: Give /dev/disk/by-{id, path} a chance to exist

2008-11-27 Thread Chris Lalancette
Chris Lalancette wrote: This patch is the same idea as my previous patch for giving /dev/disk/by-{id,path} a chance to exist. Currently libvirt can race with udev creation of /dev/disk/by-{id,path}, so if we fail to open the directory, retry up to 5 seconds. This is only likely to happen

Re: [libvirt] [PATCH 2/2]: Call udevsettle in the appropriate places

2008-11-27 Thread Chris Lalancette
Daniel P. Berrange wrote: +void virStorageBackendWaitForDevices(virConnectPtr conn) +{ +#ifdef UDEVADM +const char *const settleprog[] = { UDEVADM, settle, NULL }; +int exitstatus; + +if (access(UDEVADM, X_OK) != 0) +return; + +/* + * NOTE: we ignore errors

Re: [libvirt] PATCH: Fix QEMU/UML use of libnuma

2008-11-27 Thread Chris Lalancette
Daniel P. Berrange wrote: The 2.x series of numactl releases changed the ABI/API for certain libnuma.so functions we use. Fortunately it turns out that they provide back-compatability of both ABI and API with a combo of linker script magic, and header file inline compat functions. So, all we