Re: [libvirt] Re: [PATCH/RFC] kvm/qemu vs libvirtd restarts

2008-12-04 Thread Daniel Veillard
On Wed, Dec 03, 2008 at 06:20:12PM +0100, Guido Günther wrote: On Sun, Nov 30, 2008 at 12:43:48PM +0100, Guido Günther wrote: From 87db4a698ed9b49294c0f94137fc6beef13bd4e8 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?= [EMAIL PROTECTED] Date: Tue, 25 Nov 2008 13:02:43 +0100

Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

2008-12-04 Thread Daniel Veillard
On Wed, Dec 03, 2008 at 11:52:45PM +, Daniel P. Berrange wrote: On Wed, Dec 03, 2008 at 06:52:32PM +, Daniel P. Berrange wrote: On Wed, Dec 03, 2008 at 04:18:21PM +0100, Daniel Veillard wrote: On Mon, Dec 01, 2008 at 12:26:48AM +, Daniel P. Berrange wrote: This is a diffstat

Re: [libvirt] [PATCH] also look for /usr/bin/kvm

2008-12-04 Thread Guido Günther
On Wed, Dec 03, 2008 at 04:38:10PM +0100, Daniel Veillard wrote: On Tue, Dec 02, 2008 at 10:22:28PM +0100, Guido Günther wrote: We do so in qemudCapsInitGuest() but not in qemudProbe(). O.k. to apply? -- Guido Looks fine to me ! Applied now. -- Guido -- Libvir-list mailing list

Re: [libvirt] Re: [PATCH/RFC] kvm/qemu vs libvirtd restarts

2008-12-04 Thread Daniel P. Berrange
On Wed, Dec 03, 2008 at 06:20:12PM +0100, Guido G?nther wrote: On Sun, Nov 30, 2008 at 12:43:48PM +0100, Guido Günther wrote: From 87db4a698ed9b49294c0f94137fc6beef13bd4e8 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?= [EMAIL PROTECTED] Date: Tue, 25 Nov 2008 13:02:43 +0100

Re: [libvirt] Re: [PATCH/RFC] kvm/qemu vs libvirtd restarts

2008-12-04 Thread Guido Günther
On Thu, Dec 04, 2008 at 10:56:25AM +, Daniel P. Berrange wrote: On Wed, Dec 03, 2008 at 06:20:12PM +0100, Guido G?nther wrote: On Sun, Nov 30, 2008 at 12:43:48PM +0100, Guido Günther wrote: From 87db4a698ed9b49294c0f94137fc6beef13bd4e8 Mon Sep 17 00:00:00 2001 From:

[libvirt] Open monitor logs O_APPEND

2008-12-04 Thread Guido Günther
Hi, attached patch is from Debian Bug #507553: The logfile is opened with O_APPEND (to make logrotate work with copytruncate) and without O_TRUNC (to not lose log information e.g. with stop and start of a VM). Using collectd or munin to monitor VMs creates quiet a bit of qemu monitor output so

Re: [libvirt] Open monitor logs O_APPEND

2008-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2008 at 02:11:07PM +0100, Guido G?nther wrote: Hi, attached patch is from Debian Bug #507553: The logfile is opened with O_APPEND (to make logrotate work with copytruncate) and without O_TRUNC (to not lose log information e.g. with stop and start of a VM). Using collectd

Re: [libvirt] Re: [PATCH] bridge: set MTU of tap iface to the same value of the bridge

2008-12-04 Thread Mark McLoughlin
On Wed, 2008-12-03 at 14:09 +, Mark McLoughlin wrote: Conclusions from above meandering: 1) Your patch is a sensible default; not perfect, but a very good compromise For DV: J'adore cette patch. C'est magnifique. S'il vous plaît s'appliquer. Merci, Mark. -- Libvir-list

Re: [libvirt] Re: [PATCH] bridge: set MTU of tap iface to the same value of the bridge

2008-12-04 Thread Daniel Veillard
On Wed, Dec 03, 2008 at 11:14:28AM -0200, Eduardo Habkost wrote: On Tue, Dec 02, 2008 at 10:15:51PM -0800, Chris Wright wrote: * Eduardo Habkost ([EMAIL PROTECTED]) wrote: +static int brSetInterfaceMtu(brControl *ctl, + const char *bridge, +

Re: [libvirt] [PATCH] Fix a few docs errors

2008-12-04 Thread Cole Robinson
Daniel P. Berrange wrote: On Mon, Dec 01, 2008 at 05:36:57PM -0500, Cole Robinson wrote: The attached patch fixes a few cut and paste docs errors I've stumbled upon, and a spelling error in a virsh command output. ACK. Daniel Push now. Thanks, Cole -- Libvir-list mailing

Re: [libvirt] [PATCH] Increase initial qemu monitor read timeout

2008-12-04 Thread Cole Robinson
Daniel P. Berrange wrote: On Mon, Dec 01, 2008 at 05:36:51PM -0500, Cole Robinson wrote: See https://bugzilla.redhat.com/show_bug.cgi?id=453491 We've been getting bug reports like the above against virt-manager for a while now: installing new VMs consistently throws an error 'Timed out

[libvirt] [PATCH] Add default format info for storage volumes

2008-12-04 Thread Cole Robinson
The attached patch adds default format info for storage volumes. This fixes a regression in the latest release, where defining a storage volume without a format crashed libvirtd: https://bugzilla.redhat.com/show_bug.cgi?id=473071 This is similar to how we handle things with storage pools as

Re: [libvirt] [PATCH] Add default format info for storage volumes

2008-12-04 Thread Chris Lalancette
Cole Robinson wrote: The attached patch adds default format info for storage volumes. This fixes a regression in the latest release, where defining a storage volume without a format crashed libvirtd: https://bugzilla.redhat.com/show_bug.cgi?id=473071 This is similar to how we handle

Re: [libvirt] [PATCH] Add default format info for storage volumes

2008-12-04 Thread Daniel Veillard
On Thu, Dec 04, 2008 at 04:14:51PM +0100, Chris Lalancette wrote: Cole Robinson wrote: The attached patch adds default format info for storage volumes. This fixes a regression in the latest release, where defining a storage volume without a format crashed libvirtd:

[libvirt] Release of libvirt-0.5.1

2008-12-04 Thread Daniel Veillard
Mostly a bug fix one, as promised when 0.5.0 came out :-) Available as usual from: ftp://libvirt.org/libvirt/ Some bug fixes and local improvements: + Portability: - fix missing dep in spec file - fix compilation with new NUMA libraries (Daniel Berrange) - udev compatibility for RHEL

Re: [libvirt] Open monitor logs O_APPEND

2008-12-04 Thread Guido Günther
On Thu, Dec 04, 2008 at 01:26:40PM +, Daniel P. Berrange wrote: On Thu, Dec 04, 2008 at 02:11:07PM +0100, Guido G?nther wrote: Hi, attached patch is from Debian Bug #507553: The logfile is opened with O_APPEND (to make logrotate work with copytruncate) and without O_TRUNC (to not

[libvirt] [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Eduardo Habkost
Hi, Below is an incomplete patch for letting the MTU of a libvirt virtual network to be configured on XML. This implementation has an issue: it works when trying to set the MTU below 1500, but the kernel bridge code doesn't let us to set the bridge MTU above 1500 if there is no interface

[libvirt] Re: [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Mark McLoughlin
On Thu, 2008-12-04 at 15:42 -0200, Eduardo Habkost wrote: This implementation has an issue: it works when trying to set the MTU below 1500, but the kernel bridge code doesn't let us to set the bridge MTU above 1500 if there is no interface attached to the bridge yet. To allow setting the

[libvirt] Re: [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Eduardo Habkost
On Thu, Dec 04, 2008 at 05:54:24PM +, Mark McLoughlin wrote: On Thu, 2008-12-04 at 15:42 -0200, Eduardo Habkost wrote: This implementation has an issue: it works when trying to set the MTU below 1500, but the kernel bridge code doesn't let us to set the bridge MTU above 1500 if there

Re: [libvirt] [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2008 at 03:42:12PM -0200, Eduardo Habkost wrote: Hi, Below is an incomplete patch for letting the MTU of a libvirt virtual network to be configured on XML. This implementation has an issue: it works when trying to set the MTU below 1500, but the kernel bridge code doesn't

Re: [libvirt] Re: [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2008 at 04:07:04PM -0200, Eduardo Habkost wrote: On Thu, Dec 04, 2008 at 05:54:24PM +, Mark McLoughlin wrote: On Thu, 2008-12-04 at 15:42 -0200, Eduardo Habkost wrote: This implementation has an issue: it works when trying to set the MTU below 1500, but the kernel

Re: [libvirt] broken pipe?

2008-12-04 Thread Daniel P. Berrange
On Wed, Dec 03, 2008 at 05:47:11PM -0500, Itamar Heim wrote: Thanks for the tips. Next batch of issues... 1. while still trying to build manually... Any estimation on when/if 0.5 will make it to F10? 0.5.1 will be in F10 updates within days I expect 2. I'm using git, not cvs. Are these

Re: [libvirt] [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Eduardo Habkost
On Thu, Dec 04, 2008 at 07:32:20PM +, Daniel P. Berrange wrote: On Thu, Dec 04, 2008 at 03:42:12PM -0200, Eduardo Habkost wrote: snip I was going to suggest having something like this: virNetworkAddTap(network, net-ifname, tapfd); This isn't satisfactory. This only works for the

Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

2008-12-04 Thread Daniel P. Berrange
On Wed, Dec 03, 2008 at 04:15:05PM -0800, Chris Wright wrote: * Daniel P. Berrange ([EMAIL PROTECTED]) wrote: (* * This is the list of all libvirt methods which return * pointers to locked objects *) let lockedObjMethods = [ virDomainFindByID; virDomainFindByUUID;

Re: [libvirt] broken pipe?

2008-12-04 Thread Hugh O. Brock
On Thu, Dec 04, 2008 at 07:42:51PM +, Daniel P. Berrange wrote: On Wed, Dec 03, 2008 at 05:47:11PM -0500, Itamar Heim wrote: Thanks for the tips. Next batch of issues... 1. while still trying to build manually... Any estimation on when/if 0.5 will make it to F10? 0.5.1 will be

Re: [libvirt] [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2008 at 06:15:14PM -0200, Eduardo Habkost wrote: On Thu, Dec 04, 2008 at 07:32:20PM +, Daniel P. Berrange wrote: On Thu, Dec 04, 2008 at 03:42:12PM -0200, Eduardo Habkost wrote: snip I was going to suggest having something like this: virNetworkAddTap(network,

[libvirt] [PATCH ] (type ioem) adding qemu nic configuration option in to libvirt (XEN)

2008-12-04 Thread Gihan Munasinghe
Guys I have added a new attribute with with in interface tag called qemu which can be either true or false.. Indicating if the user wants XEN to create qeum net device or not.. This will fix the problem with PV net drivers with XEN.. Check the following examples e.g 1) Interface tag with

Re: [libvirt] [PATCH ] (type ioem) adding qemu nic configuration option in to libvirt (XEN)

2008-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2008 at 09:50:01PM +, Gihan Munasinghe wrote: interface type='bridge' qemu='false' This is not suitable because it is adding attributes that are specific to the Xen hypervisor. mac address='00:16:3e:00:a5:01'/ source bridge='eth0'/ target dev='vif1.0'/

Re: [libvirt] PATCH: 0/28: Thread safety for libvirtd daemon and drivers

2008-12-04 Thread Daniel P. Berrange
On Sun, Nov 30, 2008 at 11:14:37PM +, Daniel P. Berrange wrote: The following huge series of patches adds thread safety for the libvirtd daemon and drivers, and makes the daemon multi-threaded in processing RPC calls. This enables multiple clients to be processed in parallel, without

Re: [libvirt] [PATCH ] (type ioem) adding qemu nic configuration option in to libvirt (XEN)

2008-12-04 Thread Gihan Munasinghe
Daniel P. Berrange wrote: On Thu, Dec 04, 2008 at 09:50:01PM +, Gihan Munasinghe wrote: interface type='bridge' qemu='false' This is not suitable because it is adding attributes that are specific to the Xen hypervisor. Why can not this be used with any other hypervisor. The

Re: [libvirt] [PATCH ] (type ioem) adding qemu nic configuration option in to libvirt (XEN)

2008-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2008 at 10:33:28PM +, Gihan Munasinghe wrote: Daniel P. Berrange wrote: mac address='00:16:3e:00:a5:01'/ source bridge='eth0'/ target dev='vif1.0'/ /interface As I mentioned before this should be handled with the existing XML model element.

RE: [libvirt] broken pipe?

2008-12-04 Thread Itamar Heim
-Original Message- From: Daniel P. Berrange [mailto:[EMAIL PROTECTED] ... Basically take a look at libvirt.spec.in and make sure you have all the 'BuildRequires lines installed [IH] done that. Added the following list. xen-devel libxml2-devel gnutls-devel cyrus-sasl-devel cvs

RE: [libvirt] broken pipe -- compile errors

2008-12-04 Thread Itamar Heim
Regarding the compile errors below: --without-xen allows me to compile HEAD, but with-xen seems broken For the 0.5.0 tag - 'qemudCapsInitNUMA' qemu_conf.c:325: error: passing argument 2 of 'numa_node_to_cpus' from incompatible pointer type - doesn't seem related to the HEAD break. Could be related

Re: [libvirt] how to install updated python bindings

2008-12-04 Thread visco
hi thanks Berrange ... after installing python development packages and setting the variables i am able to work out the trouble. @Veillard unfortunately i required some latest version,which is not provided yet as rpm, api for my needs, and hence started from source. On Wed, Dec 3, 2008 at 5:31