Re: [libvirt] [PATCH 3/5] add XML parsing for vm status file

2008-12-20 Thread Guido Günther
On Thu, Dec 18, 2008 at 03:53:17PM +0100, Guido Günther wrote: On Thu, Dec 18, 2008 at 10:23:39AM +, Daniel P. Berrange wrote: No, not guarenteed to be safe because the 'config_xml' string could contain '%' sequences that'll be interpreted by sprintf. In any case why not just use

Re: [libvirt] [PATCH 4/5] save domain status during vm creation and remove it on shutdown.

2008-12-20 Thread Guido Günther
On Thu, Dec 18, 2008 at 10:26:15AM +, Daniel P. Berrange wrote: On Thu, Dec 18, 2008 at 10:37:55AM +0100, Guido G?nther wrote: On Mon, Dec 15, 2008 at 11:22:52AM +, Daniel P. Berrange wrote: On Fri, Dec 12, 2008 at 07:27:08PM +0100, Guido G?nther wrote: This patch does the actual

Re: [libvirt] kvm: save / restore

2008-12-20 Thread Matthias Pfafferodt
Hello Daniel, thnaks for your anser. Do you know the plans regarding save/restore in kvm and libvirt? I would like to save my vm's at shutdown and restore at boot time. At the moment this is not working and shutdown is used. Matthias Am Thursday 18 December 2008 13:42:36 schrieb Daniel P.

Re: [libvirt] virDomainInterfaceStats why is there a size?

2008-12-20 Thread Richard W.M. Jones
On Tue, Aug 12, 2008 at 01:55:26PM +0200, Stefan de Konink wrote: Another simple question, what is the reasoning about the size field in this call. I would really be a happy boy if anyone said: if you put in path == NULL, it will fill your stats structure up to size interfaces. ...but

[libvirt] [PATCH] virAsprintf cleanup

2008-12-20 Thread Guido Günther
Hi, please find a possible asprintf vs. virAsprintf cleanup attached. There were several occations where the result of a failed asprintf was used. Cheers, -- Guido diff --git a/.x-sc_prohibit_asprintf b/.x-sc_prohibit_asprintf new file mode 100644 index 000..614c238 --- /dev/null +++

Re: [libvirt] virDomainInterfaceStats why is there a size?

2008-12-20 Thread Stefan de Konink
Richard W.M. Jones wrote: On Tue, Aug 12, 2008 at 01:55:26PM +0200, Stefan de Konink wrote: Another simple question, what is the reasoning about the size field in this call. I would really be a happy boy if anyone said: if you put in path == NULL, it will fill your stats structure up to size

Re: [libvirt] [PATCH] avoid testcase failures due to LANG!=C

2008-12-20 Thread Jim Meyering
Guido Günther a...@sigxcpu.org wrote: some checks compare to the english error messages: ... diff --git a/tests/Makefile.am b/tests/Makefile.am index 87e4235..5290606 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -105,6 +105,7 @@ TESTS_ENVIRONMENT =

Re: [libvirt] [PATCH] virAsprintf cleanup

2008-12-20 Thread Jim Meyering
Guido Günther a...@sigxcpu.org wrote: please find a possible asprintf vs. virAsprintf cleanup attached. There were several occations where the result of a failed asprintf was used. Nice work. ACK. diff --git a/.x-sc_prohibit_asprintf b/.x-sc_prohibit_asprintf new file mode 100644 index

[libvirt] [PATCH] Make mntent.h specific to the FS storage backend

2008-12-20 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1229789393 28800 # Node ID c433c57ef39b2c343653910df84130c8849a7c11 # Parent 100de621beed6e146b239df3691bd426090955b4 Make mntent.h specific to the FS storage backend It's Linux specific, so for now, put it behind a WITH_STORAGE_FS guard.

[libvirt] [PATCH] Improve compiler flag checking

2008-12-20 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1229789393 28800 # Node ID a158bbc6df6fb8b15af875d08e73cfd3ca75f907 # Parent 34706075e6c801cd9532490c11b20b64dfcf464b Improve compiler flag checking Some compilers (including GCC) don't set the return value consistently if an erroneous option

Re: [libvirt] [PATCH] avoid testcase failures due to LANG!=C

2008-12-20 Thread Guido Günther
On Sat, Dec 20, 2008 at 04:30:30PM +0100, Jim Meyering wrote: Guido Günther a...@sigxcpu.org wrote: some checks compare to the english error messages: ... diff --git a/tests/Makefile.am b/tests/Makefile.am index 87e4235..5290606 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am

Re: [libvirt] libvirtd crashing with network bridge configuration

2008-12-20 Thread Emre Erenoglu
Hi Again, I've started to learn how to use gdb and came accross these lines which are causing the crash: /** * virStateInitialize: * * Initialize all virtualization drivers. * * Return 0 if all succeed, -1 upon any failure. */ int virStateInitialize(void) { int i, ret = 0; if