Re: [libvirt] [PATCH] split out logfile opening

2009-01-04 Thread Jim Meyering
Guido Günther a...@sigxcpu.org wrote: attached patch splits out the qemu logfile opening into a separate function which makes the code a bit more readable and I'll need this for the libvirtd restart code. ... +static int +qemudLogFD(virConnectPtr conn, const char* logDir, const char* name)

Re: [libvirt] 5 minor cleanups

2009-01-04 Thread Jim Meyering
Guido Günther a...@sigxcpu.org wrote: these accumulated over time. O.k. to apply? Those all look fine. From 35569e95febc37818998cd1834099090a3cf852d Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org Date: Mon, 22 Dec 2008 22:26:03 +0100 Subject: [PATCH] fix

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2009-01-04 Thread Jim Meyering
Jim Meyering j...@meyering.net wrote: John Levon john.le...@sun.com wrote: On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote: This all looks fine, but I'd prefer to retain the WARNING in the generated file, so that people are less likely to modify it directly. Along the Sure,

[libvirt] [PATCH 1/2] mark a few diagnostics for translation

2009-01-04 Thread Jim Meyering
Here are two warning-avoidance changes I'm about to commit: From 588ecf78ffd6f284aa7872c13d946b9b5a146ef0 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 23 Dec 2008 16:49:26 +0100 Subject: [PATCH 1/2] mark a few diagnostics for translation * src/xen_inotify.c

Re: [libvirt] proposal: allow use of bool: HACKING: discuss C types

2009-01-04 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: ... Ok, if you want to re-post the HACKING file also mentioning that 'bool' shouldn't be used in our public APIs wire protocol, and that 'true' / 'false' should only be used for initialization I'm fine with the rest of the docs. Thanks. I've done