[libvirt] [PATCH] avoid bogus descriptions due to use of gettext with the empty string

2009-01-05 Thread Jim Meyering
I noticed many warnings like this: src/virsh.c:2115: warning: Empty msgid. It is reserved by GNU gettext: gettext() returns the header entry with meta information, not the empty string. This is the trivial fix I'll commit shortly: From

[libvirt] [PATCH] Makefile.maint: sync from coreutils

2009-01-05 Thread Jim Meyering
I sync'd Makefile.maint from coreutils a few weeks ago. Here's the result I'll push soon: [no review needed, imho, since this affects only make syntax-check] From fb3793e69bf25ccd71b8e0815e86cdd952f3b759 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Fri, 5 Dec 2008

Re: [libvirt] PATCH: Fix numa build failure on 32-bit f9

2009-01-05 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: The automated build on Fedora 9, i386 is currently failing with cc1: warnings being treated as errors nodeinfo.c: In function 'virCapsInitNUMA': nodeinfo.c:212: error: passing argument 2 of 'numa_node_to_cpus' from incompatible pointer type

Re: [libvirt] PATCH: Fix numa build failure on 32-bit f9

2009-01-05 Thread Daniel P. Berrange
On Mon, Jan 05, 2009 at 01:48:21PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: The automated build on Fedora 9, i386 is currently failing with cc1: warnings being treated as errors nodeinfo.c: In function 'virCapsInitNUMA': nodeinfo.c:212: error: passing

Re: [libvirt] [PATCH]: pass flags to all virDomain*DefParse* functions

2009-01-05 Thread Daniel Veillard
On Mon, Jan 05, 2009 at 10:27:03AM +, Daniel P. Berrange wrote: On Fri, Dec 26, 2008 at 02:19:06PM +0100, Guido G?nther wrote: by honoring the VIR_DOMAIN_XML_INACTIVE flag. O.k. to commit this part as a start so you can readily use it vor lxc? ACK, assuming

[libvirt] Libvirt - Xen Enterprise - Koan

2009-01-05 Thread Tom Brown
Hi Our VM's currently run on top of Xen Enterprise, not my choice but thats the way it has to be at the moment. I'd like to be able to still use cobbler/koan to provision the systems and so i have managed to get libvirt installed onto a Xen Enterprise host. Libvirt starts but it cant connect

Re: [libvirt] [PATCH 1/2] mark a few diagnostics for translation

2009-01-05 Thread Daniel Berrange
On Mon, Jan 05, 2009 at 08:31:59AM +0100, Jim Meyering wrote: Here are two warning-avoidance changes I'm about to commit: From 588ecf78ffd6f284aa7872c13d946b9b5a146ef0 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 23 Dec 2008 16:49:26 +0100 Subject: [PATCH 1/2]

Re: [libvirt] [PATCH] avoid xgettext warning aboug bug-reporting address

2009-01-05 Thread Daniel P. Berrange
On Mon, Jan 05, 2009 at 11:21:39AM +0100, Jim Meyering wrote: Building make distcheck, I saw this go by: /usr/bin/xgettext: warning: The option --msgid-bugs-address was not specified. If you are using a `Makevars' file, please specify the

Re: [libvirt] [PATCH] avoid xgettext warning aboug bug-reporting address

2009-01-05 Thread Jim Meyering
Miloslav Trmač m...@redhat.com wrote: Jim Meyering píše v Po 05. 01. 2009 v 11:21 +0100: Building make distcheck, I saw this go by: # This is the email address or URL to which the translators shall report # bugs in the untranslated strings: # It can be your email address, or a mailing

Re: [libvirt] [PATCH] avoid xgettext warning aboug bug-reporting address

2009-01-05 Thread Miloslav Trmač
Jim Meyering píše v Po 05. 01. 2009 v 11:21 +0100: Building make distcheck, I saw this go by: # This is the email address or URL to which the translators shall report # bugs in the untranslated strings: # It can be your email address, or a mailing list address where translators #

[libvirt] Where are libvirt configuration files located ?

2009-01-05 Thread Fabien Dupont
Hello. As there's a /etc/libvirt/qemu/networks directory, where are located configuration files for pools, domains, storage volumes ? How can I autostart a pool, as I don't know where to store its XML Dump ? Your help would be very useful. Thanks. -- Fabien Dupont System Engineer Email :

[libvirt] PATCH: Fix numa build failure on 32-bit f9

2009-01-05 Thread Daniel P. Berrange
The automated build on Fedora 9, i386 is currently failing with cc1: warnings being treated as errors nodeinfo.c: In function 'virCapsInitNUMA': nodeinfo.c:212: error: passing argument 2 of 'numa_node_to_cpus' from incompatible pointer type make[3]: *** [libvirt_driver_la-nodeinfo.lo] Error 1

Re: [libvirt] [PATCH 1/2] mark a few diagnostics for translation

2009-01-05 Thread Daniel Veillard
On Mon, Jan 05, 2009 at 08:31:59AM +0100, Jim Meyering wrote: Here are two warning-avoidance changes I'm about to commit: yup, looks fine, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/

Re: [libvirt] Where are libvirt configuration files located ?

2009-01-05 Thread Daniel P. Berrange
On Mon, Jan 05, 2009 at 11:11:22AM +0100, Fabien Dupont wrote: Hello. As there's a /etc/libvirt/qemu/networks directory, where are located configuration files for pools, domains, storage volumes ? How can I autostart a pool, as I don't know where to store its XML Dump ? Don't create config

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2009-01-05 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Tue, Dec 23, 2008 at 06:31:14PM +0100, Jim Meyering wrote: John Levon john.le...@sun.com wrote: On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote: This all looks fine, but I'd prefer to retain the WARNING in the generated file,

Re: [libvirt] Libvirt - Xen Enterprise - Koan

2009-01-05 Thread Daniel P. Berrange
On Mon, Jan 05, 2009 at 05:45:24PM +, Tom Brown wrote: Hi Our VM's currently run on top of Xen Enterprise, not my choice but thats the way it has to be at the moment. I'd like to be able to still use cobbler/koan to provision the systems and so i have managed to get libvirt installed

Re: [libvirt] 5 minor cleanups

2009-01-05 Thread Daniel P. Berrange
On Fri, Dec 26, 2008 at 02:33:57PM +0100, Guido G?nther wrote: Hi, these accumulated over time. O.k. to apply? ACK, if you've not already applied this. From f79cfbdaa1cc59dd911f524793324ba7c2cc7096 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?Guido=20G=C3=BCnther?= a...@sigxcpu.org Date: Wed,

Re: [libvirt] [PATCH] avoid xgettext warning aboug bug-reporting address

2009-01-05 Thread Daniel Veillard
On Mon, Jan 05, 2009 at 12:36:20PM +0100, Jim Meyering wrote: Miloslav Trmač m...@redhat.com wrote: Jim Meyering píše v Po 05. 01. 2009 v 11:21 +0100: Building make distcheck, I saw this go by: # This is the email address or URL to which the translators shall report # bugs in the

Re: [libvirt] KVM/qemu: problems with autostart of vms with non-bridged nets

2009-01-05 Thread Daniel Veillard
On Fri, Dec 05, 2008 at 02:00:00PM +0100, Gerd v. Egidy wrote: Hi Daniel, I've committed this patch now. I'll send a suggestion for the second patch shortly... Ok, I think your suggested patch is the best we can manage at this point in time. Here's an update which also handle it for

Re: [libvirt] adding bandwidth control support

2009-01-05 Thread Jim Meyering
Max Zhen max.z...@sun.com wrote: Hi, I'm working on adding bandwidth control support in virt-install/virsh/libvirt on Xen. This support can allow setting bandwidth control in dom0 (I'm working on Solaris dom0 now) for virtual nic devices used in a domU. I've attached my design in this

[libvirt] [PATCH] avoid xgettext warning aboug bug-reporting address

2009-01-05 Thread Jim Meyering
Building make distcheck, I saw this go by: /usr/bin/xgettext: warning: The option --msgid-bugs-address was not specified. If you are using a `Makevars' file, please specify the MSGID_BUGS_ADDRESS variable there; otherwise please

Re: [PATCH] virKillProcess [was Re: [libvirt] [PATCH 2/5] daemonize qemu processes]

2009-01-05 Thread Daniel P. Berrange
On Mon, Dec 29, 2008 at 03:36:15PM +0100, Guido G?nther wrote: On Mon, Dec 15, 2008 at 02:22:42PM +0100, Daniel Veillard wrote: On Mon, Dec 15, 2008 at 11:21:20AM +, Daniel P. Berrange wrote: On Fri, Dec 12, 2008 at 07:26:32PM +0100, Guido G?nther wrote: +if (kill(vm-pid,

Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files

2009-01-05 Thread Daniel P. Berrange
On Tue, Dec 23, 2008 at 06:31:14PM +0100, Jim Meyering wrote: John Levon john.le...@sun.com wrote: On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote: This all looks fine, but I'd prefer to retain the WARNING in the generated file, so that people are less likely to modify it

Re: [libvirt] proposal: allow use of bool: HACKING: discuss C types

2009-01-05 Thread Daniel P. Berrange
On Mon, Jan 05, 2009 at 08:56:08AM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: ... Ok, if you want to re-post the HACKING file also mentioning that 'bool' shouldn't be used in our public APIs wire protocol, and that 'true' / 'false' should only be used for

Re: [libvirt] [PATCH]: pass flags to all virDomain*DefParse* functions

2009-01-05 Thread Daniel P. Berrange
On Fri, Dec 26, 2008 at 02:19:06PM +0100, Guido G?nther wrote: by honoring the VIR_DOMAIN_XML_INACTIVE flag. O.k. to commit this part as a start so you can readily use it vor lxc? ACK, assuming 'make check' still passes. It does here, sure. Patch Applied now. I've added the

Re: [libvirt] adding bandwidth control support

2009-01-05 Thread Max Zhen
Jim Meyering at 2009-1-5 23:50 wrote: Max Zhen max.z...@sun.com wrote: Hi, I'm working on adding bandwidth control support in virt-install/virsh/libvirt on Xen. This support can allow setting bandwidth control in dom0 (I'm working on Solaris dom0 now) for virtual nic devices used in a