Re: [libvirt] [PATCH] mark a few diagnostics for translation

2009-01-27 Thread Jim Meyering
Jim Meyering j...@meyering.net wrote: Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jan 26, 2009 at 03:05:05PM +0100, Jim Meyering wrote: Avoid compile-time warnings: From 4597152e0c4a1e4a5ee85156496a8625b5cc4f42 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date:

Re: [libvirt] [PATCH] trivial libvirt example code

2009-01-27 Thread Jim Meyering
Dave Allan dal...@redhat.com wrote: Richard W.M. Jones wrote: On Fri, Jan 23, 2009 at 02:51:02PM -0500, Dave Allan wrote: The examples directory doesn't have a trivial example of how to connect to a hypervisor, make a few calls, and disconnect, so I put one together. I would appreciate any

Re: [libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

2009-01-27 Thread Daniel P. Berrange
On Mon, Jan 26, 2009 at 10:39:25AM +, Mark McLoughlin wrote: IFF_VNET_HDR is a tun/tap flag that allows you to send and receive large (i.e. GSO) packets and packets with partial checksums. Setting the flag means that every packet is proceeded by the same header which virtio uses to

Re: [libvirt] [PATCH] fix errors in virReportSystemErrorFull

2009-01-27 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: ... Looking at the whole method again, I think it needs to be re-written to something closer to this: Ok, I've adapted that. Changes: - handle snprintf and vsnprintf failure - insert : into the result string - use stpcpy, not strcat (as a

Re: [libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

2009-01-27 Thread Mark McLoughlin
On Tue, 2009-01-27 at 10:05 +, Daniel P. Berrange wrote: On Mon, Jan 26, 2009 at 10:39:25AM +, Mark McLoughlin wrote: It's nearly five months since kvm-74 - the first KVM release with this feature - was released. Up until now, we've not added libvirt support because there is no

[libvirt] PATCH: Reset global error object at end of test

2009-01-27 Thread Daniel P. Berrange
There statstest test case is expected to raise a number of libvirt errors. Since these are now stored in thread locals, it is expected that this won't be free'd automatically at system shutdown. This patch adds a call to virResetError() at the end to release the memory associated with the stored

Re: [libvirt] about libvirt-qpid on libvirt.org

2009-01-27 Thread Daniel P. Berrange
On Tue, Jan 27, 2009 at 12:51:57PM +0900, Atsushi SAKAI wrote: Hi, I have a question about libvirt-qpid. The libvirt-qpid is working for QPID broker? If so, it should be added in livirt is section of following pages. http://libvirt.org/ How do you think? Yes, it should be listed - here

Re: [libvirt] about libvirt-qpid on libvirt.org

2009-01-27 Thread Atsushi SAKAI
Hi, Daniel It looks good for me. Thanks Atsushi SAKAI Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jan 27, 2009 at 12:51:57PM +0900, Atsushi SAKAI wrote: Hi, I have a question about libvirt-qpid. The libvirt-qpid is working for QPID broker? If so, it should be added

Re: [libvirt] [PATCH] fix errors in virReportSystemErrorFull

2009-01-27 Thread Daniel P. Berrange
On Tue, Jan 27, 2009 at 11:28:32AM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: ... Looking at the whole method again, I think it needs to be re-written to something closer to this: Ok, I've adapted that. +void virReportSystemErrorFull(virConnectPtr conn, +

Re: [libvirt] [PATCH] fix errors in virReportSystemErrorFull

2009-01-27 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jan 27, 2009 at 11:28:32AM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: ... Looking at the whole method again, I think it needs to be re-written to something closer to this: Ok, I've adapted that. +void

Re: [libvirt] about libvirt-qpid on libvirt.org

2009-01-27 Thread Daniel P. Berrange
On Tue, Jan 27, 2009 at 09:04:22PM +0900, Atsushi SAKAI wrote: Hi, Daniel It looks good for me. Ok, i committed that Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jan 27, 2009 at 12:51:57PM +0900, Atsushi SAKAI wrote: Hi, I have a question about libvirt-qpid.

[libvirt] [PATCH] * POTFILES.in: update: remove src/lxc_conf.c; Add src/bridge.c.

2009-01-27 Thread Jim Meyering
make syntax-check broke. Here's the fix: From 5bfc2955253b173e13659104890448d427c5e716 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 27 Jan 2009 16:27:07 +0100 Subject: [PATCH] * POTFILES.in: update: remove src/lxc_conf.c; Add src/bridge.c. --- po/POTFILES.in |2

Re: [libvirt] [PATCH] * POTFILES.in: update: remove src/lxc_conf.c; Add src/bridge.c.

2009-01-27 Thread Mark McLoughlin
On Tue, 2009-01-27 at 16:28 +0100, Jim Meyering wrote: make syntax-check broke. Here's the fix: Looks good, sorry. Seems I ran syntax-check before my patch, but not after. Doh. Thanks, Mark. -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] use virReportOOMError, not VIR_ERR_NO_MEMORY

2009-01-27 Thread Jim Meyering
I've changed over 200 uses of some_error_function with the VIR_ERR_NO_MEMORY flag to call virReportOOMError with whatever conn-like argument (if any) was in the original call. I don't claim to have tested these changes (OOM is a pain to simulate, and besides, testing so many failure points would

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-27 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jan 22, 2009 at 07:15:19PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: ... Did that, and likewise the similar allocation a little above this chunk ... All looks fine. ACK. You'll have noticed that the fix

[libvirt] Clock problems with Windows guests and Xen

2009-01-27 Thread Matthew Donovan
When I start Windows guests with libvirt my clocks are 5 hours off. When I use a Xen configuration file, I can specify an offset (rtc_timeoffset = -18000) to get my clock to sync with the host. Is there a way to do specify this offset in XML with libvirt? Right now, I'm using version 0.4.4

Re: [libvirt] Clock problems with Windows guests and Xen

2009-01-27 Thread Daniel P. Berrange
On Tue, Jan 27, 2009 at 01:33:21PM -0500, Matthew Donovan wrote: When I start Windows guests with libvirt my clocks are 5 hours off. When I use a Xen configuration file, I can specify an offset (rtc_timeoffset = -18000) to get my clock to sync with the host. Is there a way to do specify this

[libvirt] [PATCH] proxy: Fix use of uninitalized memory

2009-01-27 Thread Rasputin
On short read, members of packet header are checked before actually read. If uninitialized values can pass the test, they can be set to arbitrary values while reading remaining portion of a packet. Buffer overflow is possible. libvirt_proxy is suid-root. diff -urp

Re: [libvirt] Clock problems with Windows guests and Xen

2009-01-27 Thread Matthew Donovan
On Tue, Jan 27, 2009 at 01:33:21PM -0500, Matthew Donovan wrote: When I start Windows guests with libvirt my clocks are 5 hours off. When I use a Xen configuration file, I can specify an offset (rtc_timeoffset = -18000) to get my clock to sync with the host. Is there a way to do specify

Re: [libvirt] PATCH: Support storage copy on write volumes

2009-01-27 Thread Daniel P. Berrange
On Tue, Jan 27, 2009 at 05:59:37PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: On Thu, Jan 22, 2009 at 07:15:19PM +0100, Jim Meyering wrote: Daniel P. Berrange berra...@redhat.com wrote: ... Did that, and likewise the similar allocation a little above this

Re: [libvirt] use virReportOOMError, not VIR_ERR_NO_MEMORY

2009-01-27 Thread Daniel P. Berrange
On Tue, Jan 27, 2009 at 04:57:58PM +0100, Jim Meyering wrote: I've changed over 200 uses of some_error_function with the VIR_ERR_NO_MEMORY flag to call virReportOOMError with whatever conn-like argument (if any) was in the original call. I don't claim to have tested these changes (OOM is a

Re: [libvirt] [PATCH 1/3] use virReportOOMError, not VIR_ERR_NO_MEMORY

2009-01-27 Thread Daniel P. Berrange
On Tue, Jan 27, 2009 at 04:59:20PM +0100, Jim Meyering wrote: Here's the big one: From 099536470ae2cbe9503ed471d391e403fb2587a4 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 27 Jan 2009 12:20:06 +0100 Subject: [PATCH 1/3] error-reporting calls using

Re: [libvirt] [PATCH 1/3] use virReportOOMError, not VIR_ERR_NO_MEMORY

2009-01-27 Thread Jim Meyering
Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jan 27, 2009 at 04:59:20PM +0100, Jim Meyering wrote: Here's the big one: From 099536470ae2cbe9503ed471d391e403fb2587a4 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 27 Jan 2009 12:20:06 +0100 Subject: [PATCH

Re: [libvirt] patch: allow disk cache mode to be specified in a domain's xml definition.

2009-01-27 Thread john cooper
Daniel P. Berrange wrote: If you loook at src/qemu_conf.c, you'll find a nice method called qemudExtractVersionInfo, which runs 'qemu -help' and checks for certain interesting command line arguments :-) That problem does seem to be crying for some type of structured interface to avoid subtle

[libvirt] libvirt for rhel-5?

2009-01-27 Thread Farkas Levente
hi, is there any plan to be able to buils libvirt on rhel-5 ie. epel-5? currently all virt and kvm releated packages can be build on epel except libvirt since this dbus problem. thanks in advance. -- gcc -I../gnulib/lib -I../gnulib/lib -I../include -I../include

[libvirt] [PATCH] Fix misuse of PF_UNIX

2009-01-27 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233105335 28800 # Node ID b3a2537e2f3d5ccb055df1820c112b469a26efdb # Parent 35f5d4f77a3f50cadacf32100fdbd992394f6002 Fix misuse of PF_UNIX PF_UNIX is a protocol familay, not a valid protocol, so isn't suitable for the 3rd socket() argument.

Re: [libvirt] [PATCH] trivial libvirt example code

2009-01-27 Thread Dave Allan
Jim Meyering wrote: Dave Allan dal...@redhat.com wrote: Richard W.M. Jones wrote: On Fri, Jan 23, 2009 at 02:51:02PM -0500, Dave Allan wrote: The examples directory doesn't have a trivial example of how to connect to a hypervisor, make a few calls, and disconnect, so I put one together. I

[libvirt] [PATCH] Install schemas into correct location for Solaris

2009-01-27 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233119659 28800 # Node ID cc848242fa810e8d0126b651849de715c7ef32e4 # Parent f91041f0c607be72c4b5695f081d20716521f6c5 Install schemas into correct location for Solaris Signed-off-by: John Levon john.le...@sun.com diff --git a/configure.in

[libvirt] [PATCH] Fixes for VNC port handling

2009-01-27 Thread john . levon
# HG changeset patch # User john.le...@sun.com # Date 1233118371 28800 # Node ID f91041f0c607be72c4b5695f081d20716521f6c5 # Parent 8fce2ce6108eb1ff1865ecc21d57114db036f2a2 Fixes for VNC port handling When parsing sexpr, the VNC port should not be ignored, even when vncunused is set. Fix the