Dave Allan dal...@redhat.com wrote:
...
+static int
+showDomains(virConnectPtr conn)
+{
+int ret = 0, i, numNames, numInactiveDomains, numActiveDomains;
+char **nameList = NULL;
+
+numActiveDomains = virConnectNumOfDomains(conn);
+numInactiveDomains =
john.le...@sun.com wrote:
Install schemas into correct location for Solaris
Signed-off-by: John Levon john.le...@sun.com
diff --git a/configure.in b/configure.in
--- a/configure.in
+++ b/configure.in
@@ -141,6 +141,10 @@ if test -n $UDEVSETTLE; then
On Tue, Jan 27, 2009 at 12:05:44AM -0500, Dave Allan wrote:
Thanks for taking a look at it. I added a little code to let the user
specify a URI on the command line. Do you think it is worth committing?
Yes, +1
Rich.
--
Richard Jones, Emerging Technologies, Red Hat
On Wed, Jan 28, 2009 at 01:00:49AM +0100, Farkas Levente wrote:
hi,
is there any plan to be able to buils libvirt on rhel-5 ie. epel-5?
currently all virt and kvm releated packages can be build on epel except
libvirt since this dbus problem.
This is already fixed in CVS.
autobuild.sh fails like this on at least RHEL5.3:
cc1: warnings being treated as errors
qemud.c: In function 'qemudClientReadBuf':
qemud.c:1470: warning: format '%d' expects type 'int', but argument 7 has
type 'ssize_t'
qemud.c: In function 'qemudClientWriteBuf':
Daniel P. Berrange wrote:
On Wed, Jan 28, 2009 at 01:00:49AM +0100, Farkas Levente wrote:
hi,
is there any plan to be able to buils libvirt on rhel-5 ie. epel-5?
currently all virt and kvm releated packages can be build on epel except
libvirt since this dbus problem.
This is already fixed
On Tue, Jan 27, 2009 at 09:23:52PM -0800, john.le...@sun.com wrote:
# HG changeset patch
# User john.le...@sun.com
# Date 1233119659 28800
# Node ID cc848242fa810e8d0126b651849de715c7ef32e4
# Parent f91041f0c607be72c4b5695f081d20716521f6c5
Install schemas into correct location for Solaris
On Wed, Jan 28, 2009 at 11:06:03AM +0100, Jim Meyering wrote:
john.le...@sun.com wrote:
Fix misuse of PF_UNIX
PF_UNIX is a protocol familay, not a valid protocol, so isn't suitable
for the 3rd socket() argument. Solaris should be ignoring the invalid
protocol anyway, but this fix is
On Tue, Jan 27, 2009 at 05:26:33PM -0800, john.le...@sun.com wrote:
# HG changeset patch
# User john.le...@sun.com
# Date 1233105335 28800
# Node ID b3a2537e2f3d5ccb055df1820c112b469a26efdb
# Parent 35f5d4f77a3f50cadacf32100fdbd992394f6002
Fix misuse of PF_UNIX
PF_UNIX is a protocol
On Mon, Jan 26, 2009 at 05:25:04AM -0800, john.le...@sun.com wrote:
# HG changeset patch
# User John Levon john.le...@sun.com
# Date 1232970961 28800
# Node ID 839f1721d6d9c2cfdbc9327814a4c4a9564ff814
# Parent 26d337992a98a00d98f83247eb113ca3d729d8ef
Fix stderr spewage from docs/examples
On Wed, Jan 28, 2009 at 12:17:40PM +0100, Farkas Levente wrote:
Daniel P. Berrange wrote:
On Wed, Jan 28, 2009 at 01:00:49AM +0100, Farkas Levente wrote:
hi,
is there any plan to be able to buils libvirt on rhel-5 ie. epel-5?
currently all virt and kvm releated packages can be build on
Daniel P. Berrange berra...@redhat.com wrote:
There statstest test case is expected to raise a number of libvirt
errors. Since these are now stored in thread locals, it is expected
that this won't be free'd automatically at system shutdown. This
patch adds a call to virResetError() at the end
I did a test build of CVS on Solaris and noticed it didn't detect SASL,
even though SASL was available. It turns out the library on SOlaris is
called libsasl.so, instead of libsasl2.so. It is still API compatible
with the Linux one, so there does not seem to be a reason not to use it
So this patch
On Tue, Jan 27, 2009 at 09:23:42PM -0800, john.le...@sun.com wrote:
Fixes for VNC port handling
When parsing sexpr, the VNC port should not be ignored, even when vncunused is
set. Fix the parsing of vncdisplay, which was broken due to strtol() (never
use this function!).
Signed-off-by:
Rasputin raspu...@email.ru wrote:
On short read, members of packet header are checked before actually read.
If uninitialized values can pass the test, they can be set to arbitrary
values while reading remaining portion of a packet.
Buffer overflow is possible. libvirt_proxy is suid-root.
As per previous patches from John for Solaris, we ned a couple more fixes
to the generated remote_protocol.c/h files for good portability.
Specifically we need
s/u_quad_t/uint64_t/g;
s/quad_t/int64_t/g;
s/xdr_u_quad_t/xdr_uint64_t/g;
s/xdr_quad_t/xdr_int64_t/g;
Rasputin raspu...@email.ru wrote:
On short read, members of packet header are checked before actually read.
If uninitialized values can pass the test, they can be set to arbitrary
values while reading remaining portion of a packet.
Buffer overflow is possible. libvirt_proxy is suid-root.
Jim Meyering j...@meyering.net wrote:
...
Thanks again.
Here's what I expect to commit.
Committed that.
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Jan 28, 2009 at 11:29:16AM +, Daniel P. Berrange wrote:
+device/vfb/vncdisplay);
+if (value != NULL)
+port = strtol(value, NULL, 0);
This isn't checking the return value of strtol, so it could have
parsed
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Jan 27, 2009 at 04:59:20PM +0100, Jim Meyering wrote:
Here's the big one:
From 099536470ae2cbe9503ed471d391e403fb2587a4 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 27 Jan 2009 12:20:06 +0100
Subject: [PATCH
You can ignore the patch numbering.
There was yet another one adjusting po/POTFILES.in
that I'm not bothering to post.
Probably not worth reviewing.
Some of it is just factorization.
Other bits reflect removal of coreutils-specific things (they're
migrating into coreutils' cfg.mk (was called
Testing current CVS on RHEL-5 host exposed a number of problems in the
Xen driver
- When opening the remote driver for the network / storage / nodedev
APIs, we had missed the initialization of several fields, resulting
in a crash
- Reporting of errors from the remote driver was leaking
Daniel P. Berrange berra...@redhat.com wrote:
Testing current CVS on RHEL-5 host exposed a number of problems in the
Xen driver
- When opening the remote driver for the network / storage / nodedev
APIs, we had missed the initialization of several fields, resulting
in a crash
-
# HG changeset patch
# User john.le...@sun.com
# Date 1233162577 28800
# Node ID 6ab030d99574ee01193e92846eb7c9b41bfcd149
# Parent 5a0860d81ed44d5f189788fc340f975517595160
Fixes for VNC port handling
When parsing sexpr, the VNC port should not be ignored, even when vncunused is
set. Fix the
On Wed, Jan 28, 2009 at 05:12:16PM +0100, Jim Meyering wrote:
You can ignore the patch numbering.
There was yet another one adjusting po/POTFILES.in
that I'm not bothering to post.
Probably not worth reviewing.
Some of it is just factorization.
Other bits reflect removal of
On Thu, 2009-01-22 at 15:20 +, Daniel P. Berrange wrote:
On Thu, Jan 22, 2009 at 03:12:39PM +, Richard W.M. Jones wrote:
On Tue, Jan 20, 2009 at 02:05:26PM +0300, Dmitry Guryanov wrote:
But for working PXE boot it should have also something like
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Jan 20, 2009 at 11:08:56PM +, Daniel P. Berrange wrote:
This patch adds support for using the monitor interface to set the VNC
password
(qemu) change vnc password
Password:
A minor tricky thing is that we can't just
On Wed, Jan 28, 2009 at 06:24:17PM +, David Lutterkort wrote:
I always felt it's a mistake to work so hard to hide the actual dnsmasq
config from users - it would be much more extensible if we plonked a
config file into /etc/dnsmasq.d
Wouldn't necessarily go as far as adding a config file
Daniel P. Berrange berra...@redhat.com wrote:
I noticed a odd error message randomly appearing from virsh after all
commands had been run
# virsh dominfo VirtTest
Id: -
Name: VirtTest
UUID: 82038f2a-1344-aaf7-1a85-2a7250be2076
OS Type:hvm
Daniel P. Berrange berra...@redhat.com wrote:
As per previous patches from John for Solaris, we ned a couple more fixes
to the generated remote_protocol.c/h files for good portability.
Specifically we need
s/u_quad_t/uint64_t/g;
s/quad_t/int64_t/g;
# HG changeset patch
# User john.le...@sun.com
# Date 1233177786 28800
# Node ID 2b9283e83c20ca2a18f2cafcb963ce254e11dbb4
# Parent 9a9bd34ec485ebaf4c3861bdfffd2953fd91a1fc
Fix floppy definition for HVM guests
Code was missing to define floppy disks for Xen HVM guests. Refuse to
attach disks
On Wed, Jan 28, 2009 at 07:46:34PM +0100, Jim Meyering wrote:
Daniel P. Berrange berra...@redhat.com wrote:
On Tue, Jan 20, 2009 at 11:08:56PM +, Daniel P. Berrange wrote:
This patch adds support for using the monitor interface to set the VNC
password
(qemu) change vnc password
# HG changeset patch
# User john.le...@sun.com
# Date 1233198416 28800
# Node ID 76d670ab6ea5476be96441ea88af94644c985201
# Parent f0247b9f4da199c01412d5bd0f9d7d888cbb84de
Solaris PV is localtime. Allow this setting through the conversions.
Signed-off-by: John Levon john.le...@sun.com
diff
# HG changeset patch
# User john.le...@sun.com
# Date 1233199841 28800
# Node ID 3f2af372963ddbae509bd0d1b2e7bdf3ebb4f217
# Parent 76d670ab6ea5476be96441ea88af94644c985201
Fix another printf(%s, NULL) case
Signed-off-by: John Levon john.le...@sun.com
diff --git a/src/libvirt.c b/src/libvirt.c
The following patches provide a small example program that illustrates how to
connect to libvirt, make a few API calls and disconnect. The first patch is my
first cut at it with feedback from Rich Jones. The second patch implements
feedback from Jim Meyering.
The third patch is completely
Added examples/hellolibvirt to the parent autoconf/automake files and created
Makefile.am
---
Makefile.am |2 +-
configure.in |3 ++-
examples/hellolibvirt/Makefile.am |5 +
3 files changed, 8 insertions(+), 2 deletions(-)
create mode
Handle failure of virConnectNumOfDomains and virConnectNumOfDefinedDomains
Changed malloc to use size of variable, not type
Removed unneeded NULL check before free
Removed unneeded initialization of several variables
Changed assignment to use the ternary operator
---
This example code illustrates connecting to the hypervisor and making some
simple API calls.
Added a little code to let the user specify the URI of the hypervisor on the
command line, per the suggestion of Rich Jones.
---
examples/hellolibvirt/hellolibvirt.c | 151
# HG changeset patch
# User john.le...@sun.com
# Date 1233203295 28800
# Node ID 9aac8028d5f266023c85338afe71ecabe26079f7
# Parent add5d46423d8cc24ac922373ba5cd1b3ea2e6f9f
Fix xend XML generation when CPU pinning is used
Signed-off-by: John Levon john.le...@sun.com
diff --git
2 questions.
1)Would you explain the use case for libvirt-qpid?
Which case AMDQ messaging is good for.
If I am missing some document, Please point me.
By the way I am reading through following document.
http://jira.amqp.org/confluence/download/attachments/2523279/amqp-model-draft101.pdf
Hi,
it seems that we share the interest.
Konrad Eriksson1 wrote:
Yes, we're looking into adding similar form of access control in libvirt.
The approach we're looking at is to inject AC as a module that
intercepts calls from the libvirt core (libvirt.c) to the drivers.
Reason:
* AC
Hi,
thanks for your analysis.
Daniel P. Berrange wrote:
There are lots of scenarios to consider
- Direct local API usage. You have the PID, UID GID of the process
- Local usage via libvirtd + UNIX sockets. You can get the PID, UID GID
of the client end using the SCM_CREDENTIALS
42 matches
Mail list logo
