On Mon, Mar 02, 2009 at 08:51:01PM +, Daniel P. Berrange wrote:
> The PCI passthrough patches made it so that qemudBuildCommandLine() would
> actually try to detach your host devices & reset them. Most definitely not
> what you want when running this via a test case!
>
> This patch moves the h
The PCI passthrough patches made it so that qemudBuildCommandLine() would
actually try to detach your host devices & reset them. Most definitely not
what you want when running this via a test case!
This patch moves the host device management out into a separate method,
so that qemudBuildCommandLin
Daniel P. Berrange wrote:
...
> I really don't like these kind of tests in here - tests of the
> live drivers should be part of a separate integration test suite
> bundle, that's independant of main code releases.
As I already mentioned, adding them here is simply a
stop-gap measure to ensure we r
On Mon, Mar 02, 2009 at 08:10:23PM +0100, Jim Meyering wrote:
> diff --git a/tests/libvirtd-fail b/tests/libvirtd-fail
> new file mode 100755
> index 000..92b82c4
> --- /dev/null
> +++ b/tests/libvirtd-fail
> @@ -0,0 +1,21 @@
> +#!/bin/sh
> +# Ensure that libvirt fails when given nonexistent --
On Mon, Mar 02, 2009 at 07:38:50PM +0100, Jim Meyering wrote:
> I'm about to commit these (like what I already posted,
> but now the test kills libvirtd):
>
> >From 944052f2287f1a07034be16ea08d620c55eecd6e Mon Sep 17 00:00:00 2001
> From: Jim Meyering
> Date: Mon, 2 Mar 2009 14:46:20 +0100
> Subj
On Mon, Mar 02, 2009 at 07:38:50PM +0100, Jim Meyering wrote:
> I'm about to commit these (like what I already posted,
> but now the test kills libvirtd):
okay, it's always annoying to change virsh output, though,
ACK
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xm
On Mon, Mar 02, 2009 at 01:57:45PM -0500, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> > On Mon, Mar 02, 2009 at 01:27:33PM -0500, Cole Robinson wrote:
> >> The attached patch changes the qemu driver blockStats command to not log
> >> qemu monitor output. virt-manager offers an option to cont
On Mon, Mar 02, 2009 at 06:28:12PM +, Daniel P. Berrange wrote:
> If building with --with-driver-modules, the Xen and OpenVZ drivers fail to
> dlopen() because of a couple of missing symbol exports. THis patch adds
> them
ACK.
Reminder, it's fine to commit build failure fix before posting :-
On Mon, Mar 02, 2009 at 06:27:17PM +, Daniel P. Berrange wrote:
> Mark's patches added a attribute managed='yes|no' for PCI
> configuration. This allows the caller app to indicate who is responsible
> for attaching/detaching the PCI device from the host drivers. When using
> managed=yes, li
---
src/storage_backend_iscsi.c | 327 +-
src/storage_backend_scsi.c | 649 ---
src/storage_backend_scsi.h | 22 +-
3 files changed, 319 insertions(+), 679 deletions(-)
diff --git a/src/storage_backend_iscsi.c b/src/storage_backend
Last March, DanPB posted code to create pools from SCSI HBAs. This patch is
simply bringing that code into the current tree.
* src/storage_backend_scsi.[ch] contain the pool implementataion
* There are small changes to several other source files to integrate the new
pool type.
---
configure.in
---
configure.in|2 +-
src/Makefile.am |1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/configure.in b/configure.in
index b88a7d5..995fac5 100644
--- a/configure.in
+++ b/configure.in
@@ -1168,7 +1168,7 @@ LV_LIBTOOL_OBJDIR=${lt_cv_objdir-.}
AC_SUBST([LV_LIBTOOL_OB
These three patches contain a rework of the SCSI host storage pool patch. The
rework extracts the LUN discovery code from the iSCSI backend and generalizes
it be be usable by both the SCSI and iSCSI backends. The first patch is the
one I submitted last week that contains a port of Dan's HAL c
Here's a rebased patch from a month or two ago.
It's only fixing and adding tests, so I'll commit it momentarily.
Dan Berrange noticed that daemon-conf could interfere with
existing domains, so the latter patch below makes it use the
new log-setting and unix_sock_dir-setting config options as
well
FYI, I'm committing this as obvious.
Otherwise, you'd get this:
grep: /h/meyering/w/co/libvirt/lib/config.h: No such file or directory
./daemon-conf: skipping test: configured without QEMU support
SKIP: daemon-conf
>From e92b94d5b84d2f840ea3e0f88c17411167cfeac8 Mon Sep 17 00:00:00 2001
From
Daniel P. Berrange wrote:
> On Mon, Mar 02, 2009 at 01:27:33PM -0500, Cole Robinson wrote:
>> The attached patch changes the qemu driver blockStats command to not log
>> qemu monitor output. virt-manager offers an option to continually poll
>> VM disk stats, and if the app is left running for a whi
I'm about to commit these (like what I already posted,
but now the test kills libvirtd):
>From 944052f2287f1a07034be16ea08d620c55eecd6e Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 2 Mar 2009 14:46:20 +0100
Subject: [PATCH 1/2] virsh: tweak a format string to avoid emitting trailing
sp
On Mon, Mar 02, 2009 at 01:27:33PM -0500, Cole Robinson wrote:
> The attached patch changes the qemu driver blockStats command to not log
> qemu monitor output. virt-manager offers an option to continually poll
> VM disk stats, and if the app is left running for a while with many VMs,
> this can ma
On Mon, Mar 02, 2009 at 03:18:43PM +0100, Jim Meyering wrote:
> I found network-related config from one test leaking into another
> and making the latter test fail, despite my use of what I thought
> was everything required to keep them separate (unix_sock_dir and
> log_outputs both set in config,
The attached patch changes the qemu driver blockStats command to not log
qemu monitor output. virt-manager offers an option to continually poll
VM disk stats, and if the app is left running for a while with many VMs,
this can make the logs huge, for little benefit (a user reported 100 MB
with virt-
If building with --with-driver-modules, the Xen and OpenVZ drivers fail to
dlopen() because of a couple of missing symbol exports. THis patch adds
them
Daniel
Index: src/libvirt_private.syms
===
RCS file: /data/cvs/libvirt/src/libvir
Mark's patches added a attribute managed='yes|no' for PCI
configuration. This allows the caller app to indicate who is responsible
for attaching/detaching the PCI device from the host drivers. When using
managed=yes, libvirt does it, while using managed=no, the someone else
should do it - typic
Jim Meyering wrote:
> Cole Robinson wrote:
> ...
>> Okay, I rolled these changes and the BridgeInUse changes into one patch
>> (along with Jim's suggestions).
>>
>> I added a helper function SetBridgeName which basically does:
>>
>> if user passed bridge name:
>> verify it doesn't collide
>> else
Cole Robinson wrote:
> Daniel P. Berrange wrote:
>> On Mon, Feb 16, 2009 at 06:42:11PM -0500, Cole Robinson wrote:
>>> For some reason there are two VMDef members being used to keep track of
>>> monitor event handles: monitor_watch and monitorWatch. Remove the latter.
>> Can you remove the 'monitor
Cole Robinson wrote:
> The attached patch fixes qemu AttachDevice to show the invalid disk bus
> or type in it's error messages. This also adds an error message where
> previously we could fall through, leading virsh to print 'Unknown Error'
> if attempting to hotplug an IDE disk.
>
Committed no
Cole Robinson wrote:
> The host device hal driver can't tell when a storage device has media
> available, the culprit being an incorrect return value check. The
> attached patch fixes this.
>
Committed now.
Thanks,
Cole
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/m
Cole Robinson wrote:
> We aren't setting the persistent bit when a network is defined, so
> 'destroy' makes them disappear (though they will reappear later since
> their persistent config is never removed).
>
Committed now.
Thanks,
Cole
--
Libvir-list mailing list
Libvir-list@redhat.com
https:/
Cole Robinson wrote:
> The attached patch fixes qemu AttachDevice to show the invalid disk bus
> or type in it's error messages. This also adds an error message where
> previously we could fall through, leading virsh to print 'Unknown Error'
> if attempting to hotplug an IDE disk.
definite improve
On Fri, Feb 27, 2009 at 11:17:58AM -0500, Cole Robinson wrote:
> The attached patch fixes qemu AttachDevice to show the invalid disk bus
> or type in it's error messages. This also adds an error message where
> previously we could fall through, leading virsh to print 'Unknown Error'
> if attempting
On Fri, Feb 27, 2009 at 11:14:09AM -0500, Cole Robinson wrote:
> virsh attempts to validate the requested disk type, rather than just let
> the underlying driver do it. This was erroneously denying floppy device
> attaches. Patch attached.
ACK
Daniel
--
|: Red Hat, Engineering, London -o- ht
On Fri, Feb 27, 2009 at 11:12:12AM -0500, Cole Robinson wrote:
> The host device hal driver can't tell when a storage device has media
> available, the culprit being an incorrect return value check. The
> attached patch fixes this.
>
> Unfortunately the driver also doesn't properly detect media ej
On Fri, Feb 27, 2009 at 10:38:45AM -0500, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> > On Mon, Feb 16, 2009 at 06:42:11PM -0500, Cole Robinson wrote:
> >> For some reason there are two VMDef members being used to keep track of
> >> monitor event handles: monitor_watch and monitorWatch. Remo
On Fri, Feb 27, 2009 at 10:57:20AM -0500, Cole Robinson wrote:
> We aren't setting the persistent bit when a network is defined, so
> 'destroy' makes them disappear (though they will reappear later since
> their persistent config is never removed).
>
> Attached patch fixes this.
ACK
Daniel
--
|
On Fri, Feb 27, 2009 at 10:57:35AM -0500, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> > On Mon, Feb 16, 2009 at 06:40:59PM -0500, Cole Robinson wrote:
> >> diff --git a/src/network_driver.c b/src/network_driver.c
> >> index d750565..d83f902 100644
> >> --- a/src/network_driver.c
> >> +++ b/s
Daniel P. Berrange wrote:
...
>> Changing how the test driver handles this case
>> won't give a better diagnostic for all the other drivers.
>
> At the same time though you don't want to fill virsh up with a pile of
> different error reporting logic for each & every driver. The fine grained
> error
On Mon, Mar 02, 2009 at 05:29:58PM +0100, Jim Meyering wrote:
> Cole Robinson wrote:
> > Jim Meyering wrote:
> >> Cole Robinson wrote:
> >>> virsh attempts to validate the requested disk type, rather than just let
> >>> the underlying driver do it. This was erroneously denying floppy device
> >>> a
On Thu, Feb 26, 2009 at 02:56:13PM +, Daniel P. Berrange wrote:
> On Wed, Feb 25, 2009 at 08:17:08PM +, Mark McLoughlin wrote:
> > Add implementations of dettach, reattach and reset for
> > PCI devices.
[...]
> > Signed-off-by: Mark McLoughlin
>
> In absence of any objections, I ACK this
On Mon, Mar 02, 2009 at 11:18:24AM -0500, Cole Robinson wrote:
> Jim Meyering wrote:
> > Cole Robinson wrote:
> >> virsh attempts to validate the requested disk type, rather than just let
> >> the underlying driver do it. This was erroneously denying floppy device
> >> attaches. Patch attached.
> >
Cole Robinson wrote:
> Jim Meyering wrote:
>> Cole Robinson wrote:
>>> virsh attempts to validate the requested disk type, rather than just let
>>> the underlying driver do it. This was erroneously denying floppy device
>>> attaches. Patch attached.
>>
>> Hi Cole,
>> Your patch would do the job.
>>
On Mon, Mar 02, 2009 at 05:06:48PM +0100, Jim Meyering wrote:
> Cole Robinson wrote:
> > virsh attempts to validate the requested disk type, rather than just let
> > the underlying driver do it. This was erroneously denying floppy device
> > attaches. Patch attached.
>
> Hi Cole,
> Your patch woul
Jim Meyering wrote:
> Cole Robinson wrote:
>> virsh attempts to validate the requested disk type, rather than just let
>> the underlying driver do it. This was erroneously denying floppy device
>> attaches. Patch attached.
>
> Hi Cole,
> Your patch would do the job.
> Before:
>
> $ virsh -c tes
Cole Robinson wrote:
> virsh attempts to validate the requested disk type, rather than just let
> the underlying driver do it. This was erroneously denying floppy device
> attaches. Patch attached.
Hi Cole,
Your patch would do the job.
Before:
$ virsh -c test:///default attach-disk 1 s t --type
Cole Robinson wrote:
> The host device hal driver can't tell when a storage device has media
> available, the culprit being an incorrect return value check. The
> attached patch fixes this.
>
> Unfortunately the driver also doesn't properly detect media eject and
> media inserted hal events. I've
On Mon, Mar 02, 2009 at 03:15:17PM +0100, Matthias Dahl wrote:
> Hi.
>
> I am currently setting up a new server machine which will host several kvm's
> managed largely by libvirt. The network setup though is done prior to
> libvirtd
> startup and shouldn't be touched by it.
>
> So currently ev
Cole Robinson wrote:
...
> Okay, I rolled these changes and the BridgeInUse changes into one patch
> (along with Jim's suggestions).
>
> I added a helper function SetBridgeName which basically does:
>
> if user passed bridge name:
> verify it doesn't collide
> else:
> generate bridge name
>
> W
Jim Meyering wrote:
> Cole Robinson wrote:
>> We aren't setting the persistent bit when a network is defined, so
>> 'destroy' makes them disappear (though they will reappear later since
>> their persistent config is never removed).
>>
>> Attached patch fixes this.
>
> Hi Cole,
>
> Looks like you're
Daniel P. Berrange wrote:
> On Mon, Mar 02, 2009 at 09:18:05AM +1100, James Morris wrote:
>> On Fri, 27 Feb 2009, Daniel J Walsh wrote:
>>
>>> I think we need a mechanism in libvirtd.conf to turn this off. And
>>> allow perhaps three modes.
>>>
>>> svirt=Disabled. No Security Driver.
>>> svirt=M
I found network-related config from one test leaking into another
and making the latter test fail, despite my use of what I thought
was everything required to keep them separate (unix_sock_dir and
log_outputs both set in config, and --pid-file specified on command line).
Unfortunately, there are s
Hi.
I am currently setting up a new server machine which will host several kvm's
managed largely by libvirt. The network setup though is done prior to libvirtd
startup and shouldn't be touched by it.
So currently everything works just fine with 0.6.0 except that libvirt deletes
the tap device
Jim Meyering wrote:
> Cole Robinson wrote:
>> We aren't setting the persistent bit when a network is defined, so
>> 'destroy' makes them disappear (though they will reappear later since
>> their persistent config is never removed).
>>
>> Attached patch fixes this.
>
> Hi Cole,
>
> Looks like you're
Cole Robinson wrote:
> We aren't setting the persistent bit when a network is defined, so
> 'destroy' makes them disappear (though they will reappear later since
> their persistent config is never removed).
>
> Attached patch fixes this.
Hi Cole,
Looks like you're on the right track.
My reflex wa
On Wed, Feb 18, 2009 at 01:59:24PM +, Daniel P. Berrange wrote:
> We are using DBus from multiple threads in libvirtd. We are not calling
> dbus_threads_init_default(). Very bad things result. Happy-crashy-daemon
>
> This patch fixes that, and also stops DBus messing around with SIGPIPE and
>
On Mon, Mar 02, 2009 at 09:18:05AM +1100, James Morris wrote:
> On Fri, 27 Feb 2009, Daniel J Walsh wrote:
>
> > I think we need a mechanism in libvirtd.conf to turn this off. And
> > allow perhaps three modes.
> >
> > svirt=Disabled. No Security Driver.
> > svirt=MLS (Requires context in xml,
Cole Robinson wrote:
> Daniel P. Berrange wrote:
>> On Mon, Feb 16, 2009 at 06:42:11PM -0500, Cole Robinson wrote:
>>> For some reason there are two VMDef members being used to keep track of
>>> monitor event handles: monitor_watch and monitorWatch. Remove the latter.
>>
>> Can you remove the 'moni
On Thu, Feb 26, 2009 at 02:56:13PM +, Daniel P. Berrange wrote:
> > +/* PM12 3.2.4 Power Management Control/Status (Offset = 4) */
> > +#define PCI_PM_CTRL4/* PM control and status register
> > */
> > +#define PCI_PM_CTRL_STATE_MASK0x3 /* Current power state (D0 to D
Daniel Veillard wrote:
> On Mon, Mar 02, 2009 at 10:13:11AM +0100, Jim Meyering wrote:
>> Ryota Ozaki wrote:
>> > These patches fix:
>> > - missing VIR_FREE for the return value of virXPathString
>> > - wrong error message "missing owner element" where should be "missing
>> > group element"
>>
>> T
Daniel Veillard wrote:
> On Mon, Mar 02, 2009 at 10:14:04AM +0100, Jim Meyering wrote:
>>
>> >From a907d2da7e7f9d1f58009ff6a95454ac0eb2cbf1 Mon Sep 17 00:00:00 2001
>> From: Jim Meyering
>> Date: Mon, 2 Mar 2009 10:10:02 +0100
>> Subject: [PATCH] don't dereference uninitialized pointer
>>
>> * src
On Mon, Mar 02, 2009 at 10:14:04AM +0100, Jim Meyering wrote:
>
> >From a907d2da7e7f9d1f58009ff6a95454ac0eb2cbf1 Mon Sep 17 00:00:00 2001
> From: Jim Meyering
> Date: Mon, 2 Mar 2009 10:10:02 +0100
> Subject: [PATCH] don't dereference uninitialized pointer
>
> * src/storage_conf.c (virStoragePoo
On Mon, Mar 02, 2009 at 10:13:11AM +0100, Jim Meyering wrote:
> Ryota Ozaki wrote:
> > These patches fix:
> > - missing VIR_FREE for the return value of virXPathString
> > - wrong error message "missing owner element" where should be "missing
> > group element"
>
> Thank you!
> Both of those are f
On (Tue) Feb 24 2009 [11:58:31], Daniel P. Berrange wrote:
> On Tue, Feb 24, 2009 at 05:09:31PM +0530, Amit Shah wrote:
...
> > The best case to get a non-fragmented VM image is to have it allocated
> > completely at create-time with fallocate().
>
> The main problem with this change is that it'll
Ryota Ozaki wrote:
> These patches fix:
> - missing VIR_FREE for the return value of virXPathString
> - wrong error message "missing owner element" where should be "missing
> group element"
Thank you!
Both of those are fine.
I'll apply them today.
FYI, looking at the first one, I spotted another
>From a907d2da7e7f9d1f58009ff6a95454ac0eb2cbf1 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 2 Mar 2009 10:10:02 +0100
Subject: [PATCH] don't dereference uninitialized pointer
* src/storage_conf.c (virStoragePoolDefParsePerms): Initialize
"ptr" to NULL.
---
ChangeLog |6 ++
62 matches
Mail list logo
