Re: [libvirt] Problem with the current svirt patch

2009-03-16 Thread Daniel P. Berrange
On Mon, Mar 16, 2009 at 02:30:24PM -0400, Daniel J Walsh wrote: > On 03/13/2009 11:45 AM, Daniel P. Berrange wrote: > >On Fri, Mar 13, 2009 at 11:03:26AM -0400, Daniel J Walsh wrote: > >>The current svirt patch relabels all disk to the image_t:MCS, which is > >>incorrect. Read Only Disks and Shara

Re: [libvirt] [RFC][PATCH] storage: allow alphabetical names in owner/group of permissions

2009-03-16 Thread Daniel P. Berrange
On Mon, Mar 16, 2009 at 10:01:38AM +0100, Daniel Veillard wrote: > On Sun, Mar 15, 2009 at 02:47:14AM +0900, Ryota Ozaki wrote: > > Hi, > > > > This patch allows to specify owner/group of permissions in storage XML > > as alphabetical names. > > > > One concern of this patch is since alphabetical

[libvirt] The gui should drop the connection if libvirt stops for any reason like service libvirt stop.

2009-03-16 Thread Daniel J Walsh
diff -u virtManager/engine.py~ virtManager/engine.py --- virtManager/engine.py~ 2009-03-16 14:49:16.0 -0400 +++ virtManager/engine.py 2009-03-16 14:58:05.0 -0400 @@ -158,6 +158,7 @@ logging.error(("Could not refresh connection %s\n" % (uri)) + str(sys.e

Re: [libvirt] Problem with the current svirt patch

2009-03-16 Thread Daniel J Walsh
On 03/13/2009 11:45 AM, Daniel P. Berrange wrote: On Fri, Mar 13, 2009 at 11:03:26AM -0400, Daniel J Walsh wrote: The current svirt patch relabels all disk to the image_t:MCS, which is incorrect. Read Only Disks and Sharable Disks should not be labeled. Also when libvirt is completed running t

Re: [libvirt] [RFC][PATCH] storage: allow alphabetical names in owner/group of permissions

2009-03-16 Thread Ryota Ozaki
Hi Daniel, On Mon, Mar 16, 2009 at 6:01 PM, Daniel Veillard wrote: > On Sun, Mar 15, 2009 at 02:47:14AM +0900, Ryota Ozaki wrote: >> Hi, >> >> This patch allows to specify owner/group of permissions in storage XML >> as alphabetical names. >> >> One concern of this patch is since alphabetical nam

[libvirt] PATCH: Be more flexible in emulator choice on x86 archs

2009-03-16 Thread Daniel P. Berrange
Currently we are pretty strict about what emulator binary we allow for QEMU guests on x86 arches. In particular, for arch+domain type combos: - i686+qemu must use 'qemu' binary - x86_64+qemu must use 'qemu-system-x86_64' binary - kvm must use 'qemu-kvm' or 'kvm' binaries - i686+kvm on x86_64 h

Re: [libvirt] [PATCH] Don't allow read only connection to use SECURE_XML

2009-03-16 Thread Cole Robinson
Cole Robinson wrote: > Seems to me that a read only connection shouldn't be able to dump domain > xml with the SECURE flag. Attached patch blocks the attempt with an > explicit error message. > Applied now. Thanks, Cole -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/m

Re: [libvirt] [PATCH] Fix test driver domain save

2009-03-16 Thread Cole Robinson
Cole Robinson wrote: > Saving a domain via the test driver currently locks up, since the save > command is calling out to another public driver method. The attached > patch fixes this. > Applied now. Thanks, Cole -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/

Re: [libvirt] [PATCH] Parse qemu config before SecurityInit

2009-03-16 Thread Cole Robinson
Cole Robinson wrote: > We aren't parsing qemu.conf before initializing the security driver, yet > the config contains relevant security options. The attached patch swaps > the ordering, which fixes things for me. > > Thanks, > Cole > > Applied now. Thanks, Cole -- Libvir-list mailing list Lib

[libvirt] [PATCH] leak of file descriptors in remote code

2009-03-16 Thread Daniel Veillard
We never deallocate the pipe used to do the wake-up trick, loosing 2 descriptor per connection opened in a process, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | vir

[libvirt] [RFC][PATCH]: Secure migration

2009-03-16 Thread Chris Lalancette
All, Attached is a *very* rough first draft of the secure migration code I'm working on. This is in no way ready for merge. That being said, this demonstrates the basic idea that I'm pursuing, and I've actually been able to perform a KVM secure live migrate using this. Before I go and finis

[libvirt] [PATCH] Openvz: how to use a nondefault config

2009-03-16 Thread Anton Protopopov
Hi all. When libvirt creates an OpenVZ machine, it does smth like # vzctl create $ctid --ostemplate `ostemplate` And we can't specify an --config `config` argument. In this case vzctl chooses a default config file (a value of CONFIG variable from /etc/vz/vz.conf). But there are cases when we wa

Re: [libvirt] shit-off domains

2009-03-16 Thread Daniel P. Berrange
On Mon, Mar 16, 2009 at 05:03:10PM +0200, Zvi Dubitzky wrote: > I do not see a way to get the shut-off domain list from a libvirt API > (case when no id shown under virsh , just domain name) The virConnectListDefinedDomains() API gives you that info Daniel -- |: Red Hat, Engineering, Londo

[libvirt] shit-off domains

2009-03-16 Thread Zvi Dubitzky
I do not see a way to get the shut-off domain list from a libvirt API (case when no id shown under virsh , just domain name) Am I missing something ? thanks Zvi Dubitzky Virtualization and System Architecture Email:d...@il.ibm.com IBM Haifa Research LaboratoryPhone: +972-4-8296182 Hai

Re: [libvirt] [PATCH] fix Xen event handling

2009-03-16 Thread Nick Moffitt
Daniel P. Berrange: > On Thu, Mar 12, 2009 at 10:04:50PM +, Nick Moffitt wrote: > > http://dpaste.com/13740/ [snip] > The patch fixes the loop which dispatches callbacks, so that it does > not assume the index into 'nfds' matches the index in 'handles'. They > have to be tracked indepedantl

Re: [libvirt] PATCH: Support memory ballooning for QEMU

2009-03-16 Thread Daniel P. Berrange
On Tue, Mar 10, 2009 at 05:39:22PM +, Daniel P. Berrange wrote: > This patch implements full support for memory ballooning in the QEMU > driver. > > - Fix qemudBuildCommandLine() to set the initial boot time VM memory >allocation based off the 'maxmem' config field. > - Add call to 'qem

[libvirt] PATCH: PCI device passthrough in Xen driver

2009-03-16 Thread Daniel P. Berrange
This patch provides initial support for PCI device passthrough in Xen, at time of boot. It does not (yet) implement device hotplug for PCI, since it works in an annoyingly different way to device hotplug of disks & nics. The patch has several aspects - Refactors the pci.c file to make it easier t

Re: [libvirt] libvirt-cim

2009-03-16 Thread Daniel P. Berrange
On Sat, Mar 14, 2009 at 09:26:45AM +0200, Zvi Dubitzky wrote: > Hi > can someone tell me what is libvirt-cim . Does it mean libvirt utilized > by CIM or there is a special 'dialect' called livirt-cim libvirt-CIM is a wrapper around libvirt that implements a CIM provider for the DMTF virtualiz

Re: [libvirt] [PATCH] Don't allow read only connection to use SECURE_XML

2009-03-16 Thread Daniel P. Berrange
On Fri, Mar 13, 2009 at 05:08:08PM -0400, Cole Robinson wrote: > Seems to me that a read only connection shouldn't be able to dump domain > xml with the SECURE flag. Attached patch blocks the attempt with an > explicit error message. ACK, seems like a reasonable idea. Daniel > diff --git a/src/l

Re: [libvirt] [PATCH] Fix test driver domain save

2009-03-16 Thread Daniel P. Berrange
On Fri, Mar 13, 2009 at 05:07:52PM -0400, Cole Robinson wrote: > Saving a domain via the test driver currently locks up, since the save > command is calling out to another public driver method. The attached > patch fixes this. ACK. I should add this 'public API calls public API' scenario to the C

Re: [libvirt] [PATCH] Parse qemu config before SecurityInit

2009-03-16 Thread Daniel P. Berrange
On Fri, Mar 13, 2009 at 05:07:33PM -0400, Cole Robinson wrote: > We aren't parsing qemu.conf before initializing the security driver, yet > the config contains relevant security options. The attached patch swaps > the ordering, which fixes things for me. ACK Daniel > diff --git a/src/qemu_driver

Re: [libvirt] [PATCH] trying to close some potential FILE * leaks

2009-03-16 Thread Daniel P. Berrange
On Fri, Mar 13, 2009 at 06:20:21PM +0100, Daniel Veillard wrote: > While reviewing the code due to what seems to be a FILE * leak I > found the following problems, probably not what got me in troubles but > should still be fixed, ACK, all looks good. Daniel > Index: qemud/qemud.c >

Re: [libvirt] [RFC][PATCH] storage: allow alphabetical names in owner/group of permissions

2009-03-16 Thread Daniel Veillard
On Sun, Mar 15, 2009 at 02:47:14AM +0900, Ryota Ozaki wrote: > Hi, > > This patch allows to specify owner/group of permissions in storage XML > as alphabetical names. > > One concern of this patch is since alphabetical names are converted > to uid/gid at XML parsing (e.g., virsh pool-define some-