[libvirt] Re: [PATCH] Hardware watchdog patch, version 6 (was: Re: [Qemu-devel] [PATCH] Hardware watchdog patch, version 5)

2009-04-08 Thread Richard W.M. Jones
On Tue, Apr 07, 2009 at 04:19:42PM -0500, Hollis Blanchard wrote: > Hi Rich, your watchdog qemu patch is working fine for me (i6300esb, > default reset behavior), Hi, first of all thanks for testing this. I'm going to put forward an updated/finalized patch but it won't be til next week. > but I

Re: [libvirt] [PATCH 0/1] NPIV support

2009-04-08 Thread Daniel P. Berrange
On Tue, Apr 07, 2009 at 05:16:30PM -0400, David Allan wrote: > > This patch implements NPIV support. I don't have easy access to an > NPIV capable switch at the moment, so this is all untested code at > least from the perspective of whether it actually creates and deletes > virtual adapters, but

Re: [libvirt] [PATCH 1/1] Implement NPIV

2009-04-08 Thread Daniel P. Berrange
On Tue, Apr 07, 2009 at 05:16:31PM -0400, David Allan wrote: > > static int > +virStorageBackendVportCreateDelete(virConnectPtr conn, > + virStoragePoolObjPtr pool, > + int operation) > +{ > +int fd = -1; > +int retval =

Re: [libvirt] [PATCH] lxc: fix veth off by 1 error

2009-04-08 Thread Daniel P. Berrange
On Tue, Apr 07, 2009 at 04:21:39PM -0500, Serge E. Hallyn wrote: > When not specifying a target for veth device, veth.c:getFreeVethName() > is supposed to scan for unused veth devices in /sys/class/net. > However, when it finds one, it bumps the index by one before > returning it. > > So, if you h

Re: [libvirt] [PATCH 0/1] NPIV support

2009-04-08 Thread Daniel P. Berrange
On Tue, Apr 07, 2009 at 05:16:30PM -0400, David Allan wrote: > > This patch implements NPIV support. I don't have easy access to an > NPIV capable switch at the moment, so this is all untested code at > least from the perspective of whether it actually creates and deletes > virtual adapters, but

Re: [libvirt] 802.1q vlan-tagging support for libvirt

2009-04-08 Thread Maximilian Wilhelm
Anno domini 2009 Daniel P. Berrange scripsit: [...] > In the (nearish) future NICs will start appearing with SR-IOV capabilities. > This gives you one physical PCI device, whcih exposes multiple functions. > So a single physical NIC appears as 8 NICs to the OS. You can thus directly > assign each

Re: [libvirt] 802.1q vlan-tagging support for libvirt

2009-04-08 Thread Maximilian Wilhelm
Anno domini 2009 Daniel P. Berrange scripsit: > On Wed, Apr 08, 2009 at 01:06:48PM +0200, Maximilian Wilhelm wrote: > > Anno domini 2009 Daniel P. Berrange scripsit: That was a *really* _fast_ reply :) > > [...] > > > In the (nearish) future NICs will start appearing with SR-IOV > > > capabilit

[libvirt] [PATCH 1/2] VirtualBox support

2009-04-08 Thread Pritesh Kothari
Hi All, I have attached a patch which when applied on the HEAD as of today would allow virtualbox support in libvirt. It takes cares of all the stuff mentioned on the list earlier. Still if I have missed anything, please do tell me. The patch works very well with the VirtualBox OSE version and

Re: [libvirt] 802.1q vlan-tagging support for libvirt

2009-04-08 Thread Daniel P. Berrange
On Tue, Apr 07, 2009 at 06:32:43PM -0700, David Lutterkort wrote: > On Tue, 2009-04-07 at 18:39 -0300, Klaus Heinrich Kiwi wrote: > > I was thinking about the semantics I described above. It ultimately > > means that we'll have a bridge for each VLAN tag that crosses the trunk > > interface. So for

Re: [libvirt] 802.1q vlan-tagging support for libvirt

2009-04-08 Thread Daniel P. Berrange
On Wed, Apr 08, 2009 at 01:06:48PM +0200, Maximilian Wilhelm wrote: > Anno domini 2009 Daniel P. Berrange scripsit: > > [...] > > In the (nearish) future NICs will start appearing with SR-IOV capabilities. > > This gives you one physical PCI device, whcih exposes multiple functions. > > So a singl

Re: [libvirt] Re: [PATCH] Hardware watchdog patch, version 6 (was: Re: [Qemu-devel] [PATCH] Hardware watchdog patch, version 5)

2009-04-08 Thread Daniel P. Berrange
On Tue, Apr 07, 2009 at 04:19:42PM -0500, Hollis Blanchard wrote: > Hi Rich, your watchdog qemu patch is working fine for me (i6300esb, > default reset behavior), but I was wondering... how should libvirt find > out about the watchdog firing? This falls into the general problem space of how does Q

Re: [libvirt] Re: [Qemu-devel] Changing the QEMU svn VERSION string

2009-04-08 Thread Anthony Liguori
Paul Brook wrote: On Tuesday 07 April 2009, Daniel Jacobowitz wrote: On Tue, Apr 07, 2009 at 08:52:46AM -0500, Anthony Liguori wrote: I think that's going to lead to even more confusion. While I'm inclined to not greatly mind 0.10.99 for the development tree, when we do release candida

Re: [libvirt] Re: [Qemu-devel] Changing the QEMU svn VERSION string

2009-04-08 Thread Daniel Jacobowitz
On Tue, Apr 07, 2009 at 08:52:46AM -0500, Anthony Liguori wrote: > I think that's going to lead to even more confusion. While I'm inclined > to not greatly mind 0.10.99 for the development tree, when we do release > candidates for the next release, it's going to be 0.11.0-rc1. I don't > exp

Re: [libvirt] Re: [Qemu-devel] Changing the QEMU svn VERSION string

2009-04-08 Thread Paul Brook
On Tuesday 07 April 2009, Daniel Jacobowitz wrote: > On Tue, Apr 07, 2009 at 08:52:46AM -0500, Anthony Liguori wrote: > > I think that's going to lead to even more confusion. While I'm inclined > > to not greatly mind 0.10.99 for the development tree, when we do release > > candidates for the next

Re: [libvirt] Re: [Qemu-devel] Changing the QEMU svn VERSION string

2009-04-08 Thread Jamie Lokier
Anthony Liguori wrote: > I still think libvirt should work with versions of QEMU/KVM built from > svn/git though. I think the only way to do that is for libvirt to relax > their version checks to accommodate suffixes in the form > major.minor.stable-foo. Ok, but try to stick to a well-defined

Re: [libvirt] Thoughts on svirt configuration files.

2009-04-08 Thread Daniel J Walsh
On 04/07/2009 03:27 PM, Daniel P. Berrange wrote: On Mon, Apr 06, 2009 at 03:05:57PM -0400, Daniel J Walsh wrote: Currently we do not want to hard code virtual image names into libvirt, so libvirt and virtual-manager can use libselinux to get the default image label and process label. svirt_t a

Re: [libvirt] Re: [Qemu-devel] Changing the QEMU svn VERSION string

2009-04-08 Thread Jamie Lokier
Paul Brook wrote: > I'm extremely sceptical of anything that claims to need a fine > grained version number. In practice version numbers for open source > projects are fairly arbitrary and meaningless because almost > everyone has their own set of patches and backported fixes anyway. I find it's n

[libvirt] migration by libvirt

2009-04-08 Thread Zvi Dubitzky
Using libvirt virDomainMigrate () do I have to set the target VM with same XML config as the source VM machine before the migrate starts or the source machine Host libvirt takes care of this preparation before it starts the live migration. I am talking about the equivalent of a tcp migration

Re: [libvirt] [PATCH 0/1] NPIV support

2009-04-08 Thread Dave Allan
Daniel P. Berrange wrote: On Tue, Apr 07, 2009 at 05:16:30PM -0400, David Allan wrote: This patch implements NPIV support. I don't have easy access to an NPIV capable switch at the moment, so this is all untested code at least from the perspective of whether it actually creates and deletes virt

[libvirt] [PATCH 1/3] Allow multiple monitor devices

2009-04-08 Thread Anthony Liguori
Right now only one monitor device can be enabled at a time. In order to support asynchronous notification of events, I would like to introduce a 'wait' command that waits for an event to occur. This implies that we need an additional monitor session to allow commands to still be executed while wa

[libvirt] [PATCH 3/3] Implement vm-state notifications

2009-04-08 Thread Anthony Liguori
This patch adds notification whenever a vm starts or stops. Signed-off-by: Anthony Liguori diff --git a/vl.c b/vl.c index f78cabb..ca0bcf9 100644 --- a/vl.c +++ b/vl.c @@ -164,6 +164,8 @@ int main(int argc, char **argv) #include "libslirp.h" #endif +#include "wait.h" + //#define DEBUG_UNUSE

[libvirt] [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Anthony Liguori
The wait command will pause the monitor the command was issued in until a new event becomes available. Events are queued if there isn't a waiter present. The wait command completes after a single event is available. Today, we queue events indefinitely but in the future, I suspect we'll drop event

Re: [libvirt] Re: [PATCH] Hardware watchdog patch, version 6

2009-04-08 Thread Anthony Liguori
Daniel P. Berrange wrote: On Tue, Apr 07, 2009 at 04:19:42PM -0500, Hollis Blanchard wrote: Hi Rich, your watchdog qemu patch is working fine for me (i6300esb, default reset behavior), but I was wondering... how should libvirt find out about the watchdog firing? This falls into the gen

[libvirt] Re: [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Daniel P. Berrange
On Wed, Apr 08, 2009 at 09:16:43AM -0500, Anthony Liguori wrote: > The wait command will pause the monitor the command was issued in until a new > event becomes available. Events are queued if there isn't a waiter present. > The wait command completes after a single event is available. > > Today,

Re: [libvirt] Re: [PATCH] Hardware watchdog patch, version 6

2009-04-08 Thread Daniel P. Berrange
On Wed, Apr 08, 2009 at 09:18:55AM -0500, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >On Tue, Apr 07, 2009 at 04:19:42PM -0500, Hollis Blanchard wrote: > > > >>Hi Rich, your watchdog qemu patch is working fine for me (i6300esb, > >>default reset behavior), but I was wondering... how sho

[libvirt] Re: [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Anthony Liguori
Daniel P. Berrange wrote: On Wed, Apr 08, 2009 at 09:16:43AM -0500, Anthony Liguori wrote: The wait command will pause the monitor the command was issued in until a new event becomes available. Events are queued if there isn't a waiter present. The wait command completes after a single event

Re: [libvirt] Re: [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Gerd Hoffmann
On 04/08/09 16:33, Daniel P. Berrange wrote: On Wed, Apr 08, 2009 at 09:16:43AM -0500, Anthony Liguori wrote: The wait command will pause the monitor the command was issued in until a new event becomes available. Events are queued if there isn't a waiter present. The wait command completes afte

Re: [libvirt] migration by libvirt

2009-04-08 Thread Chris Lalancette
Zvi Dubitzky wrote: > Using libvirt virDomainMigrate () do I have to set the target VM with > same XML config as the source VM machine before the > migrate starts or the source machine Host libvirt takes care of this > preparation before it starts the live migration. > > I am talking about the

Re: [libvirt] [PATCH 2/2] VirtualBox support

2009-04-08 Thread Florian Vichot
I've just had time to test start, shutdown, dominfo and list but works great so far :) Tomorrow I'll probably try define create VRDP etc... Just one quick patch though: I'm not sure you know, but you call VBoxCGlueInit() twice at every start of virsh: once in vboxRegister() and once in vboxInitial

Re: [libvirt] Re: [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Anthony Liguori
Gerd Hoffmann wrote: On 04/08/09 16:33, Daniel P. Berrange wrote: On Wed, Apr 08, 2009 at 09:16:43AM -0500, Anthony Liguori wrote: The wait command will pause the monitor the command was issued in until a new event becomes available. Events are queued if there isn't a waiter present. The wai

[libvirt] 0.6.2: git mirror tagged, too

2009-04-08 Thread Jim Meyering
Mark McLoughlin mentioned that the LIBVIRT_0_6_2 tag was not automatically mirrored into the git tree, so I've added it. I also added a signed tag on the same change set. Among other things, that makes it so that "git describe" now generates sensible output for recent changes. But adding all the

[libvirt] Intro to libvirt-TCK (Technology Compatibility Kit)

2009-04-08 Thread Daniel P. Berrange
This mail provides a braindump introduction to a testing system I've been working on for libvirt drivers. Also following that is a short guide on how to actually write test cases to give a better flavour of what its all about. Be warned, this is a very long email :-) libvirt TCK : Technolo

[libvirt] [PATCH 1/6] Allow multiple monitor devices (v2)

2009-04-08 Thread Anthony Liguori
Right now only one monitor device can be enabled at a time. In order to support asynchronous notification of events, I would like to introduce a 'wait' command that waits for an event to occur. This implies that we need an additional monitor session to allow commands to still be executed while wa

[libvirt] [PATCH 3/6] Introduce wait filtering (v2)

2009-04-08 Thread Anthony Liguori
This patch allows the wait command to be take a class mask that is used to filter which events are waited for. Because of limitations in the monitor callbacks, this required splitting wait into two commands: wait and poll. This allows us to introduce the -x option to treat the mask as an exclusio

[libvirt] [PATCH 2/6] Introduce monitor 'wait' command (v2)

2009-04-08 Thread Anthony Liguori
The wait command will pause the monitor the command was issued in until a new event becomes available. Events are queued if there isn't a waiter present. The wait command completes after a single event is available. Today, we queue events indefinitely but in the future, I suspect we'll drop event

[libvirt] [PATCH 4/6] Document new events (v2)

2009-04-08 Thread Anthony Liguori
This patch introduces a standard way to document all new events. It also enforces that documentation exists for each event. This documentation includes a description of the details parameters that the event generates. Signed-off-by: Anthony Liguori diff --git a/Makefile.target b/Makefile.targe

[libvirt] [PATCH 6/6] Implement vnc-event notifications (v2)

2009-04-08 Thread Anthony Liguori
This patch adds notification whenever a client connects or disconnects via VNC. I'd like to add a lot more events especially ones that are auth related but this is at least a start. Signed-off-by: Anthony Liguori diff --git a/vnc.c b/vnc.c index 6d93215..abe6bdf 100644 --- a/vnc.c +++ b/vnc.c @@

[libvirt] [PATCH 5/6] Implement vm-state notifications (v2)

2009-04-08 Thread Anthony Liguori
This patch adds notification whenever a vm starts or stops. Signed-off-by: Anthony Liguori diff --git a/vl.c b/vl.c index f78cabb..ca0bcf9 100644 --- a/vl.c +++ b/vl.c @@ -164,6 +164,8 @@ int main(int argc, char **argv) #include "libslirp.h" #endif +#include "wait.h" + //#define DEBUG_UNUSE

[libvirt] Re: [PATCH 2/6] Introduce monitor 'wait' command (v2)

2009-04-08 Thread Anthony Liguori
Anthony Liguori wrote: The wait command will pause the monitor the command was issued in until a new event becomes available. Events are queued if there isn't a waiter present. The wait command completes after a single event is available. Today, we queue events indefinitely but in the future, I

[libvirt] Re: [Qemu-devel] [PATCH 2/6] Introduce monitor 'wait' command (v2)

2009-04-08 Thread Anthony Liguori
Blue Swirl wrote: On 4/8/09, Anthony Liguori wrote: The wait command will pause the monitor the command was issued in until a new event becomes available. Events are queued if there isn't a waiter present. The wait command completes after a single event is available. +if (

Re: [Qemu-devel] Re: [libvirt] Re: [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Jamie Lokier
Anthony Liguori wrote: > It doesn't. When an app enables events, we would start queuing them, > but if it didn't consume them in a timely manner (or at all), we would > start leaking memory badly. > > We want to be robust even in the face of poorly written management > apps/scripts so we need

Re: [Qemu-devel] Re: [libvirt] Re: [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Anthony Liguori
Jamie Lokier wrote: Anthony Liguori wrote: It doesn't. When an app enables events, we would start queuing them, but if it didn't consume them in a timely manner (or at all), we would start leaking memory badly. We want to be robust even in the face of poorly written management apps/scrip

Re: [Qemu-devel] Re: [libvirt] Re: [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Hollis Blanchard
On Wed, 2009-04-08 at 14:35 -0500, Anthony Liguori wrote: > You're basically saying that if something isn't connected, drop them. > If it is connected, do a monitor_printf() such that you're never queuing > events. Entirely reasonable and I've considered it. > > However, I do like the idea tho

Re: [Qemu-devel] Re: [libvirt] Re: [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Anthony Liguori
Hollis Blanchard wrote: On Wed, 2009-04-08 at 14:35 -0500, Anthony Liguori wrote: You're basically saying that if something isn't connected, drop them. If it is connected, do a monitor_printf() such that you're never queuing events. Entirely reasonable and I've considered it. However, I

Re: [Qemu-devel] Re: [libvirt] Re: [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Zachary Amsden
Anthony Liguori wrote: > However, I do like the idea though of QEMU queuing events for a certain > period of time. Not everyone always has something connected to a > monitor. I may notice that my NFS server (which runs in a VM) is not > responding, VNC to the system, switch to the monitor, and t

Re: [Qemu-devel] Re: [libvirt] Re: [PATCH 2/3] Introduce monitor 'wait' command

2009-04-08 Thread Hollis Blanchard
On Wed, 2009-04-08 at 16:14 -0500, Anthony Liguori wrote: > Hollis Blanchard wrote: > > On Wed, 2009-04-08 at 14:35 -0500, Anthony Liguori wrote: > > > >> You're basically saying that if something isn't connected, drop them. > >> If it is connected, do a monitor_printf() such that you're never

Re: [libvirt] [PATCH 1/1] Implement NPIV

2009-04-08 Thread Dave Allan
Daniel P. Berrange wrote: On Tue, Apr 07, 2009 at 05:16:31PM -0400, David Allan wrote: static int +virStorageBackendVportCreateDelete(virConnectPtr conn, + virStoragePoolObjPtr pool, + int operation) +{ +int fd = -1; +

[libvirt] Problems using unix_sock_group

2009-04-08 Thread Niraj Tolia
Hi, I am sure I am missing something simple but I can't seem to figure it out. I am trying to allow a non-root user rw access to libvirt 0.6.2. The user is a member of the libvirtd group, unix_sock_group="libvirtd", and unix_sock_rw_perms=0770. However, 'virsh list' doesn't seem to work. The perm