Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-04-23 Thread Eduardo Otubo
Hello again, I very am glad with all the feedback I got. The following attachtment is the result of the work using all the suggestions the list made. I also have a few comments over this new RFC. Here is a little Changelog: * Now the URI is recognized as phyp://u...@hmc/managed_system. To use pa

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Florian Vichot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> Isn't 3D support implied by the type of graphics card emulated ? >> eg cirrus is a 2d only card, so it seems like 3Daccel is redundant. >> Similarly if the graphics model were a 3d card. > > true. no need for that. Actually I believe there is. I

Re: [libvirt] Xen network interface behavior with 0.6.2

2009-04-23 Thread Daniel Veillard
On Thu, Apr 23, 2009 at 02:20:16PM +0100, Daniel P. Berrange wrote: > On Mon, Apr 20, 2009 at 12:58:57PM -0700, Kaitlin Rupert wrote: > > Daniel P. Berrange wrote: > > >On Mon, Apr 20, 2009 at 12:06:16PM -0700, Kaitlin Rupert wrote: > > >>Daniel P. Berrange wrote: > > >>>On Fri, Apr 17, 2009 at 01:

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel Veillard
On Thu, Apr 23, 2009 at 02:13:18PM +0100, Daniel P. Berrange wrote: > On Thu, Apr 23, 2009 at 02:56:46PM +0200, Daniel Veillard wrote: > > On Thu, Apr 23, 2009 at 01:47:17PM +0100, Daniel P. Berrange wrote: > > > On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: > > > > > I think we

Re: [libvirt] PATCH: Fix mem corruption after detaching Xen device

2009-04-23 Thread Daniel Veillard
On Thu, Apr 23, 2009 at 02:48:49PM +0100, Daniel P. Berrange wrote: > The XM driver's implementation of the 'detach device' command is causing > memory corruption, but passing the wrong size information to memmove() > by passing number of elements to move, instead of amount of memory to > move. Thi

[libvirt] PATCH: Fix mem corruption after detaching Xen device

2009-04-23 Thread Daniel P. Berrange
The XM driver's implementation of the 'detach device' command is causing memory corruption, but passing the wrong size information to memmove() by passing number of elements to move, instead of amount of memory to move. This patch fixes it Daniel diff -rup libvirt-0.6.2.orig/src/xm_internal.c li

Re: [libvirt] Xen network interface behavior with 0.6.2

2009-04-23 Thread Daniel P. Berrange
On Mon, Apr 20, 2009 at 12:58:57PM -0700, Kaitlin Rupert wrote: > Daniel P. Berrange wrote: > >On Mon, Apr 20, 2009 at 12:06:16PM -0700, Kaitlin Rupert wrote: > >>Daniel P. Berrange wrote: > >>>On Fri, Apr 17, 2009 at 01:29:12PM -0700, Kaitlin Rupert wrote: > Hi, > > I'm using libvirt

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel P. Berrange
On Thu, Apr 23, 2009 at 02:56:46PM +0200, Daniel Veillard wrote: > On Thu, Apr 23, 2009 at 01:47:17PM +0100, Daniel P. Berrange wrote: > > On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: > > > > I think we need to add an explicit tag to represent video devices > > > > real soon. At

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
On Thursday 23 April 2009 14:47:17 Daniel P. Berrange wrote: > On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: > > Hi Daniel, > > > > > We don't currently have any explicit representation of a video card > > > device. The tag is really representing the host I/O > > > layer, coveri

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel Veillard
On Thu, Apr 23, 2009 at 01:47:17PM +0100, Daniel P. Berrange wrote: > On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: > > > I think we need to add an explicit tag to represent video devices > > > real soon. At very least we need to be able to indicate the type > > > of video card -

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Gerd Hoffmann
On 04/23/09 12:43, Daniel P. Berrange wrote: Historically with Xen and QEMU there has only been ability to have either SDL graphics, or VNC graphics, but not both. Note that this has changed recently, qemu can handle both vnc and sdl now. Likewise for qemu: cheers, Gerd -

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel P. Berrange
On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote: > Hi Daniel, > > > We don't currently have any explicit representation of a video card > > device. The tag is really representing the host I/O > > layer, covering video, mouse, keyboard (and potentially audio > > too). > > I didn't

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
Hi Daniel, > We don't currently have any explicit representation of a video card > device. The tag is really representing the host I/O > layer, covering video, mouse, keyboard (and potentially audio > too). I didn't get you here? i mean there is a seperate virDomainSoundDefPtr, virDomainInputDe

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
Hi Daniel, > yes this is a limitation of the impelentation, not of the model, it > makes more sense to allow multiple graphis entries. Ok, will do this. > > feedback about attributes (auth='external' authtimeout='1234') would also > > be appreciated. Thanks. > > auth='external' sounds uncl

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel P. Berrange
On Thu, Apr 23, 2009 at 01:32:24PM +0200, Pritesh Kothari wrote: > Hi Daniel, > > > > > > > this seems ok, but the only question I have is, currently libvirt supports > only one virDomainGraphicsDef, so is it ok for me add support for more then > one virDomainGraphicsDef? or else i don't

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel Veillard
On Thu, Apr 23, 2009 at 01:32:24PM +0200, Pritesh Kothari wrote: > Hi Daniel, > > > > > > > this seems ok, but the only question I have is, currently libvirt supports > only one virDomainGraphicsDef, so is it ok for me add support for more then > one virDomainGraphicsDef? or else i don't

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Pritesh Kothari
Hi Daniel, > > this seems ok, but the only question I have is, currently libvirt supports only one virDomainGraphicsDef, so is it ok for me add support for more then one virDomainGraphicsDef? or else i don't see how i can have multiple tags. > If RDP is not enabled, then don't include

Re: [libvirt] [PATCH 1/1] Support for RDP

2009-04-23 Thread Daniel P. Berrange
On Thu, Apr 16, 2009 at 11:21:23AM +0200, Pritesh Kothari wrote: > Hi All, > > I have added support for RDP. So, summarizing your suggested XML syntax, it more or less looked like this: Historically with Xen and QEMU there has only been ability to have either SDL graphics, or VNC graphics, b