Re: [libvirt] [PATCH] fix soem missing directories and ownership in spec file

On Tue, Apr 28, 2009 at 11:34:38AM +0200, Daniel Veillard wrote: The spec file in CVs was missing the creation fo some directories and forgot to take ownership of the cache subdir used for memory dumps with QEmu/KVM @@ -305,6 +305,13 @@ rm -f $RPM_BUILD_ROOT%{_libdir}/*.a rm -f

[libvirt] PATCH: Allow for quiet build output

The following patch is a slightly gross hack that puts a wrapper around libtool to make it STFU, and only print the name of the output file, and associated input files. Since we can't change the automake generated Makefile.in to add '@' in front of all libtool commands, this sill won't be quiet

Re: [libvirt] [PATCH] fix soem missing directories and ownership in spec file

On Tue, Apr 28, 2009 at 10:38:50AM +0100, Daniel P. Berrange wrote: On Tue, Apr 28, 2009 at 11:34:38AM +0200, Daniel Veillard wrote: The spec file in CVs was missing the creation fo some directories and forgot to take ownership of the cache subdir used for memory dumps with QEmu/KVM

[libvirt] [PATCH] fix soem missing directories and ownership in spec file

The spec file in CVs was missing the creation fo some directories and forgot to take ownership of the cache subdir used for memory dumps with QEmu/KVM Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine

[libvirt] [PATCH 0/7] Improve QEMU process startup error reporting

Error reporting for failed QEMU processes isn't too great at the moment. A couple cases I have hit: - Trying to start a VM with a cdrom pointing to a nonexistent file. The svirt hook function choked on this and indicated as much in the domain log, but I still had to wait for the pidfile timeout

[libvirt] [PATCH 1/7] Add documentation for __virExec and virExec

--- src/util.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/src/util.c b/src/util.c index b7e0362..87e215d 100644 --- a/src/util.c +++ b/src/util.c @@ -266,6 +266,26 @@ int virSetCloseExec(int fd) { return 0; } +/* + * @conn

[libvirt] [PATCH 2/7] virExec: Delay daemonizing as long as possible.

This way the caller can catch more errors (e.g. from a hook callback) from the intermediate process. --- src/util.c | 56 1 files changed, 28 insertions(+), 28 deletions(-) diff --git a/src/util.c b/src/util.c index 87e215d..47a1cd3

[libvirt] [PATCH 3/7] Add helper function virExecDaemonize

Wraps __virExec with the VIR_EXEC_DAEMON flag. Waits on the intermediate process to ensure we don't end up with any zombies, and differentiates between original process errors and intermediate process errors. --- src/libvirt_private.syms |2 +- src/proxy_internal.c | 16 ++

[libvirt] [PATCH 4/7] Report qemu log data if we fail to daemonize the process.

This ensures the user will actually see 'hook' function error output. --- src/qemu_driver.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index cc510b2..5200532 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@

[libvirt] [PATCH 6/7] Check that QEMU is still alive while reading startup output.

By checking the pid every retry period, we can quickly determine if the process crashed at startup, rather than make the user wait for the entire timeout (3 seconds). --- src/qemu_driver.c | 33 ++--- 1 files changed, 22 insertions(+), 11 deletions(-) diff --git

[libvirt] [PATCH 7/7] Don't throw away QEMU startup errors when migrating.

--- src/qemu_driver.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 04df8ae..b293f72 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -225,7 +225,7 @@ qemudAutostartConfigs(struct qemud_driver *driver) {

[libvirt] [PATCH] Refresh QEMU driver caps in getCapabilities

Hi all, The attached patch fixes QEMU getCapabilities to refresh caps before returning them to the user. Currently the capabilities are only refreshed once (at daemon startup), which means libvirtd needs to be restarted to pick up changes if QEMU or KVM are installed while the daemon is running.

[libvirt] [PATCH] Remove unused file volume format 'dir'

It isn't documented, detected, and barely has any code accomodating it. Appears to be left over from an earlier iteration of the storage APIs. Thanks, Cole commit 2aec7c2f843d30e5b6882b8a335494a2de7bc156 Author: Cole Robinson crobi...@redhat.com Date: Wed Apr 22 14:54:31 2009 -0400 Remove

[libvirt] [PATCH] Fix a comment typo in storage_backend_fs.c

This comment hid from my attempt to 'grep FILE_BOCHS', which is the actual name of the constant. Thanks, Cole commit 62861e902fc3c272e46cdf9948079f12564ca119 Author: Cole Robinson crobi...@redhat.com Date: Wed Apr 22 14:51:54 2009 -0400 Update comment to reference correct volume format

Re: [libvirt] [PATCH] Refresh QEMU driver caps in getCapabilities

Cole Robinson schrieb: (...) To test the performance impact, I used a simple python script: import libvirt conn = libvirt.open(qemu:///system) for i in range(0, 30): conn.getCapabilities() The time difference was on average .02 seconds slower, which I think is negligible. If at somepoint

Re: [libvirt] [PATCH] Refresh QEMU driver caps in getCapabilities

On 04/28/2009 05:13 PM, Gerrit Slomma wrote: Cole Robinson schrieb: (...) To test the performance impact, I used a simple python script: import libvirt conn = libvirt.open(qemu:///system) for i in range(0, 30): conn.getCapabilities() The time difference was on average .02 seconds